77593 2012-02-01 18:26:09 -0800 Running a Web Worker on about:blank crashes the interpreter 2012-02-02 15:42:52 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 benjamin benjamin ap ddkilzer msaboff oldest_to_newest 547559 0 benjamin 2012-02-01 18:26:09 -0800 ...and that is sad <rdar://problem/10787649> 547567 1 125063 benjamin 2012-02-01 18:40:06 -0800 Created attachment 125063 Patch 547572 2 benjamin 2012-02-01 18:43:10 -0800 My first idea was to cut short as soon as we load the data for the Worker. The problem is we expose the execution to the Inspector so I would bypass that. This patch is the lazy approach. I assume the null page is unlikely and I don't care about the cost of starting the Worker thread. 547636 3 125063 ap 2012-02-01 21:47:44 -0800 Comment on attachment 125063 Patch What prevents the same for <script src="about:blank"> and for <a href="javascript:">? 547650 4 benjamin 2012-02-01 22:15:34 -0800 (In reply to comment #3) > (From update of attachment 125063 [details]) > What prevents the same for <script src="about:blank"> and for <a href="javascript:">? The same kind of checks. E.g.: http://trac.webkit.org/browser/trunk/Source/WebCore/dom/ScriptElement.cpp#L270 I did not try <a href="javascript:"> but I assume it is the same. 547677 5 ap 2012-02-01 23:23:05 -0800 The check you mention is not in ScriptController, it's higher on call stack. I'm not sure if it's semantically correct to return ScriptValue() when evaluating an empty string. Testing in JS console, eval("") returns undefined. Looking at original bug, it appears that UString::is8Bit() is wrong - string methods don't usually crash on null strings. Is this the only reason why it crashes? 547693 6 benjamin 2012-02-01 23:53:53 -0800 (In reply to comment #5) > The check you mention is not in ScriptController, it's higher on call stack. I'm not sure if it's semantically correct to return ScriptValue() when evaluating an empty string. Testing in JS console, eval("") returns undefined. Note this is the _Worker_ScriptController. The return value is never used anywhere (see: https://bugs.webkit.org/show_bug.cgi?id=77587 ) I will have to update the patch before landing since 77587 is landed. As I said, I considered putting this higher in the stack, but it is harder to make a correct patch due to the inspector. > Looking at original bug, it appears that UString::is8Bit() is wrong - string methods don't usually crash on null strings. Is this the only reason why it crashes? This is the same behavior as String. I think I see your point, you think the interpreter should return undefined on a Null source? In that case I should make sure the JIT does the same and then remove all the null check higher in the stack. 548168 7 benjamin 2012-02-02 14:27:26 -0800 > I think I see your point, you think the interpreter should return undefined on a Null source? In that case I should make sure the JIT does the same and then remove all the null check higher in the stack. Actually the JIT crashes in exactly the same way. It is just crashing on different timing (need 100ms instead of 10 for some reason). This is a regression. 548172 8 benjamin 2012-02-02 14:38:50 -0800 I think the regression comes from r99812. Previously we were just calling characters() which return 0 on null String. 548173 9 125192 benjamin 2012-02-02 14:39:05 -0800 Created attachment 125192 Patch 548208 10 benjamin 2012-02-02 15:42:52 -0800 Committed r106600: <http://trac.webkit.org/changeset/106600> 125063 2012-02-01 18:40:06 -0800 2012-02-02 14:39:02 -0800 Patch bug-77593-20120201184005.patch text/plain 5726 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MzIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh M2VjZmZiMjhmZDI3NTI3YTc5YzIxNDMxMTdmZjJlNjBjODE2MTc3Li4zYzgxYTdkOGI4YzBmNmUx YmE3NjJlZTgxN2VmOThjZjk5YzRjMzEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMi0wMi0wMSAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBSdW5uaW5nIGEgV2ViIFdvcmtlciBvbiBhYm91dDpibGFuayBjcmFz aGVzIHRoZSBpbnRlcnByZXRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Nzc1OTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGQgYW4gYXNzZXJ0aW9uIGZvciBudWxsIHNvdXJjZSBjb2RlIGluIG9yZGVy IHRvIG1ha2UgdGhpcyBjb25kaXRpb24gbW9yZSBleHBsaWNpdC4KKworICAgICAgICAqIGludGVy cHJldGVyL0ludGVycHJldGVyLmNwcDoKKyAgICAgICAgKEpTQzo6SW50ZXJwcmV0ZXI6OmV4ZWN1 dGUpOgorCiAyMDEyLTAxLTMwICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAg ICAgICAgZ2V0X2J5X3ZhbF9hcmd1bWVudHMgaXMgYnJva2VuIGluIHRoZSBpbnRlcnByZXRlcgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCmluZGV4IDVmOGQ2NjM1Yjk2OWRhMjNkNWE3Njc5MGY1ZmUwNjc1YzFhMmU1ZjMuLjRi Y2M0NjgyYTk1MTYzYjM5OWFiN2IwOTMwNzg2MzhmZTk2ZjUxZTUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxMi0wMi0wMSAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBSdW5uaW5nIGEgV2ViIFdvcmtlciBvbiBhYm91dDpibGFuayBjcmFz aGVzIHRoZSBpbnRlcnByZXRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Nzc1OTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBEbyBub3QgYXR0ZW1wdCB0byBydW4gdGhlIHNjcmlwdCB3aXRoIGEgZW1wdHkg aW5wdXQgc2luY2UgdGhlIEludGVycHJldGVyIGRvZXMKKyAgICAgICAgbm90IGhhbmRsZSB0aGF0 LgorCisgICAgICAgIFRlc3Q6IGZhc3Qvd29ya2Vycy9lbXB0eS13b3JrZXItbm9jcmFzaC5odG1s CisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9Xb3JrZXJTY3JpcHRDb250cm9sbGVyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OldvcmtlclNjcmlwdENvbnRyb2xsZXI6OmV2YWx1YXRlKToKKwogMjAx Mi0wMS0zMCAgR3JlZ2cgVGF2YXJlcyAgPGdtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFk ZCBQbHVtbWluZyB0byBnZXQgZ3JhcGhpY3MgZXJyb3IgbWVzc2FnZXMgdG8gSlMgQ29uc29sZQpk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVy LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAK aW5kZXggNDQ1ZTI4NjUzODRlZTAyYjg0NDdmNTA4YzRkNmMxOGE1MWM2YWZhMi4uYzc4YTI3NWMz NzJkMGZlYTNiMjUxODM1MjA2OGQzZGUyZjU2YzU1YiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCkBAIC04ODUsNiArODg1LDcgQEAg SlNWYWx1ZSBJbnRlcnByZXRlcjo6ZXhlY3V0ZShQcm9ncmFtRXhlY3V0YWJsZSogcHJvZ3JhbSwg Q2FsbEZyYW1lKiBjYWxsRnJhbWUsIFMKICAgICBWZWN0b3I8SlNPTlBEYXRhPiBKU09OUERhdGE7 CiAgICAgYm9vbCBwYXJzZVJlc3VsdDsKICAgICBjb25zdCBVU3RyaW5nIHByb2dyYW1Tb3VyY2Ug PSBwcm9ncmFtLT5zb3VyY2UoKS50b1N0cmluZygpOworICAgIEFTU0VSVCghcHJvZ3JhbVNvdXJj ZS5pc051bGwoKSk7CiAgICAgaWYgKHByb2dyYW1Tb3VyY2UuaXM4Qml0KCkpIHsKICAgICAgICAg TGl0ZXJhbFBhcnNlcjxMQ2hhcj4gbGl0ZXJhbFBhcnNlcihjYWxsRnJhbWUsIHByb2dyYW1Tb3Vy Y2UuY2hhcmFjdGVyczgoKSwgcHJvZ3JhbVNvdXJjZS5sZW5ndGgoKSwgSlNPTlApOwogICAgICAg ICBwYXJzZVJlc3VsdCA9IGxpdGVyYWxQYXJzZXIudHJ5SlNPTlBQYXJzZShKU09OUERhdGEsIHNj b3BlQ2hhaW4tPmdsb2JhbE9iamVjdC0+Z2xvYmFsT2JqZWN0TWV0aG9kVGFibGUoKS0+c3VwcG9y dHNSaWNoU291cmNlSW5mbyhzY29wZUNoYWluLT5nbG9iYWxPYmplY3QuZ2V0KCkpKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dvcmtlclNjcmlwdENvbnRyb2xsZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvV29ya2VyU2NyaXB0Q29udHJvbGxlci5j cHAKaW5kZXggMTE5ODdmZjYzOWU0ZWE5OGM2MmRiNjg0Nzk1N2I0MzIyNDYzYjhlYS4uNDY4MDVj MzUwNDFkMjQyN2U3OTM0YWVlNDkxNTcwNTA0NWFjZjc2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvV29ya2VyU2NyaXB0Q29udHJvbGxlci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvV29ya2VyU2NyaXB0Q29udHJvbGxlci5jcHAKQEAgLTEyOCw2 ICsxMjgsMTAgQEAgU2NyaXB0VmFsdWUgV29ya2VyU2NyaXB0Q29udHJvbGxlcjo6ZXZhbHVhdGUo Y29uc3QgU2NyaXB0U291cmNlQ29kZSYgc291cmNlQ29kZSwKICAgICBpZiAoaXNFeGVjdXRpb25G b3JiaWRkZW4oKSkKICAgICAgICAgcmV0dXJuIFNjcmlwdFZhbHVlKCk7CiAKKyAgICBjb25zdCBK U0M6OlNvdXJjZUNvZGUmIGpzU291cmNlQ29kZSA9IHNvdXJjZUNvZGUuanNTb3VyY2VDb2RlKCk7 CisgICAgaWYgKCFqc1NvdXJjZUNvZGUubGVuZ3RoKCkpCisgICAgICAgIHJldHVybiBTY3JpcHRW YWx1ZSgpOworCiAgICAgaW5pdFNjcmlwdElmTmVlZGVkKCk7CiAgICAgSlNMb2NrIGxvY2soU2ls ZW5jZUFzc2VydGlvbnNPbmx5KTsKIApAQCAtMTM2LDcgKzE0MCw3IEBAIFNjcmlwdFZhbHVlIFdv cmtlclNjcmlwdENvbnRyb2xsZXI6OmV2YWx1YXRlKGNvbnN0IFNjcmlwdFNvdXJjZUNvZGUmIHNv dXJjZUNvZGUsCiAgICAgbV93b3JrZXJDb250ZXh0V3JhcHBlci0+Z2xvYmFsRGF0YSgpLnRpbWVv dXRDaGVja2VyLnN0YXJ0KCk7CiAKICAgICBKU1ZhbHVlIGV2YWx1YXRpb25FeGNlcHRpb247Ci0g ICAgSlNWYWx1ZSByZXR1cm5WYWx1ZSA9IEpTQzo6ZXZhbHVhdGUoZXhlYywgZXhlYy0+ZHluYW1p Y0dsb2JhbE9iamVjdCgpLT5nbG9iYWxTY29wZUNoYWluKCksIHNvdXJjZUNvZGUuanNTb3VyY2VD b2RlKCksIG1fd29ya2VyQ29udGV4dFdyYXBwZXIuZ2V0KCksICZldmFsdWF0aW9uRXhjZXB0aW9u KTsKKyAgICBKU1ZhbHVlIHJldHVyblZhbHVlID0gSlNDOjpldmFsdWF0ZShleGVjLCBleGVjLT5k eW5hbWljR2xvYmFsT2JqZWN0KCktPmdsb2JhbFNjb3BlQ2hhaW4oKSwganNTb3VyY2VDb2RlLCBt X3dvcmtlckNvbnRleHRXcmFwcGVyLmdldCgpLCAmZXZhbHVhdGlvbkV4Y2VwdGlvbik7CiAKICAg ICBtX3dvcmtlckNvbnRleHRXcmFwcGVyLT5nbG9iYWxEYXRhKCkudGltZW91dENoZWNrZXIuc3Rv cCgpOwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKaW5kZXggN2FlMzQzZWJmNzhmMWU3YmMyODZkMzQ2NTI4YjY3MTAyM2Y4ZTViYy4u NWFiM2RlNjA5Mzg2OTgwMGY4ZDMyNTM3OGQ4YjE4M2Y3NDVkNGUxNCAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDEyLTAyLTAxICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJ1bm5pbmcgYSBXZWIgV29ya2VyIG9uIGFib3V0OmJsYW5rIGNyYXNoZXMg dGhlIGludGVycHJldGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03NzU5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZSBXb3JrZXIgdGhyZWFkIHNob3VsZCBub3QgY3Jhc2ggaWYgcnVubmluZyBvbiBh biBlbXB0eSBwYWdlLgorICAgICAgICBUaGUgdGltZXIgaXMgbmVjZXNzYXJ5IHRvIGdpdmUgYSBj aGFuY2UgZm9yIHRoZSB0aHJlYWQgdG8gc3RhcnQuCisKKyAgICAgICAgKiBmYXN0L3dvcmtlcnMv ZW1wdHktd29ya2VyLW5vY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0 L3dvcmtlcnMvZW1wdHktd29ya2VyLW5vY3Jhc2guaHRtbDogQWRkZWQuCisKIDIwMTItMDEtMzAg IFBhYmxvIEZsb3VyZXQgIDxwYWJsb2ZAbW90b3JvbGEuY29tPgogCiAgICAgICAgIERvbid0IHNl bGVjdCB0aGUgbmV4dCBzZWxlY3RhYmxlIGluZGV4IHdoZW4gZGVzZWxlY3RpbmcgYW4gb3B0aW9u IGluIHNlbGVjdCBlbGVtZW50cyB3aXRoIHNpemUgc2V0IHRvIGEgdmFsdWUgZ3JlYXRlciB0aGFu IG9uZS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9lbXB0eS13b3JrZXIt bm9jcmFzaC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvZW1wdHktd29y a2VyLW5vY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjdlZjIyZTlhNDMxYWQwMjcyNzEz YjcxZmRjODc5NDAxNmM4ZWYxMmYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0 L3dvcmtlcnMvZW1wdHktd29ya2VyLW5vY3Jhc2gtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAK K1BBU1MKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9lbXB0eS13b3JrZXIt bm9jcmFzaC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL2VtcHR5LXdvcmtlci1ub2Ny YXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uZjg4MjdmYjRmMTg4YmM1NWE5MjNmMmNmYTg3MTVkZWFmZmUw OTRhYQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9lbXB0eS13 b3JrZXItbm9jcmFzaC5odG1sCkBAIC0wLDAgKzEsMTEgQEAKKzxodG1sPgorPHNjcmlwdD4KK3Zh ciB3b3JrZXIgPSBuZXcgV29ya2VyKCdhYm91dDpibGFuaycpOworaWYgKHdpbmRvdy5sYXlvdXRU ZXN0Q29udHJvbGxlcikgeworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsK KyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7Cit9CitzZXRUaW1lb3V0 KCd3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpJywgMTApOworPC9zY3Jp cHQ+Cis8cD5QQVNTPC9wPgorPC9odG1sPgo= 125192 2012-02-02 14:39:05 -0800 2012-02-02 15:00:30 -0800 Patch bug-77593-20120202143904.patch text/plain 3727 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MzIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh M2VjZmZiMjhmZDI3NTI3YTc5YzIxNDMxMTdmZjJlNjBjODE2MTc3Li5lNjFjMDMxMzU1NzI1ZDUy NzM1OGQ5MGIyM2EyMGU2YzBmYWYwMzNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxMi0wMi0wMiAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBSdW5uaW5nIGEgV2ViIFdvcmtlciBvbiBhYm91dDpibGFuayBjcmFz aGVzIHRoZSBpbnRlcnByZXRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Nzc1OTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGUgbWV0aG9kIEludGVycHJldGVyOjpleGVjdXRlKCkgd2FzIGNyYXNoaW5n IG9uIGVtcHR5IHByb2dyYW1zIGJlY2F1c2UKKyAgICAgICAgdGhlIGFzc3VtcHRpb24gaXMgbWFk ZSB0aGUgc291cmNlIGlzIG5vdCBudWxsLgorCisgICAgICAgIFRoaXMgcGF0Y2ggc2hvcnRjdXQg dGhlIGV4ZWN1dGlvbiB3aGVuIHRoZSBTdHJpbmcgaXMgbnVsbCB0byBhdm9pZCBpbnZhbGlkCisg ICAgICAgIG1lbW9yeSBhY2Nlc3MuCisKKyAgICAgICAgKiBpbnRlcnByZXRlci9JbnRlcnByZXRl ci5jcHA6CisgICAgICAgIChKU0M6OkludGVycHJldGVyOjpleGVjdXRlKToKKwogMjAxMi0wMS0z MCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIGdldF9ieV92YWxf YXJndW1lbnRzIGlzIGJyb2tlbiBpbiB0aGUgaW50ZXJwcmV0ZXIKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCmluZGV4IDQ0NWUyODY1Mzg0 ZWUwMmI4NDQ3ZjUwOGM0ZDZjMThhNTFjNmFmYTIuLmJjYWQ5M2QzZTI3ODBhNTVkNjI0YmFmOWNk ZTIxZGVlYzcyZTJlZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnBy ZXRlci9JbnRlcnByZXRlci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJl dGVyL0ludGVycHJldGVyLmNwcApAQCAtODg1LDYgKzg4NSw4IEBAIEpTVmFsdWUgSW50ZXJwcmV0 ZXI6OmV4ZWN1dGUoUHJvZ3JhbUV4ZWN1dGFibGUqIHByb2dyYW0sIENhbGxGcmFtZSogY2FsbEZy YW1lLCBTCiAgICAgVmVjdG9yPEpTT05QRGF0YT4gSlNPTlBEYXRhOwogICAgIGJvb2wgcGFyc2VS ZXN1bHQ7CiAgICAgY29uc3QgVVN0cmluZyBwcm9ncmFtU291cmNlID0gcHJvZ3JhbS0+c291cmNl KCkudG9TdHJpbmcoKTsKKyAgICBpZiAocHJvZ3JhbVNvdXJjZS5pc051bGwoKSkKKyAgICAgICAg cmV0dXJuIGpzVW5kZWZpbmVkKCk7CiAgICAgaWYgKHByb2dyYW1Tb3VyY2UuaXM4Qml0KCkpIHsK ICAgICAgICAgTGl0ZXJhbFBhcnNlcjxMQ2hhcj4gbGl0ZXJhbFBhcnNlcihjYWxsRnJhbWUsIHBy b2dyYW1Tb3VyY2UuY2hhcmFjdGVyczgoKSwgcHJvZ3JhbVNvdXJjZS5sZW5ndGgoKSwgSlNPTlAp OwogICAgICAgICBwYXJzZVJlc3VsdCA9IGxpdGVyYWxQYXJzZXIudHJ5SlNPTlBQYXJzZShKU09O UERhdGEsIHNjb3BlQ2hhaW4tPmdsb2JhbE9iamVjdC0+Z2xvYmFsT2JqZWN0TWV0aG9kVGFibGUo KS0+c3VwcG9ydHNSaWNoU291cmNlSW5mbyhzY29wZUNoYWluLT5nbG9iYWxPYmplY3QuZ2V0KCkp KTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwppbmRleCA3YWUzNDNlYmY3OGYxZTdiYzI4NmQzNDY1MjhiNjcxMDIzZjhlNWJjLi41YWIz ZGU2MDkzODY5ODAwZjhkMzI1Mzc4ZDhiMTgzZjc0NWQ0ZTE0IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDItMDEgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CisK KyAgICAgICAgUnVubmluZyBhIFdlYiBXb3JrZXIgb24gYWJvdXQ6YmxhbmsgY3Jhc2hlcyB0aGUg aW50ZXJwcmV0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTc3NTkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhlIFdvcmtlciB0aHJlYWQgc2hvdWxkIG5vdCBjcmFzaCBpZiBydW5uaW5nIG9uIGFuIGVt cHR5IHBhZ2UuCisgICAgICAgIFRoZSB0aW1lciBpcyBuZWNlc3NhcnkgdG8gZ2l2ZSBhIGNoYW5j ZSBmb3IgdGhlIHRocmVhZCB0byBzdGFydC4KKworICAgICAgICAqIGZhc3Qvd29ya2Vycy9lbXB0 eS13b3JrZXItbm9jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qvd29y a2Vycy9lbXB0eS13b3JrZXItbm9jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAxMi0wMS0zMCAgUGFi bG8gRmxvdXJldCAgPHBhYmxvZkBtb3Rvcm9sYS5jb20+CiAKICAgICAgICAgRG9uJ3Qgc2VsZWN0 IHRoZSBuZXh0IHNlbGVjdGFibGUgaW5kZXggd2hlbiBkZXNlbGVjdGluZyBhbiBvcHRpb24gaW4g c2VsZWN0IGVsZW1lbnRzIHdpdGggc2l6ZSBzZXQgdG8gYSB2YWx1ZSBncmVhdGVyIHRoYW4gb25l LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL2VtcHR5LXdvcmtlci1ub2Ny YXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9lbXB0eS13b3JrZXIt bm9jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uN2VmMjJlOWE0MzFhZDAyNzI3MTNiNzFm ZGM4Nzk0MDE2YzhlZjEyZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvd29y a2Vycy9lbXB0eS13b3JrZXItbm9jcmFzaC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSBAQAorUEFT UwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL2VtcHR5LXdvcmtlci1ub2Ny YXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvZW1wdHktd29ya2VyLW5vY3Jhc2gu aHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi4yOWNkMGUxOWQxNTY4ZjdjOGRmZWFmMWZlM2ZmMjU5NGIxMTc1MDFj Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL2VtcHR5LXdvcmtl ci1ub2NyYXNoLmh0bWwKQEAgLTAsMCArMSwxMSBAQAorPGh0bWw+Cis8c2NyaXB0PgordmFyIHdv cmtlciA9IG5ldyBXb3JrZXIoJ2Fib3V0OmJsYW5rJyk7CitpZiAod2luZG93LmxheW91dFRlc3RD b250cm9sbGVyKSB7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAg IGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKK30KK3NldFRpbWVvdXQoJ3dp bmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCknLCAyMCk7Cis8L3NjcmlwdD4K KzxwPlBBU1M8L3A+Cis8L2h0bWw+Cg==