77591 2012-02-01 18:15:19 -0800 Replace [CustomPrototypeDefineGetter] with [CustomDefineGetter] 2012-02-03 11:30:46 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 77393 1 haraken haraken abarth darin gustavo.noronha gustavo japhet ojan webkit.review.bot xan.lopez oldest_to_newest 547547 0 haraken 2012-02-01 18:15:19 -0800 [CustomPrototypeDefineGetter] is implemented in CodeGeneratorJS.pm only, and it has the same meaning as [CustomDefineGetter]. We can replace [CustomPrototypeDefineGetter] with [CustomDefineGetter]. 547550 1 125059 haraken 2012-02-01 18:18:00 -0800 Created attachment 125059 Patch 547569 2 125059 abarth 2012-02-01 18:42:36 -0800 Comment on attachment 125059 Patch Yeah, certainly looks the same. 547579 3 125059 webkit-ews 2012-02-01 19:11:21 -0800 Comment on attachment 125059 Patch Attachment 125059 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11387710 547590 4 125059 gyuyoung.kim 2012-02-01 19:54:50 -0800 Comment on attachment 125059 Patch Attachment 125059 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11388687 547793 5 125059 gustavo.noronha 2012-02-02 04:53:01 -0800 Comment on attachment 125059 Patch Attachment 125059 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11386792 548611 6 haraken 2012-02-03 03:10:29 -0800 Sorry, the patch was wrong. [CustomDefineGetter] and [CustomPrototypeDefineGetter] are different. The former declares defineGetter() on an interface class (e.g. JSLocation), and the latter declares defineGetter() on a prototype interface class (e.g. JSLocationPrototype). Let me mark this bug as WONTFIX. 125059 2012-02-01 18:18:00 -0800 2012-02-02 04:53:01 -0800 Patch bug-77591-20120202111759.patch text/plain 2583 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODFiZWExNGVhYzFkYTcz MTcwNmU3ZmFmNzEwMjE2MjIzZTQ2ZjhmMi4uMDJlY2JjMjI4YmEzMmNhNTRhYTMwZWE1NTY2OTQ5 YTQzMjFhYzU1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAyLTAxICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXBsYWNlIFtDdXN0 b21Qcm90b3R5cGVEZWZpbmVHZXR0ZXJdIHdpdGggW0N1c3RvbURlZmluZUdldHRlcl0KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3NTkxCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0N1c3RvbVByb3RvdHlw ZURlZmluZUdldHRlcl0gaXMgaW1wbGVtZW50ZWQgaW4gQ29kZUdlbmVyYXRvckpTLnBtIG9ubHks CisgICAgICAgIGFuZCBpdCBoYXMgdGhlIHNhbWUgbWVhbmluZyBhcyBbQ3VzdG9tRGVmaW5lR2V0 dGVyXS4gVGhpcyBwYXRjaCByZXBsYWNlcworICAgICAgICBbQ3VzdG9tUHJvdG90eXBlRGVmaW5l R2V0dGVyXSB3aXRoIFtDdXN0b21EZWZpbmVHZXR0ZXJdLgorCisgICAgICAgIE5vIHRlc3RzLiBO byBjaGFuZ2VzIGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2Rl R2VuZXJhdG9ySlMucG06CisgICAgICAgIChHZW5lcmF0ZUhlYWRlcik6CisgICAgICAgICogcGFn ZS9Mb2NhdGlvbi5pZGw6CisKIDIwMTItMDItMDEgIENhaW8gTWFyY2VsbyBkZSBPbGl2ZWlyYSBG aWxobyAgPGNhaW8ub2xpdmVpcmFAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBBdm9pZCBjcmVh dGluZyBOYW1lZE5vZGVNYXAgdW5uZWNlc3NhcmlseQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0gYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQppbmRleCAyMTM5YTkzZjExMTgyMzVj MDhkNzhmMGFhOTg1ZTQ3YzMyMmM0NmJhLi44Mzg1NTE3MzkyNjc4NGI5NzBiYjlhM2YzZjk0ZTZh Nzg5NDFjYmM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0Nv ZGVHZW5lcmF0b3JKUy5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0Nv ZGVHZW5lcmF0b3JKUy5wbQpAQCAtMTA2Myw5ICsxMDYzLDYgQEAgc3ViIEdlbmVyYXRlSGVhZGVy CiAgICAgICAgIHB1c2goQGhlYWRlckNvbnRlbnQsICIgICAgYm9vbCBwdXREZWxlZ2F0ZShKU0M6 OkV4ZWNTdGF0ZSosIGNvbnN0IEpTQzo6SWRlbnRpZmllciYsIEpTQzo6SlNWYWx1ZSwgSlNDOjpQ dXRQcm9wZXJ0eVNsb3QmKTtcbiIpOwogICAgIH0KIAotICAgICMgQ3VzdG9tIGRlZmluZUdldHRl ciBmdW5jdGlvbgotICAgIHB1c2goQGhlYWRlckNvbnRlbnQsICIgICAgc3RhdGljIHZvaWQgZGVm aW5lR2V0dGVyKEpTQzo6SlNPYmplY3QqLCBKU0M6OkV4ZWNTdGF0ZSosIGNvbnN0IEpTQzo6SWRl bnRpZmllciYgcHJvcGVydHlOYW1lLCBKU0M6OkpTT2JqZWN0KiBnZXR0ZXJGdW5jdGlvbiwgdW5z aWduZWQgYXR0cmlidXRlcyk7XG4iKSBpZiAkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+ eyJDdXN0b21Qcm90b3R5cGVEZWZpbmVHZXR0ZXIifTsKLQogICAgIHB1c2goQGhlYWRlckNvbnRl bnQsICJcbnByaXZhdGU6XG4iKTsKICAgICBwdXNoKEBoZWFkZXJDb250ZW50LCAiICAgICR7Y2xh c3NOYW1lfVByb3RvdHlwZShKU0M6OkpTR2xvYmFsRGF0YSYgZ2xvYmFsRGF0YSwgSlNDOjpKU0ds b2JhbE9iamVjdCosIEpTQzo6U3RydWN0dXJlKiBzdHJ1Y3R1cmUpIDogSlNDOjpKU05vbkZpbmFs T2JqZWN0KGdsb2JhbERhdGEsIHN0cnVjdHVyZSkgeyB9XG4iKTsKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGFnZS9Mb2NhdGlvbi5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0xvY2F0 aW9uLmlkbAppbmRleCAxODZjNDE3YmIzMjUxNTIyYWZjNGU2MWY0OGViODg0YWRjMDhkM2VmLi4x YzI2ZjMwMjNiYmE1MmM1OTdhNWE1YmRjNDdhMzJkYmY2OWE1ZDFhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0xvY2F0aW9uLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0xv Y2F0aW9uLmlkbApAQCAtMzksNyArMzksNyBAQCBtb2R1bGUgd2luZG93IHsKICAgICAgICAgQ3Vz dG9tR2V0UHJvcGVydHlOYW1lcywKICAgICAgICAgQ3VzdG9tRGVmaW5lR2V0dGVyLAogICAgICAg ICBEZWxlZ2F0aW5nUHJvdG90eXBlUHV0RnVuY3Rpb24sCi0gICAgICAgIEN1c3RvbVByb3RvdHlw ZURlZmluZUdldHRlciwKKyAgICAgICAgQ3VzdG9tRGVmaW5lR2V0dGVyLAogICAgICAgICBPbWl0 Q29uc3RydWN0b3IKICAgICBdIExvY2F0aW9uIHsKICNpZiAhZGVmaW5lZChMQU5HVUFHRV9DUFAp IHx8ICFMQU5HVUFHRV9DUFAK