77589 2012-02-01 17:48:57 -0800 Remove [ImplementationUUID] and [InterfaceUUID] from html/canvas/*.idl 2012-02-01 18:48:15 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77393 1 haraken haraken abarth cmarrin darin ojan sam webkit.review.bot oldest_to_newest 547529 0 haraken 2012-02-01 17:48:57 -0800 [ImplementationUUID] and [InterfaceUUID] are used in html/canvas/*.idl, but they are not implemented in code generators and thus have no meaning. We can remove them. 547531 1 125054 haraken 2012-02-01 17:51:19 -0800 Created attachment 125054 Patch 547534 2 125054 abarth 2012-02-01 17:54:26 -0800 Comment on attachment 125054 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125054&action=review > Source/WebCore/ChangeLog:10 > + [ImplementationUUID] and [InterfaceUUID] are used in html/canvas/*.idl, > + but they are not implemented in code generators and thus have no meaning. > + This patch removes them. Do we know the history here? Did these attributes mean something at some point? Is the reason for their existence no longer important? 547543 3 haraken 2012-02-01 18:08:04 -0800 (In reply to comment #2) > Do we know the history here? Did these attributes mean something at some point? Is the reason for their existence no longer important? Those UUIDs were added in preparation of adding autogeneration of the COM DOM bindings. http://trac.webkit.org/changeset/27276 It appears that those UUIDs had been already removed from almost all IDL files, but they have remained in some IDL files in html/canvas/ unintentionally. 547544 4 125054 abarth 2012-02-01 18:09:35 -0800 Comment on attachment 125054 Patch Makes sense. Thanks. 547576 5 125054 webkit.review.bot 2012-02-01 18:48:10 -0800 Comment on attachment 125054 Patch Clearing flags on attachment: 125054 Committed r106526: <http://trac.webkit.org/changeset/106526> 547577 6 webkit.review.bot 2012-02-01 18:48:15 -0800 All reviewed patches have been landed. Closing bug. 125054 2012-02-01 17:51:19 -0800 2012-02-01 18:48:10 -0800 Patch bug-77589-20120202105118.patch text/plain 4449 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODFiZWExNGVhYzFkYTcz MTcwNmU3ZmFmNzEwMjE2MjIzZTQ2ZjhmMi4uYTIyNGIyOGVjZmQ1M2IyMjdlNzZjZTRhZTMxZTIw ZjIxYTEyMzQ5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAyLTAxICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgW0ltcGxl bWVudGF0aW9uVVVJRF0gYW5kIFtJbnRlcmZhY2VVVUlEXSBmcm9tIGh0bWwvY2FudmFzLyouaWRs CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzU4OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtJbXBsZW1l bnRhdGlvblVVSURdIGFuZCBbSW50ZXJmYWNlVVVJRF0gYXJlIHVzZWQgaW4gaHRtbC9jYW52YXMv Ki5pZGwsCisgICAgICAgIGJ1dCB0aGV5IGFyZSBub3QgaW1wbGVtZW50ZWQgaW4gY29kZSBnZW5l cmF0b3JzIGFuZCB0aHVzIGhhdmUgbm8gbWVhbmluZy4KKyAgICAgICAgVGhpcyBwYXRjaCByZW1v dmVzIHRoZW0uCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKwor ICAgICAgICAqIGh0bWwvY2FudmFzL0NhbnZhc0dyYWRpZW50LmlkbDoKKyAgICAgICAgKiBodG1s L2NhbnZhcy9DYW52YXNQYXR0ZXJuLmlkbDogVGhlIGZpbGUgaXMgbm93IGVtcHR5IHRob3VnaC4K KyAgICAgICAgKiBodG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0LmlkbDoKKyAgICAg ICAgKiBodG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuaWRsOgorICAgICAgICAq IGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5pZGw6CisKIDIwMTItMDItMDEgIENh aW8gTWFyY2VsbyBkZSBPbGl2ZWlyYSBGaWxobyAgPGNhaW8ub2xpdmVpcmFAb3BlbmJvc3NhLm9y Zz4KIAogICAgICAgICBBdm9pZCBjcmVhdGluZyBOYW1lZE5vZGVNYXAgdW5uZWNlc3NhcmlseQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzR3JhZGllbnQuaWRs IGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzR3JhZGllbnQuaWRsCmluZGV4IDQ4 Zjc1YmJkYWI3Njg0ZDU5MTZhOGJjYmU5Y2Q0MmI0M2YwZGQ0ZTMuLjc1YjE5Mjc5YjJlZWQ0OTE3 MmQ1MjFjMmJhNGRjYzQ3ODUyMDI5MTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv Y2FudmFzL0NhbnZhc0dyYWRpZW50LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZh cy9DYW52YXNHcmFkaWVudC5pZGwKQEAgLTI1LDEwICsyNSw3IEBACiAKIG1vZHVsZSBodG1sIHsK IAotICAgIGludGVyZmFjZSBbCi0gICAgICAgIEludGVyZmFjZVVVSUQ9YmIxMTA4ZWEtNmI4Yy00 YTA4LTg5NGEtMjE4NjI4NjMwY2RiLAotICAgICAgICBJbXBsZW1lbnRhdGlvblVVSUQ9YTI5NDJh ZTYtMjczMS00Mjg2LTk4Y2MtOWQ1ZTc5ZTIwZGUxCi0gICAgXSBDYW52YXNHcmFkaWVudCB7Cisg ICAgaW50ZXJmYWNlIENhbnZhc0dyYWRpZW50IHsKIAogICAgICAgICB2b2lkIGFkZENvbG9yU3Rv cChpbiBbT3B0aW9uYWw9Q2FsbFdpdGhEZWZhdWx0VmFsdWVdIGZsb2F0IG9mZnNldCwgCiAgICAg ICAgICAgICAgICAgICAgICAgICAgIGluIFtPcHRpb25hbD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0g RE9NU3RyaW5nIGNvbG9yKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMv Q2FudmFzUGF0dGVybi5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNQYXR0 ZXJuLmlkbAppbmRleCAxY2FjOGY4ODA0Yjg3OGE5ZmE2MGNkNmVjZTljNTkyMzZmNmNjOTI0Li5l NWFhMDM2MGI5OTBjNmQwNWNlOTYyM2U3OTQ3OWNkMTUzODYwYWYxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNQYXR0ZXJuLmlkbAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL2NhbnZhcy9DYW52YXNQYXR0ZXJuLmlkbApAQCAtMjUsMTEgKzI1LDcgQEAKIAog bW9kdWxlIGh0bWwgewogCi0gICAgaW50ZXJmYWNlIFsKLSAgICAgICAgSW50ZXJmYWNlVVVJRD1j MjEzMTM0OC02ZDhjLTQ3YjUtODZjYy1kNDFhZmYzNGNlMTUsCi0gICAgICAgIEltcGxlbWVudGF0 aW9uVVVJRD04MmY1ZDcxMy0zZDE3LTQ0ZGQtYWE0YS03NzY2ZmUzNDU5NDAKLSAgICBdIENhbnZh c1BhdHRlcm4gewotCisgICAgaW50ZXJmYWNlIENhbnZhc1BhdHRlcm4gewogICAgIH07CiAKIH0K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0Nv bnRleHQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29u dGV4dC5pZGwKaW5kZXggYjUzYmRjZTVhMGJiYTcxYzMxYTY1ODJmMjM0ODRmYWIyNjA3ODA3OS4u ZDg2NTdjYzhmYzlhZDM2MjY5ODk1N2UyN2FjYjRmNjc0NzQ0YmZmYyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dC5pZGwKKysrIGIv U291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dC5pZGwKQEAg LTI4LDkgKzI4LDcgQEAgbW9kdWxlIGh0bWwgewogICAgIGludGVyZmFjZSBbCiAgICAgICAgIEN1 c3RvbU1hcmtGdW5jdGlvbiwKICAgICAgICAgR2VuZXJhdGVJc1JlYWNoYWJsZSwKLSAgICAgICAg Q3VzdG9tVG9KUywKLSAgICAgICAgSW50ZXJmYWNlVVVJRD05OGZiNDhhZS03MjE2LTQ4OWMtODYy Yi04ZTEyMTdmYzQ0NDMsCi0gICAgICAgIEltcGxlbWVudGF0aW9uVVVJRD1hYjRmMDc4MS0xNTJm LTQ1MGUtOTU0Ni01YjM5ODc0OTFhNTQKKyAgICAgICAgQ3VzdG9tVG9KUwogICAgIF0gQ2FudmFz UmVuZGVyaW5nQ29udGV4dCB7CiAKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIEhUTUxDYW52 YXNFbGVtZW50IGNhbnZhczsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFz L0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZh cy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuaWRsCmluZGV4IDAxNjhlNGM2NjE1ZDY5NjYzMTA1 NTYzNTQzMDcyNDMzYTc3ZTYwOTcuLmQ1ODQ1YjhlNWJjNjUzZTM0OWFlNTM3Mjc3MzI2MzVkYjk1 YWMxOTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRl cmluZ0NvbnRleHQyRC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFz UmVuZGVyaW5nQ29udGV4dDJELmlkbApAQCAtMjUsMTAgKzI1LDcgQEAKIAogbW9kdWxlIGh0bWwg ewogCi0gICAgaW50ZXJmYWNlIFsKLSAgICAgICAgSW50ZXJmYWNlVVVJRD05OGZiNDhhZS03MjE2 LTQ4OWMtODYyYi04ZTEyMTdmYzQ0NDMsCi0gICAgICAgIEltcGxlbWVudGF0aW9uVVVJRD1hYjRm MDc4MS0xNTJmLTQ1MGUtOTU0Ni01YjM5ODc0OTFhNTQKLSAgICBdIENhbnZhc1JlbmRlcmluZ0Nv bnRleHQyRCA6IENhbnZhc1JlbmRlcmluZ0NvbnRleHQgeworICAgIGludGVyZmFjZSBDYW52YXNS ZW5kZXJpbmdDb250ZXh0MkQgOiBDYW52YXNSZW5kZXJpbmdDb250ZXh0IHsKIAogICAgICAgICB2 b2lkIHNhdmUoKTsKICAgICAgICAgdm9pZCByZXN0b3JlKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuaWRsIGIvU291cmNlL1dl YkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmlkbAppbmRleCAwYzE3MDBh M2FlYzE0Yzk2OGRlNzg3NGNiZGJmZDQ3MzI5ODhlNWEyLi4xNmFhZTE3YjBiMDE2Y2M4ZTFmMjVl MzM1NWQyZTM5NmIwODcxMzI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZh cy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2Fu dmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5pZGwKQEAgLTI3LDggKzI3LDYgQEAgbW9kdWxlIGh0 bWwgewogCiAgICAgaW50ZXJmYWNlIFsKICAgICAgICAgQ29uZGl0aW9uYWw9V0VCR0wsCi0gICAg ICAgIEludGVyZmFjZVVVSUQ9OThmYjQ4YWUtNzIxNi00ODljLTg2MmItOGUxMjE3ZmM0NDQzLAot ICAgICAgICBJbXBsZW1lbnRhdGlvblVVSUQ9YWI0ZjA3ODEtMTUyZi00NTBlLTk1NDYtNWIzOTg3 NDkxYTU0LAogICAgICAgICBDdXN0b21NYXJrRnVuY3Rpb24sCiAgICAgICAgIERvbnRDaGVja0Vu dW1zCiAgICAgXSBXZWJHTFJlbmRlcmluZ0NvbnRleHQgOiBDYW52YXNSZW5kZXJpbmdDb250ZXh0 IHsK