77588 2012-02-01 17:33:48 -0800 Remove [ObjCPrefix], [V8ConstructorTemplate], [allowAccessToNode], [v8implname] and [v8referenceattr] from code generators 2012-02-01 18:27:39 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77393 1 haraken haraken abarth darin japhet webkit.review.bot oldest_to_newest 547518 0 haraken 2012-02-01 17:33:48 -0800 We can remove [ObjCPrefix], [V8ConstructorTemplate], [allowAccessToNode], [v8implname] and [v8referenceattr] from code generators, since they are not used by any IDL files. 547520 1 125052 haraken 2012-02-01 17:36:02 -0800 Created attachment 125052 Patch 547560 2 125052 webkit.review.bot 2012-02-01 18:27:34 -0800 Comment on attachment 125052 Patch Clearing flags on attachment: 125052 Committed r106522: <http://trac.webkit.org/changeset/106522> 547561 3 webkit.review.bot 2012-02-01 18:27:39 -0800 All reviewed patches have been landed. Closing bug. 125052 2012-02-01 17:36:02 -0800 2012-02-01 18:27:34 -0800 Patch bug-77588-20120202103601.patch text/plain 7424 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODFiZWExNGVhYzFkYTcz MTcwNmU3ZmFmNzEwMjE2MjIzZTQ2ZjhmMi4uZDBkYjUyYWY3NmRmYzZlNmIxZDE0NGJiYTBkNjUw OGYxYzAwZDMxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTAyLTAxICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgW09iakNQ cmVmaXhdLCBbVjhDb25zdHJ1Y3RvclRlbXBsYXRlXSwgW2FsbG93QWNjZXNzVG9Ob2RlXSwKKyAg ICAgICAgW3Y4aW1wbG5hbWVdIGFuZCBbdjhyZWZlcmVuY2VhdHRyXSBmcm9tIGNvZGUgZ2VuZXJh dG9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzc1 ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlz IHBhdGNoIHJlbW92ZXMgW09iakNQcmVmaXhdLCBbVjhDb25zdHJ1Y3RvclRlbXBsYXRlXSwgW2Fs bG93QWNjZXNzVG9Ob2RlXSwKKyAgICAgICAgW3Y4aW1wbG5hbWVdIGFuZCBbdjhyZWZlcmVuY2Vh dHRyXSBmcm9tIGNvZGUgZ2VuZXJhdG9ycywgc2luY2UgdGhleSBhcmUgbm90IHVzZWQKKyAgICAg ICAgYnkgYW55IElETCBmaWxlcy4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlcyBpbiBi ZWhhdmlvci4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBt OgorICAgICAgICAoR2VuZXJhdGVJbXBsZW1lbnRhdGlvbik6CisgICAgICAgICogYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9yT2JqQy5wbToKKyAgICAgICAgKEdlbmVyYXRlSGVhZGVyKToK KyAgICAgICAgKEdlbmVyYXRlSW1wbGVtZW50YXRpb24pOgorICAgICAgICAqIGJpbmRpbmdzL3Nj cmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtOgorICAgICAgICAoSXNDb25zdHJ1Y3RhYmxlKToKKyAg ICAgICAgKElzQ29uc3RydWN0b3JUZW1wbGF0ZSk6CisgICAgICAgIChHZW5lcmF0ZU5vcm1hbEF0 dHJHZXR0ZXIpOgorICAgICAgICAoR2VuZXJhdGVGdW5jdGlvbkNhbGxTdHJpbmcpOgorCiAyMDEy LTAyLTAxICBDYWlvIE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gIDxjYWlvLm9saXZlaXJhQG9w ZW5ib3NzYS5vcmc+CiAKICAgICAgICAgQXZvaWQgY3JlYXRpbmcgTmFtZWROb2RlTWFwIHVubmVj ZXNzYXJpbHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvckpTLnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9ySlMucG0KaW5kZXggMjEzOWE5M2YxMTE4MjM1YzA4ZDc4ZjBhYTk4NWU0N2MzMjJjNDZi YS4uYzhjZjNiZTJkZjk4OTNmNWQ3ODlmOTllMGVhNTUzY2ZkODM3OTUxNiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KQEAgLTE3 MTEsMTAgKzE3MTEsNiBAQCBzdWIgR2VuZXJhdGVJbXBsZW1lbnRhdGlvbgogCiAgICAgICAgICAg ICAgICAgaWYgKCRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkN1 c3RvbSJ9IHx8ICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkpT Q0N1c3RvbSJ9IHx8ICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57 IkN1c3RvbUdldHRlciJ9IHx8ICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1 dGVzLT57IkpTQ0N1c3RvbUdldHRlciJ9KSB7CiAgICAgICAgICAgICAgICAgICAgIHB1c2goQGlt cGxDb250ZW50LCAiICAgIHJldHVybiBjYXN0ZWRUaGlzLT4kaW1wbEdldHRlckZ1bmN0aW9uTmFt ZShleGVjKTtcbiIpOwotICAgICAgICAgICAgICAgIH0gZWxzaWYgKCRhdHRyaWJ1dGUtPnNpZ25h dHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57ImFsbG93QWNjZXNzVG9Ob2RlIn0pIHsKLSAgICAg ICAgICAgICAgICAgICAgJGltcGxJbmNsdWRlc3siSlNET01CaW5kaW5nLmgifSA9IDE7Ci0gICAg ICAgICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgICRpbXBsQ2xhc3NOYW1lKiBp bXBsID0gc3RhdGljX2Nhc3Q8JGltcGxDbGFzc05hbWUqPihjYXN0ZWRUaGlzLT5pbXBsKCkpO1xu Iik7Ci0gICAgICAgICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgIHJldHVybiBh bGxvd0FjY2Vzc1RvTm9kZShleGVjLCBpbXBsLT4kaW1wbEdldHRlckZ1bmN0aW9uTmFtZSgpKSA/ ICIgLiBOYXRpdmVUb0pTVmFsdWUoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLCAwLCAkaW1wbENsYXNz TmFtZSwgImltcGwtPiRpbXBsR2V0dGVyRnVuY3Rpb25OYW1lKCkiLCAiY2FzdGVkVGhpcyIpIC4g IiA6IGpzVW5kZWZpbmVkKCk7XG4iKTsKICAgICAgICAgICAgICAgICB9IGVsc2lmICgkYXR0cmli dXRlLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDaGVja0ZyYW1lU2VjdXJpdHki fSkgewogICAgICAgICAgICAgICAgICAgICAkaW1wbEluY2x1ZGVzeyJEb2N1bWVudC5oIn0gPSAx OwogICAgICAgICAgICAgICAgICAgICAkaW1wbEluY2x1ZGVzeyJKU0RPTUJpbmRpbmcuaCJ9ID0g MTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvck9iakMucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0 b3JPYmpDLnBtCmluZGV4IGFkZDgxZDI1MmFmNTIzZTczZjE4Njk5M2YwYmE5NDQ5MWUwNGVlMGYu LmEzMWY3N2EwMjUxZTc1NmYyM2FkNzBiNmZlMjk4YjA2NzgzZDAxMGIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvck9iakMucG0KKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yT2JqQy5wbQpAQCAt ODc3LDEwICs4NzcsOCBAQCBzdWIgR2VuZXJhdGVIZWFkZXIKICAgICAgICAgICAgICAgICAkdHlw ZXNUb0ZvcndhcmREZWNsYXJleyRwYXJhbS0+dHlwZX0gPSAxOwogCiAgICAgICAgICAgICAgICAg aWYgKCRwYXJhbWV0ZXJJbmRleCA+PSAxKSB7Ci0gICAgICAgICAgICAgICAgICAgIG15ICRwYXJh bVByZWZpeCA9ICRwYXJhbS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57Ik9iakNQcmVmaXgifTsKLSAg ICAgICAgICAgICAgICAgICAgJHBhcmFtUHJlZml4ID0gJHBhcmFtTmFtZSB1bmxlc3MgZGVmaW5l ZCgkcGFyYW1QcmVmaXgpOwotICAgICAgICAgICAgICAgICAgICAkZnVuY3Rpb25TaWcgLj0gIiAk cGFyYW1QcmVmaXgiOwotICAgICAgICAgICAgICAgICAgICAkbWV0aG9kTmFtZSAuPSAkcGFyYW1Q cmVmaXg7CisgICAgICAgICAgICAgICAgICAgICRmdW5jdGlvblNpZyAuPSAiICRwYXJhbU5hbWUi OworICAgICAgICAgICAgICAgICAgICAkbWV0aG9kTmFtZSAuPSAkcGFyYW1OYW1lOwogICAgICAg ICAgICAgICAgIH0KIAogICAgICAgICAgICAgICAgICRmdW5jdGlvblNpZyAuPSAiOigkcGFyYW1U eXBlKSRwYXJhbU5hbWUiOwpAQCAtMTUwNCw5ICsxNTAyLDcgQEAgc3ViIEdlbmVyYXRlSW1wbGVt ZW50YXRpb24KICAgICAgICAgICAgICAgICB9CiAKICAgICAgICAgICAgICAgICBpZiAoJHBhcmFt ZXRlckluZGV4ID49IDEpIHsKLSAgICAgICAgICAgICAgICAgICAgbXkgJHBhcmFtUHJlZml4ID0g JHBhcmFtLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiT2JqQ1ByZWZpeCJ9OwotICAgICAgICAgICAg ICAgICAgICAkcGFyYW1QcmVmaXggPSAkcGFyYW0tPm5hbWUgdW5sZXNzIGRlZmluZWQoJHBhcmFt UHJlZml4KTsKLSAgICAgICAgICAgICAgICAgICAgJGZ1bmN0aW9uU2lnIC49ICIgJHBhcmFtUHJl Zml4IjsKKyAgICAgICAgICAgICAgICAgICAgJGZ1bmN0aW9uU2lnIC49ICIgIiAuICRwYXJhbS0+ bmFtZTsKICAgICAgICAgICAgICAgICB9CiAKICAgICAgICAgICAgICAgICAkZnVuY3Rpb25TaWcg Lj0gIjooJHBhcmFtVHlwZSkkcGFyYW1OYW1lIjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KaW5kZXggOGUwNGNmY2I0YzRkNTU1M2E4 OTJjZWEyMjI0YzMzNGE1ODQ1NzIwZS4uMDhkNDU1ZjAwN2NjNzhhZThiZjE3MjUyYjNjMmQxZGRl MmZjZDcxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2Rl R2VuZXJhdG9yVjgucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2Rl R2VuZXJhdG9yVjgucG0KQEAgLTcwNSw3ICs3MDUsNyBAQCBzdWIgSXNDb25zdHJ1Y3RhYmxlCiB7 CiAgICAgbXkgJGRhdGFOb2RlID0gc2hpZnQ7CiAKLSAgICByZXR1cm4gJGRhdGFOb2RlLT5leHRl bmRlZEF0dHJpYnV0ZXMtPnsiQ3VzdG9tQ29uc3RydWN0b3IifSB8fCAkZGF0YU5vZGUtPmV4dGVu ZGVkQXR0cmlidXRlcy0+eyJWOEN1c3RvbUNvbnN0cnVjdG9yIn0gfHwgJGRhdGFOb2RlLT5leHRl bmRlZEF0dHJpYnV0ZXMtPnsiQ29uc3RydWN0b3IifSB8fCAkZGF0YU5vZGUtPmV4dGVuZGVkQXR0 cmlidXRlcy0+eyJWOENvbnN0cnVjdG9yVGVtcGxhdGUifSB8fCAkZGF0YU5vZGUtPmV4dGVuZGVk QXR0cmlidXRlcy0+eyJDb25zdHJ1Y3RvclRlbXBsYXRlIn07CisgICAgcmV0dXJuICRkYXRhTm9k ZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkN1c3RvbUNvbnN0cnVjdG9yIn0gfHwgJGRhdGFOb2Rl LT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiVjhDdXN0b21Db25zdHJ1Y3RvciJ9IHx8ICRkYXRhTm9k ZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkNvbnN0cnVjdG9yIn0gfHwgJGRhdGFOb2RlLT5leHRl bmRlZEF0dHJpYnV0ZXMtPnsiQ29uc3RydWN0b3JUZW1wbGF0ZSJ9OwogfQogCiBzdWIgSXNDb25z dHJ1Y3RvclRlbXBsYXRlCkBAIC03MTMsNyArNzEzLDcgQEAgc3ViIElzQ29uc3RydWN0b3JUZW1w bGF0ZQogICAgIG15ICRkYXRhTm9kZSA9IHNoaWZ0OwogICAgIG15ICR0ZW1wbGF0ZSA9IHNoaWZ0 OwogCi0gICAgcmV0dXJuICgkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJWOENvbnN0 cnVjdG9yVGVtcGxhdGUifSAmJiAkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJWOENv bnN0cnVjdG9yVGVtcGxhdGUifSBlcSAkdGVtcGxhdGUpIHx8ICgkZGF0YU5vZGUtPmV4dGVuZGVk QXR0cmlidXRlcy0+eyJDb25zdHJ1Y3RvclRlbXBsYXRlIn0gJiYgJGRhdGFOb2RlLT5leHRlbmRl ZEF0dHJpYnV0ZXMtPnsiQ29uc3RydWN0b3JUZW1wbGF0ZSJ9IGVxICR0ZW1wbGF0ZSk7CisgICAg cmV0dXJuICRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkNvbnN0cnVjdG9yVGVtcGxh dGUifSAmJiAkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDb25zdHJ1Y3RvclRlbXBs YXRlIn0gZXEgJHRlbXBsYXRlOwogfQogCiBzdWIgR2VuZXJhdGVEb21haW5TYWZlRnVuY3Rpb25H ZXR0ZXIKQEAgLTg2NSw5ICs4NjUsNyBAQCBFTkQKICAgICB9CiAKICAgICAjIEdlbmVyYXRlIHNl Y3VyaXR5IGNoZWNrcyBpZiBuZWNlc3NhcnkKLSAgICBpZiAoJGF0dHJpYnV0ZS0+c2lnbmF0dXJl LT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiYWxsb3dBY2Nlc3NUb05vZGUifSkgewotICAgICAgICBw dXNoKEBpbXBsQ29udGVudERlY2xzLCAiICAgIGlmICghVjhCaW5kaW5nU2VjdXJpdHk6OmFsbG93 QWNjZXNzVG9Ob2RlKFY4QmluZGluZ1N0YXRlOjpPbmx5KCksIGltcC0+JGF0dHJOYW1lKCkpKVxu ICAgIHJldHVybiB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4oKTtcblxuIik7Ci0gICAgfSBlbHNpZiAo JGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ2hlY2tGcmFtZVNl Y3VyaXR5In0pIHsKKyAgICBpZiAoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJp YnV0ZXMtPnsiQ2hlY2tGcmFtZVNlY3VyaXR5In0pIHsKICAgICAgICAgcHVzaChAaW1wbENvbnRl bnREZWNscywgIiAgICBpZiAoIVY4QmluZGluZ1NlY3VyaXR5OjphbGxvd0FjY2Vzc1RvTm9kZShW OEJpbmRpbmdTdGF0ZTo6T25seSgpLCBpbXAtPmNvbnRlbnREb2N1bWVudCgpKSlcbiAgICByZXR1 cm4gdjg6OkhhbmRsZTx2ODo6VmFsdWU+KCk7XG5cbiIpOwogICAgIH0KIApAQCAtODc3LDEwICs4 NzUsNiBAQCBFTkQKICAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywgIiAgICBFeGNlcHRp b25Db2RlIGVjID0gMDtcbiIpOwogICAgIH0KIAotICAgIGlmICgkYXR0cmlidXRlLT5zaWduYXR1 cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJ2OHJlZmVyZW5jZWF0dHIifSkgewotICAgICAgICAk YXR0ck5hbWUgPSAkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJ2 OHJlZmVyZW5jZWF0dHIifTsKLSAgICB9Ci0KICAgICBteSAkcmV0dXJuVHlwZSA9IEdldFR5cGVG cm9tU2lnbmF0dXJlKCRhdHRyaWJ1dGUtPnNpZ25hdHVyZSk7CiAgICAgbXkgJGdldHRlclN0cmlu ZzsKICAgICBteSAkY2FsbFdpdGggPSAkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0 cmlidXRlcy0+eyJDYWxsV2l0aCJ9IHx8ICIiOwpAQCAtMzIwNywxMCArMzIwMSw2IEBAIHN1YiBH ZW5lcmF0ZUZ1bmN0aW9uQ2FsbFN0cmluZygpCiAgICAgbXkgJGlzU1ZHVGVhck9mZlR5cGUgPSAo JGNvZGVHZW5lcmF0b3ItPklzU1ZHVHlwZU5lZWRpbmdUZWFyT2ZmKCRyZXR1cm5UeXBlKSBhbmQg bm90ICRpbXBsQ2xhc3NOYW1lID1+IC9MaXN0JC8pOwogICAgICRuYXRpdmVSZXR1cm5UeXBlID0g JGNvZGVHZW5lcmF0b3ItPkdldFNWR1dyYXBwZWRUeXBlTmVlZGluZ1RlYXJPZmYoJHJldHVyblR5 cGUpIGlmICRpc1NWR1RlYXJPZmZUeXBlOwogCi0gICAgaWYgKCRmdW5jdGlvbi0+c2lnbmF0dXJl LT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsidjhpbXBsbmFtZSJ9KSB7Ci0gICAgICAgICRuYW1lID0g JGZ1bmN0aW9uLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJ2OGltcGxuYW1lIn07 Ci0gICAgfQotCiAgICAgaWYgKCRmdW5jdGlvbi0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0 ZXMtPnsiSW1wbGVtZW50YXRpb25GdW5jdGlvbiJ9KSB7CiAgICAgICAgICRuYW1lID0gJGZ1bmN0 aW9uLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJJbXBsZW1lbnRhdGlvbkZ1bmN0 aW9uIn07CiAgICAgfQo=