77587 2012-02-01 17:31:59 -0800 WorkerScriptController::evaluate() should not return anything 2012-02-01 21:07:10 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin abarth ap dimich japhet levin webkit.review.bot oldest_to_newest 547516 0 benjamin 2012-02-01 17:31:59 -0800 We discard the return value of Workers. It is confusing for WorkerScriptController::evaluate() to return a value. 547521 1 125053 benjamin 2012-02-01 17:37:11 -0800 Created attachment 125053 Patch 547523 2 benjamin 2012-02-01 17:38:00 -0800 Not for review just yet, I need to see how the Chromium V8 bots like this. 547573 3 125053 abarth 2012-02-01 18:44:38 -0800 Comment on attachment 125053 Patch You said this wasn't for review, but this seems non-controversial. 547580 4 benjamin 2012-02-01 19:12:21 -0800 (In reply to comment #3) > You said this wasn't for review, but this seems non-controversial. Yep, I r?ed later when I was sure that builds for Chromium. I should have commented. Thanks for the review. 547596 5 benjamin 2012-02-01 20:12:26 -0800 Committed r106529: <http://trac.webkit.org/changeset/106529> 125053 2012-02-01 17:37:11 -0800 2012-02-01 18:44:38 -0800 Patch bug-77587-20120201173710.patch text/plain 6872 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2E5ZDQ5OWM0YzQ3YWY0 YjBiMjJlMjdiMWVhYmQ4NzliN2Y4MmUzMS4uMWQ4NDQ4M2FhMTdhNzBiNDcxNGI2MWZlZTdhNGEx ZTViN2ViOTYzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAyLTAxICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFdvcmtlclNjcmlw dENvbnRyb2xsZXI6OmV2YWx1YXRlKCkgc2hvdWxkIG5vdCByZXR1cm4gYW55dGhpbmcKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3NTg3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHRoZSByZXR1 cm4gdmFsdWUgZnJvbSBXb3JrZXJTY3JpcHRDb250cm9sbGVyIGFzIGl0IGlzCisgICAgICAgIChh bmQgc2hvdWxkIGJlKSB1bnVzZWQuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9Xb3JrZXJTY3Jp cHRDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldvcmtlclNjcmlwdENvbnRyb2xs ZXI6OmV2YWx1YXRlKToKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9Xb3JrZXJTY3JpcHRDb250cm9s bGVyLmg6CisgICAgICAgIChXb3JrZXJTY3JpcHRDb250cm9sbGVyKToKKyAgICAgICAgKiBiaW5k aW5ncy92OC9Xb3JrZXJTY3JpcHRDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Oldv cmtlclNjcmlwdENvbnRyb2xsZXI6OmV2YWx1YXRlKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9X b3JrZXJTY3JpcHRDb250cm9sbGVyLmg6CisgICAgICAgIChXb3JrZXJTY3JpcHRDb250cm9sbGVy KToKKwogMjAxMi0wMi0wMSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAg ICAgIFdlYkNvcmUgcGFydCBvZiA8cmRhcjovL3Byb2JsZW0vMTA0NDI2NjM+IFBhZ2luYXRlZCBk aXNwbGF5IGRvZXMgbm90IHJlc3BlY3QgcGFnZS1icmVhay17YmVmb3JlLGFmdGVyfQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvV29ya2VyU2NyaXB0Q29udHJvbGxlci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9Xb3JrZXJTY3JpcHRDb250cm9sbGVyLmNw cAppbmRleCAxMTk4N2ZmNjM5ZTRlYTk4YzYyZGI2ODQ3OTU3YjQzMjI0NjNiOGVhLi4yYzYwZmZm ZjA5MGI4ZjY0YjcxMzFjNWIzNzk1MjkzNWY2NWVjMzAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9qcy9Xb3JrZXJTY3JpcHRDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9qcy9Xb3JrZXJTY3JpcHRDb250cm9sbGVyLmNwcApAQCAtMTA5LDI0 ICsxMDksMjMgQEAgdm9pZCBXb3JrZXJTY3JpcHRDb250cm9sbGVyOjppbml0U2NyaXB0KCkKICAg ICBBU1NFUlQoYXNPYmplY3QobV93b3JrZXJDb250ZXh0V3JhcHBlci0+cHJvdG90eXBlKCkpLT5n bG9iYWxPYmplY3QoKSA9PSBtX3dvcmtlckNvbnRleHRXcmFwcGVyKTsKIH0KIAotU2NyaXB0VmFs dWUgV29ya2VyU2NyaXB0Q29udHJvbGxlcjo6ZXZhbHVhdGUoY29uc3QgU2NyaXB0U291cmNlQ29k ZSYgc291cmNlQ29kZSkKK3ZvaWQgV29ya2VyU2NyaXB0Q29udHJvbGxlcjo6ZXZhbHVhdGUoY29u c3QgU2NyaXB0U291cmNlQ29kZSYgc291cmNlQ29kZSkKIHsKICAgICBpZiAoaXNFeGVjdXRpb25G b3JiaWRkZW4oKSkKLSAgICAgICAgcmV0dXJuIFNjcmlwdFZhbHVlKCk7CisgICAgICAgIHJldHVy bjsKIAogICAgIFNjcmlwdFZhbHVlIGV4Y2VwdGlvbjsKLSAgICBTY3JpcHRWYWx1ZSByZXN1bHQo ZXZhbHVhdGUoc291cmNlQ29kZSwgJmV4Y2VwdGlvbikpOworICAgIGV2YWx1YXRlKHNvdXJjZUNv ZGUsICZleGNlcHRpb24pOwogICAgIGlmIChleGNlcHRpb24uanNWYWx1ZSgpKSB7CiAgICAgICAg IEpTTG9jayBsb2NrKFNpbGVuY2VBc3NlcnRpb25zT25seSk7CiAgICAgICAgIHJlcG9ydEV4Y2Vw dGlvbihtX3dvcmtlckNvbnRleHRXcmFwcGVyLT5nbG9iYWxFeGVjKCksIGV4Y2VwdGlvbi5qc1Zh bHVlKCkpOwogICAgIH0KLSAgICByZXR1cm4gcmVzdWx0OwogfQogCi1TY3JpcHRWYWx1ZSBXb3Jr ZXJTY3JpcHRDb250cm9sbGVyOjpldmFsdWF0ZShjb25zdCBTY3JpcHRTb3VyY2VDb2RlJiBzb3Vy Y2VDb2RlLCBTY3JpcHRWYWx1ZSogZXhjZXB0aW9uKQordm9pZCBXb3JrZXJTY3JpcHRDb250cm9s bGVyOjpldmFsdWF0ZShjb25zdCBTY3JpcHRTb3VyY2VDb2RlJiBzb3VyY2VDb2RlLCBTY3JpcHRW YWx1ZSogZXhjZXB0aW9uKQogewogICAgIGlmIChpc0V4ZWN1dGlvbkZvcmJpZGRlbigpKQotICAg ICAgICByZXR1cm4gU2NyaXB0VmFsdWUoKTsKKyAgICAgICAgcmV0dXJuOwogCiAgICAgaW5pdFNj cmlwdElmTmVlZGVkKCk7CiAgICAgSlNMb2NrIGxvY2soU2lsZW5jZUFzc2VydGlvbnNPbmx5KTsK QEAgLTEzNiwxMyArMTM1LDEzIEBAIFNjcmlwdFZhbHVlIFdvcmtlclNjcmlwdENvbnRyb2xsZXI6 OmV2YWx1YXRlKGNvbnN0IFNjcmlwdFNvdXJjZUNvZGUmIHNvdXJjZUNvZGUsCiAgICAgbV93b3Jr ZXJDb250ZXh0V3JhcHBlci0+Z2xvYmFsRGF0YSgpLnRpbWVvdXRDaGVja2VyLnN0YXJ0KCk7CiAK ICAgICBKU1ZhbHVlIGV2YWx1YXRpb25FeGNlcHRpb247Ci0gICAgSlNWYWx1ZSByZXR1cm5WYWx1 ZSA9IEpTQzo6ZXZhbHVhdGUoZXhlYywgZXhlYy0+ZHluYW1pY0dsb2JhbE9iamVjdCgpLT5nbG9i YWxTY29wZUNoYWluKCksIHNvdXJjZUNvZGUuanNTb3VyY2VDb2RlKCksIG1fd29ya2VyQ29udGV4 dFdyYXBwZXIuZ2V0KCksICZldmFsdWF0aW9uRXhjZXB0aW9uKTsKKyAgICBKU0M6OmV2YWx1YXRl KGV4ZWMsIGV4ZWMtPmR5bmFtaWNHbG9iYWxPYmplY3QoKS0+Z2xvYmFsU2NvcGVDaGFpbigpLCBz b3VyY2VDb2RlLmpzU291cmNlQ29kZSgpLCBtX3dvcmtlckNvbnRleHRXcmFwcGVyLmdldCgpLCAm ZXZhbHVhdGlvbkV4Y2VwdGlvbik7CiAKICAgICBtX3dvcmtlckNvbnRleHRXcmFwcGVyLT5nbG9i YWxEYXRhKCkudGltZW91dENoZWNrZXIuc3RvcCgpOwogCiAgICAgaWYgKChldmFsdWF0aW9uRXhj ZXB0aW9uICYmIGlzVGVybWluYXRlZEV4ZWN1dGlvbkV4Y2VwdGlvbihldmFsdWF0aW9uRXhjZXB0 aW9uKSkgfHwgIG1fd29ya2VyQ29udGV4dFdyYXBwZXItPmdsb2JhbERhdGEoKS50ZXJtaW5hdG9y LnNob3VsZFRlcm1pbmF0ZSgpKSB7CiAgICAgICAgIGZvcmJpZEV4ZWN1dGlvbigpOwotICAgICAg ICByZXR1cm4gU2NyaXB0VmFsdWUoKTsKKyAgICAgICAgcmV0dXJuOwogICAgIH0KIAogICAgIGlm IChldmFsdWF0aW9uRXhjZXB0aW9uKSB7CkBAIC0xNTQsOSArMTUzLDYgQEAgU2NyaXB0VmFsdWUg V29ya2VyU2NyaXB0Q29udHJvbGxlcjo6ZXZhbHVhdGUoY29uc3QgU2NyaXB0U291cmNlQ29kZSYg c291cmNlQ29kZSwKICAgICAgICAgZWxzZQogICAgICAgICAgICAgKmV4Y2VwdGlvbiA9IFNjcmlw dFZhbHVlKCptX2dsb2JhbERhdGEsIGV2YWx1YXRpb25FeGNlcHRpb24pOwogICAgIH0KLQotICAg IHJldHVybiBTY3JpcHRWYWx1ZSgqbV9nbG9iYWxEYXRhLCByZXR1cm5WYWx1ZSk7Ci0KIH0KIAog dm9pZCBXb3JrZXJTY3JpcHRDb250cm9sbGVyOjpzZXRFeGNlcHRpb24oU2NyaXB0VmFsdWUgZXhj ZXB0aW9uKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvV29ya2VyU2Ny aXB0Q29udHJvbGxlci5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvV29ya2VyU2NyaXB0 Q29udHJvbGxlci5oCmluZGV4IDk1Zjk1ZThiZmRhZjFiNzExYjg5YWJiNzQzYzkyMjJmMDUxZTAz MDUuLjY5ODVlZTg5NDc0YTk1ZDQ4ZDRkYjE1OWMxYjI3ODRhNzJlODIzZjAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dvcmtlclNjcmlwdENvbnRyb2xsZXIuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9Xb3JrZXJTY3JpcHRDb250cm9sbGVyLmgKQEAg LTU2LDggKzU2LDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAgICAgcmV0dXJuIG1f d29ya2VyQ29udGV4dFdyYXBwZXIuZ2V0KCk7CiAgICAgICAgIH0KIAotICAgICAgICBTY3JpcHRW YWx1ZSBldmFsdWF0ZShjb25zdCBTY3JpcHRTb3VyY2VDb2RlJik7Ci0gICAgICAgIFNjcmlwdFZh bHVlIGV2YWx1YXRlKGNvbnN0IFNjcmlwdFNvdXJjZUNvZGUmLCBTY3JpcHRWYWx1ZSogZXhjZXB0 aW9uKTsKKyAgICAgICAgdm9pZCBldmFsdWF0ZShjb25zdCBTY3JpcHRTb3VyY2VDb2RlJik7Cisg ICAgICAgIHZvaWQgZXZhbHVhdGUoY29uc3QgU2NyaXB0U291cmNlQ29kZSYsIFNjcmlwdFZhbHVl KiBleGNlcHRpb24pOwogCiAgICAgICAgIHZvaWQgc2V0RXhjZXB0aW9uKFNjcmlwdFZhbHVlKTsK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvV29ya2VyU2NyaXB0Q29u dHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9Xb3JrZXJTY3JpcHRDb250 cm9sbGVyLmNwcAppbmRleCAwZDNiNTVmZWE0MTk4ODM3Y2NmOTIxOWFiMWZkOGNhNTM2ZDc3Y2Ux Li45YzgyN2MzZTUxODQ1NDQxMTAxYmExZDkxZGFlMmJiMGIwZDYyMTVhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9Xb3JrZXJTY3JpcHRDb250cm9sbGVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9Xb3JrZXJTY3JpcHRDb250cm9sbGVyLmNwcApA QCAtNzAsMjYgKzcwLDI0IEBAIFdvcmtlclNjcmlwdENvbnRyb2xsZXI6On5Xb3JrZXJTY3JpcHRD b250cm9sbGVyKCkKICAgICBtX2lzb2xhdGUtPkRpc3Bvc2UoKTsKIH0KIAotU2NyaXB0VmFsdWUg V29ya2VyU2NyaXB0Q29udHJvbGxlcjo6ZXZhbHVhdGUoY29uc3QgU2NyaXB0U291cmNlQ29kZSYg c291cmNlQ29kZSkKK3ZvaWQgV29ya2VyU2NyaXB0Q29udHJvbGxlcjo6ZXZhbHVhdGUoY29uc3Qg U2NyaXB0U291cmNlQ29kZSYgc291cmNlQ29kZSkKIHsKLSAgICByZXR1cm4gZXZhbHVhdGUoc291 cmNlQ29kZSwgMCk7CisgICAgZXZhbHVhdGUoc291cmNlQ29kZSwgMCk7CiB9CiAKLVNjcmlwdFZh bHVlIFdvcmtlclNjcmlwdENvbnRyb2xsZXI6OmV2YWx1YXRlKGNvbnN0IFNjcmlwdFNvdXJjZUNv ZGUmIHNvdXJjZUNvZGUsIFNjcmlwdFZhbHVlKiBleGNlcHRpb24pCit2b2lkIFdvcmtlclNjcmlw dENvbnRyb2xsZXI6OmV2YWx1YXRlKGNvbnN0IFNjcmlwdFNvdXJjZUNvZGUmIHNvdXJjZUNvZGUs IFNjcmlwdFZhbHVlKiBleGNlcHRpb24pCiB7CiAgICAgaWYgKGlzRXhlY3V0aW9uRm9yYmlkZGVu KCkpCi0gICAgICAgIHJldHVybiBTY3JpcHRWYWx1ZSgpOworICAgICAgICByZXR1cm47CiAKICAg ICBXb3JrZXJDb250ZXh0RXhlY3V0aW9uU3RhdGUgc3RhdGU7Ci0gICAgU2NyaXB0VmFsdWUgcmVz dWx0ID0gbV9wcm94eS0+ZXZhbHVhdGUoc291cmNlQ29kZS5zb3VyY2UoKSwgc291cmNlQ29kZS51 cmwoKS5zdHJpbmcoKSwgc291cmNlQ29kZS5zdGFydFBvc2l0aW9uKCksICZzdGF0ZSk7CisgICAg bV9wcm94eS0+ZXZhbHVhdGUoc291cmNlQ29kZS5zb3VyY2UoKSwgc291cmNlQ29kZS51cmwoKS5z dHJpbmcoKSwgc291cmNlQ29kZS5zdGFydFBvc2l0aW9uKCksICZzdGF0ZSk7CiAgICAgaWYgKHN0 YXRlLmhhZEV4Y2VwdGlvbikgewogICAgICAgICBpZiAoZXhjZXB0aW9uKQogICAgICAgICAgICAg KmV4Y2VwdGlvbiA9IHN0YXRlLmV4Y2VwdGlvbjsKICAgICAgICAgZWxzZQogICAgICAgICAgICAg bV93b3JrZXJDb250ZXh0LT5yZXBvcnRFeGNlcHRpb24oc3RhdGUuZXJyb3JNZXNzYWdlLCBzdGF0 ZS5saW5lTnVtYmVyLCBzdGF0ZS5zb3VyY2VVUkwsIDApOwogICAgIH0KLQotICAgIHJldHVybiBy ZXN1bHQ7CiB9CiAKIHZvaWQgV29ya2VyU2NyaXB0Q29udHJvbGxlcjo6c2NoZWR1bGVFeGVjdXRp b25UZXJtaW5hdGlvbigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9X b3JrZXJTY3JpcHRDb250cm9sbGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9Xb3Jr ZXJTY3JpcHRDb250cm9sbGVyLmgKaW5kZXggYTc3NDY4ZjYyZDA2YTg3MTA4NTE0NGI2ZDIzNTdi Y2Y1M2ZiNDkxMC4uYjU4MWU0MTQzYjU2ODk4MTVlNmI2YTE3ZDQxMGZmNDllZmUyNWY2MCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvV29ya2VyU2NyaXB0Q29udHJvbGxl ci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1dvcmtlclNjcmlwdENvbnRyb2xs ZXIuaApAQCAtNTUsOCArNTUsOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIFdvcmtl ckNvbnRleHRFeGVjdXRpb25Qcm94eSogcHJveHkoKSB7IHJldHVybiBtX3Byb3h5LmdldCgpOyB9 CiAgICAgICAgIFdvcmtlckNvbnRleHQqIHdvcmtlckNvbnRleHQoKSB7IHJldHVybiBtX3dvcmtl ckNvbnRleHQ7IH0KIAotICAgICAgICBTY3JpcHRWYWx1ZSBldmFsdWF0ZShjb25zdCBTY3JpcHRT b3VyY2VDb2RlJik7Ci0gICAgICAgIFNjcmlwdFZhbHVlIGV2YWx1YXRlKGNvbnN0IFNjcmlwdFNv dXJjZUNvZGUmLCBTY3JpcHRWYWx1ZSogZXhjZXB0aW9uKTsKKyAgICAgICAgdm9pZCBldmFsdWF0 ZShjb25zdCBTY3JpcHRTb3VyY2VDb2RlJik7CisgICAgICAgIHZvaWQgZXZhbHVhdGUoY29uc3Qg U2NyaXB0U291cmNlQ29kZSYsIFNjcmlwdFZhbHVlKiBleGNlcHRpb24pOwogCiAgICAgICAgIHZv aWQgc2V0RXhjZXB0aW9uKFNjcmlwdFZhbHVlKTsKIAo=