77583 2012-02-01 16:50:44 -0800 [WK2] Use properly quoted string literals 2012-02-03 16:31:48 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap webkit.review.bot oldest_to_newest 547492 0 ap 2012-02-01 16:50:44 -0800 Otherwise, "\." matches any character. 547494 1 125046 ap 2012-02-01 16:59:30 -0800 Created attachment 125046 proposed fix 549069 2 125046 darin 2012-02-03 14:20:48 -0800 Comment on attachment 125046 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=125046&action=review r=me, largely based on review by a sandbox expert here at Apple > Source/WebKit2/ChangeLog:18 > +2012-02-01 Alexey Proskuryakov <ap@apple.com> > + > + Need a short description and bug URL (OOPS!) > + > + Reviewed by NOBODY (OOPS!). > + > + * WebProcess/com.apple.WebProcess.sb: Duplicate change log you should remove. 549101 3 125417 ap 2012-02-03 14:38:28 -0800 Created attachment 125417 patch for landing 549227 4 125417 webkit.review.bot 2012-02-03 16:31:41 -0800 Comment on attachment 125417 patch for landing Clearing flags on attachment: 125417 Committed r106709: <http://trac.webkit.org/changeset/106709> 549228 5 webkit.review.bot 2012-02-03 16:31:48 -0800 All reviewed patches have been landed. Closing bug. 125046 2012-02-01 16:59:30 -0800 2012-02-03 14:38:28 -0800 proposed fix AddHashes.txt text/plain 3738 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNjUxNSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAyLTAxICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdIFVzZSBwcm9wZXJs eSBxdW90ZWQgc3RyaW5nIGxpdGVyYWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03NzU4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFsc28gYWRkZWQgc29tZSBGSVhNRXMuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiOgorCisyMDEyLTAyLTAxICBBbGV4ZXkgUHJv c2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIE5lZWQgYSBzaG9ydCBkZXNjcmlw dGlvbiBhbmQgYnVnIFVSTCAoT09QUyEpCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiOgor CiAyMDEyLTAyLTAxICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAg V2ViS2l0MiBwYXJ0IG9mIDxyZGFyOi8vcHJvYmxlbS8xMDQ0MjY2Mz4gUGFnaW5hdGVkIGRpc3Bs YXkgZG9lcyBub3QgcmVzcGVjdCBwYWdlLWJyZWFrLXtiZWZvcmUsYWZ0ZXJ9CkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IJKHJl dmlzaW9uIDEwNjQ3MSkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvY29tLmFwcGxlLldl YlByb2Nlc3Muc2IJKHdvcmtpbmcgY29weSkKQEAgLTM5LDggKzM5LDggQEAKICAgICAgICAobGl0 ZXJhbCAiL0xpYnJhcnkvUHJlZmVyZW5jZXMvY29tLmFwcGxlLnNlY3VyaXR5LnJldm9jYXRpb24u cGxpc3QiKQogICAgICAgIChyZWdleCAjIl4vTGlicmFyeS9NYW5hZ2VkIFByZWZlcmVuY2VzL1te L10rL2NvbVwuYXBwbGVcLm5ldHdvcmtDb25uZWN0XC5wbGlzdCQiKQogICAgICAgIChob21lLWxp dGVyYWwgIi9MaWJyYXJ5L1ByZWZlcmVuY2VzLy5HbG9iYWxQcmVmZXJlbmNlcy5wbGlzdCIpCi0g ICAgICAgKGhvbWUtcmVnZXggIi9MaWJyYXJ5L1ByZWZlcmVuY2VzL0J5SG9zdC9cLkdsb2JhbFBy ZWZlcmVuY2VzXC4iKQotICAgICAgIChob21lLXJlZ2V4ICIvTGlicmFyeS9QcmVmZXJlbmNlcy9C eUhvc3QvY29tXC5hcHBsZVwubmV0d29ya0Nvbm5lY3RcLiIpCisgICAgICAgKGhvbWUtcmVnZXgg IyIvTGlicmFyeS9QcmVmZXJlbmNlcy9CeUhvc3QvXC5HbG9iYWxQcmVmZXJlbmNlc1wuIikKKyAg ICAgICAoaG9tZS1yZWdleCAjIi9MaWJyYXJ5L1ByZWZlcmVuY2VzL0J5SG9zdC9jb21cLmFwcGxl XC5uZXR3b3JrQ29ubmVjdFwuIikKICAgICAgICAoaG9tZS1saXRlcmFsICIvTGlicmFyeS9QcmVm ZXJlbmNlcy9jb20uYXBwbGUuQVRTLnBsaXN0IikKICAgICAgICAoaG9tZS1saXRlcmFsICIvTGli cmFyeS9QcmVmZXJlbmNlcy9jb20uYXBwbGUuRG93bmxvYWRBc3Nlc3NtZW50LnBsaXN0IikKICAg ICAgICAoaG9tZS1saXRlcmFsICIvTGlicmFyeS9QcmVmZXJlbmNlcy9jb20uYXBwbGUuSElUb29s Ym94LnBsaXN0IikKQEAgLTQ5LDcgKzQ5LDcgQEAKICAgICAgICAoaG9tZS1saXRlcmFsICIvTGli cmFyeS9QcmVmZXJlbmNlcy9jb20uYXBwbGUuc2VjdXJpdHkucGxpc3QiKQogICAgICAgIChob21l LWxpdGVyYWwgIi9MaWJyYXJ5L1ByZWZlcmVuY2VzL2NvbS5hcHBsZS5zZWN1cml0eS5yZXZvY2F0 aW9uLnBsaXN0IikKICAgICAgICAoaG9tZS1saXRlcmFsICIvTGlicmFyeS9BcHBsaWNhdGlvbiBT dXBwb3J0L1N5bmNTZXJ2aWNlcy9Mb2NhbC9DbGllbnRzV2l0aENoYW5nZXMvY29tLmFwcGxlLktl eWNoYWluIikKLSAgICAgICAoaG9tZS1yZWdleCAiL0xpYnJhcnkvUHJlZmVyZW5jZXMvY29tXC5h cHBsZVwuZHJpdmVyXC4oQXBwbGVCbHVldG9vdGhNdWx0aXRvdWNoXC5tb3VzZXxBcHBsZUJsdWV0 b290aE11bHRpdG91Y2hcLnRyYWNrcGFkfEFwcGxlSElETW91c2UpXC5wbGlzdCQiKQorICAgICAg IChob21lLXJlZ2V4ICMiL0xpYnJhcnkvUHJlZmVyZW5jZXMvY29tXC5hcHBsZVwuZHJpdmVyXC4o QXBwbGVCbHVldG9vdGhNdWx0aXRvdWNoXC5tb3VzZXxBcHBsZUJsdWV0b290aE11bHRpdG91Y2hc LnRyYWNrcGFkfEFwcGxlSElETW91c2UpXC5wbGlzdCQiKQogCiAgICAgICAgOzsgT24tZGlzayBX ZWJLaXQyIGZyYW1ld29yayBsb2NhdGlvbiwgdG8gYWNjb3VudCBmb3IgZGVidWcgaW5zdGFsbGF0 aW9ucwogICAgICAgIDs7IG91dHNpZGUgb2YgL1N5c3RlbS9MaWJyYXJ5L0ZyYW1ld29ya3MKQEAg LTg2LDggKzg2LDggQEAKIDs7IFdyaXRhYmxlIHByZWZlcmVuY2VzIGFuZCB0ZW1wb3JhcnkgZmls ZXMKIChhbGxvdyBmaWxlKgogICAgICAgIChob21lLXN1YnBhdGggIi9MaWJyYXJ5L0NhY2hlcy9j b20uYXBwbGUuV2ViUHJvY2VzcyIpCi0gICAgICAgKGhvbWUtcmVnZXggIi9MaWJyYXJ5L1ByZWZl cmVuY2VzL0J5SG9zdC9jb21cLmFwcGxlXC5ISVRvb2xib3hcLiIpCi0gICAgICAgKGhvbWUtcmVn ZXggIi9MaWJyYXJ5L1ByZWZlcmVuY2VzL2NvbVwuYXBwbGVcLldlYlByb2Nlc3NcLiIpCisgICAg ICAgKGhvbWUtcmVnZXggIyIvTGlicmFyeS9QcmVmZXJlbmNlcy9CeUhvc3QvY29tXC5hcHBsZVwu SElUb29sYm94XC4iKQorICAgICAgIChob21lLXJlZ2V4ICMiL0xpYnJhcnkvUHJlZmVyZW5jZXMv Y29tXC5hcHBsZVwuV2ViUHJvY2Vzc1wuIikKIAogICAgICAgIDs7IEZJWE1FOiBUaGlzIHNob3Vs ZCBiZSByZW1vdmVkIHdoZW4gPHJkYXI6Ly9wcm9ibGVtLzEwNDc5Njg1PiBpcyBmaXhlZC4KICAg ICAgICAoaG9tZS1zdWJwYXRoICIvTGlicmFyeS9LZXljaGFpbnMiKSkKQEAgLTk2LDkgKzk2LDEx IEBACiAoYWxsb3cgZmlsZSoKICAgICAoc3VicGF0aCAiL3ByaXZhdGUvdmFyL2RiL21kcy9zeXN0 ZW0iKSkKIAotOzsgRGFyd2luIHRlbXBvcmFyeSBmaWxlcyBhbmQgU2VjdXJpdHkgbWRzIGNhY2hl cywgaWYgcHJlc2VudAorOzsgRklYTUU6IDxyZGFyOi8vcHJvYmxlbS8xMDc5MjA0Nz4gVXNlIHBy aXZhdGUgdXNlciBjYWNoZSBkaXJlY3RvcnkKIChpZiAocG9zaXRpdmU/IChzdHJpbmctbGVuZ3Ro IChwYXJhbSAiREFSV0lOX1VTRVJfQ0FDSEVfRElSIikpKQogICAgIChhbGxvdyBmaWxlKiAoc3Vi cGF0aCAoc3RyaW5nLWFwcGVuZCAocGFyYW0gIkRBUldJTl9VU0VSX0NBQ0hFX0RJUiIpICIvbWRz IikpKSkKKworOzsgRklYTUU6IDxyZGFyOi8vcHJvYmxlbS8xMDc4NTQ1Nz4gVXNlIHByaXZhdGUg dGVtcG9yYXJ5IGRpcmVjdG9yeQogKGlmIChwb3NpdGl2ZT8gKHN0cmluZy1sZW5ndGggKHBhcmFt ICJEQVJXSU5fVVNFUl9URU1QX0RJUiIpKSkKICAgICAoYWxsb3cgZmlsZSogKHN1YnBhdGggKHBh cmFtICJEQVJXSU5fVVNFUl9URU1QX0RJUiIpKSkpCiAK 125417 2012-02-03 14:38:28 -0800 2012-02-03 16:31:41 -0800 patch for landing AddHashes.txt text/plain 3482 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNjY5MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAyLTAzICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdIFVzZSBwcm9wZXJs eSBxdW90ZWQgc3RyaW5nIGxpdGVyYWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03NzU4MworCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy LgorCisgICAgICAgIEFsc28gYWRkZWQgc29tZSBGSVhNRXMuCisKKyAgICAgICAgKiBXZWJQcm9j ZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiOgorCiAyMDEyLTAyLTAzICBCZXRoIERha2luICA8 YmRha2luQGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Nzc2OTEKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvY29tLmFw cGxlLldlYlByb2Nlc3Muc2IKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYgkocmV2aXNpb24gMTA2NDcxKQorKysgU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYgkod29ya2luZyBjb3B5KQpA QCAtMzksOCArMzksOCBAQAogICAgICAgIChsaXRlcmFsICIvTGlicmFyeS9QcmVmZXJlbmNlcy9j b20uYXBwbGUuc2VjdXJpdHkucmV2b2NhdGlvbi5wbGlzdCIpCiAgICAgICAgKHJlZ2V4ICMiXi9M aWJyYXJ5L01hbmFnZWQgUHJlZmVyZW5jZXMvW14vXSsvY29tXC5hcHBsZVwubmV0d29ya0Nvbm5l Y3RcLnBsaXN0JCIpCiAgICAgICAgKGhvbWUtbGl0ZXJhbCAiL0xpYnJhcnkvUHJlZmVyZW5jZXMv Lkdsb2JhbFByZWZlcmVuY2VzLnBsaXN0IikKLSAgICAgICAoaG9tZS1yZWdleCAiL0xpYnJhcnkv UHJlZmVyZW5jZXMvQnlIb3N0L1wuR2xvYmFsUHJlZmVyZW5jZXNcLiIpCi0gICAgICAgKGhvbWUt cmVnZXggIi9MaWJyYXJ5L1ByZWZlcmVuY2VzL0J5SG9zdC9jb21cLmFwcGxlXC5uZXR3b3JrQ29u bmVjdFwuIikKKyAgICAgICAoaG9tZS1yZWdleCAjIi9MaWJyYXJ5L1ByZWZlcmVuY2VzL0J5SG9z dC9cLkdsb2JhbFByZWZlcmVuY2VzXC4iKQorICAgICAgIChob21lLXJlZ2V4ICMiL0xpYnJhcnkv UHJlZmVyZW5jZXMvQnlIb3N0L2NvbVwuYXBwbGVcLm5ldHdvcmtDb25uZWN0XC4iKQogICAgICAg IChob21lLWxpdGVyYWwgIi9MaWJyYXJ5L1ByZWZlcmVuY2VzL2NvbS5hcHBsZS5BVFMucGxpc3Qi KQogICAgICAgIChob21lLWxpdGVyYWwgIi9MaWJyYXJ5L1ByZWZlcmVuY2VzL2NvbS5hcHBsZS5E b3dubG9hZEFzc2Vzc21lbnQucGxpc3QiKQogICAgICAgIChob21lLWxpdGVyYWwgIi9MaWJyYXJ5 L1ByZWZlcmVuY2VzL2NvbS5hcHBsZS5ISVRvb2xib3gucGxpc3QiKQpAQCAtNDksNyArNDksNyBA QAogICAgICAgIChob21lLWxpdGVyYWwgIi9MaWJyYXJ5L1ByZWZlcmVuY2VzL2NvbS5hcHBsZS5z ZWN1cml0eS5wbGlzdCIpCiAgICAgICAgKGhvbWUtbGl0ZXJhbCAiL0xpYnJhcnkvUHJlZmVyZW5j ZXMvY29tLmFwcGxlLnNlY3VyaXR5LnJldm9jYXRpb24ucGxpc3QiKQogICAgICAgIChob21lLWxp dGVyYWwgIi9MaWJyYXJ5L0FwcGxpY2F0aW9uIFN1cHBvcnQvU3luY1NlcnZpY2VzL0xvY2FsL0Ns aWVudHNXaXRoQ2hhbmdlcy9jb20uYXBwbGUuS2V5Y2hhaW4iKQotICAgICAgIChob21lLXJlZ2V4 ICIvTGlicmFyeS9QcmVmZXJlbmNlcy9jb21cLmFwcGxlXC5kcml2ZXJcLihBcHBsZUJsdWV0b290 aE11bHRpdG91Y2hcLm1vdXNlfEFwcGxlQmx1ZXRvb3RoTXVsdGl0b3VjaFwudHJhY2twYWR8QXBw bGVISURNb3VzZSlcLnBsaXN0JCIpCisgICAgICAgKGhvbWUtcmVnZXggIyIvTGlicmFyeS9QcmVm ZXJlbmNlcy9jb21cLmFwcGxlXC5kcml2ZXJcLihBcHBsZUJsdWV0b290aE11bHRpdG91Y2hcLm1v dXNlfEFwcGxlQmx1ZXRvb3RoTXVsdGl0b3VjaFwudHJhY2twYWR8QXBwbGVISURNb3VzZSlcLnBs aXN0JCIpCiAKICAgICAgICA7OyBPbi1kaXNrIFdlYktpdDIgZnJhbWV3b3JrIGxvY2F0aW9uLCB0 byBhY2NvdW50IGZvciBkZWJ1ZyBpbnN0YWxsYXRpb25zCiAgICAgICAgOzsgb3V0c2lkZSBvZiAv U3lzdGVtL0xpYnJhcnkvRnJhbWV3b3JrcwpAQCAtODYsOCArODYsOCBAQAogOzsgV3JpdGFibGUg cHJlZmVyZW5jZXMgYW5kIHRlbXBvcmFyeSBmaWxlcwogKGFsbG93IGZpbGUqCiAgICAgICAgKGhv bWUtc3VicGF0aCAiL0xpYnJhcnkvQ2FjaGVzL2NvbS5hcHBsZS5XZWJQcm9jZXNzIikKLSAgICAg ICAoaG9tZS1yZWdleCAiL0xpYnJhcnkvUHJlZmVyZW5jZXMvQnlIb3N0L2NvbVwuYXBwbGVcLkhJ VG9vbGJveFwuIikKLSAgICAgICAoaG9tZS1yZWdleCAiL0xpYnJhcnkvUHJlZmVyZW5jZXMvY29t XC5hcHBsZVwuV2ViUHJvY2Vzc1wuIikKKyAgICAgICAoaG9tZS1yZWdleCAjIi9MaWJyYXJ5L1By ZWZlcmVuY2VzL0J5SG9zdC9jb21cLmFwcGxlXC5ISVRvb2xib3hcLiIpCisgICAgICAgKGhvbWUt cmVnZXggIyIvTGlicmFyeS9QcmVmZXJlbmNlcy9jb21cLmFwcGxlXC5XZWJQcm9jZXNzXC4iKQog CiAgICAgICAgOzsgRklYTUU6IFRoaXMgc2hvdWxkIGJlIHJlbW92ZWQgd2hlbiA8cmRhcjovL3By b2JsZW0vMTA0Nzk2ODU+IGlzIGZpeGVkLgogICAgICAgIChob21lLXN1YnBhdGggIi9MaWJyYXJ5 L0tleWNoYWlucyIpKQpAQCAtOTYsOSArOTYsMTEgQEAKIChhbGxvdyBmaWxlKgogICAgIChzdWJw YXRoICIvcHJpdmF0ZS92YXIvZGIvbWRzL3N5c3RlbSIpKQogCi07OyBEYXJ3aW4gdGVtcG9yYXJ5 IGZpbGVzIGFuZCBTZWN1cml0eSBtZHMgY2FjaGVzLCBpZiBwcmVzZW50Cis7OyBGSVhNRTogPHJk YXI6Ly9wcm9ibGVtLzEwNzkyMDQ3PiBVc2UgcHJpdmF0ZSB1c2VyIGNhY2hlIGRpcmVjdG9yeQog KGlmIChwb3NpdGl2ZT8gKHN0cmluZy1sZW5ndGggKHBhcmFtICJEQVJXSU5fVVNFUl9DQUNIRV9E SVIiKSkpCiAgICAgKGFsbG93IGZpbGUqIChzdWJwYXRoIChzdHJpbmctYXBwZW5kIChwYXJhbSAi REFSV0lOX1VTRVJfQ0FDSEVfRElSIikgIi9tZHMiKSkpKQorCis7OyBGSVhNRTogPHJkYXI6Ly9w cm9ibGVtLzEwNzg1NDU3PiBVc2UgcHJpdmF0ZSB0ZW1wb3JhcnkgZGlyZWN0b3J5CiAoaWYgKHBv c2l0aXZlPyAoc3RyaW5nLWxlbmd0aCAocGFyYW0gIkRBUldJTl9VU0VSX1RFTVBfRElSIikpKQog ICAgIChhbGxvdyBmaWxlKiAoc3VicGF0aCAocGFyYW0gIkRBUldJTl9VU0VSX1RFTVBfRElSIikp KSkKIAo=