77553 2012-02-01 06:51:56 -0800 [SKIA/CHROMIUM] Perform getImageData format conversions using Skia 2012-02-01 11:21:52 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 bsalomon bsalomon mdelaney7 noel.gordon senorblanco webkit.review.bot oldest_to_newest 547060 0 bsalomon 2012-02-01 06:51:56 -0800 [SKIA/CHROMIUM] Perform getImageData format conversions using Skia 547063 1 124946 bsalomon 2012-02-01 06:55:07 -0800 Created attachment 124946 Patch 547067 2 bsalomon 2012-02-01 06:59:40 -0800 I filed bug 77550 regarding the 2d.gradient.interpolate.colouralpha.html failure with analysis about why it fails. My take is that it is an acceptable failure. If this lands I'll update 73952 since we would no longer be failing the 2d.imageData.put.unchanged.html test. 547209 3 124946 senorblanco 2012-02-01 10:56:29 -0800 Comment on attachment 124946 Patch Looks good. r=me 547228 4 124946 webkit.review.bot 2012-02-01 11:21:48 -0800 Comment on attachment 124946 Patch Clearing flags on attachment: 124946 Committed r106477: <http://trac.webkit.org/changeset/106477> 547229 5 webkit.review.bot 2012-02-01 11:21:52 -0800 All reviewed patches have been landed. Closing bug. 124946 2012-02-01 06:55:07 -0800 2012-02-01 11:21:48 -0800 Patch bug-77553-20120201095506.patch text/plain 6030 bsalomon SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNjQ2NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAyLTAxICBCcmlhbiBT YWxvbW9uICA8YnNhbG9tb25AZ29vZ2xlLmNvbT4KKworICAgICAgICBbU0tJQS9DSFJPTUlVTV0g UGVyZm9ybSBnZXRJbWFnZURhdGEgZm9ybWF0IGNvbnZlcnNpb25zIHVzaW5nIFNraWEKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3NTUzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFueSBleGlzdGluZyBj YW52YXMgdGVzdHMgZXhlcmNpc2UgdGhpcyBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Z2V0SW1hZ2VEYXRhKToKKwogMjAxMi0wMi0wMSAgU2hpbnlhIEthd2FuYWthICA8c2hpbnlh a0Bnb29nbGUuY29tPgogCiAgICAgICAgIENvbnRlbnQgZWxlbWVudCBzaG91bGQgYmUgYWJsZSB0 byBiZSBkeW5hbWljYWxseSBhZGRlZC9yZW1vdmVkL3JlcGxhY2VkIGluIGEgc2hhZG93IHRyZWUu CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVy U2tpYS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv c2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwCShyZXZpc2lvbiAxMDY0NjUpCisrKyBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTIyNiw2NSArMjI2LDE4IEBAIFBhc3NSZWZQdHI8Qnl0ZUFycmF5PiBnZXRJbWFn ZURhdGEoY29uc3QKICAgICAgICAgfHwgcmVjdC5tYXhZKCkgPiBzaXplLmhlaWdodCgpKQogICAg ICAgICBtZW1zZXQoZGF0YSwgMCwgcmVzdWx0LT5sZW5ndGgoKSk7CiAKLSAgICBpbnQgb3JpZ2lu WCA9IHJlY3QueCgpOwotICAgIGludCBkZXN0WCA9IDA7Ci0gICAgaWYgKG9yaWdpblggPCAwKSB7 Ci0gICAgICAgIGRlc3RYID0gLW9yaWdpblg7Ci0gICAgICAgIG9yaWdpblggPSAwOwotICAgIH0K LSAgICBpbnQgZW5kWCA9IHJlY3QubWF4WCgpOwotICAgIGlmIChlbmRYID4gc2l6ZS53aWR0aCgp KQotICAgICAgICBlbmRYID0gc2l6ZS53aWR0aCgpOwotICAgIGludCBudW1Db2x1bW5zID0gZW5k WCAtIG9yaWdpblg7Ci0KLSAgICBpZiAobnVtQ29sdW1ucyA8PSAwKQotICAgICAgICByZXR1cm4g cmVzdWx0LnJlbGVhc2UoKTsKLQotICAgIGludCBvcmlnaW5ZID0gcmVjdC55KCk7Ci0gICAgaW50 IGRlc3RZID0gMDsKLSAgICBpZiAob3JpZ2luWSA8IDApIHsKLSAgICAgICAgZGVzdFkgPSAtb3Jp Z2luWTsKLSAgICAgICAgb3JpZ2luWSA9IDA7Ci0gICAgfQotICAgIGludCBlbmRZID0gcmVjdC5t YXhZKCk7Ci0gICAgaWYgKGVuZFkgPiBzaXplLmhlaWdodCgpKQotICAgICAgICBlbmRZID0gc2l6 ZS5oZWlnaHQoKTsKLSAgICBpbnQgbnVtUm93cyA9IGVuZFkgLSBvcmlnaW5ZOwotCi0gICAgaWYg KG51bVJvd3MgPD0gMCkKLSAgICAgICAgcmV0dXJuIHJlc3VsdC5yZWxlYXNlKCk7Ci0KLSAgICBT a0JpdG1hcCBzcmNCaXRtYXA7Ci0gICAgaWYgKCFjYW52YXMtPnJlYWRQaXhlbHMoU2tJUmVjdDo6 TWFrZVhZV0gob3JpZ2luWCwgb3JpZ2luWSwgbnVtQ29sdW1ucywgbnVtUm93cyksICZzcmNCaXRt YXApKQotICAgICAgICByZXR1cm4gcmVzdWx0LnJlbGVhc2UoKTsKLQogICAgIHVuc2lnbmVkIGRl c3RCeXRlc1BlclJvdyA9IDQgKiByZWN0LndpZHRoKCk7Ci0gICAgdW5zaWduZWQgY2hhciogZGVz dFJvdyA9IGRhdGEgKyBkZXN0WSAqIGRlc3RCeXRlc1BlclJvdyArIGRlc3RYICogNDsKKyAgICBT a0JpdG1hcCBkZXN0Qml0bWFwOworICAgIGRlc3RCaXRtYXAuc2V0Q29uZmlnKFNrQml0bWFwOjpr QVJHQl84ODg4X0NvbmZpZywgcmVjdC53aWR0aCgpLCByZWN0LmhlaWdodCgpLCBkZXN0Qnl0ZXNQ ZXJSb3cpOworICAgIGRlc3RCaXRtYXAuc2V0UGl4ZWxzKGRhdGEpOwogCi0gICAgLy8gRG8gY29u dmVyc2lvbiBvZiBieXRlIG9yZGVyIGFuZCBhbHBoYSBkaXZpZGUgKGlmIG5lY2Vzc2FyeSkKLSAg ICBmb3IgKGludCB5ID0gMDsgeSA8IG51bVJvd3M7ICsreSkgewotICAgICAgICBTa1BNQ29sb3Iq IHNyY0JpdG1hcFJvdyA9IHNyY0JpdG1hcC5nZXRBZGRyMzIoMCwgeSk7Ci0gICAgICAgIGZvciAo aW50IHggPSAwOyB4IDwgbnVtQ29sdW1uczsgKyt4KSB7Ci0gICAgICAgICAgICBTa1BNQ29sb3Ig c3JjUE1Db2xvciA9IHNyY0JpdG1hcFJvd1t4XTsKLSAgICAgICAgICAgIHVuc2lnbmVkIGNoYXIq IGRlc3RQaXhlbCA9ICZkZXN0Um93W3ggKiA0XTsKLSAgICAgICAgICAgIGlmIChtdWx0aXBsaWVk ID09IFVubXVsdGlwbGllZCkgewotICAgICAgICAgICAgICAgIHVuc2lnbmVkIGNoYXIgYSA9IFNr R2V0UGFja2VkQTMyKHNyY1BNQ29sb3IpOwotICAgICAgICAgICAgICAgIGRlc3RQaXhlbFswXSA9 IGEgPyBTa0dldFBhY2tlZFIzMihzcmNQTUNvbG9yKSAqIDI1NSAvIGEgOiAwOwotICAgICAgICAg ICAgICAgIGRlc3RQaXhlbFsxXSA9IGEgPyBTa0dldFBhY2tlZEczMihzcmNQTUNvbG9yKSAqIDI1 NSAvIGEgOiAwOwotICAgICAgICAgICAgICAgIGRlc3RQaXhlbFsyXSA9IGEgPyBTa0dldFBhY2tl ZEIzMihzcmNQTUNvbG9yKSAqIDI1NSAvIGEgOiAwOwotICAgICAgICAgICAgICAgIGRlc3RQaXhl bFszXSA9IGE7Ci0gICAgICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgICAgIC8vIElucHV0 IGFuZCBvdXRwdXQgYXJlIGJvdGggcHJlLW11bHRpcGxpZWQsIHdlIGp1c3QgbmVlZCB0byByZS1h cnJhbmdlIHRoZQotICAgICAgICAgICAgICAgIC8vIGJ5dGVzIGZyb20gdGhlIGJpdG1hcCBmb3Jt YXQgdG8gUkdCQS4KLSAgICAgICAgICAgICAgICBkZXN0UGl4ZWxbMF0gPSBTa0dldFBhY2tlZFIz MihzcmNQTUNvbG9yKTsKLSAgICAgICAgICAgICAgICBkZXN0UGl4ZWxbMV0gPSBTa0dldFBhY2tl ZEczMihzcmNQTUNvbG9yKTsKLSAgICAgICAgICAgICAgICBkZXN0UGl4ZWxbMl0gPSBTa0dldFBh Y2tlZEIzMihzcmNQTUNvbG9yKTsKLSAgICAgICAgICAgICAgICBkZXN0UGl4ZWxbM10gPSBTa0dl dFBhY2tlZEEzMihzcmNQTUNvbG9yKTsKLSAgICAgICAgICAgIH0KLSAgICAgICAgfQotICAgICAg ICBkZXN0Um93ICs9IGRlc3RCeXRlc1BlclJvdzsKLSAgICB9CisgICAgU2tDYW52YXM6OkNvbmZp Zzg4ODggY29uZmlnODg4ODsKKyAgICBpZiAobXVsdGlwbGllZCA9PSBQcmVtdWx0aXBsaWVkKQor ICAgICAgICBjb25maWc4ODg4ID0gU2tDYW52YXM6OmtSR0JBX1ByZW11bF9Db25maWc4ODg4Owor ICAgIGVsc2UKKyAgICAgICAgY29uZmlnODg4OCA9IFNrQ2FudmFzOjprUkdCQV9VbnByZW11bF9D b25maWc4ODg4OwogCisgICAgY2FudmFzLT5yZWFkUGl4ZWxzKCZkZXN0Qml0bWFwLCByZWN0Lngo KSwgcmVjdC55KCksIGNvbmZpZzg4ODgpOwogICAgIHJldHVybiByZXN1bHQucmVsZWFzZSgpOwog fQogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDY0NjUpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAxMi0wMi0wMSAgQnJpYW4gU2Fsb21v biAgPGJzYWxvbW9uQGdvb2dsZS5jb20+CisKKyAgICAgICAgW1NLSUEvQ0hST01JVU1dIFBlcmZv cm0gZ2V0SW1hZ2VEYXRhIGZvcm1hdCBjb252ZXJzaW9ucyB1c2luZyBTa2lhCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzU1MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0v dGVzdF9leHBlY3RhdGlvbnMudHh0OgorCiAyMDEyLTAyLTAxICBTaGlueWEgS2F3YW5ha2EgIDxz aGlueWFrQGdvb2dsZS5jb20+CiAKICAgICAgICAgQ29udGVudCBlbGVtZW50IHNob3VsZCBiZSBh YmxlIHRvIGJlIGR5bmFtaWNhbGx5IGFkZGVkL3JlbW92ZWQvcmVwbGFjZWQgaW4gYSBzaGFkb3cg dHJlZS4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRp b25zLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0 X2V4cGVjdGF0aW9ucy50eHQJKHJldmlzaW9uIDEwNjQ2NSkKKysrIExheW91dFRlc3RzL3BsYXRm b3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMjM3 OSw3ICsyMzc5LDcgQEAgQlVHQ1I2MTczOSBXSU4gUkVMRUFTRSA6IGFuaW1hdGlvbnMvc3VzcAog Ly8gU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTk4MiBmb3Ig bW9yZSBpbmZvLgogQlVHV0s1MjUwOSBMSU5VWCBXSU4gOiBzdmcvY3NzL3JlY3QtZ3JhZGllbnQt c3Ryb2tlLXNoYWRvdy5zdmcgPSBJTUFHRQogQlVHV0s1MjUwOSBMRU9QQVJEIDogc3ZnL2Nzcy9y ZWN0LWdyYWRpZW50LXN0cm9rZS1zaGFkb3cuc3ZnID0gSU1BR0UKLUJVR0NSNjM5MjEgTElOVVgg V0lOIENQVSA6IGZhc3QvY2FudmFzL2NhbnZhcy1maWxsUGF0aC1zaGFkb3cuaHRtbCA9IFRFWFQK K0JVR0NSNjM5MjEgTElOVVggV0lOIDogZmFzdC9jYW52YXMvY2FudmFzLWZpbGxQYXRoLXNoYWRv dy5odG1sID0gVEVYVAogCiAvLyBNYWlubHkgZmxha3kgd2l0aCBtYWMgZGVidWcsIGJ1dCBhbHNv IGludGVybWl0dGVudCBjcmFzaGVzIHNlZW4gb24gbGludXggYW5kIHdpbmRvd3MKIEJVR0NSNjQx MjkgOiBmYXN0L2ZpbGVzL3Jldm9rZS1ibG9iLXVybC5odG1sID0gUEFTUyBDUkFTSApAQCAtMjU5 MSwxMSArMjU5MSw5IEBAIEJVR0NSNzE3ODMgOiBzY3JvbGxiYXJzL2N1c3RvbS1zY3JvbGxiYXIK IC8vIEdQVQogLy8KIAotLy8gVGhpcyB0ZXN0IGV4cGVjdHMgdGhhdCBwdXRJbWFnZURhdGEgZm9s bG93ZWQgYnkgZ2V0SW1hZ2VEYXRhIGF0IHRoZSBzYW1lIGxvY2F0aW9uCi0vLyB3aWxsIHJldHVy biB0aGUgZXhhY3Qgc2FtZSBwaXhlbCB2YWx1ZXMuIEhvd2V2ZXIsIHRoZSBzcGVjIGFsbG93cyBz b21lIGZ1enppbmVzcwotLy8gZHVlIHRvIGNvbnZlcnNpb24gdG8vZnJvbSBwcmVtdWx0aXBsaWVk LWFscGhhLiBXaGVuIHdlIGRvIHRoZSBjb252ZXJzaW9ucyBvbiB0aGUKLS8vIEdQVSB3ZSBtYXkg YmUgb2ZmIGJ5IG9uZSBpbiByLCBnLCBhbmQvb3IgYi4KLUJVR1dLNzM5NTIgR1BVIDogY2FudmFz L3BoaWxpcC90ZXN0cy8yZC5pbWFnZURhdGEucHV0LnVuY2hhbmdlZC5odG1sID0gVEVYVAorLy8g Q29tYmluYXRpb24gb2YgdW5wcmVtdWwgcGx1cyBncmFkaWVudCBjb21wdXRhdGlvbiBhdCBoYWxm LWludGVnZXIgY29vcmRzIGNhdXNlcworLy8gdGhpcyB0byBmYWlsLgorQlVHV0s3NzU1MCBHUFUg OiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmdyYWRpZW50LmludGVycG9sYXRlLmNvbG91cmFscGhh Lmh0bWwgPSBURVhUCiAKIC8vIFRoZXNlIHdpbGwgaGF2ZSBzbGlnaHQgZGlmZmVyZW5jZXMgb24g dGhlIGVkZ2VzIG9mIGFudGlhbGlhc2VkIHBhdGhzIGFuZCBuZWVkIHJlYmFzZWxpbmcKIEJVR0JT QUxPTU9OIEdQVSA6IGZhc3QvY2FudmFzL2FyYzM2MC5odG1sID0gSU1BR0UK