77550 2012-02-01 06:45:38 -0800 [CHROMIUM/SKIA] canvas/philip/tests/2d.gradient.interpolate.colouralpha.html fails in GPU 2013-04-09 13:14:12 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 1 bsalomon bsalomon mdelaney7 reed schenney senorblanco webkit.review.bot oldest_to_newest 547056 0 bsalomon 2012-02-01 06:45:38 -0800 This test passes fails in the GPU Skia backend when we do the getImageData unpremultiply step on the GPU. The test draws a gradient from c1=(255, 255, 0, 0) to c2=(0, 0, 255, 255) on a x = 0 ... 100 rectangle. It samples the rect at x = 25, 50, and 75. At each sample it asserts that the read value's color components are within three of the expected value. The color expected is (191, 191, 63, 63) which roughly corresponds to .75*c1 + .25*c2 = (191.25, 191.25, 63.75, 63.75). Skia computes the same premultiplied value at the sample point in both the GPU and CPU backends (48, 48, 17, 65). Unpremultiplying gives approximately (188.31, 188.31, 66.69, 65). In the code path where the unpremultiply step is done on the CPU in WebKit code the final value is (188, 188, 66, 65) which barely passes. When the GPU unpremultiply conversion is used Skia gets (188, 188, 67, 65) and so fails by the blue component. Though the GPU conversion pushes us over the edge to failing the test, it isn't the fundamental reason why we fail. The gradient spans the range x = 0 to 100 but Skia samples it at pixel centers falling halfway between integer coords. So we are sampling the gradient at x = 0.5, 1.5,..., 99.5. When we read back the 25th pixel we're getting Skia's computation of .255 * c1 + .745 * c2. The exact answer would be (189.975, 189.75, 65.25, 65.25). If the reference color was the exact color at 25.5 rounded it would be (190, 190, 65, 65) and Skia would pass. Is the current reference color incorrect? Is Skia computing the gradient incorrectly? I took a look at the canvas spec and didn't see anything that clarified this issue. 675317 1 senorblanco 2012-07-22 09:34:10 -0700 This seems to have been fixed by the skia roll 4647-4683, most likely by Riley's linear gradient change in https://code.google.com/p/skia/source/detail?r=4680. 706319 2 bsalomon 2012-08-28 07:29:43 -0700 Reopening to attach new patch. 706320 3 160972 bsalomon 2012-08-28 07:29:45 -0700 Created attachment 160972 Patch 706322 4 bsalomon 2012-08-28 07:30:19 -0700 It turns out that this was not really fixed. In the range of the Skia roll where this started passing TomH made a changesto the shader generator which inadvertently broke the gpu-based unpremul<->premul conversions. We fell back to SW conversions and went back to barely passing the test because the conversions come out slightly different. The next Skia roll fixes the gpu-based conversions and so this test (along with canvas-fillPath-shadow.html which was also removed in r123297) will fail once again. The attached patch reverts the removal of these tests from TE. 706345 5 160972 senorblanco 2012-08-28 07:55:53 -0700 Comment on attachment 160972 Patch Darn. r=me 708583 6 160972 bsalomon 2012-08-30 07:02:58 -0700 Comment on attachment 160972 Patch I held off on c? so that it wouldn't hit before the skia roll makes it to WK DEPS (and get reverted due to unexpected pass) but that has happened. So I think this is good to go. 708592 7 160972 webkit.review.bot 2012-08-30 07:14:43 -0700 Comment on attachment 160972 Patch Rejecting attachment 160972 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13685753 708838 8 161517 bsalomon 2012-08-30 11:02:46 -0700 Created attachment 161517 Patch 708840 9 161517 bsalomon 2012-08-30 11:03:19 -0700 Comment on attachment 161517 Patch I messed up the Reviewed By line in the original patch. :( 716262 10 163164 bsalomon 2012-09-10 10:49:06 -0700 Created attachment 163164 Patch 716311 11 163164 senorblanco 2012-09-10 11:24:38 -0700 Comment on attachment 163164 Patch OK, bots willing. r=me. 716377 12 163164 webkit.review.bot 2012-09-10 12:44:07 -0700 Comment on attachment 163164 Patch Rejecting attachment 163164 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ): Merge conflict in LayoutTests/ChangeLog Failed to merge in the changes. Patch failed at 0001 Javascript in foreground tabs should not wait synchronously for plug-ins to load When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13810328 160972 2012-08-28 07:29:45 -0700 2012-08-30 11:02:43 -0700 Patch bug-77550-20120828102936.patch text/plain 2002 bsalomon SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEyNjg3NCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA4LTI4ICBCcmlhbiBTYWxvbW9uICA8 YmFzbG9tb25AZ29vZ2xlLmNvbT4KKworICAgICAgICBbQ0hST01JVU0vU0tJQV0gY2FudmFzL3Bo aWxpcC90ZXN0cy8yZC5ncmFkaWVudC5pbnRlcnBvbGF0ZS5jb2xvdXJhbHBoYS5odG1sIGZhaWxz IGluIEdQVQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Nzc1NTAKKworICAgICAgICBBZGRpbmcgdGhlIGZvbGxvd2luZyB0ZXN0cyBiYWNrIHRvIFRlc3RF eHBlY3RhdGlvbnM6CisgICAgICAgIHBsYXRmb3JtL2Nocm9taXVtL3ZpcnR1YWwvZ3B1L2NhbnZh cy9waGlsaXAvdGVzdHMvMmQuZ3JhZGllbnQuaW50ZXJwb2xhdGUuY29sb3VyYWxwaGEuaHRtbAor ICAgICAgICBwbGF0Zm9ybS9jaHJvbWl1bS92aXJ0dWFsL2dwdS9mYXN0L2NhbnZhcy9jYW52YXMt ZmlsbFBhdGgtc2hhZG93Lmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1Rlc3RF eHBlY3RhdGlvbnM6CisKIDIwMTItMDgtMjggIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1 bmcuY29tPgogCiAgICAgICAgIFtFRkxdW1dLMl1bV1RSXSBSZWJhc2VsaW5lIG5ld2x5IGFkZGVk IFNWRyB0ZXh0IHRlc3QgY2FzZXMKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVt L1Rlc3RFeHBlY3RhdGlvbnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hy b21pdW0vVGVzdEV4cGVjdGF0aW9ucwkocmV2aXNpb24gMTI2ODc0KQorKysgTGF5b3V0VGVzdHMv cGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9ucwkod29ya2luZyBjb3B5KQpAQCAtMjA4 OCw2ICsyMDg4LDcgQEAgQlVHQ1I2MTczOSBXSU4gUkVMRUFTRSA6IGFuaW1hdGlvbnMvc3VzcAog Ly8gTmV3IHRlc3RzIGFkZGVkIHdpdGggaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQv NzI0NzIgYW5kIGZ1cnRoZXIuCiAvLyBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTUxOTgyIGZvciBtb3JlIGluZm8uCiBCVUdDUjYzOTIxIDogZmFzdC9jYW52YXMv Y2FudmFzLWZpbGxQYXRoLXNoYWRvdy5odG1sID0gVEVYVAorQlVHQ1I2MzkyMSA6IHBsYXRmb3Jt L2Nocm9taXVtL3ZpcnR1YWwvZ3B1L2Zhc3QvY2FudmFzL2NhbnZhcy1maWxsUGF0aC1zaGFkb3cu aHRtbCA9IFRFWFQKIAogLy8gRklYTUU6IE5lZWQgdG8gYWRkIHRvb2xpbmcgc3VwcG9ydCBmb3Ig VjggYnVncy4KIEJVR1Y4Xzk1MyA6IGZhc3QvcmVnZXgvcGNyZS10ZXN0LTEuaHRtbCA9IFRJTUVP VVQKQEAgLTIyMjQsNiArMjIyNSw5IEBAIEJVR0NSNzE3ODMgTElPTiBTTk9XTEVPUEFSRCA6IHNj cm9sbGJhcnMKIC8vIEdQVQogLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KIAorLy8gQ29tYmluYXRpb24g b2YgdW5wcmVtdWwgcGx1cyBncmFkaWVudCBjb21wdXRhdGlvbiBhdCBoYWxmLWludGVnZXIgY29v cmRzIGNhdXNlcyAKKy8vIHRoaXMgdG8gZmFpbC4gCitCVUdXSzc3NTUwIDogcGxhdGZvcm0vY2hy b21pdW0vdmlydHVhbC9ncHUvY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5ncmFkaWVudC5pbnRlcnBv bGF0ZS5jb2xvdXJhbHBoYS5odG1sID0gVEVYVAogCiBCVUdXSzQ3OTIzIDogY29tcG9zaXRpbmcv Z2VvbWV0cnkvbGltaXQtbGF5ZXItYm91bmRzLW9wYWNpdHktdHJhbnNpdGlvbi5odG1sID0gVElN RU9VVAogCg== 161517 2012-08-30 11:02:46 -0700 2012-09-10 10:49:04 -0700 Patch bug-77550-20120830140235.patch text/plain 2047 bsalomon SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEyNzE2 MCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA4 LTMwICBCcmlhbiBTYWxvbW9uICA8YnNhbG9tb25AZ29vZ2xlLmNvbT4KKworICAgICAgICBbQ0hS T01JVU0vU0tJQV0gY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5ncmFkaWVudC5pbnRlcnBvbGF0ZS5j b2xvdXJhbHBoYS5odG1sIGZhaWxzIGluIEdQVQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzc1NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGRpbmcgdGhlIGZvbGxvd2luZyB0ZXN0cyBiYWNrIHRvIFRl c3RFeHBlY3RhdGlvbnM6CisgICAgICAgIHBsYXRmb3JtL2Nocm9taXVtL3ZpcnR1YWwvZ3B1L2Nh bnZhcy9waGlsaXAvdGVzdHMvMmQuZ3JhZGllbnQuaW50ZXJwb2xhdGUuY29sb3VyYWxwaGEuaHRt bAorICAgICAgICBwbGF0Zm9ybS9jaHJvbWl1bS92aXJ0dWFsL2dwdS9mYXN0L2NhbnZhcy9jYW52 YXMtZmlsbFBhdGgtc2hhZG93Lmh0bWwKKworICAgICAgICAqIC4uLy4uL0xheW91dFRlc3RzL3Bs YXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTItMDgtMjkgIFRoaWFnbyBN YWNpZWlyYSAgPHRoaWFnby5tYWNpZWlyYUBpbnRlbC5jb20+CiAKICAgICAgICAgVGVsbCBnaXQt YXJjaGl2ZSB0byBub3QgZXhwb3J0IC5naXRhdHRyaWJ1dGVzIGFuZCAuZ2l0aWdub3JlCkluZGV4 OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMJKHJl dmlzaW9uIDEyNzEzNCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBl Y3RhdGlvbnMJKHdvcmtpbmcgY29weSkKQEAgLTIxNDAsNiArMjE0MCw3IEBAIEJVR0NSNjE3Mzkg V0lOIFJFTEVBU0UgOiBhbmltYXRpb25zL3N1c3AKIC8vIE5ldyB0ZXN0cyBhZGRlZCB3aXRoIGh0 dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzcyNDcyIGFuZCBmdXJ0aGVyLgogLy8gU2Vl IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTk4MiBmb3IgbW9yZSBp bmZvLgogQlVHQ1I2MzkyMSA6IGZhc3QvY2FudmFzL2NhbnZhcy1maWxsUGF0aC1zaGFkb3cuaHRt bCA9IFRFWFQKK0JVR0NSNjM5MjEgOiBwbGF0Zm9ybS9jaHJvbWl1bS92aXJ0dWFsL2dwdS9mYXN0 L2NhbnZhcy9jYW52YXMtZmlsbFBhdGgtc2hhZG93Lmh0bWwgPSBURVhUCiAKIC8vIEZJWE1FOiBO ZWVkIHRvIGFkZCB0b29saW5nIHN1cHBvcnQgZm9yIFY4IGJ1Z3MuCiBCVUdWOF85NTMgOiBmYXN0 L3JlZ2V4L3BjcmUtdGVzdC0xLmh0bWwgPSBUSU1FT1VUCkBAIC0yMjc2LDYgKzIyNzcsOSBAQCBC VUdDUjcxNzgzIExJT04gU05PV0xFT1BBUkQgOiBzY3JvbGxiYXJzCiAvLyBHUFUKIC8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vCiAKKy8vIENvbWJpbmF0aW9uIG9mIHVucHJlbXVsIHBsdXMgZ3JhZGllbnQg Y29tcHV0YXRpb24gYXQgaGFsZi1pbnRlZ2VyIGNvb3JkcyBjYXVzZXMgCisvLyB0aGlzIHRvIGZh aWwuIAorQlVHV0s3NzU1MCA6IHBsYXRmb3JtL2Nocm9taXVtL3ZpcnR1YWwvZ3B1L2NhbnZhcy9w aGlsaXAvdGVzdHMvMmQuZ3JhZGllbnQuaW50ZXJwb2xhdGUuY29sb3VyYWxwaGEuaHRtbCA9IFRF WFQKIAogQlVHV0s0NzkyMyBXSU4gTElOVVggTUFDIDogY29tcG9zaXRpbmcvZ2VvbWV0cnkvbGlt aXQtbGF5ZXItYm91bmRzLW9wYWNpdHktdHJhbnNpdGlvbi5odG1sID0gVElNRU9VVAogCg== 163164 2012-09-10 10:49:06 -0700 2013-04-09 13:14:12 -0700 Patch bug-77550-20120910134842.patch text/plain 2022 bsalomon SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEyODA3 NykKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA5 LTEwICBCcmlhbiBTYWxvbW9uICA8YnNhbG9tb25AZ29vZ2xlLmNvbT4KKworICAgICAgICBbQ0hS T01JVU0vU0tJQV0gY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5ncmFkaWVudC5pbnRlcnBvbGF0ZS5j b2xvdXJhbHBoYS5odG1sIGZhaWxzIGluIEdQVQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzc1NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGRpbmcgdGhlIGZvbGxvd2luZyB0ZXN0cyBiYWNrIHRvIFRl c3RFeHBlY3RhdGlvbnM6CisgICAgICAgIHBsYXRmb3JtL2Nocm9taXVtL3ZpcnR1YWwvZ3B1L2Nh bnZhcy9waGlsaXAvdGVzdHMvMmQuZ3JhZGllbnQuaW50ZXJwb2xhdGUuY29sb3VyYWxwaGEuaHRt bAorICAgICAgICBwbGF0Zm9ybS9jaHJvbWl1bS92aXJ0dWFsL2dwdS9mYXN0L2NhbnZhcy9jYW52 YXMtZmlsbFBhdGgtc2hhZG93Lmh0bWwKKworICAgICAgICAqIC4uLy4uL0xheW91dFRlc3RzL3Bs YXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTItMDktMTAgIFRoaWFnbyBN YXJjb3MgUC4gU2FudG9zICA8dGhpYWdvLnNhbnRvc0BpbnRlbC5jb20+CiAKICAgICAgICAgW0NN YWtlXVtFRkxdIEVuYWJsZSB0aGUgTExJbnQKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2No cm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZv cm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9ucwkocmV2aXNpb24gMTI4MDc3KQorKysgTGF5b3V0 VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9ucwkod29ya2luZyBjb3B5KQpA QCAtMjEwMiw2ICsyMTAyLDcgQEAgQlVHQ1I2MTczOSBXSU4gUkVMRUFTRSA6IGFuaW1hdGlvbnMv c3VzcAogLy8gTmV3IHRlc3RzIGFkZGVkIHdpdGggaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFu Z2VzZXQvNzI0NzIgYW5kIGZ1cnRoZXIuCiAvLyBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTUxOTgyIGZvciBtb3JlIGluZm8uCiBCVUdDUjYzOTIxIDogZmFzdC9j YW52YXMvY2FudmFzLWZpbGxQYXRoLXNoYWRvdy5odG1sID0gVEVYVAorQlVHQ1I2MzkyMSA6IHBs YXRmb3JtL2Nocm9taXVtL3ZpcnR1YWwvZ3B1L2Zhc3QvY2FudmFzL2NhbnZhcy1maWxsUGF0aC1z aGFkb3cuaHRtbCA9IFRFWFQKIAogLy8gRklYTUU6IE5lZWQgdG8gYWRkIHRvb2xpbmcgc3VwcG9y dCBmb3IgVjggYnVncy4KIEJVR1Y4Xzk1MyA6IGZhc3QvcmVnZXgvcGNyZS10ZXN0LTEuaHRtbCA9 IFRJTUVPVVQKQEAgLTIyMzgsNiArMjIzOSw5IEBAIEJVR0NSNzE3ODMgTElPTiBTTk9XTEVPUEFS RCA6IHNjcm9sbGJhcnMKIC8vIEdQVQogLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KIAorLy8gQ29tYmlu YXRpb24gb2YgdW5wcmVtdWwgcGx1cyBncmFkaWVudCBjb21wdXRhdGlvbiBhdCBoYWxmLWludGVn ZXIgY29vcmRzIGNhdXNlcyAKKy8vIHRoaXMgdG8gZmFpbC4gCitCVUdXSzc3NTUwIDogcGxhdGZv cm0vY2hyb21pdW0vdmlydHVhbC9ncHUvY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5ncmFkaWVudC5p bnRlcnBvbGF0ZS5jb2xvdXJhbHBoYS5odG1sID0gVEVYVAogCiBCVUdXSzQ3OTIzIFdJTiBMSU5V WCBNQUMgOiBjb21wb3NpdGluZy9nZW9tZXRyeS9saW1pdC1sYXllci1ib3VuZHMtb3BhY2l0eS10 cmFuc2l0aW9uLmh0bWwgPSBUSU1FT1VUCiAK