77533 2012-02-01 01:53:47 -0800 [Qt] JSC build should handle --no-webkit2 option to avoid unwanted clean-builds 2012-04-17 09:27:09 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 hnandor webkit-unassigned dbates eric ossy vestbo webkit.review.bot oldest_to_newest 546920 0 hnandor 2012-02-01 01:53:47 -0800 This bug is made because of https://bugs.webkit.org/show_bug.cgi?id=74519 If we want to build only JavaScriptCore there may be an unwanted clean-build, because there may be defines that can be found after building WebKit, but cannot found when it is built with the --no-webkit2 option. 546923 1 124910 hnandor 2012-02-01 01:58:56 -0800 Created attachment 124910 Modifications in build-jsc As far as I know, we do not use the --no-webkit2 option on bots, so passing the option to build-jsc by hand is solvable. 546953 2 124910 vestbo 2012-02-01 02:39:41 -0800 Comment on attachment 124910 Modifications in build-jsc I'd rather we silently pick up BUILD_WEBKIT_ARGS, like in build-webkit, then introduce a new option to build-jsc that does not make sense for a user passing --help 547030 3 124936 hnandor 2012-02-01 05:38:30 -0800 Created attachment 124936 Modifications in build-jsc (In reply to comment #2) This patch picks up the option from BUILD_WEBKIT_ARGS, as you suggested. With this, if I understand it correctly, before want to build JSC without wk2, we have to put the --no-webkit2 option to the mentioned environment variable. 547043 4 124936 vestbo 2012-02-01 06:14:41 -0800 Comment on attachment 124936 Modifications in build-jsc View in context: https://bugs.webkit.org/attachment.cgi?id=124936&action=review > Tools/Scripts/build-jsc:79 > + if ($ENV{'BUILD_WEBKIT_ARGS'}) { How about an unconditional push @ARGV, split(/ /, $ENV{'BUILD_WEBKIT_ARGS'}) if ($ENV{'BUILD_WEBKIT_ARGS'}); > Tools/Scripts/build-jsc:85 > + push @buildWebKitArgs, split(/ /, $ENV{'BUILD_WEBKIT_ARGS'}); > + foreach (@buildWebKitArgs) { > + if ($_ eq '--no-webkit2') { > + push @ARGV, "--qmakearg=CONFIG+=no_webkit2"; > + } And then a push @ARGV, "--qmakearg=CONFIG+=no_webkit2" if checkForArgumentAndRemoveFromARGV("--no-webkit2"); 547055 5 ossy 2012-02-01 06:43:43 -0800 Or what if making isWK2() handle --no-webkit2, not only -2? And then we can use it instead of foreach or checkForArgumentAndRemoveFromARGV. It would good for build-webkit script too. 547076 6 vestbo 2012-02-01 07:34:53 -0800 (In reply to comment #5) > Or what if making isWK2() handle --no-webkit2, not only -2? And then we can use it instead of foreach or checkForArgumentAndRemoveFromARGV. It would good for build-webkit script too. That would be an option. Though it would change the default from 0 to 1. 547724 7 125095 hnandor 2012-02-02 01:02:29 -0800 Created attachment 125095 Patch (In reply to comment #5) I tried it, but it is impossible to indicate 3 cases with one bool variable. I mean if we put this into isWK2(): if (checkForArgumentAndRemoveFromARGV("-2")) { $isWK2 = 0; } elsif (checkForArgumentAndRemoveFromARGV("--no-webkit2")){ $isWK2 = 1; } else { $isWK2 = 0; } or other combination of ifs, it would be incorrect, I think. I tried to write an isNotWK2() function, but if in it we use in it the $isWK2 too, its value depends on whether isWK2() or isNotWK2() function was called sooner. But if we use a new, e.g. $isNotWK2 variable in it, it would be incomprehensible why we use $isWK2 and $isNotWK2 too. (In reply to comment #4) Ok, I have done that, but I do not understand why can we pass on all the other unchecked options in BUILD_WEBKIT_ARGS to the buildQMakeProjects. 554177 8 125095 eric 2012-02-10 10:29:03 -0800 Comment on attachment 125095 Patch Do we normally do this transition in the main script like this? don't we have helper functions in one of our perl libraries for this? 558026 9 hnandor 2012-02-16 02:46:25 -0800 (In reply to comment #8) > (From update of attachment 125095 [details]) > Do we normally do this transition in the main script like this? don't we have helper functions in one of our perl libraries for this? build-webkit does similar thing in line ~578: push @options, "--qmakearg=CONFIG+=no_webkit2" if $noWebKit2; but it does not use helper function for it. I did not find any other method which can be used here. 592015 10 hnandor 2012-03-30 03:43:05 -0700 (In reply to comment #9) Is there any reaction related to my patch, is it OK? I couldn't find a simpler way to solve it. 592065 11 125095 vestbo 2012-03-30 05:03:31 -0700 Comment on attachment 125095 Patch I think there's other ways to solve this, but those would be more intrusive and require more time, so this is good for now. 592070 12 125095 webkit.review.bot 2012-03-30 05:07:03 -0700 Comment on attachment 125095 Patch Rejecting attachment 125095 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ', u'--force', u'--reviewer', u'Tor Arne V..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/Scripts/build-jsc Hunk #1 FAILED at 74. 1 out of 1 hunk FAILED -- saving rejects to file Tools/Scripts/build-jsc.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Tor Arne V..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12288197 593215 13 135032 hnandor 2012-04-02 00:19:19 -0700 Created attachment 135032 Patch The build-jsc is modified, in my opinion that is why the review bot could not run. I redo the modifications with the latest revision. 603953 14 ossy 2012-04-17 05:46:43 -0700 ping review? 604075 15 135032 webkit.review.bot 2012-04-17 09:27:03 -0700 Comment on attachment 135032 Patch Clearing flags on attachment: 135032 Committed r114387: <http://trac.webkit.org/changeset/114387> 604076 16 webkit.review.bot 2012-04-17 09:27:09 -0700 All reviewed patches have been landed. Closing bug. 124910 2012-02-01 01:58:56 -0800 2012-02-01 05:38:30 -0800 Modifications in build-jsc buildjsc.diff text/plain 1724 hnandor ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxYzY3 Njc1Li5iMDg3MzViIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDItMDEgIE7DoW5kb3IgSHVzemthICA8aHVz emthLm5hbmRvckBzdHVkLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFtRdF0gSlNDIGJ1aWxkIHNo b3VsZCBoYW5kbGUgLS1uby13ZWJraXQyIG9wdGlvbiB0byBhdm9pZCB1bndhbnRlZCBjbGVhbi1i dWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3 NTMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGFz cyAtLW5vLXdlYmtpdDIgb3B0aW9uIHRvIGJ1aWxkUU1ha2VQcm9qZWN0cyB0byBhdm9pZCB1bndh bnRlZCBjbGVhbiBidWlsZAorICAgICAgICBpZiBXZWJLaXQgd2FzIGJ1aWxkIGJ5IHRoZSBzYW1l IG9wdGlvbi4gQXMgYSByZXN1bHQgaXQgaXMgbmVlZGVkCisgICAgICAgIHRvIGNhbGwgYnVpbGQt anNjIHdpdGggdGhpcyBvcHRpb24gaWYgd2UgcGFzc2VkIGl0IHRvIGJ1aWxkLXdlYmtpdC4KKwor ICAgICAgICAqIHFtYWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVyZXMucHJmOgorCiAyMDEyLTAy LTAxICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4gYW5kIFNlcmdpbyBW aWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg TWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9idWlsZC1qc2MgYi9U b29scy9TY3JpcHRzL2J1aWxkLWpzYwppbmRleCAyZGE5ZWU5Li5kYjEyNzQwIDEwMDc1NQotLS0g YS9Ub29scy9TY3JpcHRzL2J1aWxkLWpzYworKysgYi9Ub29scy9TY3JpcHRzL2J1aWxkLWpzYwpA QCAtMzcsNiArMzcsNyBAQCB1c2UgUE9TSVg7CiAKIG15ICRjb3ZlcmFnZVN1cHBvcnQgPSAwOwog bXkgJHNob3dIZWxwID0gMDsKK215ICRub1dlYktpdDIgPSAwOwogCiBteSAkcHJvZ3JhbU5hbWUg PSBiYXNlbmFtZSgkMCk7CiBteSAkdXNhZ2UgPSA8PEVPRjsKQEAgLTQ3LDcgKzQ4LDggQEAgRU9G CiAKIEdldE9wdGlvbnMoCiAgICAgJ2NvdmVyYWdlIScgPT4gXCRjb3ZlcmFnZVN1cHBvcnQsCi0g ICAgJ2hlbHAnID0+IFwkc2hvd0hlbHAKKyAgICAnaGVscCcgPT4gXCRzaG93SGVscCwKKyAgICAn bm8td2Via2l0MicgPT4gXCRub1dlYktpdDIKICk7CiAKIGlmICgkc2hvd0hlbHApIHsKQEAgLTc0 LDYgKzc2LDcgQEAgaWYgKGlzQXBwbGVNYWNXZWJLaXQoKSkgewogICAgICMgUmVtb3ZlIGR1cGxp Y2F0ZWQgLS1xdCBvcHRpb25zIHRvIGF2b2lkIHBhc3NpbmcgdGhlbSB0byBxbWFrZQogICAgIGNo ZWNrRm9yQXJndW1lbnRBbmRSZW1vdmVGcm9tQVJHVigiLS1xdCIpOwogICAgIG15IEBwcm9qZWN0 cyA9ICgiV1RGIiwgIkphdmFTY3JpcHRDb3JlIik7CisgICAgcHVzaCBAQVJHViwgIi0tcW1ha2Vh cmc9Q09ORklHKz1ub193ZWJraXQyIiBpZiAkbm9XZWJLaXQyOwogICAgICRyZXN1bHQgPSBidWls ZFFNYWtlUHJvamVjdHMoXEBwcm9qZWN0cywgMCwgQEFSR1YpOwogfSBlbHNpZiAoaXNXeCgpKSB7 CiAgICAgIyBCdWlsZHMgZXZlcnl0aGluZyBpbiBvbmUtc2hvdC4gTm8gbmVlZCB0byBidWlsZCBh bnl0aGluZyBoZXJlLgo= 124936 2012-02-01 05:38:30 -0800 2012-02-02 01:02:29 -0800 Modifications in build-jsc buildjsc.diff text/plain 1684 hnandor ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwYmFh YWZiLi43OGQ2OGEzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTItMDItMDEgIE7DoW5kb3IgSHVzemthICA8aHVz emthLm5hbmRvckBzdHVkLnUtc3plZ2VkLmh1PgogCisgICAgICAgIFtRdF0gSlNDIGJ1aWxkIHNo b3VsZCBoYW5kbGUgLS1uby13ZWJraXQyIG9wdGlvbiB0byBhdm9pZCB1bndhbnRlZCBjbGVhbi1i dWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3 NTMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGlj ayB1cCB0aGUgLS1uby13ZWJraXQyIG9wdGlvbiBmcm9tIEJVSUxEX1dFQktJVF9BUkdTIGFuZCBw YXNzIG9uCisgICAgICAgIHRoZSBjb3JyZXNwb25kaW5nIHBhcmFtZXRlciB0byB0aGUgYnVpbGRR TWFrZVByb2plY3RzIGZ1bmN0aW9uLgorCisgICAgICAgICogU2NyaXB0cy9idWlsZC1qc2M6CisK KzIwMTItMDItMDEgIE7DoW5kb3IgSHVzemthICA8aHVzemthLm5hbmRvckBzdHVkLnUtc3plZ2Vk Lmh1PgorCiAgICAgICAgIFtRdF0gQXV0b21hdGljIGNsZWFuIGJ1aWxkIGZlYXR1cmUgYWx3YXlz IGRvIGNsZWFuIGJ1aWxkIHdpdGggLS1uby13ZWJraXQyCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDUxOQogCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL2J1aWxkLWpzYyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjCmluZGV4IDJkYTllZTkuLjZl NWUzMGYgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjCisrKyBiL1Rvb2xzL1Nj cmlwdHMvYnVpbGQtanNjCkBAIC03NCw2ICs3NCwxOCBAQCBpZiAoaXNBcHBsZU1hY1dlYktpdCgp KSB7CiAgICAgIyBSZW1vdmUgZHVwbGljYXRlZCAtLXF0IG9wdGlvbnMgdG8gYXZvaWQgcGFzc2lu ZyB0aGVtIHRvIHFtYWtlCiAgICAgY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZyb21BUkdWKCIt LXF0Iik7CiAgICAgbXkgQHByb2plY3RzID0gKCJXVEYiLCAiSmF2YVNjcmlwdENvcmUiKTsKKwor ICAgICMgUGljayB1cCB0aGUgLS1uby13ZWJraXQyIG9wdGlvbiBmcm9tIEJVSUxEX1dFQktJVF9B UkdTIGlmIGl0IGlzIG5lZWRlZAorICAgIGlmICgkRU5WeydCVUlMRF9XRUJLSVRfQVJHUyd9KSB7 CisgICAgICAgIG15IEBidWlsZFdlYktpdEFyZ3MgPSAoKTsKKyAgICAgICAgcHVzaCBAYnVpbGRX ZWJLaXRBcmdzLCBzcGxpdCgvIC8sICRFTlZ7J0JVSUxEX1dFQktJVF9BUkdTJ30pOworICAgICAg ICBmb3JlYWNoIChAYnVpbGRXZWJLaXRBcmdzKSB7CisgICAgICAgICAgICBpZiAoJF8gZXEgJy0t bm8td2Via2l0MicpIHsKKyAgICAgICAgICAgICAgICBwdXNoIEBBUkdWLCAiLS1xbWFrZWFyZz1D T05GSUcrPW5vX3dlYmtpdDIiOworICAgICAgICAgICAgfQorICAgICAgICB9CisgICAgfQorCiAg ICAgJHJlc3VsdCA9IGJ1aWxkUU1ha2VQcm9qZWN0cyhcQHByb2plY3RzLCAwLCBAQVJHVik7CiB9 IGVsc2lmIChpc1d4KCkpIHsKICAgICAjIEJ1aWxkcyBldmVyeXRoaW5nIGluIG9uZS1zaG90LiBO byBuZWVkIHRvIGJ1aWxkIGFueXRoaW5nIGhlcmUuCg== 125095 2012-02-02 01:02:29 -0800 2012-04-02 00:19:19 -0700 Patch buildjscv2.diff text/plain 1502 hnandor ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiMDBi ZjFkLi41ZWYzNmE2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDItMDIgIE7DoW5kb3IgSHVzemthICA8aHVz emthLm5hbmRvckBzdHVkLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFtRdF0gSlNDIGJ1aWxkIHNo b3VsZCBoYW5kbGUgLS1uby13ZWJraXQyIG9wdGlvbiB0byBhdm9pZCB1bndhbnRlZCBjbGVhbi1i dWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3 NTMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGlj ayB1cCB0aGUgLS1uby13ZWJraXQyIG9wdGlvbiBmcm9tIEJVSUxEX1dFQktJVF9BUkdTIGFuZCBw YXNzIG9uCisgICAgICAgIHRoZSBjb3JyZXNwb25kaW5nIHBhcmFtZXRlciB0byB0aGUgYnVpbGRR TWFrZVByb2plY3RzIGZ1bmN0aW9uLgorCisgICAgICAgICogU2NyaXB0cy9idWlsZC1qc2M6CisK IDIwMTItMDItMDIgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmUtbGFuZCByMTA2NDQyIHBlciBBZGFtJ3Mgc3VnZ2VzdGlvbi4gV2UnbGwgZG8gYm90aCByZXN0 YXJ0aW5nIERSVCBhbmQgbG9hZGluZyBhIGZha2UgdGVzdCBmaXJzdC4KZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvYnVpbGQtanNjIGIvVG9vbHMvU2NyaXB0cy9idWlsZC1qc2MKaW5kZXggMmRh OWVlOS4uMDA3NGJjZCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9idWlsZC1qc2MKKysrIGIv VG9vbHMvU2NyaXB0cy9idWlsZC1qc2MKQEAgLTc0LDYgKzc0LDkgQEAgaWYgKGlzQXBwbGVNYWNX ZWJLaXQoKSkgewogICAgICMgUmVtb3ZlIGR1cGxpY2F0ZWQgLS1xdCBvcHRpb25zIHRvIGF2b2lk IHBhc3NpbmcgdGhlbSB0byBxbWFrZQogICAgIGNoZWNrRm9yQXJndW1lbnRBbmRSZW1vdmVGcm9t QVJHVigiLS1xdCIpOwogICAgIG15IEBwcm9qZWN0cyA9ICgiV1RGIiwgIkphdmFTY3JpcHRDb3Jl Iik7CisgICAgIyBQaWNrIHVwIHRoZSAtLW5vLXdlYmtpdDIgb3B0aW9uIGZyb20gQlVJTERfV0VC S0lUX0FSR1MgaWYgaXQgaXMgbmVlZGVkCisgICAgcHVzaCBAQVJHViwgc3BsaXQoLyAvLCAkRU5W eydCVUlMRF9XRUJLSVRfQVJHUyd9KSBpZiAoJEVOVnsnQlVJTERfV0VCS0lUX0FSR1MnfSk7Cisg ICAgcHVzaCBAQVJHViwgIi0tcW1ha2Vhcmc9Q09ORklHKz1ub193ZWJraXQyIiBpZiBjaGVja0Zv ckFyZ3VtZW50QW5kUmVtb3ZlRnJvbUFSR1YoIi0tbm8td2Via2l0MiIpOwogICAgICRyZXN1bHQg PSBidWlsZFFNYWtlUHJvamVjdHMoXEBwcm9qZWN0cywgMCwgQEFSR1YpOwogfSBlbHNpZiAoaXNX eCgpKSB7CiAgICAgIyBCdWlsZHMgZXZlcnl0aGluZyBpbiBvbmUtc2hvdC4gTm8gbmVlZCB0byBi dWlsZCBhbnl0aGluZyBoZXJlLgo= 135032 2012-04-02 00:19:19 -0700 2012-04-17 09:27:03 -0700 Patch nowkFinal.diff text/plain 1419 hnandor ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyMDhi NDNlLi44MDY5OGE0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDQtMDIgIE5hbmRvciBIdXN6a2EgIDxobmFu ZG9yQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBbUXRdIEpTQyBidWlsZCBzaG91bGQgaGFu ZGxlIC0tbm8td2Via2l0MiBvcHRpb24gdG8gYXZvaWQgdW53YW50ZWQgY2xlYW4tYnVpbGRzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzUzMworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBpY2sgdXAgdGhl IC0tbm8td2Via2l0MiBvcHRpb24gZnJvbSBCVUlMRF9XRUJLSVRfQVJHUyBhbmQgcGFzcyBvbgor ICAgICAgICB0aGUgY29ycmVzcG9uZGluZyBwYXJhbWV0ZXIgdG8gdGhlIGJ1aWxkUU1ha2VQcm9q ZWN0cyBmdW5jdGlvbi4KKworICAgICAgICAqIFNjcmlwdHMvYnVpbGQtanNjOgorCiAyMDEyLTA0 LTAxICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIHBlcmYtby1t YXRpYyBzaG91bGQgc3RvcmUgdGVzdCByZXN1bHRzJyB1bml0cwpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy9idWlsZC1qc2MgYi9Ub29scy9TY3JpcHRzL2J1aWxkLWpzYwppbmRleCBhNGM0MmIy Li4xNDQ3YmJhIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2J1aWxkLWpzYworKysgYi9Ub29s cy9TY3JpcHRzL2J1aWxkLWpzYwpAQCAtNjQsNiArNjQsOSBAQCBteSBAY292ZXJhZ2VTdXBwb3J0 T3B0aW9ucyA9ICgkY292ZXJhZ2VTdXBwb3J0KSA/IFhjb2RlQ292ZXJhZ2VTdXBwb3J0T3B0aW9u cygpCiBpZiAoaXNRdCgpKSB7CiAgICAgY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZyb21BUkdW KCItLXF0Iik7CiAgICAgbXkgQHByb2plY3RzID0gKCJXVEYiLCAiSmF2YVNjcmlwdENvcmUiKTsK KyAgICAjIFBpY2sgdXAgdGhlIC0tbm8td2Via2l0MiBvcHRpb24gZnJvbSBCVUlMRF9XRUJLSVRf QVJHUyBpZiBpdCBpcyBuZWVkZWQKKyAgICBwdXNoIEBBUkdWLCBzcGxpdCgvIC8sICRFTlZ7J0JV SUxEX1dFQktJVF9BUkdTJ30pIGlmICgkRU5WeydCVUlMRF9XRUJLSVRfQVJHUyd9KTsKKyAgICBw dXNoIEBBUkdWLCAiLS1xbWFrZWFyZz1DT05GSUcrPW5vX3dlYmtpdDIiIGlmIGNoZWNrRm9yQXJn dW1lbnRBbmRSZW1vdmVGcm9tQVJHVigiLS1uby13ZWJraXQyIik7CiAgICAgbXkgJHJlc3VsdCA9 IGJ1aWxkUU1ha2VQcm9qZWN0cyhcQHByb2plY3RzLCAwLCBAQVJHVik7CiAgICAgZXhpdCBleGl0 U3RhdHVzKCRyZXN1bHQpOwogfSBlbHNpZiAoY21ha2VCYXNlZFBvcnROYW1lKCkpIHsK