77513 2012-01-31 23:16:57 -0800 webkit-perf.appspot.com should accept test results without medians 2012-01-31 23:51:32 -0800 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77037 77512 1 rniwa webkit-unassigned abarth morrita oldest_to_newest 546827 0 rniwa 2012-01-31 23:16:57 -0800 Dromaeo tests are missing median values due to some technical issues. webkit-perf should be able to handle such reports. 546829 1 124889 rniwa 2012-01-31 23:23:40 -0800 Created attachment 124889 fixes the bug 546836 2 124889 morrita 2012-01-31 23:44:01 -0800 Comment on attachment 124889 fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=124889&action=review r=me. Sometime we should have test for this. > Websites/webkit-perf.appspot.com/report_handler.py:99 > + TestResult(name=test_name, build=build, value=float(result['avg']), valueMedian=_float_or_none(result, 'median'), Considering TestResult.value is required field, this change looks reasonable. 546837 3 rniwa 2012-01-31 23:46:20 -0800 (In reply to comment #2) > (From update of attachment 124889 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=124889&action=review > > r=me. Sometime we should have test for this. Yeah... Unfortunately, App Engine doesn't have any testing framework for python the last time I checked :( > > Websites/webkit-perf.appspot.com/report_handler.py:99 > > + TestResult(name=test_name, build=build, value=float(result['avg']), valueMedian=_float_or_none(result, 'median'), > > Considering TestResult.value is required field, this change looks reasonable. Yes. In fact, _results_are_valid checks the existence of this value. 546840 4 rniwa 2012-01-31 23:51:32 -0800 Anyway thanks for the review! Landed as http://trac.webkit.org/changeset/106436. 124889 2012-01-31 23:23:40 -0800 2012-01-31 23:44:01 -0800 fixes the bug fix77513 text/plain 2156 rniwa SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEwNjQz NCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAx LTMxICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIHdlYmtpdC1w ZXJmLmFwcHNwb3QuY29tIHNob3VsZCBhY2NlcHQgdGVzdCByZXN1bHRzIHdpdGhvdXQgbWVkaWFu cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzc1MTMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb24ndCBz dG9yZSAwcyB3aGVuIHZhbHVlcyBhcmUgbm90IGluIEpTT04uCisKKyAgICAgICAgKiBXZWJzaXRl cy93ZWJraXQtcGVyZi5hcHBzcG90LmNvbS9yZXBvcnRfaGFuZGxlci5weToKKyAgICAgICAgKFJl cG9ydEhhbmRsZXIucG9zdC5fZmxvYXRfb3Jfbm9uZSk6CisgICAgICAgIChSZXBvcnRIYW5kbGVy LnBvc3QpOgorCiAyMDEyLTAxLTMxICBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5l dGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBUYXAgaGlnaGxpZ2h0aW5nOiBTdXBwb3J0IGJldHRl ciBvdXRsaW5lcyBmb3IgbXVsdGlsaW5lIGlubGluZXMKSW5kZXg6IFdlYnNpdGVzL3dlYmtpdC1w ZXJmLmFwcHNwb3QuY29tL3JlcG9ydF9oYW5kbGVyLnB5Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNpdGVz L3dlYmtpdC1wZXJmLmFwcHNwb3QuY29tL3JlcG9ydF9oYW5kbGVyLnB5CShyZXZpc2lvbiAxMDY0 MjcpCisrKyBXZWJzaXRlcy93ZWJraXQtcGVyZi5hcHBzcG90LmNvbS9yZXBvcnRfaGFuZGxlci5w eQkod29ya2luZyBjb3B5KQpAQCAtODYsMTIgKzg2LDE4IEBACiAgICAgICAgIGlmIG5vdCBidWls ZDoKICAgICAgICAgICAgIHJldHVybgogCisgICAgICAgIGRlZiBfZmxvYXRfb3Jfbm9uZShkaWN0 aW9uYXJ5LCBrZXkpOgorICAgICAgICAgICAgdmFsdWUgPSBkaWN0aW9uYXJ5LmdldChrZXkpCisg ICAgICAgICAgICBpZiB2YWx1ZToKKyAgICAgICAgICAgICAgICByZXR1cm4gZmxvYXQodmFsdWUp CisgICAgICAgICAgICByZXR1cm4gTm9uZQorCiAgICAgICAgIGZvciB0ZXN0X25hbWUsIHJlc3Vs dCBpbiBzZWxmLl9ib2R5WydyZXN1bHRzJ10uaXRlcml0ZW1zKCk6CiAgICAgICAgICAgICB0ZXN0 ID0gc2VsZi5fYWRkX3Rlc3RfaWZfbmVlZGVkKHRlc3RfbmFtZSwgYnJhbmNoLCBwbGF0Zm9ybSkK ICAgICAgICAgICAgIG1lbWNhY2hlLmRlbGV0ZShUZXN0LmNhY2hlX2tleSh0ZXN0LmlkLCBicmFu Y2guaWQsIHBsYXRmb3JtLmlkKSkKICAgICAgICAgICAgIGlmIGlzaW5zdGFuY2UocmVzdWx0LCBk aWN0KToKLSAgICAgICAgICAgICAgICBUZXN0UmVzdWx0KG5hbWU9dGVzdF9uYW1lLCBidWlsZD1i dWlsZCwgdmFsdWU9ZmxvYXQocmVzdWx0LmdldCgnYXZnJywgMCkpLCB2YWx1ZU1lZGlhbj1mbG9h dChyZXN1bHQuZ2V0KCdtZWRpYW4nLCAwKSksCi0gICAgICAgICAgICAgICAgICAgIHZhbHVlU3Rk ZXY9ZmxvYXQocmVzdWx0LmdldCgnc3RkZXYnLCAwKSksIHZhbHVlTWluPWZsb2F0KHJlc3VsdC5n ZXQoJ21pbicsIDApKSwgdmFsdWVNYXg9ZmxvYXQocmVzdWx0LmdldCgnbWF4JywgMCkpKS5wdXQo KQorICAgICAgICAgICAgICAgIFRlc3RSZXN1bHQobmFtZT10ZXN0X25hbWUsIGJ1aWxkPWJ1aWxk LCB2YWx1ZT1mbG9hdChyZXN1bHRbJ2F2ZyddKSwgdmFsdWVNZWRpYW49X2Zsb2F0X29yX25vbmUo cmVzdWx0LCAnbWVkaWFuJyksCisgICAgICAgICAgICAgICAgICAgIHZhbHVlU3RkZXY9X2Zsb2F0 X29yX25vbmUocmVzdWx0LCAnc3RkZXYnKSwgdmFsdWVNaW49X2Zsb2F0X29yX25vbmUocmVzdWx0 LCAnbWluJyksIHZhbHVlTWF4PV9mbG9hdF9vcl9ub25lKHJlc3VsdCwgJ21heCcpKS5wdXQoKQog ICAgICAgICAgICAgZWxzZToKICAgICAgICAgICAgICAgICBUZXN0UmVzdWx0KG5hbWU9dGVzdF9u YW1lLCBidWlsZD1idWlsZCwgdmFsdWU9ZmxvYXQocmVzdWx0KSkucHV0KCkKIAo=