77491 2012-01-31 16:28:00 -0800 REGRESSION (r105401-105403): Blue flash on css border transition 2012-02-03 10:21:44 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://www.webkit.org/blog/138/css-animation/ InRadar, Regression P1 Normal --- 1 vangelis menard cmarrin enne hyatt jamesr koivisto menard mihnea simon.fraser webkit.review.bot zimmermann oldest_to_newest 546616 0 vangelis 2012-01-31 16:28:00 -0800 To reproduce: 1. Visit http://www.webkit.org/blog/138/css-animation/ 2. Hover over the div that reads: "This div will acquire a slightly thicker blue border when hovered.". Mouse out. Notice how the entire page flashes blue . This is happening both with the latest WebKit nightly (Version 5.1.2 (7534.52.7, r106392)) and Chrome Canary . Reported also in the chromium issue tracker as: http://code.google.com/p/chromium/issues/detail?id=111304 546664 1 vangelis 2012-01-31 17:13:21 -0800 Bisected to the following WebKit revision range: http://trac.webkit.org/log/trunk/?rev=105427&stop_rev=105390&verbose=on From a quick scan, here's a couple of possible suspects: * [CSSRegions]Add support for background-color in region styling https://bugs.webkit.org/show_bug.cgi?id=71488 http://trac.webkit.org/changeset/105426/trunk [mihnea@adobe.com] * Strange Result for getComputedStyle on borderWidth set in em https://bugs.webkit.org/show_bug.cgi?id=18294 http://trac.webkit.org/changeset/105403/trunk [alexis.menard@openbossa.org] * Differentiate between SVG/CSS width/height attributes/properties https://bugs.webkit.org/show_bug.cgi?id=76447 http://trac.webkit.org/changeset/105402/trunk [zimmermann@webkit.org] * Cache RenderStyle pointer as a method to avoid performance regression for region styling https://bugs.webkit.org/show_bug.cgi?id=76265 http://trac.webkit.org/changeset/105394/trunk [mihnea@adobe.com] 546668 2 vangelis 2012-01-31 17:16:20 -0800 Correcting the title as the issue is really happening on css border width animation transition. The page is not triggering the compositor at all. Maybe that makes: http://trac.webkit.org/changeset/105403/trunk a more likely suspect. 547011 3 mihnea 2012-02-01 04:53:22 -0800 Hi, The first change mentioned: * [CSSRegions]Add support for background-color in region styling https://bugs.webkit.org/show_bug.cgi?id=71488 http://trac.webkit.org/changeset/105426/trunk [mihnea@adobe.com] contains changes that are no longer in the trunk. 547144 4 ap 2012-02-01 10:00:29 -0800 Further reduced the range to r105401-105403. 547145 5 ap 2012-02-01 10:01:14 -0800 <rdar://problem/10789804> 547155 6 simon.fraser 2012-02-01 10:08:36 -0800 Almost certainly http://trac.webkit.org/changeset/105402 547195 7 koivisto 2012-02-01 10:43:16 -0800 A reduced test case would be cool. 547210 8 menard 2012-02-01 10:57:15 -0800 (In reply to comment #7) > A reduced test case would be cool. https://gist.github.com/1718650 seems to reproduce an ugly blue rectangle on the Qt port. 547214 9 menard 2012-02-01 11:04:23 -0800 (In reply to comment #8) > (In reply to comment #7) > > A reduced test case would be cool. > > https://gist.github.com/1718650 > > seems to reproduce an ugly blue rectangle on the Qt port. Clicking on item2 then item1. Ok the test case is a bit weird but it was for another bug. 547279 10 menard 2012-02-01 12:29:34 -0800 (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > A reduced test case would be cool. > > > > https://gist.github.com/1718650 > > > > seems to reproduce an ugly blue rectangle on the Qt port. > > Clicking on item2 then item1. Ok the test case is a bit weird but it was for another bug. http://trac.webkit.org/changeset/105403/trunk is the culprit. Reverting it fixes the issue. I'm looking at it right now as I did the original patch. 548664 11 125314 menard 2012-02-03 06:15:46 -0800 Created attachment 125314 Patch 548821 12 125314 webkit.review.bot 2012-02-03 10:21:39 -0800 Comment on attachment 125314 Patch Clearing flags on attachment: 125314 Committed r106672: <http://trac.webkit.org/changeset/106672> 548822 13 webkit.review.bot 2012-02-03 10:21:44 -0800 All reviewed patches have been landed. Closing bug. 125314 2012-02-03 06:15:46 -0800 2012-02-03 10:21:39 -0800 Patch bug-77491-20120203111533.patch text/plain 4615 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGY3MWYzZGJmNTJhZGQy MTJiOTNlOThhNTMyNDAwMjNmNDY5NjczYS4uNWJjYzcxZGMxZmQ4ZjRjMTFmZWU3ODAxNDgzN2Fj ZTBlYjA2NzY0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAyLTAzICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFJFR1JF U1NJT04gKHIxMDU0MDEtMTA1NDAzKTogQmx1ZSBmbGFzaCBvbiBjc3MgYm9yZGVyIHRyYW5zaXRp b24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3NDkx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIG5l dyBibGVuZCBmdW5jdGlvbiBhZGRlZCB3aXRoIHIxMDU0MDMgdGFrZXMgdW5zaWduZWQgYXMgcGFy YW1ldGVycyB0aGVyZWZvcmUKKyAgICAgICAgd2UgaGF2ZSB0byBiZSBjYXJlZnVsIHRvIG5vdCBv dmVyZmxvdyBpbiBjYXNlIHRoZSB0byBpcyBsZXNzIHRoYW4gZnJvbSAoYW5pbWF0aW5nCisgICAg ICAgIGZyb20gNDAwIHRvIDAgZm9yIGV4YW1wbGUpLgorCisgICAgICAgIFRlc3Q6IGFuaW1hdGlv bnMvYW5pbWF0aW9uLWJvcmRlci1vdmVyZmxvdy5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9h bmltYXRpb24vQW5pbWF0aW9uVXRpbGl0aWVzLmg6CisgICAgICAgIChXZWJDb3JlOjpibGVuZCk6 CisKIDIwMTItMDItMDEgIE1heCBWdWpvdmljICA8bXZ1am92aWNAYWRvYmUuY29tPgogCiAgICAg ICAgIEFkZCBzdXBwb3J0IGZvciBmaXhlZCBhbmQgcGVyY2VudCBtaW4td2lkdGggb24gdGhlIHRh YmxlIGVsZW1lbnQgZm9yIHRhYmxlLWxheW91dDogYXV0byB0bwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vYW5pbWF0aW9uL0FuaW1hdGlvblV0aWxpdGllcy5oIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vYW5pbWF0aW9uL0FuaW1hdGlvblV0aWxpdGllcy5oCmluZGV4IGFl YmNhNDZiYmFmYzVlMDcwZGQ5NTRkMjgxZTc4ZDU2NGYwODdmYTIuLjg3ZGFiZTZhNmE4YTY3OTU0 N2M4YWQwYzRiOWVhOWFiZTAzMzE1OTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2FuaW1hdGlvbi9BbmltYXRpb25VdGlsaXRpZXMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9hbmltYXRpb24vQW5pbWF0aW9uVXRpbGl0aWVzLmgKQEAgLTM3LDcgKzM3LDcgQEAg aW5saW5lIGludCBibGVuZChpbnQgZnJvbSwgaW50IHRvLCBkb3VibGUgcHJvZ3Jlc3MpCiAKIGlu bGluZSB1bnNpZ25lZCBibGVuZCh1bnNpZ25lZCBmcm9tLCB1bnNpZ25lZCB0bywgZG91YmxlIHBy b2dyZXNzKQogewotICAgIHJldHVybiBzdGF0aWNfY2FzdDx1bnNpZ25lZD4obHJvdW5kKHN0YXRp Y19jYXN0PGRvdWJsZT4oZnJvbSkgKyBzdGF0aWNfY2FzdDxkb3VibGU+KHRvIC0gZnJvbSkgKiBw cm9ncmVzcykpOworICAgIHJldHVybiBzdGF0aWNfY2FzdDx1bnNpZ25lZD4obHJvdW5kKHRvID4g ZnJvbSA/IHN0YXRpY19jYXN0PGRvdWJsZT4oZnJvbSkgKyBzdGF0aWNfY2FzdDxkb3VibGU+KHRv IC0gZnJvbSkgKiBwcm9ncmVzcyA6IHN0YXRpY19jYXN0PGRvdWJsZT4oZnJvbSkgLSBzdGF0aWNf Y2FzdDxkb3VibGU+KGZyb20gLSB0bykgKiBwcm9ncmVzcykpOwogfQogCiBpbmxpbmUgZG91Ymxl IGJsZW5kKGRvdWJsZSBmcm9tLCBkb3VibGUgdG8sIGRvdWJsZSBwcm9ncmVzcykKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBl NWNjYjY0OGExMDFjOGY5Yjc2ZGVhMTg0ZDFlNmY2MjZjNTllMWMyLi5jOTRjZGM5ZDQyNjA4MmY3 ZTM4YzdlYWVlZmY3ZTRiMDM3Mzk2NWM0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDIt MDMgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+CisKKyAgICAg ICAgUkVHUkVTU0lPTiAocjEwNTQwMS0xMDU0MDMpOiBCbHVlIGZsYXNoIG9uIGNzcyBib3JkZXIg dHJhbnNpdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Nzc0OTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGFuaW1hdGlvbnMvYW5pbWF0aW9uLWJvcmRlci1vdmVyZmxvdy1leHBlY3RlZC50eHQ6IEFk ZGVkLgorICAgICAgICAqIGFuaW1hdGlvbnMvYW5pbWF0aW9uLWJvcmRlci1vdmVyZmxvdy5odG1s OiBBZGRlZC4KKwogMjAxMi0wMi0wMSAgTWF4IFZ1am92aWMgIDxtdnVqb3ZpY0BhZG9iZS5jb20+ CiAKICAgICAgICAgQWRkIHN1cHBvcnQgZm9yIG1pbi13aWR0aCBvbiB0aGUgdGFibGUgZWxlbWVu dC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2FuaW1hdGlvbnMvYW5pbWF0aW9uLWJvcmRlci1v dmVyZmxvdy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9hbmltYXRpb25zL2FuaW1hdGlvbi1i b3JkZXItb3ZlcmZsb3ctZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjczZDkzMDQ0NzE4YjBlYjJi ZTI2MWViNjRlZDNmODc1NzU0NzZlZTYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9h bmltYXRpb25zL2FuaW1hdGlvbi1ib3JkZXItb3ZlcmZsb3ctZXhwZWN0ZWQudHh0CkBAIC0wLDAg KzEsMyBAQAorVGhpcyB0ZXN0IHBlcmZvcm1zIGFuIGFuaW1hdGlvbiBvZiB0aGUgYm9yZGVyLXRv cC13aWR0aCBwcm9wZXJ0eSBmcm9tIGEgZ2l2ZW4gdmFsdWUgdG8gMC4gSXQgdGVzdHMgaWYgYW4g aW50ZXJtZWRpYXRlIHZhbHVlIGlzIGNvcnJlY3QuCitQQVNTIC0gImJvcmRlci10b3Atd2lkdGgi IHByb3BlcnR5IGZvciAiYm94IiBlbGVtZW50IGF0IDAuMXMgc2F3IHNvbWV0aGluZyBjbG9zZSB0 bzogMjAwCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2FuaW1hdGlvbnMvYW5pbWF0aW9uLWJv cmRlci1vdmVyZmxvdy5odG1sIGIvTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9hbmltYXRpb24tYm9y ZGVyLW92ZXJmbG93Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZDhjZDNlZDhlOWM0ZGJmZDZmMWZkYWQ0Y2Nl MjA0M2E3ZmE4ODAzOQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2FuaW1hdGlvbnMv YW5pbWF0aW9uLWJvcmRlci1vdmVyZmxvdy5odG1sCkBAIC0wLDAgKzEsNDAgQEAKKzxodG1sPgor PGhlYWQ+Cis8dGl0bGU+VW5maWxsZWQgQW5pbWF0aW9uIFRlc3Q8L3RpdGxlPgorPHN0eWxlIHR5 cGU9InRleHQvY3NzIiBtZWRpYT0ic2NyZWVuIj4KKyNib3ggeworICAgIGhlaWdodDogMTAwcHg7 CisgICAgd2lkdGg6IDEwMHB4OworICAgIGJvcmRlci10b3Atd2lkdGg6IDMwMHB4OworICAgIGJv cmRlci1zdHlsZTogc29saWQ7CisgICAgLXdlYmtpdC1hbmltYXRpb24tZHVyYXRpb246IDFzOwor ICAgIC13ZWJraXQtYW5pbWF0aW9uLXRpbWluZy1mdW5jdGlvbjogZWFzZS1pbi1vdXQ7CisgICAg LXdlYmtpdC1hbmltYXRpb24tbmFtZTogImFuaW0iOworfQorQC13ZWJraXQta2V5ZnJhbWVzICJh bmltIiB7CisgICAgZnJvbSB7IGJvcmRlci10b3Atd2lkdGg6IDIwMHB4OyB9CisgICAgdG8gICB7 IGJvcmRlci10b3Atd2lkdGg6IDBweDsgfQorfQorCis8L3N0eWxlPgorICAgIDxzY3JpcHQgc3Jj PSJyZXNvdXJjZXMvYW5pbWF0aW9uLXRlc3QtaGVscGVycy5qcyIgdHlwZT0idGV4dC9qYXZhc2Ny aXB0IiBjaGFyc2V0PSJ1dGYtOCI+PC9zY3JpcHQ+CisgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2ph dmFzY3JpcHQiIGNoYXJzZXQ9InV0Zi04Ij4KKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250 cm9sbGVyKQorICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisKKyAg ICBjb25zdCBleHBlY3RlZFZhbHVlcyA9IFsKKyAgICAgIC8vIFthbmltYXRpb24tbmFtZSwgdGlt ZSwgZWxlbWVudC1pZCwgcHJvcGVydHksIGV4cGVjdGVkLXZhbHVlLCB0b2xlcmFuY2VdCisgICAg ICBbImFuaW0iLCAwLjEsICJib3giLCAiYm9yZGVyLXRvcC13aWR0aCIsIDIwMCwgMjBdLAorICAg IF07CisKKyAgICBydW5BbmltYXRpb25UZXN0KGV4cGVjdGVkVmFsdWVzKTsKKyAgICA8L3Njcmlw dD4KKzwvaGVhZD4KKzxib2R5PgorVGhpcyB0ZXN0IHBlcmZvcm1zIGFuIGFuaW1hdGlvbiBvZiB0 aGUgYm9yZGVyLXRvcC13aWR0aCBwcm9wZXJ0eSBmcm9tIGEgZ2l2ZW4gdmFsdWUgdG8gMC4gSXQg dGVzdHMgaWYgYW4gaW50ZXJtZWRpYXRlIHZhbHVlIGlzIGNvcnJlY3QuCis8ZGl2IGlkPSJib3gi PgorPC9kaXY+Cis8ZGl2IGlkPSJyZXN1bHQiPgorPC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+Cg==