77489 2012-01-31 16:07:49 -0800 [CG] Failing 2d.shadow.enable.off.2.html on Lion 2012-01-31 17:21:37 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mdelaney7 mdelaney7 cmarrin mdelaney7 simon.fraser oldest_to_newest 546601 0 mdelaney7 2012-01-31 16:07:49 -0800 The Philip canvas test named 2d.shadow.enable.off.2.html is currently skipped and otherwise failing on Lion. It tests that shadows aren't drawn under certain conditions as outlined in the canvas spec currently. This bug is for adding that check in. This part of the spec may change in the future since it's under discussion (see: https://bugs.webkit.org/show_bug.cgi?id=60091) though it's been agreed to leave the spec as-is for now, thus we should conform to it especially since it's a reasonable check to add in. 546622 1 124844 mdelaney7 2012-01-31 16:31:42 -0800 Created attachment 124844 Patch 546652 2 124844 mitz 2012-01-31 17:00:32 -0800 Comment on attachment 124844 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124844&action=review > Source/WebCore/html/canvas/CanvasRenderingContext2D.h:281 > + bool shouldDrawShadows(); This can be const. 546672 3 mdelaney7 2012-01-31 17:21:37 -0800 Committed r106415: <http://trac.webkit.org/changeset/106415> 124844 2012-01-31 16:31:42 -0800 2012-01-31 17:00:32 -0800 Patch bug-77489-20120131163141.patch text/plain 6192 mdelaney7 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNjQxMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDEyLTAxLTMxICBNYXR0aGV3 IERlbGFuZXkgIDxtZGVsYW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgRmFpbGluZyAyZC5zaGFk b3cuZW5hYmxlLm9mZi4yLmh0bWwgb24gTGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzc0ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGUgY2FudmFzIHNwZWMgcmVxdWlyZXMgdGhhdCBzaGFkb3dz IG5vdCBiZSBkcmF3biB1bmRlciBjZXJ0YWluCisgICAgICAgIGNpcmN1bXN0YW5jZXMgb3V0bGlu ZWQgaGVyZTogaHR0cDovL3d3dy53aGF0d2cub3JnL3NwZWNzL3dlYi1hcHBzL2N1cnJlbnQtd29y ay8jc2hhZG93cworICAgICAgICBUaGlzIHBhdGNoIGFkZHMgaW4gdGhvc2UgY2hlY2tzIHdoaWNo IGFsbG93cyB1cyB0byBwYXNzIG5vdyAob24gTGlvbikKKyAgICAgICAgdGhlIHBoaWxpcCBjYW52 YXMgdGVzdCB0aGF0IHdhcyBjaGVja2luZyB0aGF0IGNvbnN0cmFpbnQuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLiBVbnNraXBwaW5nIHRoZSB0ZXN0IG9uIExpb24gdGhhdCB0aGlzIHBhdGNoIGZp eGVzLgorCisgICAgICAgICogaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6c2V0QWxsQXR0 cmlidXRlc1RvRGVmYXVsdCk6CisgICAgICAgIChXZWJDb3JlOjpDYW52YXNSZW5kZXJpbmdDb250 ZXh0MkQ6OnNldFNoYWRvdyk6CisgICAgICAgIChXZWJDb3JlOjpDYW52YXNSZW5kZXJpbmdDb250 ZXh0MkQ6OmFwcGx5U2hhZG93KToKKyAgICAgICAgKFdlYkNvcmU6OkNhbnZhc1JlbmRlcmluZ0Nv bnRleHQyRDo6c2hvdWxkRHJhd1NoYWRvd3MpOgorICAgICAgICAqIGh0bWwvY2FudmFzL0NhbnZh c1JlbmRlcmluZ0NvbnRleHQyRC5oOgorICAgICAgICAoQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJE KToKKwogMjAxMi0wMS0zMSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgog CiAgICAgICAgIFRpbGVDYWNoZTo6c2V0TmVlZHNEaXNwbGF5SW5SZWN0IGNsZWFudXAKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5n Q29udGV4dDJELmNwcAkocmV2aXNpb24gMTA2MzIxKQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9j YW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzE1 LDcgKzMxNSw3IEBAIHZvaWQgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpzZXRBbGxBdHQKICAg ICBpZiAoIWNvbnRleHQpCiAgICAgICAgIHJldHVybjsKIAotICAgIGNvbnRleHQtPnNldExlZ2Fj eVNoYWRvdyhGbG9hdFNpemUoKSwgMCwgQ29sb3I6OnRyYW5zcGFyZW50LCBDb2xvclNwYWNlRGV2 aWNlUkdCKTsKKyAgICBhcHBseVNoYWRvdygpOwogICAgIGNvbnRleHQtPnNldEFscGhhKDEpOwog ICAgIGNvbnRleHQtPnNldENvbXBvc2l0ZU9wZXJhdGlvbihDb21wb3NpdGVTb3VyY2VPdmVyKTsK IH0KQEAgLTExNTAsNyArMTE1MCw3IEBAIHZvaWQgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpz ZXRTaGFkb3cKICAgICBpZiAoIWMpCiAgICAgICAgIHJldHVybjsKIAotICAgIGMtPnNldExlZ2Fj eVNoYWRvdyhGbG9hdFNpemUod2lkdGgsIC1oZWlnaHQpLCBzdGF0ZSgpLm1fc2hhZG93Qmx1ciwg c3RhdGUoKS5tX3NoYWRvd0NvbG9yLCBDb2xvclNwYWNlRGV2aWNlUkdCKTsKKyAgICBhcHBseVNo YWRvdygpOwogfQogCiB2b2lkIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6c2V0U2hhZG93KGZs b2F0IHdpZHRoLCBmbG9hdCBoZWlnaHQsIGZsb2F0IGJsdXIsIGNvbnN0IFN0cmluZyYgY29sb3Is IGZsb2F0IGFscGhhKQpAQCAtMTE2OCw3ICsxMTY4LDcgQEAgdm9pZCBDYW52YXNSZW5kZXJpbmdD b250ZXh0MkQ6OnNldFNoYWRvdwogICAgIGlmICghYykKICAgICAgICAgcmV0dXJuOwogCi0gICAg Yy0+c2V0TGVnYWN5U2hhZG93KEZsb2F0U2l6ZSh3aWR0aCwgLWhlaWdodCksIHN0YXRlKCkubV9z aGFkb3dCbHVyLCBzdGF0ZSgpLm1fc2hhZG93Q29sb3IsIENvbG9yU3BhY2VEZXZpY2VSR0IpOwor ICAgIGFwcGx5U2hhZG93KCk7CiB9CiAKIHZvaWQgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpz ZXRTaGFkb3coZmxvYXQgd2lkdGgsIGZsb2F0IGhlaWdodCwgZmxvYXQgYmx1ciwgZmxvYXQgZ3Jh eUxldmVsLCBmbG9hdCBhbHBoYSkKQEAgLTExODEsNyArMTE4MSw3IEBAIHZvaWQgQ2FudmFzUmVu ZGVyaW5nQ29udGV4dDJEOjpzZXRTaGFkb3cKICAgICBpZiAoIWMpCiAgICAgICAgIHJldHVybjsK IAotICAgIGMtPnNldExlZ2FjeVNoYWRvdyhGbG9hdFNpemUod2lkdGgsIC1oZWlnaHQpLCBzdGF0 ZSgpLm1fc2hhZG93Qmx1ciwgc3RhdGUoKS5tX3NoYWRvd0NvbG9yLCBDb2xvclNwYWNlRGV2aWNl UkdCKTsKKyAgICBhcHBseVNoYWRvdygpOwogfQogCiB2b2lkIENhbnZhc1JlbmRlcmluZ0NvbnRl eHQyRDo6c2V0U2hhZG93KGZsb2F0IHdpZHRoLCBmbG9hdCBoZWlnaHQsIGZsb2F0IGJsdXIsIGZs b2F0IHIsIGZsb2F0IGcsIGZsb2F0IGIsIGZsb2F0IGEpCkBAIC0xMTk0LDcgKzExOTQsNyBAQCB2 b2lkIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6c2V0U2hhZG93CiAgICAgaWYgKCFjKQogICAg ICAgICByZXR1cm47CiAKLSAgICBjLT5zZXRMZWdhY3lTaGFkb3coRmxvYXRTaXplKHdpZHRoLCAt aGVpZ2h0KSwgc3RhdGUoKS5tX3NoYWRvd0JsdXIsIHN0YXRlKCkubV9zaGFkb3dDb2xvciwgQ29s b3JTcGFjZURldmljZVJHQik7CisgICAgYXBwbHlTaGFkb3coKTsKIH0KIAogdm9pZCBDYW52YXNS ZW5kZXJpbmdDb250ZXh0MkQ6OnNldFNoYWRvdyhmbG9hdCB3aWR0aCwgZmxvYXQgaGVpZ2h0LCBm bG9hdCBibHVyLCBmbG9hdCBjLCBmbG9hdCBtLCBmbG9hdCB5LCBmbG9hdCBrLCBmbG9hdCBhKQpA QCAtMTIxNCw3ICsxMjE0LDcgQEAgdm9pZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OnNldFNo YWRvdwogICAgIENHQ29udGV4dFNldFNoYWRvd1dpdGhDb2xvcihkYy0+cGxhdGZvcm1Db250ZXh0 KCksIGFkanVzdGVkU2hhZG93U2l6ZSh3aWR0aCwgLWhlaWdodCksIGJsdXIsIHNoYWRvd0NvbG9y KTsKICAgICBDR0NvbG9yUmVsZWFzZShzaGFkb3dDb2xvcik7CiAjZWxzZQotICAgIGRjLT5zZXRM ZWdhY3lTaGFkb3coRmxvYXRTaXplKHdpZHRoLCAtaGVpZ2h0KSwgYmx1ciwgc3RhdGUoKS5tX3No YWRvd0NvbG9yLCBDb2xvclNwYWNlRGV2aWNlUkdCKTsKKyAgICBhcHBseVNoYWRvdygpOwogI2Vu ZGlmCiB9CiAKQEAgLTEyMzIsOSArMTIzMiwxNyBAQCB2b2lkIENhbnZhc1JlbmRlcmluZ0NvbnRl eHQyRDo6YXBwbHlTaGFkCiAgICAgaWYgKCFjKQogICAgICAgICByZXR1cm47CiAKLSAgICBmbG9h dCB3aWR0aCA9IHN0YXRlKCkubV9zaGFkb3dPZmZzZXQud2lkdGgoKTsKLSAgICBmbG9hdCBoZWln aHQgPSBzdGF0ZSgpLm1fc2hhZG93T2Zmc2V0LmhlaWdodCgpOwotICAgIGMtPnNldExlZ2FjeVNo YWRvdyhGbG9hdFNpemUod2lkdGgsIC1oZWlnaHQpLCBzdGF0ZSgpLm1fc2hhZG93Qmx1ciwgc3Rh dGUoKS5tX3NoYWRvd0NvbG9yLCBDb2xvclNwYWNlRGV2aWNlUkdCKTsKKyAgICBpZiAoc2hvdWxk RHJhd1NoYWRvd3MoKSkgeworICAgICAgICBmbG9hdCB3aWR0aCA9IHN0YXRlKCkubV9zaGFkb3dP ZmZzZXQud2lkdGgoKTsKKyAgICAgICAgZmxvYXQgaGVpZ2h0ID0gc3RhdGUoKS5tX3NoYWRvd09m ZnNldC5oZWlnaHQoKTsKKyAgICAgICAgYy0+c2V0TGVnYWN5U2hhZG93KEZsb2F0U2l6ZSh3aWR0 aCwgLWhlaWdodCksIHN0YXRlKCkubV9zaGFkb3dCbHVyLCBzdGF0ZSgpLm1fc2hhZG93Q29sb3Is IENvbG9yU3BhY2VEZXZpY2VSR0IpOworICAgIH0gZWxzZQorICAgICAgICBjLT5zZXRMZWdhY3lT aGFkb3coRmxvYXRTaXplKCksIDAsIENvbG9yOjp0cmFuc3BhcmVudCwgQ29sb3JTcGFjZURldmlj ZVJHQik7Cit9CisKK2Jvb2wgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpzaG91bGREcmF3U2hh ZG93cygpCit7CisgICAgcmV0dXJuIGFscGhhQ2hhbm5lbChzdGF0ZSgpLm1fc2hhZG93Q29sb3Ip ICYmIChzdGF0ZSgpLm1fc2hhZG93Qmx1ciB8fCAhc3RhdGUoKS5tX3NoYWRvd09mZnNldC5pc1pl cm8oKSk7CiB9CiAKIHN0YXRpYyBMYXlvdXRTaXplIHNpemUoSFRNTEltYWdlRWxlbWVudCogaW1h Z2UpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250 ZXh0MkQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNS ZW5kZXJpbmdDb250ZXh0MkQuaAkocmV2aXNpb24gMTA2MzIxKQorKysgU291cmNlL1dlYkNvcmUv aHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmgJKHdvcmtpbmcgY29weSkKQEAg LTI3OCw2ICsyNzgsNyBAQCBwcml2YXRlOgogICAgIGNvbnN0IFN0YXRlJiBzdGF0ZSgpIGNvbnN0 IHsgcmV0dXJuIG1fc3RhdGVTdGFjay5sYXN0KCk7IH0KIAogICAgIHZvaWQgYXBwbHlTaGFkb3co KTsKKyAgICBib29sIHNob3VsZERyYXdTaGFkb3dzKCk7CiAKICAgICB2b2lkIGRpZERyYXcoY29u c3QgRmxvYXRSZWN0JiwgdW5zaWduZWQgb3B0aW9ucyA9IENhbnZhc0RpZERyYXdBcHBseUFsbCk7 CiAgICAgdm9pZCBkaWREcmF3RW50aXJlQ2FudmFzKCk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDY0 MTEpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx MiBAQAorMjAxMi0wMS0zMSAgTWF0dGhldyBEZWxhbmV5ICA8bWRlbGFuZXlAYXBwbGUuY29tPgor CisgICAgICAgIEZhaWxpbmcgMmQuc2hhZG93LmVuYWJsZS5vZmYuMi5odG1sIG9uIExpb24KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3NDg5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9t YWMtbGlvbi9Ta2lwcGVkOiBXZSBjYW4gdW5za2lwIHRoaXMgdGVzdCBub3cgdGhhdCB0aGlzIHBh dGNoIGhhcyB1cyBwYXNzaW5nIHRoaXMgdGVzdC4KKwogMjAxMi0wMS0zMSAgT2xpdmVyIEh1bnQg IDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBFcnJvci5zdGFjawpJbmRl eDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLWxpb24vU2tpcHBlZAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtbGlvbi9Ta2lwcGVkCShyZXZpc2lvbiAxMDYzMjEpCisr KyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtbGlvbi9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBA IC0xLDggKzEsNSBAQAogIyAtLS0gQ2FudmFzIC0tLQogCi0jIDxyZGFyOi8vcHJvYmxlbS85MTIx ODEwPgotY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5zaGFkb3cuZW5hYmxlLm9mZi4yLmh0bWwKLQog IyBUaGlzIHRlc3QgaW5jb3JyZWN0bHkgY2hlY2tzIHRoZSBzaGFkb3cgYmx1cidzIGRpc3RhbmNl IGFuZCBuZWVkcyB0byBiZSBmaXhlZAogIyA8cmRhcjovL3Byb2JsZW0vOTMyNjIyMD4KIGZhc3Qv Y2FudmFzL2NhbnZhcy1zY2FsZS1zaGFkb3dCbHVyLmh0bWwK