77487 2012-01-31 16:02:58 -0800 Make js-test-pre.js more worker friendly 2012-02-03 12:46:58 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dgrogan dgrogan jsbell ojan webkit.review.bot oldest_to_newest 546593 0 dgrogan 2012-01-31 16:02:58 -0800 Make js-test-pre.js more worker friendly 546600 1 124840 dgrogan 2012-01-31 16:06:34 -0800 Created attachment 124840 Patch 546607 2 dgrogan 2012-01-31 16:19:47 -0800 Ojan, could you review this? 546624 3 124840 ojan 2012-01-31 16:31:55 -0800 Comment on attachment 124840 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124840&action=review > LayoutTests/fast/js/resources/js-test-pre.js:3 > +if (!isWorker() && window.layoutTestController) > layoutTestController.dumpAsText(window.enablePixelTesting); Why not just use self.layoutTestController and self.enablePixelTesting? Then you don't need to check or move isWorker. Similarly, can you change all uses of window in this file to self for consistency? 548201 4 125200 dgrogan 2012-02-02 15:38:43 -0800 Created attachment 125200 Patch 548207 5 dgrogan 2012-02-02 15:42:18 -0800 (In reply to comment #3) > (From update of attachment 124840 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=124840&action=review > > > LayoutTests/fast/js/resources/js-test-pre.js:3 > > +if (!isWorker() && window.layoutTestController) > > layoutTestController.dumpAsText(window.enablePixelTesting); > > Why not just use self.layoutTestController and self.enablePixelTesting? Then you don't need to check or move isWorker. Similarly, can you change all uses of window in this file to self for consistency? I was thinking that 'window' is clearer than 'self' so wanted to leave 'window' if possible. But you're right, the consistency of 'self' everywhere is better. 548962 6 125200 webkit.review.bot 2012-02-03 12:46:53 -0800 Comment on attachment 125200 Patch Clearing flags on attachment: 125200 Committed r106684: <http://trac.webkit.org/changeset/106684> 548963 7 webkit.review.bot 2012-02-03 12:46:58 -0800 All reviewed patches have been landed. Closing bug. 124840 2012-01-31 16:06:34 -0800 2012-02-02 15:38:40 -0800 Patch bug-77487-20120131160633.patch text/plain 2739 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NDA0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYWQ5NzNiODFkMjA4MDY2OGEzZGFl NzVhZjRmMmU5OTkzNjU3ZGUxYi4uZTJiMDVhOTMzZGNjZWNjNjgxNjNmNWNlODk0ZWUxZGRmNzI2 ZGU0YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAxLTMxICBEYXZpZCBHcm9nYW4gIDxk Z3JvZ2FuQGNocm9taXVtLm9yZz4KKworICAgICAgICBNYWtlIGpzLXRlc3QtcHJlLmpzIG1vcmUg d29ya2VyIGZyaWVuZGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03NzQ4NworCisgICAgICAgIERvbid0IGNoZWNrIGZvciB3aW5kb3cubGF5b3V0VGVz dENvbnRyb2xsZXIgZnJvbSBhIHdvcmtlci4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzOgor ICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9iYXNpY3MuanM6CisKIDIwMTIt MDEtMzEgIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtR dF1bV0syXSBib3QgbGFja3MgbW9iaWxpdHkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv anMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIGIvTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJj ZXMvanMtdGVzdC1wcmUuanMKaW5kZXggNWVhNTgxZTM0NTk2MTIxYTZlZjNiOWM0N2FlZDJkNmFm YWMyMjBhZS4uZTQzZjM1M2FhOGE1YjM3OTJjNjgzNzJmNGY2ODgzODdiYjM1ZDUxOSAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMKQEAgLTEsNSArMSw1 IEBACiAvLyBzdmcvZHluYW1pYy11cGRhdGVzIHRlc3RzIHNldCBlbmFibGVQaXhlbFRlc3Rpbmc9 dHJ1ZSwgYXMgd2Ugd2FudCB0byBkdW1wIHRleHQgKyBwaXhlbCByZXN1bHRzCi1pZiAod2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyKQoraWYgKCFpc1dvcmtlcigpICYmIHdpbmRvdy5sYXlvdXRU ZXN0Q29udHJvbGxlcikKICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KHdpbmRv dy5lbmFibGVQaXhlbFRlc3RpbmcpOwogCiB2YXIgZGVzY3JpcHRpb24sIGRlYnVnLCBzdWNjZXNz ZnVsbHlQYXJzZWQsIGVycm9yTWVzc2FnZTsKQEAgLTQ4LDExICs0OCw2IEBAIHZhciBkZXNjcmlw dGlvbiwgZGVidWcsIHN1Y2Nlc3NmdWxseVBhcnNlZCwgZXJyb3JNZXNzYWdlOwogICAgICAgICBz cGFuLmlubmVySFRNTCA9IG1zZyArICc8YnIgLz4nOwogICAgIH07CiAKLSAgICBmdW5jdGlvbiBp c1dvcmtlcigpCi0gICAgewotICAgICAgICByZXR1cm4gdHlwZW9mIGRvY3VtZW50ID09PSAndW5k ZWZpbmVkJzsKLSAgICB9Ci0KICAgICB2YXIgY3NzID0KICAgICAgICAgIi5wYXNzIHsiICsKICAg ICAgICAgICAgICJmb250LXdlaWdodDogYm9sZDsiICsKQEAgLTc3LDEzICs3MiwxOCBAQCB2YXIg ZGVzY3JpcHRpb24sIGRlYnVnLCBzdWNjZXNzZnVsbHlQYXJzZWQsIGVycm9yTWVzc2FnZTsKICAg ICBpZiAoIWlzV29ya2VyKCkpCiAgICAgICAgIGluc2VydFN0eWxlU2hlZXQoKTsKIAotICAgIHdp bmRvdy5vbmVycm9yID0gZnVuY3Rpb24obWVzc2FnZSkKKyAgICBzZWxmLm9uZXJyb3IgPSBmdW5j dGlvbihtZXNzYWdlKQogICAgIHsKICAgICAgICAgZXJyb3JNZXNzYWdlID0gbWVzc2FnZTsKICAg ICB9OwogCiB9KSgpOwogCitmdW5jdGlvbiBpc1dvcmtlcigpCit7CisgICAgcmV0dXJuIHR5cGVv ZiBkb2N1bWVudCA9PT0gJ3VuZGVmaW5lZCc7Cit9CisKIGZ1bmN0aW9uIGRlc2NyaXB0aW9uUXVp ZXQobXNnKSB7IGRlc2NyaXB0aW9uKG1zZywgdHJ1ZSk7IH0KIAogZnVuY3Rpb24gZXNjYXBlSFRN TCh0ZXh0KQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvcmVzb3Vy Y2VzL2Jhc2ljcy5qcyBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9i YXNpY3MuanMKaW5kZXggN2RiMGNmNDc4ZjEyMGZiZGYxYTJhYmU2M2ZhMTFjYzMwYThiYjA1Zi4u MzM1NmU1ZDA4MjFiMzcyOTQ4NjExYTQ4ZjhhYWQ3ODJhOWFhYzMyYSAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvcmVzb3VyY2VzL2Jhc2ljcy5qcworKysgYi9MYXlv dXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMvYmFzaWNzLmpzCkBAIC0xLDcgKzEs NCBAQAogaWYgKHRoaXMuaW1wb3J0U2NyaXB0cykgewotICAgIC8vIEZJWE1FOiBDaGFuZ2UganMt dGVzdC1wcmUuanMgdG8gdXNlIHNlbGYgaW4gcGxhY2Ugb2Ygd2luZG93IHdoZXJlCi0gICAgLy8g cG9zc2libGUsIHNvIHdlIGNhbiByZW1vdmUgdGhlIG5leHQgbGluZS4gIGh0dHA6Ly93ZWJraXQu b3JnL2IvNzY3NjIKLSAgICB3aW5kb3cgPSBzZWxmOwogICAgIGltcG9ydFNjcmlwdHMoJy4uLy4u Ly4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzJyk7CiAgICAgaW1wb3J0U2NyaXB0 cygnaWRiLXdvcmtlci1jb21tb24uanMnKTsKICAgICBpbXBvcnRTY3JpcHRzKCdzaGFyZWQuanMn KTsK 125200 2012-02-02 15:38:43 -0800 2012-02-03 12:46:53 -0800 Patch bug-77487-20120202153842.patch text/plain 2709 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NDA0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYWQ5NzNiODFkMjA4MDY2OGEzZGFl NzVhZjRmMmU5OTkzNjU3ZGUxYi4uMWFiYmMwOTliYWNlZjdjYjYxOTYzMzQwMDkxYmY5YzY1ZTdh ODYzZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAxLTMxICBEYXZpZCBHcm9nYW4gIDxk Z3JvZ2FuQGNocm9taXVtLm9yZz4KKworICAgICAgICBNYWtlIGpzLXRlc3QtcHJlLmpzIG1vcmUg d29ya2VyIGZyaWVuZGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03NzQ4NworCisgICAgICAgIFJlcGxhY2UgdXNlcyBvZiAnd2luZG93JyB3aXRoICdz ZWxmJy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGZhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzOgorICAgICAgICAqIHN0b3JhZ2UvaW5k ZXhlZGRiL3Jlc291cmNlcy9iYXNpY3MuanM6CisKIDIwMTItMDEtMzEgIEJhbGF6cyBLZWxlbWVu ICA8a2JhbGF6c0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF1bV0syXSBib3QgbGFja3MgbW9i aWxpdHkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3Qt cHJlLmpzIGIvTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMKaW5k ZXggNWVhNTgxZTM0NTk2MTIxYTZlZjNiOWM0N2FlZDJkNmFmYWMyMjBhZS4uOGJiNDQ5OTE3YjIw Mjc3YWE2M2NmZmVlNzAwYWRhODIxOWM0YzkxNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFz dC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9qcy9y ZXNvdXJjZXMvanMtdGVzdC1wcmUuanMKQEAgLTEsNiArMSw2IEBACiAvLyBzdmcvZHluYW1pYy11 cGRhdGVzIHRlc3RzIHNldCBlbmFibGVQaXhlbFRlc3Rpbmc9dHJ1ZSwgYXMgd2Ugd2FudCB0byBk dW1wIHRleHQgKyBwaXhlbCByZXN1bHRzCi1pZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVy KQotICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQod2luZG93LmVuYWJsZVBpeGVs VGVzdGluZyk7CitpZiAoc2VsZi5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRUZXN0 Q29udHJvbGxlci5kdW1wQXNUZXh0KHNlbGYuZW5hYmxlUGl4ZWxUZXN0aW5nKTsKIAogdmFyIGRl c2NyaXB0aW9uLCBkZWJ1Zywgc3VjY2Vzc2Z1bGx5UGFyc2VkLCBlcnJvck1lc3NhZ2U7CiAKQEAg LTc3LDcgKzc3LDcgQEAgdmFyIGRlc2NyaXB0aW9uLCBkZWJ1Zywgc3VjY2Vzc2Z1bGx5UGFyc2Vk LCBlcnJvck1lc3NhZ2U7CiAgICAgaWYgKCFpc1dvcmtlcigpKQogICAgICAgICBpbnNlcnRTdHls ZVNoZWV0KCk7CiAKLSAgICB3aW5kb3cub25lcnJvciA9IGZ1bmN0aW9uKG1lc3NhZ2UpCisgICAg c2VsZi5vbmVycm9yID0gZnVuY3Rpb24obWVzc2FnZSkKICAgICB7CiAgICAgICAgIGVycm9yTWVz c2FnZSA9IG1lc3NhZ2U7CiAgICAgfTsKQEAgLTQxOCw5ICs0MTgsOSBAQCBmdW5jdGlvbiBpc1N1 Y2Nlc3NmdWxseVBhcnNlZCgpCiBmdW5jdGlvbiBmaW5pc2hKU1Rlc3QoKQogewogICAgIHdhc0Zp bmlzaEpTVGVzdENhbGxlZCA9IHRydWU7Ci0gICAgaWYgKCF3aW5kb3cud2FzUG9zdFRlc3RTY3Jp cHRQYXJzZWQpCisgICAgaWYgKCFzZWxmLndhc1Bvc3RUZXN0U2NyaXB0UGFyc2VkKQogICAgICAg ICByZXR1cm47CiAgICAgaXNTdWNjZXNzZnVsbHlQYXJzZWQoKTsKLSAgICBpZiAod2luZG93Lmpz VGVzdElzQXN5bmMgJiYgd2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgIGlmIChzZWxm LmpzVGVzdElzQXN5bmMgJiYgc2VsZi5sYXlvdXRUZXN0Q29udHJvbGxlcikKICAgICAgICAgbGF5 b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOwogfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvc3RvcmFnZS9pbmRleGVkZGIvcmVzb3VyY2VzL2Jhc2ljcy5qcyBiL0xheW91dFRlc3RzL3N0 b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9iYXNpY3MuanMKaW5kZXggN2RiMGNmNDc4ZjEyMGZi ZGYxYTJhYmU2M2ZhMTFjYzMwYThiYjA1Zi4uMzM1NmU1ZDA4MjFiMzcyOTQ4NjExYTQ4ZjhhYWQ3 ODJhOWFhYzMyYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvcmVz b3VyY2VzL2Jhc2ljcy5qcworKysgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9yZXNv dXJjZXMvYmFzaWNzLmpzCkBAIC0xLDcgKzEsNCBAQAogaWYgKHRoaXMuaW1wb3J0U2NyaXB0cykg ewotICAgIC8vIEZJWE1FOiBDaGFuZ2UganMtdGVzdC1wcmUuanMgdG8gdXNlIHNlbGYgaW4gcGxh Y2Ugb2Ygd2luZG93IHdoZXJlCi0gICAgLy8gcG9zc2libGUsIHNvIHdlIGNhbiByZW1vdmUgdGhl IG5leHQgbGluZS4gIGh0dHA6Ly93ZWJraXQub3JnL2IvNzY3NjIKLSAgICB3aW5kb3cgPSBzZWxm OwogICAgIGltcG9ydFNjcmlwdHMoJy4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3Qt cHJlLmpzJyk7CiAgICAgaW1wb3J0U2NyaXB0cygnaWRiLXdvcmtlci1jb21tb24uanMnKTsKICAg ICBpbXBvcnRTY3JpcHRzKCdzaGFyZWQuanMnKTsK