77486 2012-01-31 15:45:20 -0800 TileCache::setNeedsDisplayInRect cleanup 2012-01-31 15:58:15 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 546579 0 andersca 2012-01-31 15:45:20 -0800 TileCache::setNeedsDisplayInRect cleanup 546580 1 124836 andersca 2012-01-31 15:49:17 -0800 Created attachment 124836 Patch 546584 2 124836 kling 2012-01-31 15:52:59 -0800 Comment on attachment 124836 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124836&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) OOPS > Source/WebCore/platform/graphics/ca/mac/TileCache.mm:222 > +void TileCache::getTileIndexRangeForRect(const IntRect& rect, IntPoint& topLeft, IntPoint& bottomRight) The 2nd and 3rd arguments should be TileIndex& 546591 3 andersca 2012-01-31 15:58:15 -0800 Committed r106411: <http://trac.webkit.org/changeset/106411> 124836 2012-01-31 15:49:17 -0800 2012-01-31 15:52:59 -0800 Patch bug-77486-20120131154936.patch text/plain 4116 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NDA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjM3YzlmNDFlYWQxYmY2 MTZiYzljMjIzZTc0MTIxZGRhMTE4NjkwZi4uZDllMjYwNWQ3MGU3MjY3ZDhjYjc3MDgwYjc5YmZj ZTU2NDBiZDE3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAxLTMxICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgVGlsZUNhY2hlOjpz ZXROZWVkc0Rpc3BsYXlJblJlY3QgY2xlYW51cAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzc0ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2NhL21hYy9UaWxlQ2FjaGUuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9jYS9tYWMvVGlsZUNhY2hlLm1tOgorICAgICAgICAoV2ViQ29yZTo6VGlsZUNhY2hl OjpzZXROZWVkc0Rpc3BsYXlJblJlY3QpOgorICAgICAgICBUaWxlQ2FjaGU6OnRpbGVMYXllckF0 SW5kZXggY2FuIGluIHRoZSBmdXR1cmUgcmV0dXJuIG5pbCwgc28gY29wZSB3aXRoIHRoYXQuIEFs c28sIHJlcGxhY2UKKyAgICAgICAgbmVzdGVkIGlmIHN0YXRlbWVudHMgd2l0aCBjb250aW51ZSBz dGF0ZW1lbnRzLgorCisgICAgICAgIChXZWJDb3JlOjpUaWxlQ2FjaGU6OmdldFRpbGVJbmRleFJh bmdlRm9yUmVjdCk6CisgICAgICAgIFJlbmFtZSB0aGlzIHRvIGJldHRlciBpbmRpY2F0ZSB0aGF0 IGl0IHJldHVybnMgYSByYW5nZSBvZiBpbmRpY2VzLgorCiAyMDEyLTAxLTMxICBTYW1pIEt5b3N0 aWxhICA8c2t5b3N0aWxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gQ29tcG9z aXRvciBkZWJ1ZyBib3JkZXJzIGFyZSBub3Qgc2NhbGVkIGNvcnJlY3RseQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvbWFjL1RpbGVDYWNoZS5oIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvbWFjL1RpbGVDYWNoZS5oCmluZGV4IDli YzY2NzZmNzZmMmY0ZGI0M2M4ZDFjMjc0YWFmNTc2YzM5YjY0YTIuLjZiZDZiYmIzY2Y0N2M5YWY0 M2Q4ZmQ1MWE4MmUyM2I5NzE5NTE1YWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NhL21hYy9UaWxlQ2FjaGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jYS9tYWMvVGlsZUNhY2hlLmgKQEAgLTc1LDcgKzc1LDcgQEAgcHJpdmF0 ZToKICAgICBGbG9hdFJlY3QgdmlzaWJsZVJlY3QoKSBjb25zdDsKIAogICAgIEludFJlY3QgYm91 bmRzKCkgY29uc3Q7Ci0gICAgdm9pZCBnZXRUaWxlUmFuZ2VGb3JSZWN0KGNvbnN0IEludFJlY3Qm LCBJbnRQb2ludCYgdG9wTGVmdCwgSW50UG9pbnQmIGJvdHRvbVJpZ2h0KTsKKyAgICB2b2lkIGdl dFRpbGVJbmRleFJhbmdlRm9yUmVjdChjb25zdCBJbnRSZWN0JiwgVGlsZUluZGV4JiB0b3BMZWZ0 LCBUaWxlSW5kZXgmIGJvdHRvbVJpZ2h0KTsKIAogICAgIEludFNpemUgbnVtVGlsZXNGb3JHcmlk U2l6ZShjb25zdCBJbnRTaXplJikgY29uc3Q7CiAgICAgdm9pZCByZXNpemVUaWxlR3JpZChjb25z dCBJbnRTaXplJiBudW1UaWxlcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jYS9tYWMvVGlsZUNhY2hlLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2EvbWFjL1RpbGVDYWNoZS5tbQppbmRleCA0MTIwYjI5Y2ZjMDU5ODA4ZDEzNDc3 YWM4OGRhZGZjNjBjYjRhZTc2Li5hNDBhNjFjNDBmNTI0MWI3MDQ0MjA3N2RlMDZhYWEwMDkwMTJh MmZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMv VGlsZUNhY2hlLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL21h Yy9UaWxlQ2FjaGUubW0KQEAgLTgxLDI0ICs4MSwyNiBAQCB2b2lkIFRpbGVDYWNoZTo6c2V0TmVl ZHNEaXNwbGF5SW5SZWN0KGNvbnN0IEludFJlY3QmIHJlY3QpCiAgICAgICAgIHJldHVybjsKIAog ICAgIC8vIEZpbmQgdGhlIHRpbGVzIHRoYXQgbmVlZCB0byBiZSBpbnZhbGlkYXRlZC4KLSAgICBJ bnRQb2ludCB0b3BMZWZ0OwotICAgIEludFBvaW50IGJvdHRvbVJpZ2h0OwotICAgIGdldFRpbGVS YW5nZUZvclJlY3QocmVjdCwgdG9wTGVmdCwgYm90dG9tUmlnaHQpOworICAgIFRpbGVJbmRleCB0 b3BMZWZ0OworICAgIFRpbGVJbmRleCBib3R0b21SaWdodDsKKyAgICBnZXRUaWxlSW5kZXhSYW5n ZUZvclJlY3QocmVjdCwgdG9wTGVmdCwgYm90dG9tUmlnaHQpOwogCiAgICAgZm9yIChpbnQgeSA9 IHRvcExlZnQueSgpOyB5IDw9IGJvdHRvbVJpZ2h0LnkoKTsgKyt5KSB7CiAgICAgICAgIGZvciAo aW50IHggPSB0b3BMZWZ0LngoKTsgeCA8PSBib3R0b21SaWdodC54KCk7ICsreCkgewogICAgICAg ICAgICAgV2ViVGlsZUxheWVyKiB0aWxlTGF5ZXIgPSB0aWxlTGF5ZXJBdEluZGV4KEludFBvaW50 KHgsIHkpKTsKKyAgICAgICAgICAgIGlmICghdGlsZUxheWVyKQorICAgICAgICAgICAgICAgIGNv bnRpbnVlOwogCiAgICAgICAgICAgICBDR1JlY3QgdGlsZVJlY3QgPSBbbV90aWxlQ2FjaGVMYXll ciBjb252ZXJ0UmVjdDpyZWN0IHRvTGF5ZXI6dGlsZUxheWVyXTsKKyAgICAgICAgICAgIGlmIChD R1JlY3RJc0VtcHR5KHRpbGVSZWN0KSkKKyAgICAgICAgICAgICAgICBjb250aW51ZTsKIAotICAg ICAgICAgICAgaWYgKCFDR1JlY3RJc0VtcHR5KHRpbGVSZWN0KSkgewotICAgICAgICAgICAgICAg IFt0aWxlTGF5ZXIgc2V0TmVlZHNEaXNwbGF5SW5SZWN0OnRpbGVSZWN0XTsKKyAgICAgICAgICAg IFt0aWxlTGF5ZXIgc2V0TmVlZHNEaXNwbGF5SW5SZWN0OnRpbGVSZWN0XTsKIAotICAgICAgICAg ICAgICAgIGlmIChzaG91bGRTaG93UmVwYWludENvdW50ZXJzKCkpIHsKLSAgICAgICAgICAgICAg ICAgICAgQ0dSZWN0IGJvdW5kcyA9IFt0aWxlTGF5ZXIgYm91bmRzXTsKLSAgICAgICAgICAgICAg ICAgICAgQ0dSZWN0IGluZGljYXRvclJlY3QgPSBDR1JlY3RNYWtlKGJvdW5kcy5vcmlnaW4ueCwg Ym91bmRzLm9yaWdpbi55LCA1MiwgMjcpOwotICAgICAgICAgICAgICAgICAgICBbdGlsZUxheWVy IHNldE5lZWRzRGlzcGxheUluUmVjdDppbmRpY2F0b3JSZWN0XTsKLSAgICAgICAgICAgICAgICB9 CisgICAgICAgICAgICBpZiAoc2hvdWxkU2hvd1JlcGFpbnRDb3VudGVycygpKSB7CisgICAgICAg ICAgICAgICAgQ0dSZWN0IGJvdW5kcyA9IFt0aWxlTGF5ZXIgYm91bmRzXTsKKyAgICAgICAgICAg ICAgICBDR1JlY3QgaW5kaWNhdG9yUmVjdCA9IENHUmVjdE1ha2UoYm91bmRzLm9yaWdpbi54LCBi b3VuZHMub3JpZ2luLnksIDUyLCAyNyk7CisgICAgICAgICAgICAgICAgW3RpbGVMYXllciBzZXRO ZWVkc0Rpc3BsYXlJblJlY3Q6aW5kaWNhdG9yUmVjdF07CiAgICAgICAgICAgICB9CiAgICAgICAg IH0KICAgICB9CkBAIC0yMTcsNyArMjE5LDcgQEAgSW50UmVjdCBUaWxlQ2FjaGU6OmJvdW5kcygp IGNvbnN0CiAgICAgcmV0dXJuIEludFJlY3QoSW50UG9pbnQoKSwgSW50U2l6ZShbbV90aWxlQ2Fj aGVMYXllciBib3VuZHNdLnNpemUpKTsKIH0KIAotdm9pZCBUaWxlQ2FjaGU6OmdldFRpbGVSYW5n ZUZvclJlY3QoY29uc3QgSW50UmVjdCYgcmVjdCwgSW50UG9pbnQmIHRvcExlZnQsIEludFBvaW50 JiBib3R0b21SaWdodCkKK3ZvaWQgVGlsZUNhY2hlOjpnZXRUaWxlSW5kZXhSYW5nZUZvclJlY3Qo Y29uc3QgSW50UmVjdCYgcmVjdCwgSW50UG9pbnQmIHRvcExlZnQsIEludFBvaW50JiBib3R0b21S aWdodCkKIHsKICAgICB0b3BMZWZ0LnNldFgobWF4KHJlY3QueCgpIC8gbV90aWxlU2l6ZS53aWR0 aCgpLCAwKSk7CiAgICAgdG9wTGVmdC5zZXRZKG1heChyZWN0LnkoKSAvIG1fdGlsZVNpemUuaGVp Z2h0KCksIDApKTsK