77453 2012-01-31 10:41:25 -0800 [chromium] Expose windowResizerRectChanged() on WebWidget. 2012-01-31 15:02:36 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thakis thakis webkit.review.bot oldest_to_newest 546218 0 thakis 2012-01-31 10:41:25 -0800 [chromium] Expose windowResizerRectChanged() on WebWidget. 546219 1 124771 thakis 2012-01-31 10:41:55 -0800 Created attachment 124771 Patch 546220 2 webkit.review.bot 2012-01-31 10:44:13 -0800 Attachment 124771 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource First, rewinding head to replay your work on top of it... Applying: Fix compilation errors on build-webkit --debug --no-workers on mac. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/qt/Skipped CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style. 546222 3 124771 fishd 2012-01-31 10:45:22 -0800 Comment on attachment 124771 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124771&action=review R=me > Source/WebKit/chromium/public/WebWidget.h:188 > + virtual void windowResizerRectChanged() { } nit: please name this didChangeWindowResizerRect() to match naming conventions in the API. 546224 4 124773 thakis 2012-01-31 10:47:55 -0800 Created attachment 124773 Patch for landing 546535 5 124773 webkit.review.bot 2012-01-31 15:02:30 -0800 Comment on attachment 124773 Patch for landing Clearing flags on attachment: 124773 Committed r106401: <http://trac.webkit.org/changeset/106401> 546536 6 webkit.review.bot 2012-01-31 15:02:36 -0800 All reviewed patches have been landed. Closing bug. 124771 2012-01-31 10:41:55 -0800 2012-01-31 10:47:51 -0800 Patch bug-77453-20120131104154.patch text/plain 2938 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MjE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDMzN2MzNzg2ZTVlMWNlMTk3MmNlMmRiY2Y4YjYxNDNiYmFmOGFlMTAuLjNlMmQ1YzU2YzI4MzIy YTRiYTk3MjRkNDQ4NTVmZGFlZDc3OTg4OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDEtMzEgIE5pY28gV2ViZXIgIDx0aGFraXNAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gRXhwb3NlIHdpbmRvd1Jlc2l6ZXJSZWN0Q2hhbmdl ZCgpIG9uIFdlYldpZGdldC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTc3NDUzCisKKyAgICAgICAgTmVlZGVkIGZvciBodHRwOi8vY3JidWcuY29tLzEx MTI2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog cHVibGljL1dlYldpZGdldC5oOgorICAgICAgICAoV2ViV2lkZ2V0KToKKyAgICAgICAgKFdlYktp dDo6V2ViV2lkZ2V0Ojp3aW5kb3dSZXNpemVyUmVjdENoYW5nZWQpOgorICAgICAgICAqIHNyYy9X ZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjp3aW5kb3dSZXNp emVyUmVjdENoYW5nZWQpOgorICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKiBzcmMvV2ViVmll d0ltcGwuaDoKKyAgICAgICAgKFdlYlZpZXdJbXBsKToKKwogMjAxMi0wMS0yOSAgTmljbyBXZWJl ciAgPG5pY29sYXN3ZWJlckBnbXguZGU+CiAKICAgICAgICAgW2Nocm9taXVtL21hY10gRml4IHR3 by1maW5nZXIgc2Nyb2xsaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJXaWRnZXQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYldpZGdl dC5oCmluZGV4IDU1NWRhZGNiMTUzYjRkZWI1ODhlZmZkMGU0MmJiOGMwOGIwYmFkNTAuLmVkYWVi OTVkNzhkMTFiMTNiN2NiZjk1MmQwMTE5MDc2MzQ4YzdiZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYldpZGdldC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYldpZGdldC5oCkBAIC0xODEsNiArMTgxLDEyIEBAIHB1YmxpYzoKICAg ICAvLyByZWFzb25zIHN1Y2ggYXMgdGhlIHVzZXIgZXhpdGluZyBsb2NrLCB3aW5kb3cgZm9jdXMg Y2hhbmdpbmcsIGV0Yy4KICAgICB2aXJ0dWFsIHZvaWQgZGlkTG9zZVBvaW50ZXJMb2NrKCkgeyB9 CiAKKyAgICAvLyBJbmZvcm1zIHRoZSBXZWJXaWRnZXQgdGhhdCB0aGUgcmVzaXplciByZWN0IGNo YW5nZWQuIEhhcHBlbnMgZm9yIGV4YW1wbGUKKyAgICAvLyBvbiBtYWMsIHdoZW4gYSB3aWRnZXQg YXBwZWFycyBiZWxvdyB0aGUgV2ViV2lkZ2V0IHdpdGhvdXQgY2hhbmdpbmcgdGhlCisgICAgLy8g V2ViV2lkZ2V0J3Mgc2l6ZSAoV2ViV2lkZ2V0OjpyZXNpemUoKSBhdXRvbWF0aWNhbGx5IGNoZWNr cyB0aGUgcmVzaXplcgorICAgIC8vIHJlY3QuKQorICAgIHZpcnR1YWwgdm9pZCB3aW5kb3dSZXNp emVyUmVjdENoYW5nZWQoKSB7IH0KKwogcHJvdGVjdGVkOgogICAgIH5XZWJXaWRnZXQoKSB7IH0K IH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5j cHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKaW5kZXggZDVh OGJhOGI2ZTM5YTRlNDgxNTJlZWE0MzIwMDNhYzdjZTIzMjc2Yi4uNmRiZmQ1OTUyMDM4ZjZhMGNi ZmVmMzE4Njc4MThmZjczNzcyZjU1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViVmlld0ltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlZpZXdJbXBsLmNwcApAQCAtMTc3Niw2ICsxNzc2LDEyIEBAIHZvaWQgV2ViVmlld0ltcGw6OmRp ZExvc2VQb2ludGVyTG9jaygpCiAjZW5kaWYKIH0KIAordm9pZCBXZWJWaWV3SW1wbDo6d2luZG93 UmVzaXplclJlY3RDaGFuZ2VkKCkKK3sKKyAgICBpZiAobWFpbkZyYW1lSW1wbCgpLT5mcmFtZVZp ZXcoKSkKKyAgICAgICAgbWFpbkZyYW1lSW1wbCgpLT5mcmFtZVZpZXcoKS0+d2luZG93UmVzaXpl clJlY3RDaGFuZ2VkKCk7Cit9CisKIC8vIFdlYlZpZXcgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIAogV2ViU2V0dGlu Z3MqIFdlYlZpZXdJbXBsOjpzZXR0aW5ncygpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi Vmlld0ltcGwuaAppbmRleCAwMmJjNWM5MjFkYTM2YzZlY2RiN2UwZTExYWNlOWJmMzE3ZDJkMmY1 Li41MTk2NDYzM2Y4ZTdkOTM1ZWQ3MDIwM2NkZDg5MmU2YmEzZWU4Yzc2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCisrKyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgKQEAgLTEzMiw2ICsxMzIsNyBAQCBwdWJsaWM6 CiAgICAgdmlydHVhbCB2b2lkIGRpZEFjcXVpcmVQb2ludGVyTG9jaygpOwogICAgIHZpcnR1YWwg dm9pZCBkaWROb3RBY3F1aXJlUG9pbnRlckxvY2soKTsKICAgICB2aXJ0dWFsIHZvaWQgZGlkTG9z ZVBvaW50ZXJMb2NrKCk7CisgICAgdmlydHVhbCB2b2lkIHdpbmRvd1Jlc2l6ZXJSZWN0Q2hhbmdl ZCgpOwogCiAgICAgLy8gV2ViVmlldyBtZXRob2RzOgogICAgIHZpcnR1YWwgdm9pZCBpbml0aWFs aXplTWFpbkZyYW1lKFdlYkZyYW1lQ2xpZW50Kik7Cg== 124773 2012-01-31 10:47:55 -0800 2012-01-31 15:02:30 -0800 Patch for landing bug-77453-20120131104754.patch text/plain 2946 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MjE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDMzN2MzNzg2ZTVlMWNlMTk3MmNlMmRiY2Y4YjYxNDNiYmFmOGFlMTAuLjBiZTRiM2M2ODZiMGQy OGNlNDE2YmM5NzcwOTFhZmIzZWFhYzQyY2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDEtMzEgIE5pY28gV2ViZXIgIDx0aGFraXNAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gRXhwb3NlIHdpbmRvd1Jlc2l6ZXJSZWN0Q2hhbmdl ZCgpIG9uIFdlYldpZGdldC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTc3NDUzCisKKyAgICAgICAgTmVlZGVkIGZvciBodHRwOi8vY3JidWcuY29tLzEx MTI2NgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KKworICAgICAgICAqIHB1 YmxpYy9XZWJXaWRnZXQuaDoKKyAgICAgICAgKFdlYldpZGdldCk6CisgICAgICAgIChXZWJLaXQ6 OldlYldpZGdldDo6ZGlkQ2hhbmdlV2luZG93UmVzaXplclJlY3QpOgorICAgICAgICAqIHNyYy9X ZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpkaWRDaGFuZ2VX aW5kb3dSZXNpemVyUmVjdCk6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAqIHNyYy9XZWJW aWV3SW1wbC5oOgorICAgICAgICAoV2ViVmlld0ltcGwpOgorCiAyMDEyLTAxLTI5ICBOaWNvIFdl YmVyICA8bmljb2xhc3dlYmVyQGdteC5kZT4KIAogICAgICAgICBbY2hyb21pdW0vbWFjXSBGaXgg dHdvLWZpbmdlciBzY3JvbGxpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYldpZGdldC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViV2lk Z2V0LmgKaW5kZXggNTU1ZGFkY2IxNTNiNGRlYjU4OGVmZmQwZTQyYmI4YzA4YjBiYWQ1MC4uY2Ex NjBhMjZlMDBiNzAyNDljYmI1NTE3MzNjZTE0NDE3NmU2ZmFlYyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViV2lkZ2V0LmgKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViV2lkZ2V0LmgKQEAgLTE4MSw2ICsxODEsMTIgQEAgcHVibGljOgog ICAgIC8vIHJlYXNvbnMgc3VjaCBhcyB0aGUgdXNlciBleGl0aW5nIGxvY2ssIHdpbmRvdyBmb2N1 cyBjaGFuZ2luZywgZXRjLgogICAgIHZpcnR1YWwgdm9pZCBkaWRMb3NlUG9pbnRlckxvY2soKSB7 IH0KIAorICAgIC8vIEluZm9ybXMgdGhlIFdlYldpZGdldCB0aGF0IHRoZSByZXNpemVyIHJlY3Qg Y2hhbmdlZC4gSGFwcGVucyBmb3IgZXhhbXBsZQorICAgIC8vIG9uIG1hYywgd2hlbiBhIHdpZGdl dCBhcHBlYXJzIGJlbG93IHRoZSBXZWJXaWRnZXQgd2l0aG91dCBjaGFuZ2luZyB0aGUKKyAgICAv LyBXZWJXaWRnZXQncyBzaXplIChXZWJXaWRnZXQ6OnJlc2l6ZSgpIGF1dG9tYXRpY2FsbHkgY2hl Y2tzIHRoZSByZXNpemVyCisgICAgLy8gcmVjdC4pCisgICAgdmlydHVhbCB2b2lkIGRpZENoYW5n ZVdpbmRvd1Jlc2l6ZXJSZWN0KCkgeyB9CisKIHByb3RlY3RlZDoKICAgICB+V2ViV2lkZ2V0KCkg eyB9CiB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0lt cGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4 IGQ1YThiYThiNmUzOWE0ZTQ4MTUyZWVhNDMyMDAzYWM3Y2UyMzI3NmIuLjk0ODI0OTdlMjhhNmY1 M2UzMWNlNjk3ZmRkOWI3YTlkY2Y2ODU3MzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJWaWV3SW1wbC5jcHAKQEAgLTE3NzYsNiArMTc3NiwxMiBAQCB2b2lkIFdlYlZpZXdJbXBs OjpkaWRMb3NlUG9pbnRlckxvY2soKQogI2VuZGlmCiB9CiAKK3ZvaWQgV2ViVmlld0ltcGw6OmRp ZENoYW5nZVdpbmRvd1Jlc2l6ZXJSZWN0KCkKK3sKKyAgICBpZiAobWFpbkZyYW1lSW1wbCgpLT5m cmFtZVZpZXcoKSkKKyAgICAgICAgbWFpbkZyYW1lSW1wbCgpLT5mcmFtZVZpZXcoKS0+d2luZG93 UmVzaXplclJlY3RDaGFuZ2VkKCk7Cit9CisKIC8vIFdlYlZpZXcgLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIAogV2Vi U2V0dGluZ3MqIFdlYlZpZXdJbXBsOjpzZXR0aW5ncygpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViVmlld0ltcGwuaAppbmRleCAwMmJjNWM5MjFkYTM2YzZlY2RiN2UwZTExYWNlOWJmMzE3 ZDJkMmY1Li5hMDM5YTA5Y2ViODdjMjBlM2RhODQzMzMxZjFiZWFhZWQzZjRmMTMxIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCisrKyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgKQEAgLTEzMiw2ICsxMzIsNyBAQCBw dWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGRpZEFjcXVpcmVQb2ludGVyTG9jaygpOwogICAgIHZp cnR1YWwgdm9pZCBkaWROb3RBY3F1aXJlUG9pbnRlckxvY2soKTsKICAgICB2aXJ0dWFsIHZvaWQg ZGlkTG9zZVBvaW50ZXJMb2NrKCk7CisgICAgdmlydHVhbCB2b2lkIGRpZENoYW5nZVdpbmRvd1Jl c2l6ZXJSZWN0KCk7CiAKICAgICAvLyBXZWJWaWV3IG1ldGhvZHM6CiAgICAgdmlydHVhbCB2b2lk IGluaXRpYWxpemVNYWluRnJhbWUoV2ViRnJhbWVDbGllbnQqKTsK