77448 2012-01-31 10:01:00 -0800 Vector<T>::operator== shouldn't require T to have operator!= 2012-01-31 10:18:28 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca webkit.review.bot oldest_to_newest 546185 0 andersca 2012-01-31 10:01:00 -0800 Vector<T>::operator== shouldn't require T to have operator!= 546187 1 124765 andersca 2012-01-31 10:03:10 -0800 Created attachment 124765 Patch 546188 2 webkit.review.bot 2012-01-31 10:05:14 -0800 Attachment 124765 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource First, rewinding head to replay your work on top of it... Applying: Fix compilation errors on build-webkit --debug --no-workers on mac. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/qt/Skipped CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style. 546190 3 andersca 2012-01-31 10:07:37 -0800 Committed r106368: <http://trac.webkit.org/changeset/106368> 546196 4 124765 darin 2012-01-31 10:18:28 -0800 Comment on attachment 124765 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124765&action=review > Source/JavaScriptCore/ChangeLog:9 > + Change VectorComparer::compare to use !(a == b) instead of a != b since > + it makes more sense for Vector::operator== to use the element's operator==. But now Vector::operator!= requires the element to have operator== ;-) 124765 2012-01-31 10:03:10 -0800 2012-01-31 10:18:28 -0800 Patch bug-77448-20120131100329.patch text/plain 1384 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh M2VjZmZiMjhmZDI3NTI3YTc5YzIxNDMxMTdmZjJlNjBjODE2MTc3Li5lZTE2YmFhNDhhNDM1N2Mz YjcxZWJhZDEyYjdhZDdjNjRjMDM0M2M4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMi0wMS0zMSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUu Y29tPgorCisgICAgICAgIFZlY3RvcjxUPjo6b3BlcmF0b3I9PSBzaG91bGRuJ3QgcmVxdWlyZSBU IHRvIGhhdmUgb3BlcmF0b3IhPQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Nzc0NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBDaGFuZ2UgVmVjdG9yQ29tcGFyZXI6OmNvbXBhcmUgdG8gdXNlICEoYSA9PSBi KSBpbnN0ZWFkIG9mIGEgIT0gYiBzaW5jZQorICAgICAgICBpdCBtYWtlcyBtb3JlIHNlbnNlIGZv ciBWZWN0b3I6Om9wZXJhdG9yPT0gdG8gdXNlIHRoZSBlbGVtZW50J3Mgb3BlcmF0b3I9PS4KKwor ICAgICAgICAqIHd0Zi9WZWN0b3IuaDoKKwogMjAxMi0wMS0zMCAgT2xpdmVyIEh1bnQgIDxvbGl2 ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIGdldF9ieV92YWxfYXJndW1lbnRzIGlzIGJyb2tlbiBp biB0aGUgaW50ZXJwcmV0ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYv VmVjdG9yLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1ZlY3Rvci5oCmluZGV4IDEzNjhh Yzk5YmQ4NmY5YWJjMzU1MmM1NTYzYWNjNDI0NjUxYjQ3M2EuLjE3NWYxYTU4MmNlOTZhNTE2N2Ri MmRmYTc0Njc5ZWRkNWQ3ODk1N2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93 dGYvVmVjdG9yLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9WZWN0b3IuaApAQCAt MTk0LDcgKzE5NCw3IEBAIG5hbWVzcGFjZSBXVEYgewogICAgICAgICBzdGF0aWMgYm9vbCBjb21w YXJlKGNvbnN0IFQqIGEsIGNvbnN0IFQqIGIsIHNpemVfdCBzaXplKQogICAgICAgICB7CiAgICAg ICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHNpemU7ICsraSkKLSAgICAgICAgICAgICAg ICBpZiAoYVtpXSAhPSBiW2ldKQorICAgICAgICAgICAgICAgIGlmICghKGFbaV0gPT0gYltpXSkp CiAgICAgICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgICAgIHJldHVybiB0 cnVlOwogICAgICAgICB9Cg==