77446 2012-01-31 09:10:22 -0800 [CSSRegions]Reduce the cases when the box style in region is computed 2012-07-23 23:37:03 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 57312 1 mihnea webkit-unassigned webkit.review.bot oldest_to_newest 546140 0 mihnea 2012-01-31 09:10:22 -0800 Box style in regions should be computed only when the region has region styling rules. 546147 1 124756 mihnea 2012-01-31 09:14:49 -0800 Created attachment 124756 Patch 546153 2 webkit.review.bot 2012-01-31 09:17:36 -0800 Attachment 124756 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource First, rewinding head to replay your work on top of it... Applying: Fix compilation errors on build-webkit --debug --no-workers on mac. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/qt/Skipped CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style. 546238 3 124756 hyatt 2012-01-31 11:00:31 -0800 Comment on attachment 124756 Patch r=me 546526 4 124756 webkit.review.bot 2012-01-31 14:55:17 -0800 Comment on attachment 124756 Patch Clearing flags on attachment: 124756 Committed r106398: <http://trac.webkit.org/changeset/106398> 546527 5 webkit.review.bot 2012-01-31 14:55:21 -0800 All reviewed patches have been landed. Closing bug. 124756 2012-01-31 09:14:49 -0800 2012-01-31 14:55:17 -0800 Patch 77446.patch text/plain 1816 mihnea ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxODE2NzY2Li4yZDA1YjBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDEtMzEgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAg ICAgICAgW0NTU1JlZ2lvbnNdUmVkdWNlIHRoZSBjYXNlcyB3aGVuIHRoZSBib3ggc3R5bGUgaW4g cmVnaW9uIGlzIGNvbXB1dGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03NzQ0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgcmVnaW9uIHN0eWxlIHRlc3RzLgorCisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJSZWdpb246OnNldFJlZ2lvbkJveGVzUmVnaW9uU3R5bGUpOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyUmVnaW9uOjpyZXN0b3JlUmVnaW9uQm94ZXNPcmlnaW5hbFN0eWxlKToKKwogMjAxMi0w MS0zMSAgUGV0ZXIgUnliaW4gIDxwZXRlci5yeWJpbkBnbWFpbC5jb20+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogQ29kZUdlbmVyYXRvckluc3BlY3Rvci5weTogcmVpbXBsZW1lbnQgZ2VuZXJh dGVkIGFycmF5IHR5cGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyUmVnaW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSZWdpb24uY3Bw CmluZGV4IDZhM2NmNDYuLmIwYTdmYTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJSZWdpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJSZWdpb24uY3BwCkBAIC05OCw2ICs5OCw5IEBAIGJvb2wgUmVuZGVyUmVnaW9uOjppc0xhc3RS ZWdpb24oKSBjb25zdAogCiB2b2lkIFJlbmRlclJlZ2lvbjo6c2V0UmVnaW9uQm94ZXNSZWdpb25T dHlsZSgpCiB7CisgICAgaWYgKCFoYXNDdXN0b21SZWdpb25TdHlsZSgpKQorICAgICAgICByZXR1 cm47CisKICAgICBmb3IgKFJlbmRlckJveFJlZ2lvbkluZm9NYXA6Oml0ZXJhdG9yIGl0ZXIgPSBt X3JlbmRlckJveFJlZ2lvbkluZm8uYmVnaW4oKSwgZW5kID0gbV9yZW5kZXJCb3hSZWdpb25JbmZv LmVuZCgpOyBpdGVyICE9IGVuZDsgKytpdGVyKSB7CiAgICAgICAgIGNvbnN0IFJlbmRlckJveCog Ym94ID0gaXRlci0+Zmlyc3Q7CiAgICAgICAgIGlmICghYm94LT5jYW5IYXZlUmVnaW9uU3R5bGUo KSkKQEAgLTExNSw2ICsxMTgsOSBAQCB2b2lkIFJlbmRlclJlZ2lvbjo6c2V0UmVnaW9uQm94ZXNS ZWdpb25TdHlsZSgpCiAKIHZvaWQgUmVuZGVyUmVnaW9uOjpyZXN0b3JlUmVnaW9uQm94ZXNPcmln aW5hbFN0eWxlKCkKIHsKKyAgICBpZiAoIWhhc0N1c3RvbVJlZ2lvblN0eWxlKCkpCisgICAgICAg IHJldHVybjsKKwogICAgIGZvciAoUmVuZGVyQm94UmVnaW9uSW5mb01hcDo6aXRlcmF0b3IgaXRl ciA9IG1fcmVuZGVyQm94UmVnaW9uSW5mby5iZWdpbigpLCBlbmQgPSBtX3JlbmRlckJveFJlZ2lv bkluZm8uZW5kKCk7IGl0ZXIgIT0gZW5kOyArK2l0ZXIpIHsKICAgICAgICAgY29uc3QgUmVuZGVy Qm94KiBib3ggPSBpdGVyLT5maXJzdDsKICAgICAgICAgUmVuZGVyQm94UmVnaW9uU3R5bGVNYXA6 Oml0ZXJhdG9yIGl0ID0gbV9yZW5kZXJCb3hSZWdpb25TdHlsZS5maW5kKGJveCk7Cg==