77442 2012-01-31 08:49:47 -0800 [Qt] PlatformTouchPoint does not set radius and force values 2012-02-01 09:39:18 -0800 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen webkit.review.bot oldest_to_newest 546104 0 allan.jensen 2012-01-31 08:49:47 -0800 The constructor in PlatformTouchPointQt does not set all the values that are possible. We can not currently get a rotationAngle value from the Qt api, but radius and force is can be set from touch.rect and touch.pressure values. These values are currently only used by WebCore to pass on to Web application using the DOM Touch API. 546113 1 124748 allan.jensen 2012-01-31 08:54:32 -0800 Created attachment 124748 Patch 546122 2 webkit.review.bot 2012-01-31 08:59:09 -0800 Attachment 124748 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource First, rewinding head to replay your work on top of it... Applying: Fix compilation errors on build-webkit --debug --no-workers on mac. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/qt/Skipped CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style. 547132 3 124748 webkit.review.bot 2012-02-01 09:39:14 -0800 Comment on attachment 124748 Patch Clearing flags on attachment: 124748 Committed r106470: <http://trac.webkit.org/changeset/106470> 547133 4 webkit.review.bot 2012-02-01 09:39:18 -0800 All reviewed patches have been landed. Closing bug. 124748 2012-01-31 08:54:32 -0800 2012-02-01 09:39:14 -0800 Patch bug-77442-20120131175345.patch text/plain 2706 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDJhODRjYmM4OWM0ODMw MGRiNGY5OWM1Y2M5Njk1NDhjYzMzZDY0MS4uNThjZTZmZmM3M2NiODJjNGRmNzdiYTJjYTAxMzFk M2U0NTc4MzgyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAxLTMxICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgorCisgICAgICAgIFtR dF0gU2V0IGFsbCBQbGF0Zm9ybVRvdWNoUG9pbnQgdmFsdWVzIHBvc3NpYmxlIGZyb20gYSBRVG91 Y2ggZXZlbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03NzQ0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogcGxhdGZvcm0vcXQvUGxhdGZvcm1Ub3VjaFBvaW50UXQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UGxhdGZvcm1Ub3VjaFBvaW50OjpQbGF0Zm9ybVRvdWNoUG9pbnQpOgorCiAyMDEyLTAxLTMx ICBBbGV4ZWkgRmlsaXBwb3YgIDxhbGV4ZWlmQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBzaG93IHNpemVzIGluIGJ5dGVzIGluc3RlYWQgb2YgS0IsIE1CIGluIGhlYXAg cHJvZmlsZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9QbGF0Zm9y bVRvdWNoUG9pbnRRdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9QbGF0Zm9ybVRv dWNoUG9pbnRRdC5jcHAKaW5kZXggYzI5MzIxMjljMDA5MGNhNzEwYmRkODFlYjZlMDc2Y2RlNzM1 MzE3YS4uZWU1ZTU2ZGY3YWMzZTA4NjM2MWE5MjkxMGYwN2IyYTFjOGNjNmE2YiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1Ub3VjaFBvaW50UXQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRmb3JtVG91Y2hQb2ludFF0LmNwcApA QCAtMSw3ICsxLDcgQEAKIC8qCiAgKiBUaGlzIGZpbGUgaXMgcGFydCBvZiB0aGUgV2ViS2l0IHBy b2plY3QuCiAgKgotICogQ29weXJpZ2h0IChDKSAyMDA5IE5va2lhIENvcnBvcmF0aW9uIGFuZC9v ciBpdHMgc3Vic2lkaWFyeSgtaWVzKQorICogQ29weXJpZ2h0IChDKSAyMDA5LDIwMTIgTm9raWEg Q29ycG9yYXRpb24gYW5kL29yIGl0cyBzdWJzaWRpYXJ5KC1pZXMpCiAgKgogICogVGhpcyBsaWJy YXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgogICog bW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJs aWMKQEAgLTI4LDE3ICsyOCwyOSBAQAogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBQbGF0Zm9ybVRv dWNoUG9pbnQ6OlBsYXRmb3JtVG91Y2hQb2ludChjb25zdCBRVG91Y2hFdmVudDo6VG91Y2hQb2lu dCYgcG9pbnQpCi17CiAgICAgLy8gVGhlIFFUb3VjaEV2ZW50OjpUb3VjaFBvaW50IEFQSSBzdGF0 ZXMgdGhhdCBpZHMgd2lsbCBiZSA+PSAwLgotICAgIG1faWQgPSBzdGF0aWNfY2FzdDx1bnNpZ25l ZD4ocG9pbnQuaWQoKSk7CisgICAgOiBtX2lkKHBvaW50LmlkKCkpCisgICAgLCBtX3NjcmVlblBv cyhwb2ludC5zY3JlZW5Qb3MoKS50b1BvaW50KCkpCisgICAgLCBtX3Bvcyhwb2ludC5wb3MoKS50 b1BvaW50KCkpCit7CiAgICAgc3dpdGNoIChwb2ludC5zdGF0ZSgpKSB7CiAgICAgY2FzZSBRdDo6 VG91Y2hQb2ludFJlbGVhc2VkOiBtX3N0YXRlID0gVG91Y2hSZWxlYXNlZDsgYnJlYWs7CiAgICAg Y2FzZSBRdDo6VG91Y2hQb2ludE1vdmVkOiBtX3N0YXRlID0gVG91Y2hNb3ZlZDsgYnJlYWs7CiAg ICAgY2FzZSBRdDo6VG91Y2hQb2ludFByZXNzZWQ6IG1fc3RhdGUgPSBUb3VjaFByZXNzZWQ7IGJy ZWFrOwogICAgIGNhc2UgUXQ6OlRvdWNoUG9pbnRTdGF0aW9uYXJ5OiBtX3N0YXRlID0gVG91Y2hT dGF0aW9uYXJ5OyBicmVhazsKICAgICB9Ci0gICAgbV9zY3JlZW5Qb3MgPSBwb2ludC5zY3JlZW5Q b3MoKS50b1BvaW50KCk7Ci0gICAgbV9wb3MgPSBwb2ludC5wb3MoKS50b1BvaW50KCk7CisgICAg Ly8gUXQgcmVwb3J0cyB0b3VjaCBwb2ludCBzaXplIGFzIHJlY3RhbmdsZXMsIGJ1dCB3ZSB3aWxs IHByZXRlbmQgaXQgaXMgYW4gb3ZhbC4KKyAgICBRUmVjdCB0b3VjaFJlY3QgPSBwb2ludC5yZWN0 KCkudG9BbGlnbmVkUmVjdCgpOworICAgIGlmICh0b3VjaFJlY3QuaXNWYWxpZCgpKSB7CisgICAg ICAgIG1fcmFkaXVzWCA9IHBvaW50LnJlY3QoKS53aWR0aCgpIC8gMjsKKyAgICAgICAgbV9yYWRp dXNZID0gcG9pbnQucmVjdCgpLmhlaWdodCgpIC8gMjsKKyAgICB9IGVsc2UgeworICAgICAgICAv LyBodHRwOi8vd3d3LnczLm9yZy9UUi8yMDExL1dELXRvdWNoLWV2ZW50cy0yMDExMDUwNTogMSBp ZiBubyB2YWx1ZSBpcyBrbm93bi4KKyAgICAgICAgbV9yYWRpdXNYID0gMTsKKyAgICAgICAgbV9y YWRpdXNZID0gMTsKKyAgICB9CisgICAgbV9mb3JjZSA9IHBvaW50LnByZXNzdXJlKCk7CisgICAg Ly8gRklYTUU6IFN1cHBvcnQgbV9yb3RhdGlvbkFuZ2xlIGlmIFFUb3VjaEV2ZW50IGF0IHNvbWUg cG9pbnQgc3VwcG9ydHMgaXQuCiB9CiAKIH0K