77436 2012-01-31 07:22:32 -0800 [Chromium] Minimum Scale Factor computed based on stale visibleContentsRect 2013-04-12 08:22:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 70559 1 fsamuel fsamuel aelias fishd jamesr rjkroege schenney siraj tdanderson webkit.review.bot oldest_to_newest 546036 0 fsamuel 2012-01-31 07:22:32 -0800 [Chromium] Minimum Scale Factor computed based on stale visibleContentsRect 546037 1 124728 fsamuel 2012-01-31 07:24:19 -0800 Created attachment 124728 Patch 546038 2 webkit.review.bot 2012-01-31 07:26:07 -0800 Attachment 124728 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource First, rewinding head to replay your work on top of it... Applying: Fix compilation errors on build-webkit --debug --no-workers on mac. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/qt/Skipped CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style. 546408 3 124728 fishd 2012-01-31 13:04:39 -0800 Comment on attachment 124728 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124728&action=review > Source/WebCore/page/FrameView.cpp:2961 > + if (!m_frame->document()) what's the relationship between this change and the change to ChromeClientImpl.cpp? 561566 4 124728 jamesr 2012-02-21 20:56:18 -0800 Comment on attachment 124728 Patch Where is your test? 874748 5 schenney 2013-04-12 08:22:31 -0700 https://code.google.com/p/chromium/issues/detail?id=230845 124728 2012-01-31 07:24:19 -0800 2012-02-21 20:56:18 -0800 Patch bug-77436-20120131102418.patch text/plain 3579 fsamuel U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzdlZjYzYjNkY2I4NzRm NDFlZjQ5YzNjNTA0M2U2MzgyNjJlYjhjYS4uYjRmNmY0Y2FmZDcxOGFhMmQ3ZjMyNmY5ZDA0YWRl NTU5YmJjMjFlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAxLTMxICBGYWR5 IFNhbXVlbCAgPGZzYW11ZWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gTWlu aW11bSBTY2FsZSBGYWN0b3IgY29tcHV0ZWQgYmFzZWQgb24gc3RhbGUgdmlzaWJsZUNvbnRlbnRz UmVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzc0 MzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYWxs aW5nIHdlYlZpZXctPmxheW91dCBvbiBmcmFtZXMgdGhhdCBkb24ndCBoYXZlIGRvY3VtZW50cyBj YXVzZXMKKyAgICAgICAgYSBjcmFzaC4KKworICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6dXBkYXRlTGF5b3V0QW5kU3R5bGVJZk5lZWRl ZFJlY3Vyc2l2ZSk6CisKIDIwMTItMDEtMjcgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9y Zz4KIAogICAgICAgICBmbGV4Ym94IHNjcm9sbGJhcnMgZG9uJ3QgdGFrZSBmbGV4LWRpcmVjdGlv biBpbnRvIGFjY291bnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdl TG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggOTVlMjE0Mjk3Mjk1 Y2I3MTZhMjY4MDk0MGQ0Mjg3NmM4MzAyMWY3YS4uZjgxYTNkN2VkNjBhOTBlMjlhNGFlM2FiMzAy NzgzOWJjNDEwMjAxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBA QAorMjAxMi0wMS0zMSAgRmFkeSBTYW11ZWwgIDxmc2FtdWVsQGNocm9taXVtLm9yZz4KKworICAg ICAgICBbQ2hyb21pdW1dIE1pbmltdW0gU2NhbGUgRmFjdG9yIGNvbXB1dGVkIGJhc2VkIG9uIHN0 YWxlIHZpc2libGVDb250ZW50c1JlY3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTc3NDM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2UgbmVlZCB0byBtYWtlIHN1cmUgdGhhdCBhIHBhZ2UgaXMgZnVsbHkg bGFpZCBvdXQgYmVmb3JlIGNvbXB1dGluZworICAgICAgICBhIG5ldyBtaW5pbXVtIHNjYWxlIGZh Y3RvciBiZWNhdXNlIHRoZSBtaW5pbXVtIHNjYWxlIGZhY3RvciBkZXBlbmRzIG9uIHRoZQorICAg ICAgICBjb250ZW50cyBzaXplLCB3aGljaCBtaWdodCBiZSBzdGFsZS4gVGhpcyBjYW4gY2F1c2Ug d2VpcmQsIHNsaWdodGx5IG9mZgorICAgICAgICBwYWdlIHNjYWxpbmcgaW4gc29tZSBjYXNlcy4K KworICAgICAgICAqIHNyYy9DaHJvbWVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 Q2hyb21lQ2xpZW50SW1wbDo6ZGlzcGF0Y2hWaWV3cG9ydFByb3BlcnRpZXNEaWRDaGFuZ2UpOgor CiAyMDEyLTAxLTI2ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBbQ2hyb21pdW1dIENsZWFudXAgb2YgV2ViUG9wdXBNZW51SW1wbApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFt ZVZpZXcuY3BwCmluZGV4IDQwMWQzZjc3ODk0NTMxNDE5NWU2ZjMyZThkNTc1M2RmMDcyMmVhYTIu LjM5YzM2MzBjMmUxNTJmNDVlOWY0ZmU0NmYxZjlmYjIxNTJhZTRkNWMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L0ZyYW1lVmlldy5jcHAKQEAgLTI5NTgsNiArMjk1OCw5IEBAIHZvaWQgRnJhbWVWaWV3Ojp1cGRh dGVMYXlvdXRBbmRTdHlsZUlmTmVlZGVkUmVjdXJzaXZlKCkKICAgICAvLyByZWdpb24gYnV0IHRo ZW4gYmVjb21lIGluY2x1ZGVkIGxhdGVyIGJ5IHRoZSBzZWNvbmQgZnJhbWUgYWRkaW5nIHJlY3Rz IHRvIHRoZSBkaXJ0eSByZWdpb24KICAgICAvLyB3aGVuIGl0IGxheXMgb3V0LgogCisgICAgaWYg KCFtX2ZyYW1lLT5kb2N1bWVudCgpKQorICAgICAgICByZXR1cm47CisKICAgICBtX2ZyYW1lLT5k b2N1bWVudCgpLT51cGRhdGVTdHlsZUlmTmVlZGVkKCk7CiAKICAgICBpZiAobmVlZHNMYXlvdXQo KSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudElt cGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAK aW5kZXggZmIwN2I0YzEwM2ZiMjc5YTI0YzRmMTY3OGViNTk4OGYzMjE3M2JhNi4uZDM3NmQ4MDJi YzhkNDgxMzJiMTQwNjRkNzU0OTAxOWVlYWNmYWYyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKQEAgLTY1OCw4ICs2NTgsMTMgQEAgdm9p ZCBDaHJvbWVDbGllbnRJbXBsOjpkaXNwYXRjaFZpZXdwb3J0UHJvcGVydGllc0RpZENoYW5nZShj b25zdCBWaWV3cG9ydEFyZ3VtZW4KICAgICAvLyBGSVhNRTogSW52ZXN0aWdhdGUgdGhlIGltcGFj dCB0aGlzIGhhcyBvbiBsYXlvdXQvcmVuZGVyaW5nIGlmIGFueS4KICAgICAvLyBUaGlzIGV4cG9z ZXMgdGhlIGNvcnJlY3QgZGV2aWNlIHNjYWxlIHRvIGphdmFzY3JpcHQgYW5kIG1lZGlhIHF1ZXJp ZXMuCiAgICAgbV93ZWJWaWV3LT5zZXREZXZpY2VTY2FsZUZhY3Rvcihjb21wdXRlZC5kZXZpY2VQ aXhlbFJhdGlvKTsKLSAgICBtX3dlYlZpZXctPnNldFBhZ2VTY2FsZUZhY3RvckxpbWl0cyhjb21w dXRlZC5taW5pbXVtU2NhbGUsIGNvbXB1dGVkLm1heGltdW1TY2FsZSk7CiAgICAgbV93ZWJWaWV3 LT5zZXRQYWdlU2NhbGVGYWN0b3JQcmVzZXJ2aW5nU2Nyb2xsT2Zmc2V0KGNvbXB1dGVkLmluaXRp YWxTY2FsZSAqIGNvbXB1dGVkLmRldmljZVBpeGVsUmF0aW8pOworICAgIC8vIFdlIG5lZWQgdG8g bWFrZSBzdXJlIHRoZSBwYWdlIGhhcyBjb21wbGV0ZWQgbGF5b3V0IGJlZm9yZSB3ZSBjYWxsIHNl dFBhZ2VTY2FsZUZhY3RvckxpbWl0cworICAgIC8vIGJlY2F1c2UgaXQgZXZhbHVhdGVzIHRoZSBt aW5pbXVtIHNjYWxlIGZhY3RvciBiYXNlZCBvbiB2aXNpYmxlQ29udGVudFJlY3Qgd2hpY2ggZ2V0 cyB0aGUKKyAgICAvLyBkb2N1bWVudCB3aWR0aC4KKyAgICBtX3dlYlZpZXctPmxheW91dCgpOwor ICAgIG1fd2ViVmlldy0+c2V0UGFnZVNjYWxlRmFjdG9yTGltaXRzKGNvbXB1dGVkLm1pbmltdW1T Y2FsZSwgY29tcHV0ZWQubWF4aW11bVNjYWxlKTsKKwogI2VuZGlmCiB9CiAK