77433 2012-01-31 06:58:20 -0800 Absolute positioned elements do not reposition on fixed layout size change 2014-02-05 11:08:17 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 70559 1 fsamuel webkit-unassigned aelias allan.jensen dglazkov fishd hausmann kenneth mthiesse rjkroege simon.fraser tdanderson webkit.review.bot yael zalan oldest_to_newest 546013 0 fsamuel 2012-01-31 06:58:20 -0800 Absolute Positioned Elements Do Not Reposition on Fixed Layout Size Change 546015 1 124722 fsamuel 2012-01-31 06:59:21 -0800 Created attachment 124722 Patch 546019 2 fsamuel 2012-01-31 07:01:01 -0800 I don't yet have a layout test for this (will have one shortly) but I'm uploading this to share and get early feedback. 546021 3 webkit.review.bot 2012-01-31 07:03:21 -0800 Attachment 124722 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource First, rewinding head to replay your work on top of it... Applying: Fix compilation errors on build-webkit --debug --no-workers on mac. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/qt/Skipped CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style. 593472 4 135102 tdanderson 2012-04-02 07:53:20 -0700 Created attachment 135102 Sample HTML file to reproduce the bug 593476 5 tdanderson 2012-04-02 08:08:03 -0700 Steps to reproduce the bug in chromium: 1. Run chromium with the --enable-viewport flag. 2. Open the attached HTML file. 3. Vertically resize the window to be larger, which increases the fixed layout size. The corner box incorrectly repositions itself by moving up instead of down. (Note: If there are visible scrollbars, you may have to repeat this step to see the effect.) This does not appear to reproduce on a horizontal resize. Steps to reproduce a (very likely) related bug in chromium: 1. Run chromium with the flags --window-size=1000,800 and --enable-fixed-layout=800,600. 2. Open the attached HTML file. 3. Vertically/horizontally resize the window. The corner box incorrectly repositions itself by moving in the direction opposite to the window resize direction (it should not move at all when the window is resized, since the layout size is fixed). 600685 6 136779 tdanderson 2012-04-11 16:16:17 -0700 Created attachment 136779 Sample HTML file to reproduce the bug 600703 7 136786 tdanderson 2012-04-11 16:34:13 -0700 Created attachment 136786 Patch 600713 8 tdanderson 2012-04-11 16:43:44 -0700 (In reply to comment #7) > Created an attachment (id=136786) [details] > Patch This patch is for feedback and discussion only. It fixes the bug for the attached HTML file, but will not work in general since setFixedLayoutSize is called in FrameView::setFixedVisibleContentRect. I am unclear about the original intended purpose of the member variable m_fixedVisibleContentRect in ScrollView and how this patch would impact its use elsewhere. It would be greatly appreciated if the developer who added this member variable could offer some feedback. 601936 9 allan.jensen 2012-04-13 02:46:12 -0700 (In reply to comment #8) > (In reply to comment #7) > > Created an attachment (id=136786) [details] [details] > > Patch > > This patch is for feedback and discussion only. It fixes the bug for the attached HTML file, but will not work in general since setFixedLayoutSize is called in FrameView::setFixedVisibleContentRect. > > I am unclear about the original intended purpose of the member variable m_fixedVisibleContentRect in ScrollView and how this patch would impact its use elsewhere. It would be greatly appreciated if the developer who added this member variable could offer some feedback. FixedVisibleContentRect is the visibleContentRect when scrolling and clipping is performed outside of the ScrollView. This is why scrollbar width and height should not be subtracted from it. Why did you change this in ScrollView? 601937 10 136786 allan.jensen 2012-04-13 02:52:25 -0700 Comment on attachment 136786 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136786&action=review > Source/WebCore/page/FrameView.cpp:1705 > + ScrollView::setFixedLayoutSize(IntSize(visibleContentRect.width(), visibleContentRect.height())); This is wrong. The layout size and visible-content rect are not related. The visible content rect is what is visible when page zooming for instance. The fixed layout should stay the same when the visible rect changes. > Source/WebCore/platform/ScrollView.cpp:-237 > - if (!m_fixedVisibleContentRect.isEmpty()) > - return m_fixedVisibleContentRect; > - This should not be changed. The fixed visible content rect overrides the calculated content rect. > Source/WebKit/chromium/src/WebViewImpl.cpp:1291 > + if (mainFrameImpl() && mainFrameImpl()->frameView()) > + mainFrameImpl()->frameView()->setFixedVisibleContentRect(IntRect(0, 0, newSize.width, newSize.height)); > + I think you might be setting the wrong variable here. Perhaps you really mean to set fixed layout size here? 605999 11 124722 eric 2012-04-19 15:28:12 -0700 Comment on attachment 124722 Patch Needs test. 806350 12 mthiesse 2013-01-14 07:45:03 -0800 It appears that the original bug has been fixed, or is otherwise not reproducible. The --enable-fixed-layout flag no longer works (on chromium) and appears to have no effect. However, I found a similar bug that still exists when the --enable-viewport flag is present. Steps to reproduce: 1. Run chromium with the --enable-viewport flag. 2. Open the sample HTML file uploaded by Terry (the first one). 3. Resize the window horizontally or vertically to make it smaller. - Note that the Corner box shifts away from the corner by about the width of a scrollbar 4. Resize the window from the corner to decrease both width and height. - Scroll bars now appear. 5. Repeat 4. - The Corner box has now moved partially, or fully, off of the screen with the scroll bars still present. Thoughts on why this happens: When resizing the window the ScrollView::updateScrollbars(const IntSize& desiredOffset) method is called multiple times, the first time the method is called contentsSize(), and visibleContentRect() sizes are equal to the previous window size and match, so nothing much happens. The second time updateScrollbars is called visibleContentRect() has been updated to the new size, while contentsSize() has not been updated, so the method believes scroll bars are required, and adds them. After adding scrollbars, the updateScrollbars recursively calls itself since the visible size has changed, but this time through the contentsSize() has been updated (since a Layout has been performed in the interim), and it is determined that scrollbars are no longer needed, so it removes them. However, the page no longer lays out correctly and you see the effects described above. 806393 13 182586 mthiesse 2013-01-14 08:55:41 -0800 Created attachment 182586 Patch 806395 14 tdanderson 2013-01-14 08:58:56 -0800 This bug (both versions as described in comment #5) is relevant for Chrome on Android. Related: https://bugs.webkit.org/show_bug.cgi?id=105486 806399 15 182586 fsamuel 2013-01-14 09:00:50 -0800 Comment on attachment 182586 Patch It's been a while since I've looked at this code: What does FixedVisibleContentRect do? 806404 16 mthiesse 2013-01-14 09:10:11 -0800 (In reply to comment #15) > (From update of attachment 182586 [details]) > It's been a while since I've looked at this code: What does FixedVisibleContentRect do? http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/page/FrameView.cpp&exact_package=chromium&q=FrameView::setFixedVisibleContentRect&l=1782 It starts by calling FrameView::setViewportConstrainedObjectsNeedLayout() which sets NeedsLayout to true for all "constrained objects" (I'm not exactly sure what constrained objects are). It then checks if the scroll offset has changed, but this shouldn't be the case because the method is called with the old scroll offset values. updateScrollbars() is then called with the new window size (which triggers a layout, which is what we need to update the scrollview contentsSize()). 806460 17 aelias 2013-01-14 10:44:12 -0800 --enable-viewport is not yet supported on desktop and there are several missing pieces. Chrome for Android also intentionally doesn't use fixedVisibleContentRect since its semantics aren't useful given that our compositor manages scrolling and clipping at a higher level. I'm not sure what you're trying to achieve here, are you trying to support viewport tag on desktop? If so we should take a step back and discuss the design. 806595 18 182586 webkit.review.bot 2013-01-14 13:56:19 -0800 Comment on attachment 182586 Patch Attachment 182586 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15868617 New failing tests: fast/dom/vertical-scrollbar-in-rtl.html fast/dynamic/window-resize-scrollbars-test.html fast/dom/rtl-scroll-to-leftmost-and-resize.html 845358 19 tdanderson 2013-03-01 11:33:53 -0800 I have not looked at this in a very long time. Marking as available for someone else to take. 976922 20 182586 kling 2014-02-05 11:07:51 -0800 Comment on attachment 182586 Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag. 124722 2012-01-31 06:59:21 -0800 2012-04-19 15:28:12 -0700 Patch bug-77433-20120131095920.patch text/plain 1415 fsamuel U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzdlZjYzYjNkY2I4NzRm NDFlZjQ5YzNjNTA0M2U2MzgyNjJlYjhjYS4uNjEzYjM0OTYxYzM4Y2M1MDZhMTExZjliMDVlZjhl MjRiZDE5YTFhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAxLTMxICBGYWR5 IFNhbXVlbCAgPGZzYW11ZWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFic29sdXRlIFBvc2l0 aW9uZWQgRWxlbWVudHMgRG8gTm90IFJlcG9zaXRpb24gb24gRml4ZWQgTGF5b3V0IFNpemUgQ2hh bmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzQz MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbGxp bmcgY29udGVudHNSZXNpemVkKCkgaW4gc2V0Rml4ZWRMYXlvdXRTaXplIGFkZHJlc3NlcyB0aGUg aXNzdWUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlNjcm9sbFZpZXc6OnNldEZpeGVkTGF5b3V0U2l6ZSk6CisKIDIwMTItMDEtMjcgIFRv bnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBmbGV4Ym94IHNjcm9sbGJh cnMgZG9uJ3QgdGFrZSBmbGV4LWRpcmVjdGlvbiBpbnRvIGFjY291bnQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vU2Nyb2xsVmlldy5jcHAKaW5kZXggZjJiYjA1NGEzYTM5ZmNkZTFiMGEyMTAyYmU0OTA1 YjIzNjRiYzk5OS4uMTZkZGExODFlMjY4YzIyNWE1MzAwYTMxYWJmN2U4ZWJjOTdhZGIxMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAKQEAgLTI3Myw2ICsyNzMsOSBAQCB2 b2lkIFNjcm9sbFZpZXc6OnNldEZpeGVkTGF5b3V0U2l6ZShjb25zdCBJbnRTaXplJiBuZXdTaXpl KQogICAgICAgICByZXR1cm47CiAgICAgbV9maXhlZExheW91dFNpemUgPSBuZXdTaXplOwogICAg IHVwZGF0ZVNjcm9sbGJhcnMoc2Nyb2xsT2Zmc2V0KCkpOworICAgIC8vIEFic29sdXRlIHBvc2l0 aW9uZWQgZWxlbWVudHMgZG9uJ3Qgc2VlbSB0byByZXBvc2l0aW9uCisgICAgLy8gdGhlbXNlbHZl cyB1bmxlc3Mgd2UgY2FsbCBjb250ZW50c1Jlc2l6ZWQuCisgICAgY29udGVudHNSZXNpemVkKCk7 CiB9CiAKIGJvb2wgU2Nyb2xsVmlldzo6dXNlRml4ZWRMYXlvdXQoKSBjb25zdAo= 135102 2012-04-02 07:53:20 -0700 2012-04-11 16:16:58 -0700 Sample HTML file to reproduce the bug absolute_position.html text/html 414 tdanderson PGh0bWw+CjxoZWFkPgo8bWV0YSBuYW1lPSJ2aWV3cG9ydCIgY29udGVudD0id2lkdGg9ZGV2aWNl LXdpZHRoIj4KPHRpdGxlPkZpeGVkIHBvc2l0aW9uIGJveCBpbiBib3R0b20gcmlnaHQgY29ybmVy PC90aXRsZT4KPC9oZWFkPgoKPGJvZHk+CjxkaXYgaWQ9InRvcGJveCIgc3R5bGU9ImJhY2tncm91 bmQ6IzY2ZmZjYzsgYm9yZGVyOnNvbGlkIDFweCAjMDAwMDAwOyBwYWRkaW5nOjEwcHg7Ij5Ub3Ag Ym94PC9kaXY+CjxkaXYgaWQ9ImNvcm5lcmJveCIgc3R5bGU9ImJhY2tncm91bmQ6I2ZmZmYwMDsg Ym9yZGVyOnNvbGlkIDFweCAjMDAwMDAwOyBwYWRkaW5nOjEwcHg7IHBvc2l0aW9uOmZpeGVkOyB3 aWR0aDoyMDBweDsgcmlnaHQ6MTBweDsgYm90dG9tOjEwcHg7Ij5Db3JuZXIgYm94PC9kaXY+Cjwv Ym9keT4KCjwvaHRtbD4K 136779 2012-04-11 16:16:17 -0700 2012-04-11 16:16:17 -0700 Sample HTML file to reproduce the bug absolute_position.html text/html 362 tdanderson PGh0bWw+CjxoZWFkPgo8dGl0bGU+Rml4ZWQgcG9zaXRpb24gYm94IGluIGJvdHRvbSByaWdodCBj b3JuZXI8L3RpdGxlPgo8L2hlYWQ+Cgo8Ym9keT4KPGRpdiBpZD0idG9wYm94IiBzdHlsZT0iYmFj a2dyb3VuZDojNjZmZmNjOyBib3JkZXI6c29saWQgMXB4ICMwMDAwMDA7IHBhZGRpbmc6MTBweDsi PlRvcCBib3g8L2Rpdj4KPGRpdiBpZD0iY29ybmVyYm94IiBzdHlsZT0iYmFja2dyb3VuZDojZmZm ZjAwOyBib3JkZXI6c29saWQgMXB4ICMwMDAwMDA7IHBhZGRpbmc6MTBweDsgcG9zaXRpb246Zml4 ZWQ7IHdpZHRoOjIwMHB4OyBib3R0b206MTBweDsgcmlnaHQ6MTBweDsiPkNvcm5lciBib3g8L2Rp dj4KPC9ib2R5PgoKPC9odG1sPgo= 136786 2012-04-11 16:34:13 -0700 2012-04-13 02:52:25 -0700 Patch bug-77433-20120411193412.patch text/plain 5719 tdanderson U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzOTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjI0ZWUxZWJhODQ3Y2Mz OTViZTFhYzRmMDg2ZmE3MTJjYWFmM2EwNS4uMGU4NTgxZDdkY2FmZTlhNjExNmZjMjNiZTFhN2Nh MGViZDNhMTQ4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTA0LTExICBUZXJy eSBBbmRlcnNvbiAgPHRkYW5kZXJzb25AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFic29sdXRl IHBvc2l0aW9uZWQgZWxlbWVudHMgZG8gbm90IHJlcG9zaXRpb24gb24gZml4ZWQgbGF5b3V0IHNp emUgY2hhbmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03NzQzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgIFBhdGNoIHVwbG9hZGVkIGZvciBkaXNj dXNzaW9uIGFuZCBmZWVkYmFjayBvbmx5LgorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpzZXRGaXhlZFZpc2libGVDb250ZW50UmVj dCk6CisgICAgICAgICAgICBTZXR0aW5nIHRoZSBmaXhlZCBsYXlvdXQgc2l6ZSBoZXJlIHRvIGJl IGVxdWFsIHRvIHRoZSBzaXplIG9mCisgICAgICAgICAgICB2aXNpYmxlQ29udGVudFJlY3QgZml4 ZXMgdGhlIGJ1ZyBpbiB0aGUgYXR0YWNoZWQgSFRNTCBmaWxlLCBidXQgaXMKKyAgICAgICAgICAg IG5vdCBjb3JyZWN0IHNpbmNlIHRoZSB2aWV3cG9ydCB0YWcgb2YgYSBwYWdlIG1heSBzZXQgaXRz IG93bgorICAgICAgICAgICAgZml4ZWQgbGF5b3V0IHNpemUuCisgICAgICAgICogcGxhdGZvcm0v U2Nyb2xsVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxWaWV3Ojp2aXNpYmxlQ29u dGVudFJlY3QpOgorICAgICAgICAgICAgSWYgdGhlIG1fZml4ZWRWaXNpYmxlQ29udGVudFJlY3Qg aXMgdG8gYmUgcmV0dXJuZWQgaW4gdGhpcyBjYXNlLCBpbnN0ZWFkCisgICAgICAgICAgICByZXR1 cm4gYW4gYWRqdXN0ZWQgdmVyc2lvbiB0aGF0IHVzZXMgdGhlIGN1cnJlbnQgc2Nyb2xsIG9mZnNl dC4gIElmCisgICAgICAgICAgICB0aGUgb3JpZ2luYWwgbV9maXhlZFZpc2libGVDb250ZW50UmVj dCB3ZXJlIHJldHVybmVkIGhlcmUsIGl0cyB4IGFuZCB5CisgICAgICAgICAgICB2YWx1ZXMgd2Vy ZSBhbHdheXMgZXF1YWwgdG8gMCwgbWFraW5nIHNjcm9sbGluZyBpbXBvc3NpYmxlLgorCiAyMDEy LTA0LTEwICBaaGVueWFvIE1vICA8em1vQGdvb2dsZS5jb20+CiAKICAgICAgICAgV2ViR0xSZW5k ZXJpbmdDb250ZXh0IHNob3VsZCBkZWZlciBjYWNoaW5nIHByb2dyYW0gaW5mbwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL0NoYW5nZUxvZwppbmRleCAxYmJhOTU1Yzk0MTMxMzIyNDQ1NzU4NGQxYTE4MDFhZmJiYmFh ZTJjLi40MmUwMWUwMGRhM2NmMDU0YjI1NjVjNDJiMjY0Y2I5OTc4MmE3NTJiIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA0LTExICBUZXJyeSBBbmRl cnNvbiAgPHRkYW5kZXJzb25AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFic29sdXRlIHBvc2l0 aW9uZWQgZWxlbWVudHMgZG8gbm90IHJlcG9zaXRpb24gb24gZml4ZWQgbGF5b3V0IHNpemUgY2hh bmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzQz MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBhdGNo IHVwbG9hZGVkIGZvciBkaXNjdXNzaW9uIGFuZCBmZWVkYmFjayBvbmx5LgorCisgICAgICAgICog c3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OnJlc2l6 ZSk6CisgICAgICAgICAgICBPbiBhIHdpbmRvdyByZXNpemUsIHVwZGF0ZSB0aGUgdmFsdWUgb2Yg bV9maXhlZFZpc2libGVDb250ZW50UmVjdAorICAgICAgICAgICAgaW4gU2Nyb2xsVmlldy4gIE5v dGUgdGhhdCAwLDAgaXMgcGFzc2VkIGluLCB3aGljaCBpcyBub3QKKyAgICAgICAgICAgIG5lY2Vz c2FyaWx5IHRoZSBjb3JyZWN0IHBvc2l0aW9uIG9mIHRoaXMgcmVjdC4gIFRoaXMgc2hvdWxkIGFs d2F5cworICAgICAgICAgICAgYmUgZXF1YWwgdG8gdGhlIHNjcm9sbCBvZmZzZXQsIHdoaWNoIHdl IGhhbmRsZSBpbiAKKyAgICAgICAgICAgIFNjcm9sbFZpZXc6OnZpc2libGVDb250ZW50UmVjdC4K KwogMjAxMi0wNC0xMSAgRGF2aWQgRG9yd2luICA8ZGRvcndpbkBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgQWRkIGtleVN5c3RlbSBhdHRyaWJ1dGUgdG8gY2FuUGxheVR5cGUoKSBmb3IgRW5jcnlw dGVkIE1lZGlhIEV4dGVuc2lvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJh bWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAppbmRleCBjMWI3 MDA1ZDU3YTQ0N2Y2NDVjMWQyN2Q3NjFkYjgwYzI5M2Y1YTBmLi4yYTczMGRhYWQxYjIwOGI1ODAx ZTIyNGFhNjBjNzZhOWVlMDczZjU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Zy YW1lVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCkBAIC0x NzAyLDEyICsxNzAyLDE1IEBAIHZvaWQgRnJhbWVWaWV3OjpzZXRGaXhlZFZpc2libGVDb250ZW50 UmVjdChjb25zdCBJbnRSZWN0JiB2aXNpYmxlQ29udGVudFJlY3QpCiB7CiAgICAgSW50U2l6ZSBv ZmZzZXQgPSBzY3JvbGxPZmZzZXQoKTsKICAgICBTY3JvbGxWaWV3OjpzZXRGaXhlZFZpc2libGVD b250ZW50UmVjdCh2aXNpYmxlQ29udGVudFJlY3QpOworICAgIFNjcm9sbFZpZXc6OnNldEZpeGVk TGF5b3V0U2l6ZShJbnRTaXplKHZpc2libGVDb250ZW50UmVjdC53aWR0aCgpLCB2aXNpYmxlQ29u dGVudFJlY3QuaGVpZ2h0KCkpKTsKICAgICBpZiAob2Zmc2V0ICE9IHNjcm9sbE9mZnNldCgpKSB7 CiAgICAgICAgIGlmIChtX2ZyYW1lLT5wYWdlKCktPnNldHRpbmdzKCktPmFjY2VsZXJhdGVkQ29t cG9zaXRpbmdGb3JGaXhlZFBvc2l0aW9uRW5hYmxlZCgpKQogICAgICAgICAgICAgdXBkYXRlRml4 ZWRFbGVtZW50c0FmdGVyU2Nyb2xsaW5nKCk7CiAgICAgICAgIHNjcm9sbFBvc2l0aW9uQ2hhbmdl ZCgpOwogICAgIH0KICAgICBmcmFtZSgpLT5sb2FkZXIoKS0+Y2xpZW50KCktPmRpZENoYW5nZVNj cm9sbE9mZnNldCgpOworICAgIGNvbnRlbnRzUmVzaXplZCgpOworICAgIHZpc2libGVDb250ZW50 c1Jlc2l6ZWQoKTsKIH0KIAogdm9pZCBGcmFtZVZpZXc6OnNjcm9sbFBvc2l0aW9uQ2hhbmdlZFZp YVBsYXRmb3JtV2lkZ2V0KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Nj cm9sbFZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAKaW5k ZXggYzRiNzM0N2FiZDA5YzE0OGQ5NmUyN2JkYzNjNWNiZWJmN2E2N2U0OC4uNDBmZWZhMGFjNTkw NTBkMGFkZTYwZDg2MWMyMDdiN2U2NGM0NTc5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Ny b2xsVmlldy5jcHAKQEAgLTIzMiw5ICsyMzIsNiBAQCBJbnRSZWN0IFNjcm9sbFZpZXc6OnZpc2li bGVDb250ZW50UmVjdChib29sIGluY2x1ZGVTY3JvbGxiYXJzKSBjb25zdAogICAgIGlmIChwbGF0 Zm9ybVdpZGdldCgpKQogICAgICAgICByZXR1cm4gcGxhdGZvcm1WaXNpYmxlQ29udGVudFJlY3Qo aW5jbHVkZVNjcm9sbGJhcnMpOwogCi0gICAgaWYgKCFtX2ZpeGVkVmlzaWJsZUNvbnRlbnRSZWN0 LmlzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJuIG1fZml4ZWRWaXNpYmxlQ29udGVudFJlY3Q7Ci0K ICAgICBpbnQgdmVydGljYWxTY3JvbGxiYXJXaWR0aCA9IDA7CiAgICAgaW50IGhvcml6b250YWxT Y3JvbGxiYXJIZWlnaHQgPSAwOwogCkBAIC0yNDUsMTAgKzI0MiwxMyBAQCBJbnRSZWN0IFNjcm9s bFZpZXc6OnZpc2libGVDb250ZW50UmVjdChib29sIGluY2x1ZGVTY3JvbGxiYXJzKSBjb25zdAog ICAgICAgICAgICAgaG9yaXpvbnRhbFNjcm9sbGJhckhlaWdodCA9ICFob3Jpem9udGFsQmFyLT5p c092ZXJsYXlTY3JvbGxiYXIoKSA/IGhvcml6b250YWxCYXItPmhlaWdodCgpIDogMDsKICAgICB9 CiAKKyAgICBpbnQgd2lkdGhWYWwgPSBtX2ZpeGVkVmlzaWJsZUNvbnRlbnRSZWN0LmlzRW1wdHko KSA/IHdpZHRoKCkgOiBtX2ZpeGVkVmlzaWJsZUNvbnRlbnRSZWN0LndpZHRoKCk7CisgICAgaW50 IGhlaWdodFZhbCA9IG1fZml4ZWRWaXNpYmxlQ29udGVudFJlY3QuaXNFbXB0eSgpID8gaGVpZ2h0 KCkgOiBtX2ZpeGVkVmlzaWJsZUNvbnRlbnRSZWN0LmhlaWdodCgpOworCiAgICAgcmV0dXJuIElu dFJlY3QobV9zY3JvbGxPZmZzZXQud2lkdGgoKSwKICAgICAgICAgICAgICAgICAgICBtX3Njcm9s bE9mZnNldC5oZWlnaHQoKSwKLSAgICAgICAgICAgICAgICAgICBtYXgoMCwgd2lkdGgoKSAtIHZl cnRpY2FsU2Nyb2xsYmFyV2lkdGgpLCAKLSAgICAgICAgICAgICAgICAgICBtYXgoMCwgaGVpZ2h0 KCkgLSBob3Jpem9udGFsU2Nyb2xsYmFySGVpZ2h0KSk7CisgICAgICAgICAgICAgICAgICAgbWF4 KDAsIHdpZHRoVmFsIC0gdmVydGljYWxTY3JvbGxiYXJXaWR0aCksIAorICAgICAgICAgICAgICAg ICAgIG1heCgwLCBoZWlnaHRWYWwgLSBob3Jpem9udGFsU2Nyb2xsYmFySGVpZ2h0KSk7CiB9CiAj ZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0lt cGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4 IDJlNDhkNGNkZjg5NGE5ZGI1MDcyYzc3MmYxMDIzYmZjMjY3ZGNmNTcuLmRjNGRmOGUxMzQ4MDk5 M2VhYjRmNDc3ZmNiMGU2ZDA4YzkyN2E0MTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJWaWV3SW1wbC5jcHAKQEAgLTEyODYsNiArMTI4Niw5IEBAIHZvaWQgV2ViVmlld0ltcGw6 OnJlc2l6ZShjb25zdCBXZWJTaXplJiBuZXdTaXplKQogICAgICAgICByZXR1cm47CiAgICAgbV9z aXplID0gbmV3U2l6ZTsKIAorICAgIGlmIChtYWluRnJhbWVJbXBsKCkgJiYgbWFpbkZyYW1lSW1w bCgpLT5mcmFtZVZpZXcoKSkgCisgICAgICAgIG1haW5GcmFtZUltcGwoKS0+ZnJhbWVWaWV3KCkt PnNldEZpeGVkVmlzaWJsZUNvbnRlbnRSZWN0KEludFJlY3QoMCwgMCwgbmV3U2l6ZS53aWR0aCwg bmV3U2l6ZS5oZWlnaHQpKTsKKwogICAgIFdlYkRldlRvb2xzQWdlbnRQcml2YXRlKiBhZ2VudFBy aXZhdGUgPSBkZXZUb29sc0FnZW50UHJpdmF0ZSgpOwogICAgIGlmIChhZ2VudFByaXZhdGUgJiYg YWdlbnRQcml2YXRlLT5tZXRyaWNzT3ZlcnJpZGRlbigpKQogICAgICAgICBhZ2VudFByaXZhdGUt PndlYlZpZXdSZXNpemVkKCk7Cg== 182586 2013-01-14 08:55:41 -0800 2014-02-05 11:08:17 -0800 Patch bug-77433-20130114115242.patch text/plain 1801 mthiesse U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGY2ZDYyNDY1MGQxNmMwYTI2ODRiYmQ4ZjY2MmQ1YTVjMWQ1MTRiMDYuLjRiMWQwNGNiNzNiN2Q3 NTNlNDE5MjBjOGI1ZWExMDU3NjlhYjg5NzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTMtMDEtMTQgIE1pY2hhZWwgVGhpZXNzZW4gIDxtdGhpZXNzZUBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgQWJzb2x1dGUgcG9zaXRpb25lZCBlbGVtZW50cyBkbyBu b3QgcmVwb3NpdGlvbiBvbiBmaXhlZCBsYXlvdXQgc2l6ZSBjaGFuZ2UKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3NDMzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgYSBjYWxsIHRvIHRoZSBmcmFt ZXZpZXcgc2V0Rml4ZWRWaXNpYmxlQ29udGVudFJlY3QoKSBmcm9tIAorICAgICAgICBXZWJWaWV3 SW1wbDo6cmVzaXplKCkgdG8gdXBkYXRlIHRoZSB2YWx1ZSByZXR1cm5lZCBieSBjb250ZW50c1Np emUoKSBjYWxsIAorICAgICAgICBpbiBTY3JvbGxWaWV3Ojp1cGRhdGVTY3JvbGxiYXJzKCkuIAor CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmll d0ltcGw6OnJlc2l6ZSk6CisKIDIwMTMtMDEtMTAgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292 QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTM5MjI3 LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3Bw IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4IGYzMmM1 ZjYxOTU5ZjA0NmM0MGExYjFkMDIxZmJhOTQxYTdhNzk5ODAuLjQ5NzU0Mzc1NmU3NTMzMmEzZGQ4 OTZmYzg5ZTU5NjVkNTk0OGNlOTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJW aWV3SW1wbC5jcHAKQEAgLTE1ODgsNiArMTU4OCw5IEBAIHZvaWQgV2ViVmlld0ltcGw6OnJlc2l6 ZShjb25zdCBXZWJTaXplJiBuZXdTaXplKQogI2lmIEVOQUJMRShWSUVXUE9SVCkKICAgICBWaWV3 cG9ydEFyZ3VtZW50cyB2aWV3cG9ydEFyZ3VtZW50cyA9IG1haW5GcmFtZUltcGwoKS0+ZnJhbWUo KS0+ZG9jdW1lbnQoKS0+dmlld3BvcnRBcmd1bWVudHMoKTsKICAgICBtX3BhZ2UtPmNocm9tZSgp LT5jbGllbnQoKS0+ZGlzcGF0Y2hWaWV3cG9ydFByb3BlcnRpZXNEaWRDaGFuZ2Uodmlld3BvcnRB cmd1bWVudHMpOworICAgIGlmIChtYWluRnJhbWVJbXBsKCkgJiYgbWFpbkZyYW1lSW1wbCgpLT5m cmFtZVZpZXcoKSkKKyAgICAgICAgbWFpbkZyYW1lSW1wbCgpLT5mcmFtZVZpZXcoKS0+c2V0Rml4 ZWRWaXNpYmxlQ29udGVudFJlY3QoSW50UmVjdChvbGRTY3JvbGxPZmZzZXQud2lkdGgoKSwKKyAg ICAgICAgICAgIG9sZFNjcm9sbE9mZnNldC5oZWlnaHQoKSwgbmV3U2l6ZS53aWR0aCwgbmV3U2l6 ZS5oZWlnaHQpKTsKICNlbmRpZgogCiAgICAgV2ViRGV2VG9vbHNBZ2VudFByaXZhdGUqIGFnZW50 UHJpdmF0ZSA9IGRldlRvb2xzQWdlbnRQcml2YXRlKCk7Cg==