77432 2012-01-31 06:49:47 -0800 REGRESSION (r105908): WebKit1.InspectorBarTest is crashing 2012-01-31 07:11:57 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac (Intel) OS X 10.7 RESOLVED FIXED PlatformOnly, Regression P2 Normal --- 1 aroben aroben ap enrica webkit.review.bot oldest_to_newest 546002 0 aroben 2012-01-31 06:49:47 -0800 To reproduce: 1. run-api-tests Ever since r105908, WebKit1.InspectorBarTest crashes like this: Note: Google Test filter = WebKit1.InspectorBarTest [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from WebKit1 [ RUN ] WebKit1.InspectorBarTest 2012-01-30 17:57:39.751 TestWebKitAPI[19111:f07] -[WebHTMLView typingAttributes]: unrecognized selector sent to instance 0x7fb95292c9f0 2012-01-30 17:57:39.752 TestWebKitAPI[19111:f07] An uncaught exception was raised 2012-01-30 17:57:39.752 TestWebKitAPI[19111:f07] -[WebHTMLView typingAttributes]: unrecognized selector sent to instance 0x7fb95292c9f0 2012-01-30 17:57:39.754 TestWebKitAPI[19111:f07] ( 0 CoreFoundation 0x00007fff872c8286 __exceptionPreprocess + 198 1 libobjc.A.dylib 0x00007fff93b10d5e objc_exception_throw + 43 2 CoreFoundation 0x00007fff873544ce -[NSObject doesNotRecognizeSelector:] + 190 3 CoreFoundation 0x00007fff872b5133 ___forwarding___ + 371 4 CoreFoundation 0x00007fff872b4f48 _CF_forwarding_prep_0 + 232 5 TestWebKitAPI 0x0000000103705501 _ZN13TestWebKitAPI29WebKit1_InspectorBarTest_Test8TestBodyEv + 1617 6 TestWebKitAPI 0x000000010370feea _ZN7testing4Test3RunEv + 154 7 TestWebKitAPI 0x00000001037109ad _ZN7testing8internal12TestInfoImpl3RunEv + 189 8 TestWebKitAPI 0x000000010371129d _ZN7testing8TestCase3RunEv + 205 9 TestWebKitAPI 0x00000001037164a9 _ZN7testing8internal12UnitTestImpl11RunAllTestsEv + 793 10 TestWebKitAPI 0x0000000103716189 _ZN7testing8UnitTest3RunEv + 25 11 TestWebKitAPI 0x0000000103660f20 _ZN13TestWebKitAPI15TestsController3runEiPPc + 48 12 TestWebKitAPI 0x0000000103660d99 main + 121 13 TestWebKitAPI 0x0000000103660334 start + 52 14 ??? 0x0000000000000002 0x0 + 2 ) 2012-01-30 17:57:39.754 TestWebKitAPI[19111:f07] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[WebHTMLView typingAttributes]: unrecognized selector sent to instance 0x7fb95292c9f0' *** First throw call stack: ( 0 CoreFoundation 0x00007fff872c8286 __exceptionPreprocess + 198 1 libobjc.A.dylib 0x00007fff93b10d5e objc_exception_throw + 43 2 CoreFoundation 0x00007fff873544ce -[NSObject doesNotRecognizeSelector:] + 190 3 CoreFoundation 0x00007fff872b5133 ___forwarding___ + 371 4 CoreFoundation 0x00007fff872b4f48 _CF_forwarding_prep_0 + 232 5 TestWebKitAPI 0x0000000103705501 _ZN13TestWebKitAPI29WebKit1_InspectorBarTest_Test8TestBodyEv + 1617 6 TestWebKitAPI 0x000000010370feea _ZN7testing4Test3RunEv + 154 7 TestWebKitAPI 0x00000001037109ad _ZN7testing8internal12TestInfoImpl3RunEv + 189 8 TestWebKitAPI 0x000000010371129d _ZN7testing8TestCase3RunEv + 205 9 TestWebKitAPI 0x00000001037164a9 _ZN7testing8internal12UnitTestImpl11RunAllTestsEv + 793 10 TestWebKitAPI 0x0000000103716189 _ZN7testing8UnitTest3RunEv + 25 11 TestWebKitAPI 0x0000000103660f20 _ZN13TestWebKitAPI15TestsController3runEiPPc + 48 12 TestWebKitAPI 0x0000000103660d99 main + 121 13 TestWebKitAPI 0x0000000103660334 start + 52 14 ??? 0x0000000000000002 0x0 + 2 ) terminate called throwing an exception 546005 1 aroben 2012-01-31 06:50:13 -0800 I think I have a fix. 546008 2 aroben 2012-01-31 06:52:56 -0800 Before r105908: http://build.webkit.org/builders/Lion%20Intel%20Debug%20%28Tests%29/builds/2972 After r105908: http://build.webkit.org/builders/Lion%20Intel%20Debug%20%28Tests%29/builds/2973 546023 3 124724 aroben 2012-01-31 07:04:49 -0800 Created attachment 124724 Only call -typingAttributes on WebViews, not WebHTMLViews 546026 4 webkit.review.bot 2012-01-31 07:08:03 -0800 Attachment 124724 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource First, rewinding head to replay your work on top of it... Applying: Fix compilation errors on build-webkit --debug --no-workers on mac. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/qt/Skipped CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style. 546027 5 124724 koivisto 2012-01-31 07:08:43 -0800 Comment on attachment 124724 Only call -typingAttributes on WebViews, not WebHTMLViews r=me 546029 6 aroben 2012-01-31 07:11:57 -0800 Committed r106359: <http://trac.webkit.org/changeset/106359> 124724 2012-01-31 07:04:49 -0800 2012-01-31 07:08:42 -0800 Only call -typingAttributes on WebViews, not WebHTMLViews bug-77432-20120131100448.patch text/plain 1878 aroben U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MzU2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDdhOTA5N2NkZmQ0YTMxM2E2MjdkNjU1ZjMwMTY3NmQz NTY2YWY1Mi4uMjc3NmM3MTZlY2UyOGZmZmU1ZGMzMTU3NGEzMTIyNWQ1MjUxMGIwMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTAxLTMxICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KKworICAgICAg ICBPbmx5IGNhbGwgLXR5cGluZ0F0dHJpYnV0ZXMgb24gV2ViVmlld3MsIG5vdCBXZWJIVE1MVmll d3MKKworICAgICAgICBMb29rcyBsaWtlIHRoaXMgY2FzZSB3YXMganVzdCBtaXNzZWQgaW4gcjEw NTkwOC4KKworICAgICAgICBGaXhlcyA8aHR0cDovL3dlYmtpdC5vcmcvYi83NzQzMj4gUkVHUkVT U0lPTiAocjEwNTkwOCk6IFdlYktpdDEuSW5zcGVjdG9yQmFyVGVzdCBpcyBjcmFzaGluZworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVzdFdlYktp dEFQSS9UZXN0cy9tYWMvSW5zcGVjdG9yQmFyLm1tOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6 VEVTVCk6IENhbGwgLXR5cGluZ0F0dHJpYnV0ZXMgb24gdGhlIFdlYlZpZXcsIGp1c3QgbGlrZSB3 ZSBkbyAyIGxpbmVzCisgICAgICAgIGVhcmxpZXIuCisKIDIwMTItMDEtMzEgIEpvY2VseW4gVHVy Y290dGUgIDxqb2NlbHluLnR1cmNvdHRlQG5va2lhLmNvbT4KIAogICAgICAgICBbUXRdIE1pbmlC cm93c2VyOiBTaG93IHRvdWNoIG1vY2tpbmcgaW5kaWNhdG9ycyBvbmx5IHdoZW4gQ3RybCBpcyBo ZWxkIGRvd24uCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL21hYy9JbnNw ZWN0b3JCYXIubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL21hYy9JbnNwZWN0b3JCYXIu bW0KaW5kZXggYmY0ODlhMjhkZjRmNGZlNDcyYTEwNGYzZWYyOWQ3YjFhN2ZiZDNjYi4uMGE1MWUy ZmI0NTFjYjcwYWMxZTk0MDI1YjE2NWYzNmE4MDU4MzU5OCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9tYWMvSW5zcGVjdG9yQmFyLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvbWFjL0luc3BlY3RvckJhci5tbQpAQCAtNjYsNyArNjYsNyBAQCBURVNUKFdl YktpdDEsIEluc3BlY3RvckJhclRlc3QpCiAgICAgRVhQRUNUX1RSVUUoW3dlYlZpZXcuZ2V0KCkg cmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rvcih0eXBpbmdBdHRyaWJ1dGVzKV0pOwogICAgIE5T RGljdGlvbmFyeSAqYXR0cmlidXRlcyA9IFsoaWQpd2ViVmlldy5nZXQoKSB0eXBpbmdBdHRyaWJ1 dGVzXTsKICAgICBbKGlkKVtbW3dlYlZpZXcuZ2V0KCkgbWFpbkZyYW1lXSBmcmFtZVZpZXddIGRv Y3VtZW50Vmlld10gZG9Db21tYW5kQnlTZWxlY3RvcjpAc2VsZWN0b3IoYm9sZDopXTsKLSAgICBF WFBFQ1RfRkFMU0UoW2F0dHJpYnV0ZXMgaXNFcXVhbDpbKGlkKVtbW3dlYlZpZXcuZ2V0KCkgbWFp bkZyYW1lXSBmcmFtZVZpZXddIGRvY3VtZW50Vmlld10gdHlwaW5nQXR0cmlidXRlc11dKTsKKyAg ICBFWFBFQ1RfRkFMU0UoW2F0dHJpYnV0ZXMgaXNFcXVhbDpbKGlkKXdlYlZpZXcuZ2V0KCkgdHlw aW5nQXR0cmlidXRlc11dKTsKICAgICAKICAgICBbd2ViVmlldy5nZXQoKSBzZWxlY3RBbGw6bmls XTsKICAgICBOU0F0dHJpYnV0ZWRTdHJpbmcgKmF0dHJTdHJpbmcgPSBbKE5TVmlldyA8TlNUZXh0 SW5wdXQ+ICopW1tbd2ViVmlldy5nZXQoKSBtYWluRnJhbWVdIGZyYW1lVmlld10gZG9jdW1lbnRW aWV3XSBhdHRyaWJ1dGVkU3Vic3RyaW5nRnJvbVJhbmdlOk5TTWFrZVJhbmdlKDAsIDUpXTsK