77417 2012-01-31 02:37:14 -0800 [Qt][WK2] Make UIProcess decide about encoding of input data for application URL schemes. 2012-01-31 05:48:18 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zeno zeno hausmann webkit.review.bot oldest_to_newest 545880 0 zeno 2012-01-31 02:37:14 -0800 see also: https://bugs.webkit.org/show_bug.cgi?id=77007#c11 Also we should get rid of parent() call chain to detect the QQuickWebViewExperimental. 545899 1 124696 zeno 2012-01-31 03:10:34 -0800 Created attachment 124696 patch for review. 545900 2 webkit.review.bot 2012-01-31 03:13:22 -0800 Attachment 124696 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource From git://git.webkit.org/WebKit 2a654fd..67a004e master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 106350 = 2a654fd8513245efac73e1f8526121f158404c41 r106351 = 67a004e6a82b832ecb29c8ac1912a1019be73b2a Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Applying: Fix compilation errors on build-webkit --debug --no-workers on mac. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/qt/Skipped CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style. 545977 3 124696 zeno 2012-01-31 05:48:10 -0800 Comment on attachment 124696 patch for review. Clearing flags on attachment: 124696 Committed r106355: <http://trac.webkit.org/changeset/106355> 545978 4 zeno 2012-01-31 05:48:18 -0800 All reviewed patches have been landed. Closing bug. 124696 2012-01-31 03:10:34 -0800 2012-01-31 05:48:10 -0800 patch for review. 77417_20120131-120922.patch text/plain 6773 zeno ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5MjAxNjdjLi5lNDY5N2I1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTItMDEtMzEgIFplbm8gQWxiaXNzZXIgIDx6ZW5vQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW1F0XVtXSzJdIE1ha2UgVUlQcm9jZXNzIGRlY2lkZSBhYm91dCBlbmNvZGluZyBvZiBpbnB1 dCBkYXRhIGZvciBhcHBsaWNhdGlvbiBVUkwgc2NoZW1lcy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3NDE3CisKKyAgICAgICAgTWFrZSB0aGUgVUlQ cm9jZXNzIGRlY2lkZSBhYm91dCB0aGUgZW5jb2RpbmcgYW5kIGRpc3BsYXkKKyAgICAgICAgYSB3 YXJuaW5nIGluIGNhc2Ugbm8gZW5jb2Rpbmcgd2FzIGRlZmluZWQuCisgICAgICAgIE1ha2UgdGhl IFFRdWlja05ldHdvcmtSZXBseSBzdG9yZSBhIFFXZWFrUG9pbnRlciB0byB0aGUKKyAgICAgICAg UVF1aWNrV2ViVmlld0V4cGVyaW1lbnRhbCB0byBnZXQgcmlkIG9mIGhhY2tpc2ggY2hhaW4gb2Yg cGFyZW50YWwgcXVlcmllcy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrbmV0d29ya3JlcGx5LmNwcDoKKyAg ICAgICAgKFFRdWlja05ldHdvcmtSZXBseTo6c2VuZCk6CisgICAgICAgIChRUXVpY2tOZXR3b3Jr UmVwbHk6OnNldFdlYlZpZXdFeHBlcmltZW50YWwpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv cXQvcXF1aWNrbmV0d29ya3JlcGx5X3AuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Fx dWlja3dlYnZpZXcuY3BwOgorICAgICAgICAoUVF1aWNrV2ViVmlld0V4cGVyaW1lbnRhbDo6c2No ZW1lRGVsZWdhdGVzX0FwcGVuZCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9xdC9RdE5ldHdvcmtS ZXBseS5jcHA6CisgICAgICAgIChXZWJLaXQ6OlF0TmV0d29ya1JlcGx5OjpRdE5ldHdvcmtSZXBs eSk6CisgICAgICAgIChXZWJLaXQ6OlF0TmV0d29ya1JlcGx5OjpzZXRSZXBseURhdGEpOgorCiAy MDEyLTAxLTMwICBKb2NlbHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBub2tpYS5jb20+ CiAKICAgICAgICAgW1F0XSBEaXNjb25uZWN0IHRoZSBMYXllclRyZWVIb3N0IGZyb20gbGF5ZXJz IHdoZW4gdGhleSBnZXQgcmVtb3ZlZCBmcm9tIHRoZWlyIHBhcmVudC4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrbmV0d29ya3JlcGx5LmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrbmV0d29ya3JlcGx5LmNwcAppbmRl eCA0YmVhNjljLi4zOGFjN2I5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL3F0L3FxdWlja25ldHdvcmtyZXBseS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC9xcXVpY2tuZXR3b3JrcmVwbHkuY3BwCkBAIC02OCw2ICs2OCw3IEBAIHZvaWQg UVF1aWNrTmV0d29ya1JlcGx5OjpzZW5kKCkKICAgICAgICAgc3RyaW5nRGF0YSA9IG1fZGF0YS50 b1N0cmluZygpOwogICAgICAgICBwdHJEYXRhID0gcmVpbnRlcnByZXRfY2FzdDxjb25zdCB2b2lk Kj4oc3RyaW5nRGF0YS5jb25zdERhdGEoKSk7CiAgICAgICAgIHNtTGVuZ3RoID0gc2l6ZW9mKFFD aGFyKSAqIHN0cmluZ0RhdGEubGVuZ3RoKCk7CisgICAgICAgIHNldENvbnRlbnRUeXBlKFFMYXRp bjFTdHJpbmcoInRleHQvaHRtbDsgY2hhcnNldD11dGYtMTYiKSk7CiAgICAgfSBlbHNlIHsKICAg ICAgICAgaWYgKCFtX2RhdGEuY2FuQ29udmVydDxRQnl0ZUFycmF5PigpKQogICAgICAgICAgICAg cmV0dXJuOwpAQCAtNzYsNiArNzcsMTEgQEAgdm9pZCBRUXVpY2tOZXR3b3JrUmVwbHk6OnNlbmQo KQogICAgICAgICBzbUxlbmd0aCA9IGJ5dGVBcnJheURhdGEuc2l6ZSgpOwogICAgIH0KIAorICAg IGlmIChjb250ZW50VHlwZSgpLmlzRW1wdHkoKSkgeworICAgICAgICBxV2FybmluZygiUVF1aWNr TmV0d29ya1JlcGx5OjpzZW5kIC0gQ2Fubm90IHNlbmQgcmF3IGRhdGEgd2l0aG91dCBhIGNvbnRl bnQgdHlwZSBiZWluZyBzcGVjaWZpZWQhIik7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKICAg ICBXVEY6OlJlZlB0cjxXZWJLaXQ6OlNoYXJlZE1lbW9yeT4gc2hhcmVkTWVtb3J5ID0gU2hhcmVk TWVtb3J5OjpjcmVhdGUoc21MZW5ndGgpOwogICAgIGlmICghc2hhcmVkTWVtb3J5KQogICAgICAg ICByZXR1cm47CkBAIC04NSwxMyArOTEsOCBAQCB2b2lkIFFRdWlja05ldHdvcmtSZXBseTo6c2Vu ZCgpCiAKICAgICBpZiAoc2hhcmVkTWVtb3J5LT5jcmVhdGVIYW5kbGUobV9uZXR3b3JrUmVwbHlE YXRhLT5kYXRhKCkubV9kYXRhSGFuZGxlLCBTaGFyZWRNZW1vcnk6OlJlYWRPbmx5KSkgewogICAg ICAgICBtX25ldHdvcmtSZXBseURhdGEtPmRhdGEoKS5tX2NvbnRlbnRMZW5ndGggPSBzbUxlbmd0 aDsKLQotICAgICAgICBRT2JqZWN0KiBzY2hlbWVQYXJlbnQgPSBwYXJlbnQoKS0+cGFyZW50KCk7 Ci0gICAgICAgIGlmIChzY2hlbWVQYXJlbnQpIHsKLSAgICAgICAgICAgIFFRdWlja1dlYlZpZXdF eHBlcmltZW50YWwqIHdlYlZpZXdFeHBlcmltZW50YWwgPSBxb2JqZWN0X2Nhc3Q8UVF1aWNrV2Vi Vmlld0V4cGVyaW1lbnRhbCo+KHNjaGVtZVBhcmVudC0+cGFyZW50KCkpOwotICAgICAgICAgICAg aWYgKHdlYlZpZXdFeHBlcmltZW50YWwpCi0gICAgICAgICAgICAgICAgd2ViVmlld0V4cGVyaW1l bnRhbC0+c2VuZEFwcGxpY2F0aW9uU2NoZW1lUmVwbHkodGhpcyk7Ci0gICAgICAgIH0KKyAgICAg ICAgaWYgKG1fd2ViVmlld0V4cGVyaW1lbnRhbCkKKyAgICAgICAgICAgIG1fd2ViVmlld0V4cGVy aW1lbnRhbC5kYXRhKCktPnNlbmRBcHBsaWNhdGlvblNjaGVtZVJlcGx5KHRoaXMpOwogICAgIH0K IAogICAgIC8vIEFmdGVyIHNlbmRpbmcgdGhlIHJlcGx5IGRhdGEsIHdlIGhhdmUgdG8gcmVpbml0 aWFsaXplIHRoZSBtX25ldHdvcmtSZXBseURhdGEsCkBAIC05OSw2ICsxMDAsMTEgQEAgdm9pZCBR UXVpY2tOZXR3b3JrUmVwbHk6OnNlbmQoKQogICAgIG1fbmV0d29ya1JlcGx5RGF0YSA9IGFkb3B0 UmVmKG5ldyBXZWJLaXQ6OlF0UmVmQ291bnRlZE5ldHdvcmtSZXBseURhdGEpOwogfQogCit2b2lk IFFRdWlja05ldHdvcmtSZXBseTo6c2V0V2ViVmlld0V4cGVyaW1lbnRhbChRUXVpY2tXZWJWaWV3 RXhwZXJpbWVudGFsKiB3ZWJWaWV3RXhwZXJpbWVudGFsKQoreworICAgIG1fd2ViVmlld0V4cGVy aW1lbnRhbCA9IHdlYlZpZXdFeHBlcmltZW50YWw7Cit9CisKIFdlYktpdDo6UXRSZWZDb3VudGVk TmV0d29ya1JlcXVlc3REYXRhKiBRUXVpY2tOZXR3b3JrUmVwbHk6Om5ldHdvcmtSZXF1ZXN0RGF0 YSgpIGNvbnN0CiB7CiAgICAgcmV0dXJuIG1fbmV0d29ya1JlcXVlc3REYXRhLmdldCgpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2tuZXR3b3JrcmVw bHlfcC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2tuZXR3b3JrcmVw bHlfcC5oCmluZGV4IDcxM2Y0ZTYuLjEwMDdmM2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrbmV0d29ya3JlcGx5X3AuaAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja25ldHdvcmtyZXBseV9wLmgKQEAgLTIzLDEwICsy MywxMiBAQAogCiAjaW5jbHVkZSAiUXROZXR3b3JrUmVwbHlEYXRhLmgiCiAjaW5jbHVkZSAiUXRO ZXR3b3JrUmVxdWVzdERhdGEuaCIKKyNpbmNsdWRlICJxcXVpY2t3ZWJ2aWV3X3AuaCIKICNpbmNs dWRlICJTaGFyZWRNZW1vcnkuaCIKICNpbmNsdWRlICJxd2Via2l0Z2xvYmFsLmgiCiAjaW5jbHVk ZSA8UU5ldHdvcmtBY2Nlc3NNYW5hZ2VyPgogI2luY2x1ZGUgPFFPYmplY3Q+CisjaW5jbHVkZSA8 UVdlYWtQb2ludGVyPgogI2luY2x1ZGUgPFF0RGVjbGFyYXRpdmUvcWRlY2xhcmF0aXZlbGlzdC5o PgogI2luY2x1ZGUgPFF0UXVpY2svcXF1aWNraXRlbS5oPgogCkBAIC00NCw2ICs0Niw3IEBAIHB1 YmxpYzoKICAgICBRVmFyaWFudCBkYXRhKCkgY29uc3Q7CiAgICAgdm9pZCBzZXREYXRhKGNvbnN0 IFFWYXJpYW50JiBkYXRhKTsKIAorICAgIHZvaWQgc2V0V2ViVmlld0V4cGVyaW1lbnRhbChRUXVp Y2tXZWJWaWV3RXhwZXJpbWVudGFsKik7CiAgICAgV2ViS2l0OjpRdFJlZkNvdW50ZWROZXR3b3Jr UmVxdWVzdERhdGEqIG5ldHdvcmtSZXF1ZXN0RGF0YSgpIGNvbnN0OwogICAgIHZvaWQgc2V0TmV0 d29ya1JlcXVlc3REYXRhKFdURjo6UGFzc1JlZlB0cjxXZWJLaXQ6OlF0UmVmQ291bnRlZE5ldHdv cmtSZXF1ZXN0RGF0YT4gZGF0YSk7CiAgICAgV2ViS2l0OjpRdFJlZkNvdW50ZWROZXR3b3JrUmVw bHlEYXRhKiBuZXR3b3JrUmVwbHlEYXRhKCkgY29uc3Q7CkBAIC01NSw2ICs1OCw3IEBAIHByaXZh dGU6CiAgICAgV1RGOjpSZWZQdHI8V2ViS2l0OjpRdFJlZkNvdW50ZWROZXR3b3JrUmVxdWVzdERh dGE+IG1fbmV0d29ya1JlcXVlc3REYXRhOwogICAgIFdURjo6UmVmUHRyPFdlYktpdDo6UXRSZWZD b3VudGVkTmV0d29ya1JlcGx5RGF0YT4gbV9uZXR3b3JrUmVwbHlEYXRhOwogICAgIFFWYXJpYW50 IG1fZGF0YTsKKyAgICBRV2Vha1BvaW50ZXI8UVF1aWNrV2ViVmlld0V4cGVyaW1lbnRhbD4gbV93 ZWJWaWV3RXhwZXJpbWVudGFsOwogfTsKIAogUU1MX0RFQ0xBUkVfVFlQRShRUXVpY2tOZXR3b3Jr UmVwbHkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlj a3dlYnZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2 aWV3LmNwcAppbmRleCA5MzVkZTkyLi5hZjgxOGZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKQEAgLTgyNCw2ICs4MjQsNyBAQCB2 b2lkIFFRdWlja1dlYlZpZXdFeHBlcmltZW50YWw6OnNjaGVtZURlbGVnYXRlc19BcHBlbmQoUURl Y2xhcmF0aXZlTGlzdFByb3BlcnR5PAogICAgIFFRdWlja1dlYlZpZXdFeHBlcmltZW50YWwqIHdl YlZpZXdFeHBlcmltZW50YWwgPSBxb2JqZWN0X2Nhc3Q8UVF1aWNrV2ViVmlld0V4cGVyaW1lbnRh bCo+KHByb3BlcnR5LT5vYmplY3QtPnBhcmVudCgpKTsKICAgICBpZiAoIXdlYlZpZXdFeHBlcmlt ZW50YWwpCiAgICAgICAgIHJldHVybjsKKyAgICBzY2hlbWUtPnJlcGx5KCktPnNldFdlYlZpZXdF eHBlcmltZW50YWwod2ViVmlld0V4cGVyaW1lbnRhbCk7CiAgICAgUVF1aWNrV2ViVmlld1ByaXZh dGUqIGQgPSB3ZWJWaWV3RXhwZXJpbWVudGFsLT5kX2Z1bmMoKTsKICAgICBkLT53ZWJQYWdlUHJv eHktPnJlZ2lzdGVyQXBwbGljYXRpb25TY2hlbWUoc2NoZW1lLT5zY2hlbWUoKSk7CiB9CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3F0L1F0TmV0d29ya1JlcGx5LmNwcCBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvcXQvUXROZXR3b3JrUmVwbHkuY3BwCmluZGV4IGM3 MWYxM2YuLmU2NTAyMmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvcXQv UXROZXR3b3JrUmVwbHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvcXQvUXRO ZXR3b3JrUmVwbHkuY3BwCkBAIC00NSw3ICs0NSw2IEBAIFF0TmV0d29ya1JlcGx5OjpRdE5ldHdv cmtSZXBseShjb25zdCBRTmV0d29ya1JlcXVlc3QmIHJlcSwgUXROZXR3b3JrQWNjZXNzTWFuYWdl CiAgICAgc2V0T3BlcmF0aW9uKFFOZXR3b3JrQWNjZXNzTWFuYWdlcjo6R2V0T3BlcmF0aW9uKTsK ICAgICBzZXRVcmwocmVxLnVybCgpKTsKICAgICBzZXRPcGVuTW9kZShRSU9EZXZpY2U6OlJlYWRP bmx5KTsKLSAgICBzZXRIZWFkZXIoUU5ldHdvcmtSZXF1ZXN0OjpDb250ZW50VHlwZUhlYWRlciwg UVZhcmlhbnQoUVN0cmluZzo6ZnJvbUxvY2FsOEJpdCgidGV4dC9odG1sOyBjaGFyc2V0PVVURi0x NiIpKSk7CiB9CiAKIHZvaWQgUXROZXR3b3JrUmVwbHk6OnNldERhdGEoY29uc3QgU2hhcmVkTWVt b3J5OjpIYW5kbGUmIGhhbmRsZSwgcWludDY0IGRhdGFTaXplKQpAQCAtNjIsNyArNjEsNyBAQCB2 b2lkIFF0TmV0d29ya1JlcGx5OjpzZXREYXRhKGNvbnN0IFNoYXJlZE1lbW9yeTo6SGFuZGxlJiBo YW5kbGUsIHFpbnQ2NCBkYXRhU2l6ZQogCiB2b2lkIFF0TmV0d29ya1JlcGx5OjpzZXRSZXBseURh dGEoY29uc3QgUXROZXR3b3JrUmVwbHlEYXRhJiByZXBseURhdGEpCiB7Ci0gICAgaWYgKCFyZXBs eURhdGEubV9jb250ZW50VHlwZS5pc051bGwoKSkKKyAgICBpZiAoIXJlcGx5RGF0YS5tX2NvbnRl bnRUeXBlLmlzRW1wdHkoKSkKICAgICAgICAgc2V0SGVhZGVyKFFOZXR3b3JrUmVxdWVzdDo6Q29u dGVudFR5cGVIZWFkZXIsIFFTdHJpbmcocmVwbHlEYXRhLm1fY29udGVudFR5cGUpKTsKICAgICBz ZXRIZWFkZXIoUU5ldHdvcmtSZXF1ZXN0OjpDb250ZW50TGVuZ3RoSGVhZGVyLCBRVmFyaWFudDo6 ZnJvbVZhbHVlKHJlcGx5RGF0YS5tX2NvbnRlbnRMZW5ndGgpKTsKICAgICBzZXREYXRhKHJlcGx5 RGF0YS5tX2RhdGFIYW5kbGUsIHJlcGx5RGF0YS5tX2NvbnRlbnRMZW5ndGgpOwo=