77373 2012-01-30 15:12:11 -0800 REGRESSION (r91935): text-combine fails 2012-01-30 17:58:12 -0800 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED data:text/html,<div style="-webkit-writing-mode: vertical-rl; font-family: hiragino mincho pro"><span style="-webkit-text-combine: horizontal;">1200</span> InRadar, Regression P1 Normal --- 1 mitz mitz oldest_to_newest 545455 0 mitz 2012-01-30 15:12:11 -0800 To reproduce, open the URL. The number 1200 should be rendered horizontally in quarter-width glyphs. 545458 1 mitz 2012-01-30 15:12:31 -0800 <rdar://problem/10778045> 545629 2 124636 mitz 2012-01-30 17:18:18 -0800 Created attachment 124636 Do not use the vertical-glyph getter for horizontal, non-fullwidth glyphs 545634 3 124636 darin 2012-01-30 17:22:02 -0800 Comment on attachment 124636 Do not use the vertical-glyph getter for horizontal, non-fullwidth glyphs View in context: https://bugs.webkit.org/attachment.cgi?id=124636&action=review > Source/WebCore/platform/graphics/mac/GlyphPageTreeNodeMac.cpp:68 > + } else if ((fontData->platformData().widthVariant() != RegularWidth && CTFontGetGlyphsForCharacters(fontData->platformData().ctFont(), buffer, glyphs.data(), bufferLength)) > + || (fontData->platformData().widthVariant() == RegularWidth && wkGetVerticalGlyphsForCharacters(fontData->platformData().ctFont(), buffer, glyphs.data(), bufferLength))) { I think this should use ? : or an if statement rather than calling widthVariant twice. Maybe in a helper function. 545669 4 mitz 2012-01-30 17:58:12 -0800 Fixed in <http://trac.webkit.org/r106310>. 124636 2012-01-30 17:18:18 -0800 2012-01-30 17:22:02 -0800 Do not use the vertical-glyph getter for horizontal, non-fullwidth glyphs bug-77373-20120130171823.patch text/plain 3197 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNjMwNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAxLTMwICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEwNzc4 MDQ1PiBSRUdSRVNTSU9OIChyOTE5MzUpOiB0ZXh0LWNvbWJpbmUgZmFpbHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3MzczCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlZCB0ZXN0cyB0aGF0IHdl cmUgZmFpbGluZyBiZWNhdXNlIG9mIHRoaXMgYnVnIGZyb20gdGhlIExpb24gc2tpcHBlZAorICAg ICAgICBsaXN0LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0dseXBoUGFnZVRy ZWVOb2RlTWFjLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdseXBoUGFnZTo6ZmlsbCk6IENoYW5n ZWQgdG8gdXNlIENURm9udEdldEdseXBoc0ZvckNoYXJhY3RlcnMsCisgICAgICAgIHJhdGhlciB0 aGFuIHdrR2V0VmVydGljYWxHbHlwaHNGb3JDaGFyYWN0ZXJzLCBmb3Igbm9uLWZ1bGx3aWR0aCBm b250cy4KKwogMjAxMi0wMS0zMCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29t PgogCiAgICAgICAgIFNob3cgZGVidWcgYm9yZGVycyBmb3IgaW5kaXZpZHVhbCB0aWxlIGNhY2hl IHRpbGVzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvR2x5cGhQ YWdlVHJlZU5vZGVNYWMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL21hYy9HbHlwaFBhZ2VUcmVlTm9kZU1hYy5jcHAJKHJldmlzaW9uIDEwNjI5NykK KysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9HbHlwaFBhZ2VUcmVlTm9k ZU1hYy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY0LDcgKzY0LDggQEAgYm9vbCBHbHlwaFBhZ2U6 OmZpbGwodW5zaWduZWQgb2Zmc2V0LCB1bgogICAgICAgICAgICAgICAgIGhhdmVHbHlwaHMgPSB0 cnVlOwogICAgICAgICAgICAgfQogICAgICAgICB9Ci0gICAgfSBlbHNlIGlmICh3a0dldFZlcnRp Y2FsR2x5cGhzRm9yQ2hhcmFjdGVycyhmb250RGF0YS0+cGxhdGZvcm1EYXRhKCkuY3RGb250KCks IGJ1ZmZlciwgZ2x5cGhzLmRhdGEoKSwgYnVmZmVyTGVuZ3RoKSkgeworICAgIH0gZWxzZSBpZiAo KGZvbnREYXRhLT5wbGF0Zm9ybURhdGEoKS53aWR0aFZhcmlhbnQoKSAhPSBSZWd1bGFyV2lkdGgg JiYgQ1RGb250R2V0R2x5cGhzRm9yQ2hhcmFjdGVycyhmb250RGF0YS0+cGxhdGZvcm1EYXRhKCku Y3RGb250KCksIGJ1ZmZlciwgZ2x5cGhzLmRhdGEoKSwgYnVmZmVyTGVuZ3RoKSkKKyAgICAgICAg fHwgKGZvbnREYXRhLT5wbGF0Zm9ybURhdGEoKS53aWR0aFZhcmlhbnQoKSA9PSBSZWd1bGFyV2lk dGggJiYgd2tHZXRWZXJ0aWNhbEdseXBoc0ZvckNoYXJhY3RlcnMoZm9udERhdGEtPnBsYXRmb3Jt RGF0YSgpLmN0Rm9udCgpLCBidWZmZXIsIGdseXBocy5kYXRhKCksIGJ1ZmZlckxlbmd0aCkpKSB7 CiAgICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBsZW5ndGg7ICsraSkgewogICAgICAg ICAgICAgaWYgKCFnbHlwaHNbaV0pCiAgICAgICAgICAgICAgICAgc2V0R2x5cGhEYXRhRm9ySW5k ZXgob2Zmc2V0ICsgaSwgMCwgMCk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDYzMDQpCisrKyBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0w MS0zMCAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgorCisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8xMDc3ODA0NT4gUkVHUkVTU0lPTiAocjkxOTM1KTogdGV4dC1jb21iaW5lIGZhaWxz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzM3Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZWQg dGVzdHMgdGhhdCB3ZXJlIGZhaWxpbmcgYmVjYXVzZSBvZiB0aGlzIGJ1ZyBmcm9tIHRoZSBza2lw cGVkIGxpc3QuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtbGlvbi9Ta2lwcGVkOgorCiAyMDEy LTAxLTMwICBSYWtlc2ggS04gIDxyYWtlc2gua25AbW90b3JvbGEuY29tPgogCiAgICAgICAgIHNp bmdsZS1maWxlIGlucHV0IGVsZW1lbnRzIHNob3VsZCByZWZ1c2UgbXVsdGktZmlsZSBkcmFncwpJ bmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLWxpb24vU2tpcHBlZAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtbGlvbi9Ta2lwcGVkCShyZXZpc2lvbiAxMDYyOTcp CisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtbGlvbi9Ta2lwcGVkCSh3b3JraW5nIGNvcHkp CkBAIC0xMjEsMTAgKzEyMSw2IEBAIHN2Zy9XM0MtU1ZHLTEuMS1TRS90eXBlcy1kb20tMDEtYi5z dmcKIAogIyAtLS0gTWlzYyBmYWlsdXJlcyB0aGF0IG5lZWQgaW52ZXN0aWdhdGlvbiAtLS0KIAot IyBUaGVzZSBmYWlsIGluIERSVCBidXQgbG9vayBjb3JyZWN0IGluIFNhZmFyaS4KLWZhc3QvdGV4 dC9lbXBoYXNpcy1jb21iaW5lZC10ZXh0Lmh0bWwKLWZhc3QvdGV4dC9pbnRlcm5hdGlvbmFsL3Rl eHQtY29tYmluZS1pbWFnZS10ZXN0Lmh0bWwKLQogIyBTZW5kaW5nIHRoZSBtb3VzZSBkb3duIGV2 ZW50IHRvIHRoZSBzY3JvbGxiYXIgc3RhcnRzIGEgbmVzdGVkIHJ1biBsb29wIHdoaWNoIGNhdXNl cyBhIGhhbmcuCiBmYXN0L2V2ZW50cy9tb3VzZWRvd24taW4tc3ViZnJhbWUtc2Nyb2xsYmFyLmh0 bWwKIAo=