77368 2012-01-30 14:01:50 -0800 [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom 2012-06-07 17:21:25 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Windows 7 RESOLVED FIXED P2 Normal --- 77789 1 tony tony dpranke ojan tkent webkit.review.bot oldest_to_newest 545393 0 tony 2012-01-30 14:01:50 -0800 I'll upload an pixel result that shows this. Other platforms don't seem to do this. 545396 1 124596 tony 2012-01-30 14:02:28 -0800 Created attachment 124596 pixel result with scrollbars In the attach image, the scrollbars shouldn't overflow the green boxes. 545397 2 tony 2012-01-30 14:02:55 -0800 dpranke said he's hoping to work on this this quarter. 582013 3 tony 2012-03-19 12:01:55 -0700 I tracked this down since I had another ref test fail. The bug is here: http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp#L51 WebRect is defined as a point + width/height. SkIRect is a left, top, right and bottom edge. The conversion needs to subtract 1 from the width and the height. For example, suppose WebRect is at 0, 0 and has a width and height of 10. This converts to a SkIRect with points at 0, 0, 10, 10, but that's actually a width and height of 11. This also explains why we don't have right/bottom edges on any of our scrollbars, e.g.: http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-win/css1/basic/class_as_selector-expected.png We'll need to rebaseline many tests, e.g., all textareas and all scrollbars are different. 643772 4 146351 tony 2012-06-07 12:00:49 -0700 Created attachment 146351 Patch 643822 5 tony 2012-06-07 13:07:05 -0700 Committed r119748: <http://trac.webkit.org/changeset/119748> 644106 6 tkent 2012-06-07 17:21:25 -0700 Probably all of rectangles drawn by the mock theme have this issue. e.g. LayoutTests/platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.png 124596 2012-01-30 14:02:28 -0800 2012-01-30 14:02:28 -0800 pixel result with scrollbars cross-axis-scrollbar-actual.png image/png 4308 tony iVBORw0KGgoAAAANSUhEUgAAAyAAAAJYCAIAAAAVFBUnAAAAKXRFWHRjaGVja3N1bQBjNDIyYjg5 MGYyZjVlNmMxOThmOGRmMTA0Nzk1MTk1NjinTN4AABBmSURBVHic7d1bcqNIAkBRa6L2pOWVe3le lebD3Q6VHhhJ1wUJ53x0VNt6JMbAVYKlw+l0egMAoPO/pQcAALA1AgsAICawAABih4nvnU6nw+Fw fZHWzS9u3vlSHw7//tyW+jm066Vdofv89QCAc4e3s0pYVUOs1sVP6e//fD5XTfW87aMBAG/Tpwhf POh+JdqP3mVZi3RJ+6TSCgBy/7t3fHXcBQB4zq85N7o4izTnTOLn18/vePOW51+8vsv5zb5ucPOJ Jh52/lcmFudiDM8N8l6zXt9x+qc6/TjfLsi9784Z+fX6uvnvr6W4+QO5mKeU8gBsz/eBdfN4ef2t i3tdXCB/898Xd5+4pv7mvWY+7PRXpu94MYYXBznnjjMX8O3KzPVy77szR36++Df/ff4TvvezXfYK NgD4C75/m4aLQ+DNI+Kcw+ThP4/e/esQ/vW/E9NR0w97MY8yfzzfLuDFIM+f5ebIp+94PbaLx5kz 5m+Hff7dJ0Y+/Zj3fiAAsAezThHec++M2L0bv3L3e85nv+497M0n+qHxJF4cwPSCvLiY55NVF/99 ZcwAsCUvBdbb2TVDTx+tX7n7vTteP+zMJ3pxPOsxvSALLubNCUgA2JiX3sl9zmmjieuZ7t19+hqj iSuZvn3G6aebeRbsIReXJT2aFDcvJP+6vOnbez3x3S/TI3/6UqrPG3+aeRcAGM7tq6Evvnjv4qHp qYiL81ATF05dfOXe9UDX3715WnDOE80cz/WNL34CEyOZs1zzx3bxODeLZ2IAE8/43MgnrsS/uOXN s7fn3317MNEAYP3GOLA5AG/D9EwYAGyGD3sGAIgNMH/gmugtuXmKEAA2ZoDAAgAYi1OEAACxw9v7 0kMYx+n3Gmf7Dv/07y6xWe/Z7cNfBmvwAe/Z7a3BRaxzLwo/4dU3GoWxfHx8zLzl8Xj80ZHwHGsQ GIJThAAAMYEFABATWOza8Xh0Imlo1iCwTgILACAmsNivr5kPUyCDsgaB1RJYAAAxgQVvb6ZAxmcN AqsisNip6+OxI/RYrEFgzQQWAEBMYLFH96Y6TIGMwhoEVk5gAQDEBBYAQMyHPbNH8z8wmHWyBoGV M4MFABATWAAAMacI2Rd/ZTY6axAYgsBiX+Zfu+NAvk7WIDAEpwgBAGICCwAgJrAAAGICCwAgJrAA AGICCwAgJrAAAGICCwAgJrAAAGICCwAg5qNy2LXzT1OZ/xksrIc1CKyTGSwAgJjAAgCICSwAgJhr sNiX80t25n+L9bAGgSEILPZl/nXQjtbrZA0CQ3CKEAAgJrAAAGJOEbJHEyePvJfSEKxBYOXMYAEA xAQWe3RvksPkxyisQWDlBBYAQExgwb9MfozOGgTWQ2CxUxcHY8fm4ViDwJoJLACAmMBiv77mPEx+ DMoaBFZLYAEAxLzRKLtm5mN01iCwTmawAABiAgsAICawAABih6UHMJjT6bT0EHje4fDYL7zVvTbr XIOPjmrnbFbsxK+3x68SPR6PG7iw9ImlOB6PPzQY/g579tGtdg3ai86/yw8NBtbGKUIAgNj3b9Pw 9YJjA6+37vlcxg0vILAge1HYoanA2ttc7h52gsDfZC8Ku3UjsPa2R7jmpRjwCntRe1H4I7A2v1N4 aAHtIIBH2Yte39helH1ykTsAQOyPGazP1xmbfwU2k1ddwKPsRc/Zi7JnN67BsoOwUwBeYS9qLwp3 /4rw4+Nje3uH823+3tLZLwAJe1HYs6m3adjbizA7BaBlLwq79f0bje5hg9nDMgJL2cMeZg/LCA/x V4QAADGBBQAQOyw9gMGcTqelhwCsy+FgR/oAe1F24tfb+9JDGMfpt/0CcOV96QGMw16U/XCKEAAg JrAAAGICCwAgJrAAAGICCwAgJrAAAGICCwAgJrAAAGIHb6oLANAygwUAEBNYAAAxgQUAEBNYAAAx gQUAEBNYAAAxgQUAEBNYAAAxgQUAEBNYAAAxgQUAEBNYAAAxgQUAEBNYAAAxgQUAEBNYAAAxgQUA EBNYAAAxgQUAEBNYAAAxgQUAEBNYAAAxgQUAEBNYAACxw9v70kMYx+n3aekh3HD457D0EH7Ye3Z7 a3B01uDw3rPbr/OXAb78WnoA8L2Pj4+Ztzwejz86EuBFNmd2wilCAICYwAIAiAksxnM8Hp07gG2w ObNVAgsAICawGMzXi12vemF0Nmc2TGABAMQEFgPzqhc2w+bMxggsRnK9C7ZThkHZnNk2gQUAEBNY DOPeq1uvemE4Nmc2T2ABAMQEFgBAzIc9M4z5nxELrJzNmc0zgwUAEBNYAAAxpwgZgD8sgs2wObMT AosBzL9cw74bVs7mzE44RQgAEBNYAAAxgQUAEBNYAAAxgQUAEBNYAAAxb9MAS3tfegDjOLwfTqfT 0qMA+J7AguU9+rlsx+NxAx/l9sRSeGMkYBROEQIAxMxgwdp9TdtsYNbqns9l3PACAnsjsBjP+Xmi bR+S93ZGbA8pyYX9bM7sjcCC1dlbV10zoQWMTmDBimw+rR5aQJkFjMtF7gAAMTNYDGBi2mNjUz6f szUbW6inmbvapP1szuycwGIA8w+029hByyxptWF725zZLYEFK/Xx8bG9A8z5wfXe0qkrYAMEFqzX 3qaypBWwGQKLYUx0xrYPzNteuk97WEbO7XZzZj/8FSEAQExgMYx7r2u93oXh2JzZPKcIYXlPXGW1 jQuztrEUANcEFmPbwuvd96UHMI7T79PSQ+AHbWFzhv84RchILva/dscwLpsz2yawAABiAovBfL3M 9XoXRmdzZsMEFgBAzEXujMeLXdgMmzNbZQYLACAmsAAAYgILACB2WHoAgzmdvM/h33Y4PPZbah3B atmc2Y/D2+PXGB6Pxw1clvjEUhyPR1s7APAtpwgBAGLfv03D16exbmDW6p7PZdzwAgIAf9NUYO3t g+73kJIAwF9wI7D21lXXTGgBAK/4I7A2n1YPLaDMAgCe4yJ3AIDYHzNYn7M1m5/HmsncFQDwnBvX YMksaQUAvOLuXxF+fHxsr7HOy+ne0qkrAOBFU2/TsLepLGkFACS+f6PRPWTHHpYRAPhr/BUhAEBM YAEAxA5LD2Awp9Np6SEAAGt3eHtfegjjOP1WVwDA95wiBACICSwAgJjAAgCICSwAgJjAAgCICSwA gJjAAgCICSwAgNjBW5MDALTMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEA xAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQW AEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBM YAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEA xAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQW AEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBM YAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEA xAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQW AEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBM YAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEA xAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQW AEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBM YAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEA xAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQW AEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBM YAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEA xAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQW AEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBM YAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEA xAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQW AEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBM YAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEA xAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQW AEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBM YAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEA xAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQW AEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBM YAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEA xAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQW AEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBM YAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEA xAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQWAEBMYAEAxAQW AEBMYAEAxAQWAEDs/+qdmmpEuCnGAAAAAElFTkSuQmCC 146351 2012-06-07 12:00:49 -0700 2012-06-07 12:04:37 -0700 Patch bug-77368-20120607120050.patch text/plain 1584 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NTk1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODJlMTBlZTI0Yzk0OWExY2EwYmZhYjMwYmQ5OWZlYmM4 NWFkNjE4OS4uNzg5MDlhZWJiMjE4YmMzODhhNmY3ODI5MzE3NjRhMGE4MTE0N2E2OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA2LTA3ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgW2Nocm9taXVtXSBXaW4gbW9jayBzY3JvbGxiYXJzIGFwcGVhciB0byBvdmVyZmxvdyBieSBh IHBpeGVsIHRvIHRoZSByaWdodCBhbmQgYm90dG9tCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzM2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEl0IGRvZXNuJ3QgbG9vayBsaWtlIHdlIGV2ZXIgZ2V0IGEg cmVjdCB3aXRoIHdpZHRoIG9yIGhlaWdodCBvZiAwLgorICAgICAgICBJIHJhbiBjc3MxLCBjc3My LjEsIGZhc3QvZm9ybXMsIGFuZCB0YWJsZXMgd2l0aG91dCBhbnkgY3Jhc2hlcy4KKworICAgICAg ICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlRoZW1lRW5naW5lRFJUV2luLmNwcDoKKyAg ICAgICAgKHdlYlJlY3RUb1NrSVJlY3QpOiBDb3JyZWN0bHkgY29udmVydCBhIFdlYlJlY3QgdG8g YSBTa0lSZWN0LgorCiAyMDEyLTA2LTA2ICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBv emRueWFrb3ZAaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdW0RSVF0gaHR0cC90ZXN0cy9nbG9i YWxoaXN0b3J5IHRlc3RjYXNlcyBkbyBub3QgcGFzcwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vV2ViVGhlbWVFbmdpbmVEUlRXaW4uY3BwIGIvVG9vbHMvRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vV2ViVGhlbWVFbmdpbmVEUlRXaW4uY3BwCmluZGV4IDc4OWIxYzgx Njk5MWZlZGNmNWNiNmY3MDAzNmQ5ZWQ0NTVlY2FkYmUuLjgzMWMzNTRmYTJhNDdiYzIzYjQ4MmJk M2ZiZTk4NTRiYzhmMmU4Y2YgMTAwNzU1Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9t aXVtL1dlYlRoZW1lRW5naW5lRFJUV2luLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9j aHJvbWl1bS9XZWJUaGVtZUVuZ2luZURSVFdpbi5jcHAKQEAgLTUxLDcgKzUxLDcgQEAgc3RhdGlj IGNvbnN0IGludCBkZmNzTm9ybWFsID0gMHgwMDAwOwogc3RhdGljIFNrSVJlY3Qgd2ViUmVjdFRv U2tJUmVjdChjb25zdCBXZWJSZWN0JiB3ZWJSZWN0KQogewogICAgIFNrSVJlY3QgaXJlY3Q7Ci0g ICAgaXJlY3Quc2V0KHdlYlJlY3QueCwgd2ViUmVjdC55LCB3ZWJSZWN0LnggKyB3ZWJSZWN0Lndp ZHRoLCB3ZWJSZWN0LnkgKyB3ZWJSZWN0LmhlaWdodCk7CisgICAgaXJlY3Quc2V0KHdlYlJlY3Qu eCwgd2ViUmVjdC55LCB3ZWJSZWN0LnggKyB3ZWJSZWN0LndpZHRoIC0gMSwgd2ViUmVjdC55ICsg d2ViUmVjdC5oZWlnaHQgLSAxKTsKICAgICByZXR1cm4gaXJlY3Q7CiB9CiAK