77360 2012-01-30 13:00:11 -0800 [BlackBerry] OS(QNX) also has TM_GMTOFF, TM_ZONE, and TIMEGM 2012-06-13 08:11:57 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Minor --- 1 yong.li.webkit yong.li.webkit milian.wolff webkit.review.bot oldest_to_newest 545331 0 yong.li.webkit 2012-01-30 13:00:11 -0800 OS(QNX) should also define HAVE(TM_GMTOFF, TM_ZONE, and TIMEGM) 545335 1 124585 yong.li.webkit 2012-01-30 13:06:56 -0800 Created attachment 124585 the patch 545347 2 124585 rwlbuis 2012-01-30 13:12:30 -0800 Comment on attachment 124585 the patch Looks good. 545432 3 124585 webkit.review.bot 2012-01-30 14:48:25 -0800 Comment on attachment 124585 the patch Clearing flags on attachment: 124585 Committed r106290: <http://trac.webkit.org/changeset/106290> 545433 4 webkit.review.bot 2012-01-30 14:48:29 -0800 All reviewed patches have been landed. Closing bug. 648006 5 milian.wolff 2012-06-13 07:50:02 -0700 can someone clarify how this is supposed to work, or which QNX version should support this? For QNX6 I can only find timegm in nbutil.h which would also mean we need to link against nbutil.so to get that in. As-Is the patch that has landed here breaks compilation of QtWebKit for QNX6 for me. 648030 6 yong.li.webkit 2012-06-13 08:11:57 -0700 (In reply to comment #5) > can someone clarify how this is supposed to work, or which QNX version should support this? > > For QNX6 I can only find timegm in nbutil.h which would also mean we need to link against nbutil.so to get that in. > > As-Is the patch that has landed here breaks compilation of QtWebKit for QNX6 for me. TIMEGM isn't important thing. We saw this issue. And it is fixed for playbook 2.x You can just cherry-pick this patch: commit 98aacd9c57a8f38261e9fa4554f2cc7e8343030c Author: Ming Xie <mxie@rim.com> Date: Thu Feb 2 13:50:41 2012 -0500 2012-02-02 Ming Xie <mxie@rim.com> Disable HAVE_TIMEGM in *GR2.0* build only. Reviewed by Yong Li. * wtf/Platform.h: # =============================================== # COMMIT DIFF(S) # =============================================== # =============================================== # Revision 1: webkit/98aacd9c57a8f38261e9fa4554f2cc7e8343030c # =============================================== 98aacd9c57a8f38261e9fa4554f2cc7e8343030c diff --git a/Source/JavaScriptCore/wtf/Platform.h b/Source/JavaScriptCore/wtf/Platform.h index 2ef394a..f169fbf 100644 --- a/Source/JavaScriptCore/wtf/Platform.h +++ b/Source/JavaScriptCore/wtf/Platform.h @@ -673,8 +673,10 @@ && !OS(ANDROID) #define HAVE_TM_GMTOFF 1 #define HAVE_TM_ZONE 1 +#if !OS(QNX) #define HAVE_TIMEGM 1 #endif +#endif #if OS(DARWIN) 124585 2012-01-30 13:06:56 -0800 2012-01-30 14:48:25 -0800 the patch 77360.patch text/plain 1021 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGI4ODhmMjQuLjVmMjkxZmIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAxLTMwICBZb25nIExpICA8eW9s aUByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBPUyhRTlgpIGFsc28gaGFzIFRNX0dN VE9GRiwgVE1fWk9ORSwgYW5kIFRJTUVHTQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzczNjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUdXJuIG9uIEhBVkUoVE1fR01UT0ZGKSwgSEFWRShUTV9aT05FKSwg YW5kIEhBVkUoVElNRUdNKQorICAgICAgICBmb3IgT1MoUU5YKS4KKworICAgICAgICAqIHd0Zi9Q bGF0Zm9ybS5oOgorCiAyMDEyLTAxLTIwICBZb25nIExpICA8eW9saUByaW0uY29tPgogCiAgICAg ICAgIFtCbGFja0JlcnJ5XSBJbXBsZW1lbnQgT1NBbGxvY2F0b3I6OmNvbW1pdC9kZWNvbW1pdC4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAppbmRleCA5MGRlYmQ5Li40NzlmYWY2IDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCkBAIC02NjksNyArNjY5LDcgQEAKICNl bmRpZgogI2VuZGlmCiAKLSNpZiAhT1MoV0lORE9XUykgJiYgIU9TKFNPTEFSSVMpICYmICFPUyhR TlgpIFwKKyNpZiAhT1MoV0lORE9XUykgJiYgIU9TKFNPTEFSSVMpIFwKICAgICAmJiAhT1MoUlZD VCkgXAogICAgICYmICFPUyhBTkRST0lEKQogI2RlZmluZSBIQVZFX1RNX0dNVE9GRiAxCg==