7735 2006-03-12 06:35:25 -0800 REGRESSION: crash on importing bookmarks 2006-03-12 14:06:06 -0800 1 1 1 Unclassified WebKit WebKit Misc. 420+ Mac OS X 10.4 RESOLVED FIXED P1 Normal --- 1 ap ap oldest_to_newest 35992 0 ap 2006-03-12 06:35:25 -0800 Almost the same as bug 5541: AtomicString is non-functional at Safari startup, when bookmarks are imported, which causes a crash as soon as it is used (which happens to be in HTMLNames::init()). Steps to reproduce: 1. Launch MSIE at least once, to make it write out its bookmarks 2. defaults write com.apple.Safari IEFavoritesWereImported 0 3. run-safari Results: Safari crashes 35994 1 7021 ap 2006-03-12 06:47:52 -0800 Created attachment 7021 proposed fix 36037 2 7021 mjs 2006-03-12 13:32:27 -0800 Comment on attachment 7021 proposed fix r=me 7021 2006-03-12 06:47:52 -0800 2006-03-12 13:32:27 -0800 proposed fix 7735r1_patch.txt text/plain 1974 ap SW5kZXg6IFdlYkNvcmUvZG9tL0V2ZW50TmFtZXMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv ZG9tL0V2ZW50TmFtZXMuY3BwCShyZXZpc2lvbiAxMzI2MSkKKysrIFdlYkNvcmUvZG9tL0V2ZW50 TmFtZXMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Myw2ICs0Myw4IEBAIHZvaWQgaW5pdCgpCiAg ICAgc3RhdGljIGJvb2wgaW5pdGlhbGl6ZWQ7CiAgICAgaWYgKCFpbml0aWFsaXplZCkgewogICAg ICAgICAvLyBVc2UgcGxhY2VtZW50IG5ldyB0byBpbml0aWFsaXplIHRoZSBnbG9iYWxzLgorICAg ICAgICAKKyAgICAgICAgQXRvbWljU3RyaW5nOjppbml0KCk7CiAgICAgICAgICNkZWZpbmUgSU5J VElBTElaRV9HTE9CQUwobmFtZSkgbmV3ICgodm9pZCopJm5hbWUjI0V2ZW50KSBBdG9taWNTdHJp bmcoI25hbWUpOwogICAgICAgICBET01fRVZFTlRfTkFNRVNfRk9SX0VBQ0goSU5JVElBTElaRV9H TE9CQUwpCiAgICAgICAgIGluaXRpYWxpemVkID0gdHJ1ZTsKSW5kZXg6IFdlYkNvcmUvZG9tL1F1 YWxpZmllZE5hbWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZG9tL1F1YWxpZmllZE5hbWUu Y3BwCShyZXZpc2lvbiAxMzI2MSkKKysrIFdlYkNvcmUvZG9tL1F1YWxpZmllZE5hbWUuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xNzksNiArMTc5LDggQEAgdm9pZCBRdWFsaWZpZWROYW1lOjppbml0 KCkKICAgICBzdGF0aWMgYm9vbCBpbml0aWFsaXplZDsKICAgICBpZiAoIWluaXRpYWxpemVkKSB7 CiAgICAgICAgIC8vIFVzZSBwbGFjZW1lbnQgbmV3IHRvIGluaXRpYWxpemUgdGhlIGdsb2JhbHMu CisgICAgICAgIAorICAgICAgICBBdG9taWNTdHJpbmc6OmluaXQoKTsKICAgICAgICAgbmV3ICgo dm9pZCopJmFueU5hbWUpIFF1YWxpZmllZE5hbWUobnVsbEF0b20sIHN0YXJBdG9tLCBzdGFyQXRv bSk7CiAgICAgICAgIGluaXRpYWxpemVkID0gdHJ1ZTsKICAgICB9CkluZGV4OiBXZWJDb3JlL2to dG1sL2h0bWwvaHRtbG5hbWVzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2todG1sL2h0bWwv aHRtbG5hbWVzLmNwcAkocmV2aXNpb24gMTMyNjEpCisrKyBXZWJDb3JlL2todG1sL2h0bWwvaHRt bG5hbWVzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDksNiArNDksNyBAQCB2b2lkIGluaXQoKQog ICAgIGlmICghaW5pdGlhbGl6ZWQpIHsKICAgICAgICAgLy8gVXNlIHBsYWNlbWVudCBuZXcgdG8g aW5pdGlhbGl6ZSB0aGUgZ2xvYmFscy4KIAorICAgICAgICBBdG9taWNTdHJpbmc6OmluaXQoKTsK ICAgICAgICAgQXRvbWljU3RyaW5nIHhodG1sTlMoImh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0 bWwiKTsKIAogICAgICAgICAvLyBOYW1lc3BhY2UKSW5kZXg6IFdlYkNvcmUva3N2ZzIvc2NyaXB0 cy9tYWtlX25hbWVzLnBsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUva3N2ZzIvc2NyaXB0cy9tYWtl X25hbWVzLnBsCShyZXZpc2lvbiAxMzI2MSkKKysrIFdlYkNvcmUva3N2ZzIvc2NyaXB0cy9tYWtl X25hbWVzLnBsCSh3b3JraW5nIGNvcHkpCkBAIC0yNzksNiArMjc5LDggQEAgcHJpbnQgInZvaWQg aW5pdCgpCiAgICAgaW5pdGlhbGl6ZWQgPSB0cnVlOwogICAgIAogICAgIC8vIFVzZSBwbGFjZW1l bnQgbmV3IHRvIGluaXRpYWxpemUgdGhlIGdsb2JhbHMuCisgICAgCisgICAgQXRvbWljU3RyaW5n Ojppbml0KCk7CiAiOwogCQogICAgIHByaW50KCIgICAgQXRvbWljU3RyaW5nICR7bG93ZXJOYW1l c3BhY2V9TlMoXCIkbmFtZXNwYWNlVVJJXCIpO1xuXG4iKTsK