77340 2012-01-30 08:24:23 -0800 Unexpected syntax error 2012-01-30 16:15:51 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac (Intel) OS X 10.7 RESOLVED FIXED P2 Normal --- 1 sander oliver ap barraclough bugs.webkit.org oliver zherczeg oldest_to_newest 545112 0 sander 2012-01-30 08:24:23 -0800 A single line of JS triggers a syntax error which I wouldn't expect since the code within the function is correct and should not be executed at all. > function a() { new x('x'+y).c = ''; } Results in a syntax error: > SyntaxError: Unexpected token '=' Upon removing variable y within this function, the syntax error magically disappears: > function a() { new x('x').c = ''; } Also reproducible in stable versions of Safari. Executing this code in Firefox / Chrome works just fine. 545113 1 124555 sander 2012-01-30 08:25:00 -0800 Created attachment 124555 Testcase 545334 2 barraclough 2012-01-30 13:05:13 -0800 Huh, interesting. I can repro the issue, looks like a bug. I think the spec defined parsing here may be odd (looks like this should evaluate as: new (x('x'+y).c) = '' and not: (new x('x'+y)).c = '' Very strange that removing the +y influences behavior. We have some caching of the parsing of very small functions, possible that this works correctly in the initial parse of the outer program, and fails on the reparse of the function body (and in the case without +y maybe the caching means we get to skip the reparse). 545353 3 oliver 2012-01-30 13:19:17 -0800 I have a fix, we weren't doing the correct logic when handling a 'new expr()' expression, so we end up thinking that we don't have a lhs element to assign to 545357 4 oliver 2012-01-30 13:22:07 -0800 Building on my Air, so i won't have patch for ~an hour 545359 5 zherczeg 2012-01-30 13:25:40 -0800 Oh those new expressions... I remember them. Parsing them is a nightmare. Btw 11.2 in Ecma-262 545366 6 oliver 2012-01-30 13:32:20 -0800 (In reply to comment #5) > Oh those new expressions... I remember them. Parsing them is a nightmare. Btw 11.2 in Ecma-262 This is a regression due to some strictness hardening i did (in terms of parser strictness, rather than "strict mode"), the fix is trivial, alas this machine is slow. /me wants someone to invent a 24 core processor that runs at 3ghz, produces no heat, and has ~30 hours of battery life. is that too much to ask? 545478 7 124613 oliver 2012-01-30 15:21:36 -0800 Created attachment 124613 Patch 545552 8 oliver 2012-01-30 16:15:51 -0800 Committed r106297: <http://trac.webkit.org/changeset/106297> 124555 2012-01-30 08:25:00 -0800 2012-01-30 08:25:00 -0800 Testcase index.html text/html 151 sander PGh0bWw+CjxoZWFkPgoJPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgoJCWZ1bmN0aW9u IGEoKSB7IG5ldyB4KCd4Jyt5KS5jID0gJyc7IH0KCgkJY29uc29sZS5sb2coJ3lheScpOwoJPC9z Y3JpcHQ+CjwvaGVhZD4KPGJvZHk+CjwvYm9keT4KPC9odG1sPg== 124613 2012-01-30 15:21:36 -0800 2012-01-30 15:40:41 -0800 Patch bug-77340-20120130152130.patch text/plain 6215 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi MGRiNWFhZmQyNzUyMWJhNzExZTgzNDJlZWI0ZmM5M2NhYWY3NDA2Li44OGU4ZWI4YzY1NTcyYjdj YTRiNGUwZTYwNjc0ZmNkZWJlYmYwZjQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMi0wMS0zMCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIFVuZXhwZWN0ZWQgc3ludGF4IGVycm9yCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzM0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZ1bmN0aW9uIGNhbGxzIGFuZCBuZXcgZXhwcmVzc2lv bnMgaGF2ZSB0aGUgc2FtZSBzZW1hbnRpY3MgZm9yCisgICAgICAgIGFzc2lnbm1lbnQsIHNvIHNo b3VsZCBzaW1wbHkgc2hhcmUgdGhlaXIgbGhzIGhhbmRsaW5nLgorCisgICAgICAgICogcGFyc2Vy L1BhcnNlci5jcHA6CisgICAgICAgIChKU0M6Ojo6cGFyc2VNZW1iZXJFeHByZXNzaW9uKToKKwog MjAxMi0wMS0zMCAgWW9uZyBMaSAgPHlvbGlAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJy eV0gT1MoUU5YKSBhbHNvIGhhcyBUTV9HTVRPRkYsIFRNX1pPTkUsIGFuZCBUSU1FR00KZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcAppbmRleCA0NzM2NjFjNmY1NTMzYTg4MDQ2 ZTFhZjBlZDU1MjdmZWFkODAzMzlkLi4yODY1MDkzMzAyOTQ1NjIxMjllMmU1ODAwOGJjYzQxMDBi YWFiNzhjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5j cHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCkBAIC0xNTEy LDIzICsxNTEyLDIwIEBAIHRlbXBsYXRlIDxjbGFzcyBUcmVlQnVpbGRlcj4gVHJlZUV4cHJlc3Np b24gUGFyc2VyPExleGVyVHlwZT46OnBhcnNlTWVtYmVyRXhwcmVzCiAgICAgICAgIH0KICAgICAg ICAgY2FzZSBPUEVOUEFSRU46IHsKICAgICAgICAgICAgIG1fbm9uVHJpdmlhbEV4cHJlc3Npb25D b3VudCsrOworICAgICAgICAgICAgaW50IG5vbkxIU0NvdW50ID0gbV9ub25MSFNDb3VudDsKICAg ICAgICAgICAgIGlmIChuZXdDb3VudCkgewogICAgICAgICAgICAgICAgIG5ld0NvdW50LS07Ci0g ICAgICAgICAgICAgICAgaWYgKG1hdGNoKE9QRU5QQVJFTikpIHsKLSAgICAgICAgICAgICAgICAg ICAgaW50IGV4cHJFbmQgPSBsYXN0VG9rZW5FbmQoKTsKLSAgICAgICAgICAgICAgICAgICAgVHJl ZUFyZ3VtZW50cyBhcmd1bWVudHMgPSBwYXJzZUFyZ3VtZW50cyhjb250ZXh0KTsKLSAgICAgICAg ICAgICAgICAgICAgZmFpbElmRmFsc2UoYXJndW1lbnRzKTsKLSAgICAgICAgICAgICAgICAgICAg YmFzZSA9IGNvbnRleHQuY3JlYXRlTmV3RXhwcihtX2xleGVyLT5sYXN0TGluZU51bWJlcigpLCBi YXNlLCBhcmd1bWVudHMsIHN0YXJ0LCBleHByRW5kLCBsYXN0VG9rZW5FbmQoKSk7Ci0gICAgICAg ICAgICAgICAgfSBlbHNlCi0gICAgICAgICAgICAgICAgICAgIGJhc2UgPSBjb250ZXh0LmNyZWF0 ZU5ld0V4cHIobV9sZXhlci0+bGFzdExpbmVOdW1iZXIoKSwgYmFzZSwgc3RhcnQsIGxhc3RUb2tl bkVuZCgpKTsgICAgICAgICAgICAgICAKKyAgICAgICAgICAgICAgICBpbnQgZXhwckVuZCA9IGxh c3RUb2tlbkVuZCgpOworICAgICAgICAgICAgICAgIFRyZWVBcmd1bWVudHMgYXJndW1lbnRzID0g cGFyc2VBcmd1bWVudHMoY29udGV4dCk7CisgICAgICAgICAgICAgICAgZmFpbElmRmFsc2UoYXJn dW1lbnRzKTsKKyAgICAgICAgICAgICAgICBiYXNlID0gY29udGV4dC5jcmVhdGVOZXdFeHByKG1f bGV4ZXItPmxhc3RMaW5lTnVtYmVyKCksIGJhc2UsIGFyZ3VtZW50cywgc3RhcnQsIGV4cHJFbmQs IGxhc3RUb2tlbkVuZCgpKTsgICAgICAgICAgIAogICAgICAgICAgICAgfSBlbHNlIHsKLSAgICAg ICAgICAgICAgICBpbnQgbm9uTEhTQ291bnQgPSBtX25vbkxIU0NvdW50OwogICAgICAgICAgICAg ICAgIGludCBleHByZXNzaW9uRW5kID0gbGFzdFRva2VuRW5kKCk7CiAgICAgICAgICAgICAgICAg VHJlZUFyZ3VtZW50cyBhcmd1bWVudHMgPSBwYXJzZUFyZ3VtZW50cyhjb250ZXh0KTsKICAgICAg ICAgICAgICAgICBmYWlsSWZGYWxzZShhcmd1bWVudHMpOwogICAgICAgICAgICAgICAgIGJhc2Ug PSBjb250ZXh0Lm1ha2VGdW5jdGlvbkNhbGxOb2RlKG1fbGV4ZXItPmxhc3RMaW5lTnVtYmVyKCks IGJhc2UsIGFyZ3VtZW50cywgZXhwcmVzc2lvblN0YXJ0LCBleHByZXNzaW9uRW5kLCBsYXN0VG9r ZW5FbmQoKSk7Ci0gICAgICAgICAgICAgICAgbV9ub25MSFNDb3VudCA9IG5vbkxIU0NvdW50Owog ICAgICAgICAgICAgfQorICAgICAgICAgICAgbV9ub25MSFNDb3VudCA9IG5vbkxIU0NvdW50Owog ICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KICAgICAgICAgY2FzZSBET1Q6IHsKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRl eCBiYTczM2E3OWM5NTIyN2ZhZTZkODA4NTM1MTQwOWI5MjAwN2FmYWJiLi40YmZlYTBmZjJiNTQx OGIxZDhjNGY2ODU2MDljNzE2NTVhMDllOGVhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTIt MDEtMzAgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KKworICAgICAgICBVbmV4cGVj dGVkIHN5bnRheCBlcnJvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NzczNDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGQgbmV3IHRlc3RzIGZvciBjb3JyZWN0IHBhcnNpbmcgb2YgbmV3IGV4cHJlc3Np b25zCisKKyAgICAgICAgKiBmYXN0L2pzL3BhcnNlci1zeW50YXgtY2hlY2stZXhwZWN0ZWQudHh0 OgorICAgICAgICAqIGZhc3QvanMvc2NyaXB0LXRlc3RzL3BhcnNlci1zeW50YXgtY2hlY2suanM6 CisgICAgICAgIChydW5UZXN0KToKKyAgICAgICAgKGludmFsaWQpOgorCiAyMDEyLTAxLTMwICBM ZXZpIFdlaW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2Vk IGdhcmRlbmluZy4gTWFya2luZyBmYXN0L2pzL2RmZy1pbnQzMmFycmF5LW92ZXJmbG93LXZhbHVl cy5odG1sIGFzIHNsb3cKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvanMvcGFyc2VyLXN5 bnRheC1jaGVjay1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2pzL3BhcnNlci1zeW50 YXgtY2hlY2stZXhwZWN0ZWQudHh0CmluZGV4IGQyOGVmMDlmZWM0ZmZmMTZlYTdhMmQ4Y2FhYzVk YzdhODNmNmQ3NzkuLjJkZDc2MjYyYjFjMzdjZWUxZGE1YWI5OTQzOGVlMzMwNDk4NjQ5ZmYgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvanMvcGFyc2VyLXN5bnRheC1jaGVjay1leHBlY3Rl ZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9qcy9wYXJzZXItc3ludGF4LWNoZWNrLWV4cGVj dGVkLnR4dApAQCAtNTY3LDYgKzU2NywxMCBAQCBQQVNTIFZhbGlkOiAgICJpZiAoMCkgb2JqLmZv b187ICIKIFBBU1MgVmFsaWQ6ICAgImZ1bmN0aW9uIGYoKSB7IGlmICgwKSBvYmouZm9vXzsgIH0i CiBQQVNTIFZhbGlkOiAgICJpZiAoMCkgb2JqLmZvb1x1MDNiYjsgIgogUEFTUyBWYWxpZDogICAi ZnVuY3Rpb24gZigpIHsgaWYgKDApIG9iai5mb29cdTAzYmI7ICB9IgorUEFTUyBWYWxpZDogICAi aWYgKDApIG5ldyBhKGIrYykuZCA9IDUiCitQQVNTIFZhbGlkOiAgICJmdW5jdGlvbiBmKCkgeyBp ZiAoMCkgbmV3IGEoYitjKS5kID0gNSB9IgorUEFTUyBWYWxpZDogICAiaWYgKDApIG5ldyBhKGIr YykgPSA1IgorUEFTUyBWYWxpZDogICAiZnVuY3Rpb24gZigpIHsgaWYgKDApIG5ldyBhKGIrYykg PSA1IH0iCiBQQVNTIGUubGluZSBpcyAxCiBQQVNTIGZvbyBpcyAnUEFTUycKIFBBU1MgYmFyIGlz ICdQQVNTJwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvcGFy c2VyLXN5bnRheC1jaGVjay5qcyBiL0xheW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0LXRlc3RzL3Bh cnNlci1zeW50YXgtY2hlY2suanMKaW5kZXggYWExNjBkY2Q5NjFmNTQ4MzQ0ZmNkMzk5ZjBjZTZk MDRhZGJhNjQ3NS4uNWZkNjkzNzE4MGNjNDdkOTA0MjQ5Yzc1YjViNGVlMWJlN2YzZjM5MCAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvcGFyc2VyLXN5bnRheC1j aGVjay5qcworKysgYi9MYXlvdXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9wYXJzZXItc3lu dGF4LWNoZWNrLmpzCkBAIC0yLDcgKzIsNyBAQCBkZXNjcmlwdGlvbigKICJUaGlzIHRlc3QgY2hl Y2tzIHRoYXQgdGhlIGZvbGxvd2luZyBleHByZXNzaW9ucyBvciBzdGF0ZW1lbnRzIGFyZSB2YWxp ZCBFQ01BU0NSSVBUIGNvZGUgb3Igc2hvdWxkIHRocm93IHBhcnNlIGVycm9yIgogKTsKIAotZnVu Y3Rpb24gcnVuVGVzdChfYSwgdGhyb3dzKQorZnVuY3Rpb24gcnVuVGVzdChfYSwgZXJyb3JUeXBl KQogewogICAgIHZhciBzdWNjZXNzOwogICAgIGlmICh0eXBlb2YgX2EgIT0gInN0cmluZyIpCkBA IC0xMywxNiArMTMsMTYgQEAgZnVuY3Rpb24gcnVuVGVzdChfYSwgdGhyb3dzKQogICAgIH0gY2F0 Y2ggKGUpIHsKICAgICAgICAgc3VjY2VzcyA9ICEoZSBpbnN0YW5jZW9mIFN5bnRheEVycm9yKTsK ICAgICB9Ci0gICAgaWYgKHRocm93cyA9PSAhc3VjY2VzcykgewotICAgICAgICBpZiAodGhyb3dz KQorICAgIGlmICgoISFlcnJvclR5cGUpID09ICFzdWNjZXNzKSB7CisgICAgICAgIGlmIChlcnJv clR5cGUpCiAgICAgICAgICAgICB0ZXN0UGFzc2VkKCdJbnZhbGlkOiAiJyArIF9hICsgJyInKTsK ICAgICAgICAgZWxzZQogICAgICAgICAgICAgdGVzdFBhc3NlZCgnVmFsaWQ6ICAgIicgKyBfYSAr ICciJyk7CiAgICAgfSBlbHNlIHsKLSAgICAgICAgaWYgKHRocm93cykKLSAgICAgICAgICAgIHRl c3RGYWlsZWQoJ0ludmFsaWQ6ICInICsgX2EgKyAnIiBzaG91bGQgdGhyb3cgU3ludGF4RXJyb3I6 IFBhcnNlIGVycm9yJyk7CisgICAgICAgIGlmIChlcnJvclR5cGUpCisgICAgICAgICAgICB0ZXN0 RmFpbGVkKCdJbnZhbGlkOiAiJyArIF9hICsgJyIgc2hvdWxkIHRocm93ICcgKyBlcnJvclR5cGUu bmFtZSk7CiAgICAgICAgIGVsc2UKLSAgICAgICAgICAgIHRlc3RGYWlsZWQoJ1ZhbGlkOiAgICIn ICsgX2EgKyAnIiBzaG91bGQgTk9UIHRocm93IFN5bnRheEVycm9yOiBQYXJzZSBlcnJvcicpOwor ICAgICAgICAgICAgdGVzdEZhaWxlZCgnVmFsaWQ6ICAgIicgKyBfYSArICciIHNob3VsZCBOT1Qg dGhyb3cgJyk7CiAgICAgfQogfQogCkBAIC0zMyw4ICszMyw5IEBAIGZ1bmN0aW9uIHZhbGlkKF9h KQogICAgIHJ1blRlc3QoImZ1bmN0aW9uIGYoKSB7ICIgKyBfYSArICIgfSIsIGZhbHNlKTsKIH0K IAotZnVuY3Rpb24gaW52YWxpZChfYSkKK2Z1bmN0aW9uIGludmFsaWQoX2EsIF90eXBlKQogewor ICAgIF90eXBlID0gX3R5cGUgfHwgU3ludGF4RXJyb3I7CiAgICAgLy8gVGVzdCBib3RoIHRoZSBn cmFtbWFyIGFuZCB0aGUgc3ludGF4IGNoZWNrZXIKICAgICBydW5UZXN0KF9hLCB0cnVlKTsKICAg ICBydW5UZXN0KCJmdW5jdGlvbiBmKCkgeyAiICsgX2EgKyAiIH0iLCB0cnVlKTsKQEAgLTM2MCw2 ICszNjEsOCBAQCB2YWxpZCgiaWYgKDApIG9iai5fZm9vOyAiKQogdmFsaWQoImlmICgwKSBvYmou Zm9vJDsgIikKIHZhbGlkKCJpZiAoMCkgb2JqLmZvb187ICIpCiB2YWxpZCgiaWYgKDApIG9iai5m b29cXHUwM2JiOyAiKQordmFsaWQoImlmICgwKSBuZXcgYShiK2MpLmQgPSA1Iik7Cit2YWxpZCgi aWYgKDApIG5ldyBhKGIrYykgPSA1Iik7CiAKIHRyeSB7IGV2YWwoImEuYi5jID0ge307Iik7IH0g Y2F0Y2goZTEpIHsgZT1lMTsgc2hvdWxkQmUoImUubGluZSIsICIxIikgfQogZm9vID0gJ0ZBSUwn Owo=