77334 2012-01-30 05:32:33 -0800 [chromium] MediaStream API: Fix a few memory leaks 2012-01-30 10:36:38 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 tommyw tommyw fishd webkit.review.bot oldest_to_newest 545040 0 tommyw 2012-01-30 05:32:33 -0800 It seems that either the behaviour of WebPrivatePtr has changed or I misunderstood something, but I fixed a memory leak in WebMediaStreamDescriptor and safeguarded WebMediaStreamSource. 545045 1 124535 tommyw 2012-01-30 05:35:56 -0800 Created attachment 124535 Patch 545048 2 webkit.review.bot 2012-01-30 05:37:38 -0800 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 545157 3 124535 fishd 2012-01-30 09:27:24 -0800 Comment on attachment 124535 Patch Sorry for not catching this in the initial code review! 545198 4 124535 webkit.review.bot 2012-01-30 10:36:33 -0800 Comment on attachment 124535 Patch Clearing flags on attachment: 124535 Committed r106256: <http://trac.webkit.org/changeset/106256> 545199 5 webkit.review.bot 2012-01-30 10:36:38 -0800 All reviewed patches have been landed. Closing bug. 124535 2012-01-30 05:35:56 -0800 2012-01-30 10:36:33 -0800 Patch bug-77334-20120130143555.patch text/plain 4479 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDJiN2E1NThmN2RjZGJhODUyZWE4MGU5NGVlZjBiY2E3Y2ZlZDA5NmYuLjgyYzVjNDNlMTc1NTFm NTI3MzZmNGM5NGI4NTRkNDU4NDgzYzgxNWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjYgQEAKKzIwMTItMDEtMzAgIFRvbW15IFdpZGVuZmx5Y2h0ICA8dG9tbXl3QGdv b2dsZS5jb20+CisKKyAgICAgICAgW2Nocm9taXVtXSBNZWRpYVN0cmVhbSBBUEk6IEZpeCBhIGZl dyBtZW1vcnkgbGVha3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTc3MzM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSXQgc2VlbXMgdGhhdCBlaXRoZXIgdGhlIGJlaGF2aW91ciBvZiBXZWJQcml2YXRlUHRy IGhhcyBjaGFuZ2VkIG9yIEkgbWlzdW5kZXJzdG9vZAorICAgICAgICBzb21ldGhpbmcsIGJ1dCBJ IGZpeGVkIGEgbWVtb3J5IGxlYWsgaW4gV2ViTWVkaWFTdHJlYW1EZXNjcmlwdG9yIGFuZCBzYWZl Z3VhcmRlZAorICAgICAgICBXZWJNZWRpYVN0cmVhbVNvdXJjZS4KKworICAgICAgICAqIHB1Ymxp Yy9wbGF0Zm9ybS9XZWJNZWRpYVN0cmVhbURlc2NyaXB0b3IuaDoKKyAgICAgICAgKFdlYktpdDo6 V2ViTWVkaWFTdHJlYW1EZXNjcmlwdG9yOjpXZWJNZWRpYVN0cmVhbURlc2NyaXB0b3IpOgorICAg ICAgICAqIHB1YmxpYy9wbGF0Zm9ybS9XZWJNZWRpYVN0cmVhbVNvdXJjZS5oOgorICAgICAgICAo V2ViS2l0OjpXZWJNZWRpYVN0cmVhbVNvdXJjZTo6V2ViTWVkaWFTdHJlYW1Tb3VyY2UpOgorICAg ICAgICAoV2ViS2l0OjpXZWJNZWRpYVN0cmVhbVNvdXJjZTo6b3BlcmF0b3I9KToKKyAgICAgICAg KFdlYk1lZGlhU3RyZWFtU291cmNlKToKKyAgICAgICAgKiBzcmMvV2ViTWVkaWFTdHJlYW1EZXNj cmlwdG9yLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViTWVkaWFTdHJlYW1EZXNjcmlwdG9yOjph c3NpZ24pOgorICAgICAgICAqIHNyYy9XZWJNZWRpYVN0cmVhbVNvdXJjZS5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYk1lZGlhU3RyZWFtU291cmNlOjphc3NpZ24pOgorICAgICAgICAoV2ViS2l0 KToKKwogMjAxMi0wMS0yNiAgSGFucyBXZW5uYm9yZyAgPGhhbnNAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFNwZWVjaCBJbnB1dDogbW92ZSBNb2NrU3BlZWNoSW5wdXRDbGllbnQgaW50byBDaHJv bWl1bSBEdW1wUmVuZGVyVHJlZSBpbXBsZW1lbnRhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvcGxhdGZvcm0vV2ViTWVkaWFTdHJlYW1EZXNjcmlwdG9yLmgg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9wbGF0Zm9ybS9XZWJNZWRpYVN0cmVhbURl c2NyaXB0b3IuaAppbmRleCBmYjllOGZmZjcyYTlkNDVmYzlhYmI5ZGE3ZmYyZmMwZGY5NTk3MDUz Li5mZjhiZDE5Y2I0NjBiYTgzZGU0MmRjYTAzMjk3NDVhYTA1Mjg5NTRlIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9wbGF0Zm9ybS9XZWJNZWRpYVN0cmVhbURlc2Ny aXB0b3IuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9wbGF0Zm9ybS9XZWJN ZWRpYVN0cmVhbURlc2NyaXB0b3IuaApAQCAtNDIsNyArNDIsNyBAQCBjbGFzcyBXZWJTdHJpbmc7 CiBjbGFzcyBXZWJNZWRpYVN0cmVhbURlc2NyaXB0b3IgewogcHVibGljOgogICAgIFdlYk1lZGlh U3RyZWFtRGVzY3JpcHRvcigpIHsgfQotICAgIFdlYk1lZGlhU3RyZWFtRGVzY3JpcHRvcihjb25z dCBXZWJNZWRpYVN0cmVhbURlc2NyaXB0b3ImIHJlcXVlc3QpIHsgYXNzaWduKHJlcXVlc3QpOyB9 CisgICAgV2ViTWVkaWFTdHJlYW1EZXNjcmlwdG9yKGNvbnN0IFdlYk1lZGlhU3RyZWFtRGVzY3Jp cHRvciYgb3RoZXIpIHsgYXNzaWduKG90aGVyKTsgfQogICAgIH5XZWJNZWRpYVN0cmVhbURlc2Ny aXB0b3IoKSB7IHJlc2V0KCk7IH0KIAogICAgIFdlYk1lZGlhU3RyZWFtRGVzY3JpcHRvciYgb3Bl cmF0b3I9KGNvbnN0IFdlYk1lZGlhU3RyZWFtRGVzY3JpcHRvciYgb3RoZXIpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9wbGF0Zm9ybS9XZWJNZWRpYVN0cmVhbVNv dXJjZS5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvcGxhdGZvcm0vV2ViTWVkaWFT dHJlYW1Tb3VyY2UuaAppbmRleCBiNjVlOTk2YmQ2YjVhNTQ3YTEwMjgzNTE0NTU3YjQ3YzlkMzRh MmY2Li4xNDJkNTk4NjZlNmFjODU4MmMyNDkzODJkMTU3ZGQ1NmI1ZjhkNzY3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9wbGF0Zm9ybS9XZWJNZWRpYVN0cmVhbVNv dXJjZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL3BsYXRmb3JtL1dlYk1l ZGlhU3RyZWFtU291cmNlLmgKQEAgLTUxLDggKzUxLDE3IEBAIHB1YmxpYzoKICAgICB9OwogCiAg ICAgV2ViTWVkaWFTdHJlYW1Tb3VyY2UoKSB7IH0KKyAgICBXZWJNZWRpYVN0cmVhbVNvdXJjZShj b25zdCBXZWJNZWRpYVN0cmVhbVNvdXJjZSYgb3RoZXIpIHsgYXNzaWduKG90aGVyKTsgfQogICAg IH5XZWJNZWRpYVN0cmVhbVNvdXJjZSgpIHsgcmVzZXQoKTsgfQogCisgICAgV2ViTWVkaWFTdHJl YW1Tb3VyY2UmIG9wZXJhdG9yPShjb25zdCBXZWJNZWRpYVN0cmVhbVNvdXJjZSYgb3RoZXIpCisg ICAgeworICAgICAgICBhc3NpZ24ob3RoZXIpOworICAgICAgICByZXR1cm4gKnRoaXM7CisgICAg fQorCisgICAgV0VCS0lUX0VYUE9SVCB2b2lkIGFzc2lnbihjb25zdCBXZWJNZWRpYVN0cmVhbVNv dXJjZSYpOworCiAgICAgV0VCS0lUX0VYUE9SVCB2b2lkIGluaXRpYWxpemUoY29uc3QgV2ViU3Ry aW5nJiBpZCwgVHlwZSwgY29uc3QgV2ViU3RyaW5nJiBuYW1lKTsKICAgICBXRUJLSVRfRVhQT1JU IHZvaWQgcmVzZXQoKTsKICAgICBib29sIGlzTnVsbCgpIGNvbnN0IHsgcmV0dXJuIG1fcHJpdmF0 ZS5pc051bGwoKTsgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi TWVkaWFTdHJlYW1EZXNjcmlwdG9yLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl Yk1lZGlhU3RyZWFtRGVzY3JpcHRvci5jcHAKaW5kZXggNzgzMTFhZGFjNjMyMTY4MDc1NmE5Yzc4 NTMwNWViMTEwYTdkZmY4OS4uN2RhZjMyOWU1MjU1ZGQ3NDQ0YmJkMzlkMGViOGUyMGJmNjMyNDI0 ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTWVkaWFTdHJlYW1E ZXNjcmlwdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVN0 cmVhbURlc2NyaXB0b3IuY3BwCkBAIC0xMzgsMTAgKzEzOCw3IEBAIHZvaWQgV2ViTWVkaWFTdHJl YW1EZXNjcmlwdG9yOjppbml0aWFsaXplKGNvbnN0IFdlYlN0cmluZyYgbGFiZWwsIGNvbnN0IFdl YlZlY3RvCiAKIHZvaWQgV2ViTWVkaWFTdHJlYW1EZXNjcmlwdG9yOjphc3NpZ24oY29uc3QgV2Vi TWVkaWFTdHJlYW1EZXNjcmlwdG9yJiBvdGhlcikKIHsKLSAgICBNZWRpYVN0cmVhbURlc2NyaXB0 b3IqIHAgPSBvdGhlci5tX3ByaXZhdGUuZ2V0KCk7Ci0gICAgaWYgKHApCi0gICAgICAgIHAtPnJl ZigpOwotICAgIG1fcHJpdmF0ZSA9IHA7CisgICAgbV9wcml2YXRlID0gb3RoZXIubV9wcml2YXRl OwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYk1lZGlhU3RyZWFtU291cmNlLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYk1lZGlhU3RyZWFtU291cmNlLmNwcAppbmRleCBmZTgyNmYxOGJlM2U0NTFi YTdmYjk1NmFhMDAyOWY4MjI3Y2M1OWNhLi5hOWZhYzRiMDYwMWI3ZGVmZDkwMTVkZmM0OGVmODNi NDZkNTkzOGQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJNZWRp YVN0cmVhbVNvdXJjZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTWVk aWFTdHJlYW1Tb3VyY2UuY3BwCkBAIC01Myw2ICs1MywxMSBAQCBXZWJNZWRpYVN0cmVhbVNvdXJj ZSYgV2ViTWVkaWFTdHJlYW1Tb3VyY2U6Om9wZXJhdG9yPShXZWJDb3JlOjpNZWRpYVN0cmVhbVNv dXJjZQogICAgIHJldHVybiAqdGhpczsKIH0KIAordm9pZCBXZWJNZWRpYVN0cmVhbVNvdXJjZTo6 YXNzaWduKGNvbnN0IFdlYk1lZGlhU3RyZWFtU291cmNlJiBvdGhlcikKK3sKKyAgICBtX3ByaXZh dGUgPSBvdGhlci5tX3ByaXZhdGU7Cit9CisKIHZvaWQgV2ViTWVkaWFTdHJlYW1Tb3VyY2U6OnJl c2V0KCkKIHsKICAgICBtX3ByaXZhdGUucmVzZXQoKTsK