77332 2012-01-30 05:06:18 -0800 Node::parentOrHostElement(): Node::shadowHost() already returns an Element* 2012-01-30 07:19:24 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rolandsteiner rolandsteiner dglazkov morrita webkit.review.bot oldest_to_newest 545026 0 rolandsteiner 2012-01-30 05:06:18 -0800 In Node::parentOrHostElement(), the call to shadowHost() can only return an Element*, or 0. In the former case, the following test is unnecessary, while in the 0 case (if that should ever occur) it would crash. 545027 1 124526 rolandsteiner 2012-01-30 05:08:17 -0800 Created attachment 124526 Patch 545054 2 124526 tkent 2012-01-30 05:56:27 -0800 Comment on attachment 124526 Patch ok 545081 3 124526 webkit.review.bot 2012-01-30 07:19:19 -0800 Comment on attachment 124526 Patch Clearing flags on attachment: 124526 Committed r106242: <http://trac.webkit.org/changeset/106242> 545082 4 webkit.review.bot 2012-01-30 07:19:24 -0800 All reviewed patches have been landed. Closing bug. 124526 2012-01-30 05:08:17 -0800 2012-01-30 07:19:19 -0800 Patch bug-77332-20120130220815.patch text/plain 1240 rolandsteiner U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MjAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWQ0MjYxN2UzZGNkYWJj YWRkNGUwM2NjZjI0ZDVmYTU2ZmNjYThjOS4uM2QxNzFiNzNjODk0NzIyMmVkMGE0ZmRmMWIzYWIx YjAxN2I3ZmVhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAxLTMwICBSb2xh bmQgU3RlaW5lciAgPHJvbGFuZHN0ZWluZXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIE5vZGU6 OnBhcmVudE9ySG9zdEVsZW1lbnQoKTogTm9kZTo6c2hhZG93SG9zdCgpIGFscmVhZHkgcmV0dXJu cyBhbiBFbGVtZW50KgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzczMzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBObyBuZXcgdGVzdHMuIChzaW1wbGUgcmVmYWN0b3JpbmcpCisKKyAgICAgICAgKiBkb20v Tm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOb2RlOjpwYXJlbnRPckhvc3RFbGVtZW50KToK KwogMjAxMi0wMS0yOSAgTm9lbCBHb3Jkb24gIDxub2VsLmdvcmRvbkBnbWFpbC5jb20+CiAKICAg ICAgICAgW2Nocm9taXVtXSBVc2UgZGVjb2Rpbmcgc3dpenpsZSBvbmx5IG9uIGxpYmpwZWctdHVy Ym8gMS4xLjkwKwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwIGIvU291 cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCmluZGV4IDQxOWY3YjUxYzg5YTZiZjk4NzhlNTk0Yjgy MGMyMDYzZWRmNWQxYWEuLmMxM2MyYjA1NzAzNGEzMDNlMzA2M2I3YTUyNDU1NGI2YmJkZjMyNDEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vTm9kZS5jcHAKQEAgLTE1NDcsNyArMTU0Nyw3IEBAIEVsZW1lbnQqIE5vZGU6OnBh cmVudE9ySG9zdEVsZW1lbnQoKSBjb25zdAogICAgICAgICByZXR1cm4gMDsKIAogICAgIGlmIChw YXJlbnQtPmlzU2hhZG93Um9vdCgpKQotICAgICAgICBwYXJlbnQgPSBwYXJlbnQtPnNoYWRvd0hv c3QoKTsKKyAgICAgICAgcmV0dXJuIHBhcmVudC0+c2hhZG93SG9zdCgpOwogCiAgICAgaWYgKCFw YXJlbnQtPmlzRWxlbWVudE5vZGUoKSkKICAgICAgICAgcmV0dXJuIDA7Cg==