77326 2012-01-30 04:04:50 -0800 Web Inspector: keyboard navigation through comparison view in heap profiler should update retainers view 2012-01-30 08:17:27 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 yurys yurys apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 544996 0 yurys 2012-01-30 04:04:50 -0800 Currently it is only updated when I click on corresponding line. 545056 1 124538 yurys 2012-01-30 05:59:34 -0800 Created attachment 124538 Patch 545105 2 124538 pfeldman 2012-01-30 08:07:01 -0800 Comment on attachment 124538 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124538&action=review > Source/WebCore/inspector/front-end/DataGrid.js:1473 > this.dispatchEventToListeners("selected"); It seems strange that you introduce SelectedNode event beside the "selected" one. 545108 3 yurys 2012-01-30 08:17:27 -0800 Committed r106245: <http://trac.webkit.org/changeset/106245> 124538 2012-01-30 05:59:34 -0800 2012-01-30 08:07:01 -0800 Patch bug-77326-20120130175932.patch text/plain 6898 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzNmYzg3MTUyNTE0ZTA0 MmYxNjRiNWYwZjQxNjY5YjY3NWIxZWNmNi4uMzBmNjM1MTU4NDMzNWMwOGJmZTc0MjQwY2VkNmRi ZjRkMjYwMjNkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEyLTAxLTMwICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGtleWJvYXJkIG5hdmlnYXRpb24gdGhyb3VnaCBjb21wYXJpc29uIHZpZXcgaW4gaGVhcCBw cm9maWxlciBzaG91bGQgdXBkYXRlIHJldGFpbmVycyB2aWV3CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzMyNgorCisgICAgICAgIEtleWJvYXJkIG5h dmlnYXRpb24gaW4gdGhlIGRldGFpbGVkIGhlYXAgc25hcHNob3QgdmlldyBub3cgdXBkYXRlcyBy ZXRhaW5lcnMgdmlldy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRGF0YUdyaWQuanM6IEFkZGVkIFNlbGVjdGVk Tm9kZS9EZXNsZWN0ZWROb2RlIGV2ZW50cyB0byBEYXRhR3JpZC4KKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5EYXRhR3JpZE5vZGUucHJvdG90eXBlLnNlbGVjdCk6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuRGF0YUdyaWROb2RlLnByb3RvdHlwZS5kZXNlbGVjdCk6CisgICAgICAgICogaW5zcGVjdG9y L2Zyb250LWVuZC9EZXRhaWxlZEhlYXBzaG90Vmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5EZXRhaWxlZEhlYXBzaG90Vmlldy5wcm90b3R5cGUuX3NlbGVjdGlvbkNoYW5nZWQpOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLkRldGFpbGVkSGVhcHNob3RWaWV3LnByb3RvdHlwZS5fc2V0UmV0 YWlubWVudERhdGFHcmlkU291cmNlKToKKworMjAxMi0wMS0zMCAgWXVyeSBTZW1pa2hhdHNreSAg PHl1cnlzQGNocm9taXVtLm9yZz4KKwogICAgICAgICBVbnJldmlld2VkLiBDbGFuZyBidWlsZCBm aXggYWZ0ZXIgcjEwNjIxOAogCiAgICAgICAgICogaW5zcGVjdG9yL0NvZGVHZW5lcmF0b3JJbnNw ZWN0b3IucHk6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0RhdGFHcmlkLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EYXRhR3Jp ZC5qcwppbmRleCBmNWEyMWY5NzhjMGRjZGJhYWQwNDZkYTRkZDdhMjBkMzYwMTVmYTMyLi4wMzZj YjRmZmJjOTI5ZGMxNzgzYzExMWVhMzg1N2FjZDkzOTgyZTI0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RhdGFHcmlkLmpzCisrKyBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGF0YUdyaWQuanMKQEAgLTE2Miw2ICsxNjIsMTEgQEAg V2ViSW5zcGVjdG9yLkRhdGFHcmlkID0gZnVuY3Rpb24oY29sdW1ucywgZWRpdENhbGxiYWNrLCBk ZWxldGVDYWxsYmFjaykKICAgICB0aGlzLl9jb2x1bW5XaWR0aHNJbml0aWFsaXplZCA9IGZhbHNl OwogfQogCitXZWJJbnNwZWN0b3IuRGF0YUdyaWQuRXZlbnRzID0geworICAgIFNlbGVjdGVkTm9k ZTogIlNlbGVjdGVkTm9kZSIsCisgICAgRGVzZWxlY3RlZE5vZGU6ICJEZXNlbGVjdGVkTm9kZSIK K30KKwogLyoqCiAgKiBAcGFyYW0ge0FycmF5LjxzdHJpbmc+fSBjb2x1bW5OYW1lcwogICogQHBh cmFtIHtBcnJheS48c3RyaW5nPn0gdmFsdWVzCkBAIC0xNDY0LDggKzE0NjksMTAgQEAgV2ViSW5z cGVjdG9yLkRhdGFHcmlkTm9kZS5wcm90b3R5cGUgPSB7CiAgICAgICAgIGlmICh0aGlzLl9lbGVt ZW50KQogICAgICAgICAgICAgdGhpcy5fZWxlbWVudC5hZGRTdHlsZUNsYXNzKCJzZWxlY3RlZCIp OwogCi0gICAgICAgIGlmICghc3VwcmVzc1NlbGVjdGVkRXZlbnQpCisgICAgICAgIGlmICghc3Vw cmVzc1NlbGVjdGVkRXZlbnQpIHsKICAgICAgICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlz dGVuZXJzKCJzZWxlY3RlZCIpOworICAgICAgICAgICAgdGhpcy5kYXRhR3JpZC5kaXNwYXRjaEV2 ZW50VG9MaXN0ZW5lcnMoV2ViSW5zcGVjdG9yLkRhdGFHcmlkLkV2ZW50cy5TZWxlY3RlZE5vZGUp OworICAgICAgICB9CiAgICAgfSwKIAogICAgIHJldmVhbEFuZFNlbGVjdDogZnVuY3Rpb24oKQpA QCAtMTQ4OCw4ICsxNDk1LDEwIEBAIFdlYkluc3BlY3Rvci5EYXRhR3JpZE5vZGUucHJvdG90eXBl ID0gewogICAgICAgICBpZiAodGhpcy5fZWxlbWVudCkKICAgICAgICAgICAgIHRoaXMuX2VsZW1l bnQucmVtb3ZlU3R5bGVDbGFzcygic2VsZWN0ZWQiKTsKIAotICAgICAgICBpZiAoIXN1cHJlc3NE ZXNlbGVjdGVkRXZlbnQpCisgICAgICAgIGlmICghc3VwcmVzc0Rlc2VsZWN0ZWRFdmVudCkgewog ICAgICAgICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoImRlc2VsZWN0ZWQiKTsK KyAgICAgICAgICAgIHRoaXMuZGF0YUdyaWQuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYklu c3BlY3Rvci5EYXRhR3JpZC5FdmVudHMuRGVzZWxlY3RlZE5vZGUpOworICAgICAgICB9CiAgICAg fSwKIAogICAgIHRyYXZlcnNlTmV4dE5vZGU6IGZ1bmN0aW9uKHNraXBIaWRkZW4sIHN0YXlXaXRo aW4sIGRvbnRQb3B1bGF0ZSwgaW5mbykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvRGV0YWlsZWRIZWFwc2hvdFZpZXcuanMgYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0RldGFpbGVkSGVhcHNob3RWaWV3LmpzCmluZGV4IGE4ODY5ZGFl MjdlODkxNGEwNDY4MDMyOGU3ZWM3ZTZjNmZkMDBjZWUuLmJkYmRhNmFhNmVkYmMxMjVlZDYwZDU0 MjRjZWZmYzliOTliODM2NzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvRGV0YWlsZWRIZWFwc2hvdFZpZXcuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9EZXRhaWxlZEhlYXBzaG90Vmlldy5qcwpAQCAtNDI5LDI5ICs0Mjks MjkgQEAgV2ViSW5zcGVjdG9yLkRldGFpbGVkSGVhcHNob3RWaWV3ID0gZnVuY3Rpb24ocGFyZW50 LCBwcm9maWxlKQogICAgIHRoaXMuY29udGFpbm1lbnRWaWV3ID0gbmV3IFdlYkluc3BlY3Rvci5W aWV3KCk7CiAgICAgdGhpcy5jb250YWlubWVudFZpZXcuZWxlbWVudC5hZGRTdHlsZUNsYXNzKCJ2 aWV3Iik7CiAgICAgdGhpcy5jb250YWlubWVudERhdGFHcmlkID0gbmV3IFdlYkluc3BlY3Rvci5I ZWFwU25hcHNob3RDb250YWlubWVudERhdGFHcmlkKCk7Ci0gICAgdGhpcy5jb250YWlubWVudERh dGFHcmlkLmVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCB0aGlzLl9tb3VzZUNsaWNr SW5Db250ZW50c0dyaWQuYmluZCh0aGlzKSwgdHJ1ZSk7CiAgICAgdGhpcy5jb250YWlubWVudERh dGFHcmlkLmVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigibW91c2Vkb3duIiwgdGhpcy5fbW91c2VE b3duSW5Db250ZW50c0dyaWQuYmluZCh0aGlzKSwgdHJ1ZSk7CiAgICAgdGhpcy5jb250YWlubWVu dERhdGFHcmlkLnNob3codGhpcy5jb250YWlubWVudFZpZXcuZWxlbWVudCk7CisgICAgdGhpcy5j b250YWlubWVudERhdGFHcmlkLmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLkRhdGFHcmlk LkV2ZW50cy5TZWxlY3RlZE5vZGUsIHRoaXMuX3NlbGVjdGlvbkNoYW5nZWQsIHRoaXMpOwogCiAg ICAgdGhpcy5jb25zdHJ1Y3RvcnNWaWV3ID0gbmV3IFdlYkluc3BlY3Rvci5WaWV3KCk7CiAgICAg dGhpcy5jb25zdHJ1Y3RvcnNWaWV3LmVsZW1lbnQuYWRkU3R5bGVDbGFzcygidmlldyIpOwogICAg IHRoaXMuY29uc3RydWN0b3JzRGF0YUdyaWQgPSBuZXcgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hv dENvbnN0cnVjdG9yc0RhdGFHcmlkKCk7Ci0gICAgdGhpcy5jb25zdHJ1Y3RvcnNEYXRhR3JpZC5l bGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgdGhpcy5fbW91c2VDbGlja0luQ29udGVu dHNHcmlkLmJpbmQodGhpcyksIHRydWUpOwogICAgIHRoaXMuY29uc3RydWN0b3JzRGF0YUdyaWQu ZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJtb3VzZWRvd24iLCB0aGlzLl9tb3VzZURvd25JbkNv bnRlbnRzR3JpZC5iaW5kKHRoaXMpLCB0cnVlKTsKICAgICB0aGlzLmNvbnN0cnVjdG9yc0RhdGFH cmlkLnNob3codGhpcy5jb25zdHJ1Y3RvcnNWaWV3LmVsZW1lbnQpOworICAgIHRoaXMuY29uc3Ry dWN0b3JzRGF0YUdyaWQuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuRGF0YUdyaWQuRXZl bnRzLlNlbGVjdGVkTm9kZSwgdGhpcy5fc2VsZWN0aW9uQ2hhbmdlZCwgdGhpcyk7CiAKICAgICB0 aGlzLmRpZmZWaWV3ID0gbmV3IFdlYkluc3BlY3Rvci5WaWV3KCk7CiAgICAgdGhpcy5kaWZmVmll dy5lbGVtZW50LmFkZFN0eWxlQ2xhc3MoInZpZXciKTsKICAgICB0aGlzLmRpZmZEYXRhR3JpZCA9 IG5ldyBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90RGlmZkRhdGFHcmlkKCk7Ci0gICAgdGhpcy5k aWZmRGF0YUdyaWQuZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIHRoaXMuX21vdXNl Q2xpY2tJbkNvbnRlbnRzR3JpZC5iaW5kKHRoaXMpLCB0cnVlKTsKICAgICB0aGlzLmRpZmZEYXRh R3JpZC5zaG93KHRoaXMuZGlmZlZpZXcuZWxlbWVudCk7CisgICAgdGhpcy5kaWZmRGF0YUdyaWQu YWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuRGF0YUdyaWQuRXZlbnRzLlNlbGVjdGVkTm9k ZSwgdGhpcy5fc2VsZWN0aW9uQ2hhbmdlZCwgdGhpcyk7CiAKICAgICB0aGlzLmRvbWluYXRvclZp ZXcgPSBuZXcgV2ViSW5zcGVjdG9yLlZpZXcoKTsKICAgICB0aGlzLmRvbWluYXRvclZpZXcuZWxl bWVudC5hZGRTdHlsZUNsYXNzKCJ2aWV3Iik7CiAgICAgdGhpcy5kb21pbmF0b3JEYXRhR3JpZCA9 IG5ldyBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90RG9taW5hdG9yc0RhdGFHcmlkKCk7Ci0gICAg dGhpcy5kb21pbmF0b3JEYXRhR3JpZC5lbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwg dGhpcy5fbW91c2VDbGlja0luQ29udGVudHNHcmlkLmJpbmQodGhpcyksIHRydWUpOwogICAgIHRo aXMuZG9taW5hdG9yRGF0YUdyaWQuZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJtb3VzZWRvd24i LCB0aGlzLl9tb3VzZURvd25JbkNvbnRlbnRzR3JpZC5iaW5kKHRoaXMpLCB0cnVlKTsKICAgICB0 aGlzLmRvbWluYXRvckRhdGFHcmlkLnNob3codGhpcy5kb21pbmF0b3JWaWV3LmVsZW1lbnQpOwor ICAgIHRoaXMuZG9taW5hdG9yRGF0YUdyaWQuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3Iu RGF0YUdyaWQuRXZlbnRzLlNlbGVjdGVkTm9kZSwgdGhpcy5fc2VsZWN0aW9uQ2hhbmdlZCwgdGhp cyk7CiAKICAgICB0aGlzLnJldGFpbm1lbnRWaWV3SGVhZGVyID0gZG9jdW1lbnQuY3JlYXRlRWxl bWVudCgiZGl2Iik7CiAgICAgdGhpcy5yZXRhaW5tZW50Vmlld0hlYWRlci5hZGRTdHlsZUNsYXNz KCJyZXRhaW5lcnMtdmlldy1oZWFkZXIiKTsKQEAgLTgwOSwxOCArODA5LDE1IEBAIFdlYkluc3Bl Y3Rvci5EZXRhaWxlZEhlYXBzaG90Vmlldy5wcm90b3R5cGUgPSB7CiAgICAgICAgIHByb2ZpbGUu c2lkZWJhckVsZW1lbnQuc3VidGl0bGUgPSBOdW1iZXIuYnl0ZXNUb1N0cmluZyhzLnRvdGFsU2l6 ZSk7CiAgICAgfSwKIAotICAgIF9tb3VzZUNsaWNrSW5Db250ZW50c0dyaWQ6IGZ1bmN0aW9uKGV2 ZW50KQorICAgIF9zZWxlY3Rpb25DaGFuZ2VkOiBmdW5jdGlvbihldmVudCkKICAgICB7Ci0gICAg ICAgIHZhciBjZWxsID0gZXZlbnQudGFyZ2V0LmVuY2xvc2luZ05vZGVPclNlbGZXaXRoTm9kZU5h bWUoInRkIik7Ci0gICAgICAgIGlmICghY2VsbCB8fCAoIWNlbGwuaGFzU3R5bGVDbGFzcygib2Jq ZWN0LWNvbHVtbiIpKSkKLSAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgdmFyIHJvdyA9IGV2 ZW50LnRhcmdldC5lbmNsb3NpbmdOb2RlT3JTZWxmV2l0aE5vZGVOYW1lKCJ0ciIpOwotICAgICAg ICBpZiAoIXJvdykKLSAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgdmFyIG5vZGVJdGVtID0g cm93Ll9kYXRhR3JpZE5vZGU7Ci0gICAgICAgIGlmICghbm9kZUl0ZW0gfHwgbm9kZUl0ZW0uaXNF dmVudFdpdGhpbkRpc2Nsb3N1cmVUcmlhbmdsZShldmVudCkpCi0gICAgICAgICAgICByZXR1cm47 Ci0gICAgICAgIGlmIChub2RlSXRlbS5zbmFwc2hvdE5vZGVJbmRleCkKKyAgICAgICAgdmFyIHNl bGVjdGVkTm9kZSA9IGV2ZW50LnRhcmdldC5zZWxlY3RlZE5vZGU7CisgICAgICAgIHRoaXMuX3Nl dFJldGFpbm1lbnREYXRhR3JpZFNvdXJjZShzZWxlY3RlZE5vZGUpOworICAgIH0sCisKKyAgICBf c2V0UmV0YWlubWVudERhdGFHcmlkU291cmNlOiBmdW5jdGlvbihub2RlSXRlbSkKKyAgICB7Cisg ICAgICAgIGlmIChub2RlSXRlbSAmJiBub2RlSXRlbS5zbmFwc2hvdE5vZGVJbmRleCkKICAgICAg ICAgICAgIHRoaXMucmV0YWlubWVudERhdGFHcmlkLnNldERhdGFTb3VyY2UodGhpcywgbm9kZUl0 ZW0uaXNEZWxldGVkTm9kZSA/IG5vZGVJdGVtLmRhdGFHcmlkLmJhc2VTbmFwc2hvdCA6IG5vZGVJ dGVtLmRhdGFHcmlkLnNuYXBzaG90LCBub2RlSXRlbS5zbmFwc2hvdE5vZGVJbmRleCwgbm9kZUl0 ZW0uaXNEZWxldGVkTm9kZSA/IHRoaXMuYmFzZVNlbGVjdEVsZW1lbnQuY2hpbGROb2Rlc1t0aGlz LmJhc2VTZWxlY3RFbGVtZW50LnNlbGVjdGVkSW5kZXhdLmxhYmVsICsgIiB8ICIgOiAiIik7CiAg ICAgICAgIGVsc2UKICAgICAgICAgICAgIHRoaXMucmV0YWlubWVudERhdGFHcmlkLnJlc2V0KCk7 Cg==