77321 2012-01-30 01:15:34 -0800 Web Inspector: Change Open Resource and Go To function shortcuts in scripts panel. 2012-01-30 05:03:19 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 544929 0 vsevik 2012-01-30 01:15:34 -0800 Currently we have: - Open Resource = Ctrl/Cmd + Shift + T - Go To Function = Ctrl/Cmd + O Ctrl/Cmd + Shift + T looks bad because - it conflicts with reopen last closed tab (at least in chrome on mac) - it is needed more often then go to function, the shortcut should be shorter. Suggested: - Open Resource = Ctrl/Cmd + O - Go To Function = Ctrl/Cmd + Shift + O 544930 1 124506 vsevik 2012-01-30 01:16:38 -0800 Created attachment 124506 Patch 545023 2 vsevik 2012-01-30 05:03:19 -0800 Committed r106236: <http://trac.webkit.org/changeset/106236> 124506 2012-01-30 01:16:38 -0800 2012-01-30 04:44:05 -0800 Patch bug-77321-20120130131636.patch text/plain 3688 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTE3YWRmYmY5OTEzMWMw ZWZiNDM2YWYyMGVhYzU4Y2M5NWE0MDBhNi4uYzA2NjE1YTZmMjdjMzMzOGJkZTBhZmI3NDg4ODk1 OWU1MjE5YTJmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAxLTMwICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IENoYW5nZSBPcGVuIFJlc291cmNlIGFuZCBHbyBUbyBmdW5jdGlvbiBzaG9ydGN1dHMgaW4g c2NyaXB0cyBwYW5lbC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTc3MzIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0ZpbHRlcmVkSXRlbVNlbGVjdGlvbkRpYWxvZy5q czoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5KYXZhU2NyaXB0T3V0bGluZURpYWxvZy5jcmVhdGVT aG9ydGN1dCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuT3BlblJlc291cmNlRGlhbG9nLmNyZWF0 ZVNob3J0Y3V0KToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5q czoKKwogMjAxMi0wMS0yOSAgWm9sdGFuIEhlcmN6ZWcgIDx6aGVyY3plZ0B3ZWJraXQub3JnPgog CiAgICAgICAgIEN1c3RvbSB3cml0dGVuIENTUyBsZXhlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9GaWx0ZXJlZEl0ZW1TZWxlY3Rpb25EaWFsb2cuanMg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0ZpbHRlcmVkSXRlbVNlbGVjdGlv bkRpYWxvZy5qcwppbmRleCA4M2MwMzY0NDQxMGRlMDZiMGNlNTliNzg4OTY2MjY3NTkxY2VkYjM3 Li5mMDBlMTVjODVmYjdkMDAyOGM3ZjBhOTEzYzBjZDExYjlmZGRjOWFlIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0ZpbHRlcmVkSXRlbVNlbGVjdGlvbkRp YWxvZy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0ZpbHRlcmVk SXRlbVNlbGVjdGlvbkRpYWxvZy5qcwpAQCAtNTE1LDcgKzUxNSw3IEBAIFdlYkluc3BlY3Rvci5K YXZhU2NyaXB0T3V0bGluZURpYWxvZy5fc2hvdyA9IGZ1bmN0aW9uKHBhbmVsLCBzb3VyY2VWaWV3 KQogCiBXZWJJbnNwZWN0b3IuSmF2YVNjcmlwdE91dGxpbmVEaWFsb2cuY3JlYXRlU2hvcnRjdXQg PSBmdW5jdGlvbigpCiB7Ci0gICAgcmV0dXJuIFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0 Lm1ha2VEZXNjcmlwdG9yKCJvIiwgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZp ZXJzLkN0cmxPck1ldGEpOworICAgIHJldHVybiBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1 dC5tYWtlRGVzY3JpcHRvcigibyIsIFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlm aWVycy5DdHJsT3JNZXRhIHwgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXJz LlNoaWZ0KTsKIH0KIAogV2ViSW5zcGVjdG9yLkphdmFTY3JpcHRPdXRsaW5lRGlhbG9nLnByb3Rv dHlwZSA9IHsKQEAgLTYzNiw3ICs2MzYsNyBAQCBXZWJJbnNwZWN0b3IuT3BlblJlc291cmNlRGlh bG9nLl9zaG93ID0gZnVuY3Rpb24ocGFuZWwsIHByZXNlbnRhdGlvbk1vZGVsLCByZWxhdAogCiBX ZWJJbnNwZWN0b3IuT3BlblJlc291cmNlRGlhbG9nLmNyZWF0ZVNob3J0Y3V0ID0gZnVuY3Rpb24o KQogewotICAgIHJldHVybiBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5tYWtlRGVzY3Jp cHRvcigidCIsIFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVycy5DdHJsT3JN ZXRhIHwgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXJzLlNoaWZ0KTsKKyAg ICByZXR1cm4gV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQubWFrZURlc2NyaXB0b3IoIm8i LCBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllcnMuQ3RybE9yTWV0YSk7CiB9 CiAKIFdlYkluc3BlY3Rvci5PcGVuUmVzb3VyY2VEaWFsb2cucHJvdG90eXBlID0gewpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcwppbmRl eCBhNDI5ZjU2MTRjMmI3YWQyYzE3NGExZjM2ZDY5NDE5ZThjYzc3MmE0Li5mZTBmZGE5NGYxNDJj MDQ5MjcxNDVkZmQ2OGQ5NjgxNjUzMWQ1MjRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcwpAQCAtMTMxLDEyICsxMzEsMTIgQEAg V2ViSW5zcGVjdG9yLlNjcmlwdHNQYW5lbCA9IGZ1bmN0aW9uKHByZXNlbnRhdGlvbk1vZGVsKQog ICAgIGhlbHBTZWN0aW9uLmFkZEtleShldmFsdWF0ZUluQ29uc29sZVNob3J0Y3V0Lm5hbWUsIFdl Ykluc3BlY3Rvci5VSVN0cmluZygiRXZhbHVhdGUgc2VsZWN0aW9uIGluIGNvbnNvbGUiKSk7CiAg ICAgdGhpcy5yZWdpc3RlclNob3J0Y3V0KGV2YWx1YXRlSW5Db25zb2xlU2hvcnRjdXQua2V5LCB0 aGlzLl9ldmFsdWF0ZVNlbGVjdGlvbkluQ29uc29sZS5iaW5kKHRoaXMpKTsKIAotICAgIHZhciBz Y3JpcHRPdXRsaW5lU2hvcnRjdXQgPSBXZWJJbnNwZWN0b3IuSmF2YVNjcmlwdE91dGxpbmVEaWFs b2cuY3JlYXRlU2hvcnRjdXQoKTsKLSAgICBoZWxwU2VjdGlvbi5hZGRLZXkoc2NyaXB0T3V0bGlu ZVNob3J0Y3V0Lm5hbWUsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiR28gdG8gRnVuY3Rpb24iKSk7 Ci0KICAgICB2YXIgb3BlblJlc291cmNlU2hvcnRjdXQgPSBXZWJJbnNwZWN0b3IuT3BlblJlc291 cmNlRGlhbG9nLmNyZWF0ZVNob3J0Y3V0KCk7CiAgICAgaGVscFNlY3Rpb24uYWRkS2V5KG9wZW5S ZXNvdXJjZVNob3J0Y3V0Lm5hbWUsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiT3BlbiBTY3JpcHQi KSk7CiAKKyAgICB2YXIgc2NyaXB0T3V0bGluZVNob3J0Y3V0ID0gV2ViSW5zcGVjdG9yLkphdmFT Y3JpcHRPdXRsaW5lRGlhbG9nLmNyZWF0ZVNob3J0Y3V0KCk7CisgICAgaGVscFNlY3Rpb24uYWRk S2V5KHNjcmlwdE91dGxpbmVTaG9ydGN1dC5uYW1lLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkdv IHRvIEZ1bmN0aW9uIikpOworCiAgICAgdmFyIHBhbmVsRW5hYmxlckhlYWRpbmcgPSBXZWJJbnNw ZWN0b3IuVUlTdHJpbmcoIllvdSBuZWVkIHRvIGVuYWJsZSBkZWJ1Z2dpbmcgYmVmb3JlIHlvdSBj YW4gdXNlIHRoZSBTY3JpcHRzIHBhbmVsLiIpOwogICAgIHZhciBwYW5lbEVuYWJsZXJEaXNjbGFp bWVyID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJFbmFibGluZyBkZWJ1Z2dpbmcgd2lsbCBtYWtl IHNjcmlwdHMgcnVuIHNsb3dlci4iKTsKICAgICB2YXIgcGFuZWxFbmFibGVyQnV0dG9uID0gV2Vi SW5zcGVjdG9yLlVJU3RyaW5nKCJFbmFibGUgRGVidWdnaW5nIik7Cg==