77301 2012-01-29 13:06:18 -0800 Web Inspector: TimelinePanel does not respect InspectorFrontendHost.canSaveAs 2012-01-30 04:06:38 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 joepeck pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 544755 0 joepeck 2012-01-29 13:06:18 -0800 The TimelinePanel has Save and Load timeline data context menu options. Like other areas that use InspectorFrontendHost.saveAs this should first check if InspectorFrontendHost.canSaveAs() is true, before presenting the options. Some ports, like mac, return false for this. 544995 1 124520 pfeldman 2012-01-30 04:02:05 -0800 Created attachment 124520 Patch 544997 2 pfeldman 2012-01-30 04:06:38 -0800 Committed r106230: <http://trac.webkit.org/changeset/106230> 124520 2012-01-30 04:02:05 -0800 2012-01-30 04:05:22 -0800 Patch bug-77301-20120130160203.patch text/plain 2815 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MjI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTdmZWFjODk1ZGQxZmM5 MGIzNGUyNmU4MTE5NzU5ZDIxODkwN2ZkYi4uMWI4ZTVlM2ZmM2JiMmJlZDYwMjk3MjUyYWIyODJk Njc0OTQ5MmQ2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAxLTMwICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AZ29vZ2xlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBUaW1lbGluZVBhbmVsIGRvZXMgbm90IHJlc3BlY3QgSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmNh blNhdmVBcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzczMDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGluc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5UaW1lbGluZVBhbmVsLnByb3RvdHlwZS5fcmVnaXN0ZXJTaG9ydGN1dHMpOgorCiAyMDEy LTAxLTMwICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkByaW0uY29tPgogCiAgICAg ICAgIE5vdCByZXZpZXdlZC4gRml4IENsYW5nIGJ1aWxkIGZvciByZWFsIGFmdGVyIHIxMDYyMTgu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5l UGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFu ZWwuanMKaW5kZXggOTZkNmNhNjZjY2E3NGVkMDgwMDhmY2NiNDIyZWZhMzliY2U1MGNkNC4uMjhk YjRlZDA1OTJjY2QwNTkwMDJkZTAzMGRmM2JiOGQ5MjAxNWI5OCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVsLmpzCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qcwpAQCAtMzE2LDgg KzMxNiwxMCBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbC5wcm90b3R5cGUgPSB7CiAgICAg ICAgIHRoaXMuX3Nob3J0Y3V0c1tzaG9ydGN1dC5tYWtlS2V5KCJlIiwgbW9kaWZpZXJzLkN0cmxP ck1ldGEpXSA9IHRoaXMuX3RvZ2dsZVRpbWVsaW5lQnV0dG9uQ2xpY2tlZC5iaW5kKHRoaXMpOwog ICAgICAgICBzZWN0aW9uLmFkZEtleShzaG9ydGN1dC5zaG9ydGN1dFRvU3RyaW5nKCJlIiwgbW9k aWZpZXJzLkN0cmxPck1ldGEpLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlN0YXJ0L3N0b3AgcmVj b3JkaW5nIikpOwogCi0gICAgICAgIHRoaXMuX3Nob3J0Y3V0c1tzaG9ydGN1dC5tYWtlS2V5KCJz IiwgbW9kaWZpZXJzLkN0cmxPck1ldGEpXSA9IHRoaXMuX3NhdmVUb0ZpbGUuYmluZCh0aGlzKTsK LSAgICAgICAgc2VjdGlvbi5hZGRLZXkoc2hvcnRjdXQuc2hvcnRjdXRUb1N0cmluZygicyIsIG1v ZGlmaWVycy5DdHJsT3JNZXRhKSwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJTYXZlIFRpbWVsaW5l IGRhdGFcdTIwMjYiKSk7CisgICAgICAgIGlmIChJbnNwZWN0b3JGcm9udGVuZEhvc3QuY2FuU2F2 ZUFzKCkpIHsKKyAgICAgICAgICAgIHRoaXMuX3Nob3J0Y3V0c1tzaG9ydGN1dC5tYWtlS2V5KCJz IiwgbW9kaWZpZXJzLkN0cmxPck1ldGEpXSA9IHRoaXMuX3NhdmVUb0ZpbGUuYmluZCh0aGlzKTsK KyAgICAgICAgICAgIHNlY3Rpb24uYWRkS2V5KHNob3J0Y3V0LnNob3J0Y3V0VG9TdHJpbmcoInMi LCBtb2RpZmllcnMuQ3RybE9yTWV0YSksIFdlYkluc3BlY3Rvci5VSVN0cmluZygiU2F2ZSBUaW1l bGluZSBkYXRhXHUyMDI2IikpOworICAgICAgICB9CiAKICAgICAgICAgdGhpcy5fc2hvcnRjdXRz W3Nob3J0Y3V0Lm1ha2VLZXkoIm8iLCBtb2RpZmllcnMuQ3RybE9yTWV0YSldID0gdGhpcy5fZmls ZVNlbGVjdG9yRWxlbWVudC5jbGljay5iaW5kKHRoaXMuX2ZpbGVTZWxlY3RvckVsZW1lbnQpOwog ICAgICAgICBzZWN0aW9uLmFkZEtleShzaG9ydGN1dC5zaG9ydGN1dFRvU3RyaW5nKCJvIiwgbW9k aWZpZXJzLkN0cmxPck1ldGEpLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkxvYWQgVGltZWxpbmUg ZGF0YVx1MjAyNiIpKTsKQEAgLTM0MCw3ICszNDIsOCBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVQ YW5lbC5wcm90b3R5cGUgPSB7CiAgICAgX2NvbnRleHRNZW51OiBmdW5jdGlvbihldmVudCkKICAg ICB7CiAgICAgICAgIHZhciBjb250ZXh0TWVudSA9IG5ldyBXZWJJbnNwZWN0b3IuQ29udGV4dE1l bnUoKTsKLSAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kSXRlbShXZWJJbnNwZWN0b3IuVUlTdHJp bmcoIiZTYXZlIFRpbWVsaW5lIGRhdGFcdTIwMjYiKSwgdGhpcy5fc2F2ZVRvRmlsZS5iaW5kKHRo aXMpKTsKKyAgICAgICAgaWYgKEluc3BlY3RvckZyb250ZW5kSG9zdC5jYW5TYXZlQXMoKSkKKyAg ICAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0ZW0oV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCIm U2F2ZSBUaW1lbGluZSBkYXRhXHUyMDI2IiksIHRoaXMuX3NhdmVUb0ZpbGUuYmluZCh0aGlzKSk7 CiAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0ZW0oV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJM Jm9hZCBUaW1lbGluZSBkYXRhXHUyMDI2IiksIHRoaXMuX2ZpbGVTZWxlY3RvckVsZW1lbnQuY2xp Y2suYmluZCh0aGlzLl9maWxlU2VsZWN0b3JFbGVtZW50KSk7CiAgICAgICAgIGNvbnRleHRNZW51 LnNob3coZXZlbnQpOwogICAgIH0sCg==