77300 2012-01-29 10:35:55 -0800 [chromium] enable -Wexit-time-destructors for webkit unit tests 2012-01-31 15:56:01 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77395 1 fischman fischman japhet leviw thakis tony webkit.review.bot oldest_to_newest 544741 0 fischman 2012-01-29 10:35:55 -0800 Pacify clang shared_library build by leaking a global static. 544742 1 124465 fischman 2012-01-29 10:36:38 -0800 Created attachment 124465 Patch 544743 2 fischman 2012-01-29 10:39:47 -0800 FTR, this change enables me to build targets: chrome test_shell_tests webkit_unit_tests DumpRenderTree with set|grep ^GYP: GYP_DEFINES='disable_nacl=1 enable_svg=0 proprietary_codecs=1 ffmpeg_branding=ChromeOS component=shared_library clang=1 clang_use_chrome_plugins=1' GYP_GENERATORS=ninja GYP_GENERATOR_FLAGS='output_dir=ninja config=Debug' 544777 3 124473 fischman 2012-01-29 15:26:30 -0800 Created attachment 124473 Patch 544778 4 fischman 2012-01-29 15:28:22 -0800 Nico pointed out new usages of exit-time dtors in tests will break the clang/shared build, which will likely be invisible to non-shared/non-clang builders. Updated patch includes the exit-time-dtors warnings for the webkit_unit_tests target for even non-shared builds, since it's clean now this should help keep it clean. 545172 5 124473 tony 2012-01-30 09:45:20 -0800 Comment on attachment 124473 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124473&action=review > Source/WebKit/chromium/tests/TextureManagerTest.cpp:42 > -FakeTextureAllocator fakeTextureAllocator; > +DEFINE_STATIC_LOCAL(FakeTextureAllocator, fakeTextureAllocator, ()); Can we move this into the requestTexture function? That appears to be the only place it's used. 545175 6 124564 fischman 2012-01-30 09:51:22 -0800 Created attachment 124564 Patch 545177 7 fischman 2012-01-30 09:51:47 -0800 (In reply to comment #5) > (From update of attachment 124473 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=124473&action=review > > > Source/WebKit/chromium/tests/TextureManagerTest.cpp:42 > > -FakeTextureAllocator fakeTextureAllocator; > > +DEFINE_STATIC_LOCAL(FakeTextureAllocator, fakeTextureAllocator, ()); > > Can we move this into the requestTexture function? That appears to be the only place it's used. Done. 545197 8 124564 tony 2012-01-30 10:36:01 -0800 Comment on attachment 124564 Patch The patch doesn't apply. I'll rebase to tip-of-tree and cq+ for you. 545200 9 tony 2012-01-30 10:38:25 -0800 (In reply to comment #8) > (From update of attachment 124564 [details]) > The patch doesn't apply. I'll rebase to tip-of-tree and cq+ for you. Looks like it was fixed in https://bugs.webkit.org/show_bug.cgi?id=77333. I'll just land the gyp change. 545202 10 124570 tony 2012-01-30 10:41:48 -0800 Created attachment 124570 Patch for landing 545222 11 124570 webkit.review.bot 2012-01-30 11:07:14 -0800 Comment on attachment 124570 Patch for landing Clearing flags on attachment: 124570 Committed r106259: <http://trac.webkit.org/changeset/106259> 545223 12 webkit.review.bot 2012-01-30 11:07:19 -0800 All reviewed patches have been landed. Closing bug. 545680 13 leviw 2012-01-30 18:10:34 -0800 I'm afraid this breaks the build when we include webkittests as we do in the shared builders. See build output here: http://build.chromium.org/p/chromium/builders/Linux%20Clang%20%28dbg%29/builds/19648/steps/compile/logs/stdio I think this should be rolled back and re-opened pending a fix to webkittests or the build config (so WebKit isn't dependent on webkittests). 545691 14 leviw 2012-01-30 18:25:14 -0800 Re-opening as I rolled this out in r106313. 545750 15 fischman 2012-01-30 20:20:43 -0800 How strange. The gyp target webkit_unit_tests built fine for me, which is why this seemed like a safe change. Tony/Nico/Levi: any ideas why find ninja/Debug/ -iname '*.ninja'|xargs grep FrameTestHelpers finds nothing in my chromium checkout? I.e. FrameTestHelpers.cpp doesn't seem to be referenced by any .ninja files, even though it is in webkit_unittest_files in third_party/WebKit/Source/WebKit/chromium/WebKit.gypi 546353 16 tony 2012-01-31 12:17:15 -0800 (In reply to comment #15) > How strange. The gyp target webkit_unit_tests built fine for me, which is why this seemed like a safe change. > > Tony/Nico/Levi: any ideas why > find ninja/Debug/ -iname '*.ninja'|xargs grep FrameTestHelpers According to WebKit.gyp, we don't compile FrameTestHelpers.cpp when using a components build. This warning is only triggered when using clang + static build. 546360 17 fischman 2012-01-31 12:21:38 -0800 (In reply to comment #16) > (In reply to comment #15) > > How strange. The gyp target webkit_unit_tests built fine for me, which is why this seemed like a safe change. > > > > Tony/Nico/Levi: any ideas why > > find ninja/Debug/ -iname '*.ninja'|xargs grep FrameTestHelpers > > According to WebKit.gyp, we don't compile FrameTestHelpers.cpp when using a components build. This warning is only triggered when using clang + static build. But that's only for the "webkit" target, right? Why is FTH.cpp not included in the "webkit_unit_tests" target? 546427 18 tony 2012-01-31 13:22:33 -0800 (In reply to comment #17) > But that's only for the "webkit" target, right? > Why is FTH.cpp not included in the "webkit_unit_tests" target? In WebKitUnitTests.gyp, it says: ['inside_chromium_build==1 and component=="shared_library"', { 'defines': [ 'WEBKIT_DLL_UNITTEST', ], }, { 'sources': [ '<@(webkit_unittest_files)', ], FrameTestHelpers.cpp will be compiled if you're not building a shared library. Does the clang error repro for you if you disable the shared build? 546565 19 124835 fischman 2012-01-31 15:34:48 -0800 Created attachment 124835 Patch 546568 20 fischman 2012-01-31 15:35:55 -0800 (In reply to comment #18) > Does the clang error repro for you if you disable the shared build? D'oh! I was looking at a version of the file in which I was trying to rip out the craxy that is the webkit-target-includes-test-files-but-only-in-shared-builds and forgot ToT still has the conditional. Verified that the latest patch builds in static build. 546574 21 124835 tony 2012-01-31 15:39:04 -0800 Comment on attachment 124835 Patch FYI: Levi here's another attempt at enabling -Wexit-time-destructors. It probably isn't tested by any of the canary bots so if this fails on the Chromium waterfall, feel free to revert. 546581 22 leviw 2012-01-31 15:49:32 -0800 Throwing the current WebKit Sheriff on the thread. 546588 23 124835 webkit.review.bot 2012-01-31 15:55:54 -0800 Comment on attachment 124835 Patch Clearing flags on attachment: 124835 Committed r106410: <http://trac.webkit.org/changeset/106410> 546590 24 webkit.review.bot 2012-01-31 15:56:01 -0800 All reviewed patches have been landed. Closing bug. 124465 2012-01-29 10:36:38 -0800 2012-01-29 15:26:27 -0800 Patch bug-77300-20120129103637.patch text/plain 1411 fischman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDg1ZTNmZDFmMjQ1MTcwOGI4YjcxZTQ4YmMzMTIwNjkxMmU5Y2M4YTEuLjJlNWZjOGQxZjVjYjJl ZDcxNWJlMTQyOWJiYzczZDk1OGQxM2E0M2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMDEtMjkgIEFtaSBGaXNjaG1hbiAgPGZpc2NobWFuQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIFBhY2lmeSBjbGFuZyBzaGFyZWRfbGlicmFy eSBidWlsZCBieSBsZWFraW5nIGEgZ2xvYmFsIHN0YXRpYy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3MzAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB0ZXN0cy9UZXh0dXJlTWFuYWdlclRlc3QuY3Bw OgorICAgICAgICAoV1RGKToKKwogMjAxMi0wMS0yNyAgSmVmZiBUaW1hbnVzICA8dHdpekBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBJbmNyZWFzZSB0aGUgc2l6ZSBvZiB0aGUg R2FuZXNoIHRleHR1cmUgY2FjaGUgdG8gcHJldmVudCBwZXJmb3JtYW5jZSBwcm9ibGVtcyBvbiBh ZHZhbmNlZCBDYW52YXMyRCBwYWdlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vdGVzdHMvVGV4dHVyZU1hbmFnZXJUZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v dGVzdHMvVGV4dHVyZU1hbmFnZXJUZXN0LmNwcAppbmRleCA3YzA4OGRhYmM4ZGZmMmQzMzIzNzdl MzVjMGJhNTYxMDE3MGJiZGZkLi4wMmRkNGEwYTRlN2E1ODhkNWYwYzRjYmFiMDYyMWNlODk3OTI5 YjQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1RleHR1cmVNYW5h Z2VyVGVzdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9UZXh0dXJlTWFu YWdlclRlc3QuY3BwCkBAIC0zOSw3ICszOSw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQg ZGVsZXRlVGV4dHVyZSh1bnNpZ25lZCwgY29uc3QgSW50U2l6ZSYsIEdDM0RlbnVtKSB7IH0KIH07 CiAKLUZha2VUZXh0dXJlQWxsb2NhdG9yIGZha2VUZXh0dXJlQWxsb2NhdG9yOworREVGSU5FX1NU QVRJQ19MT0NBTChGYWtlVGV4dHVyZUFsbG9jYXRvciwgZmFrZVRleHR1cmVBbGxvY2F0b3IsICgp KTsKIGNvbnN0IEludFNpemUgdGV4dHVyZVNpemUoMjU2LCAyNTYpOwogY29uc3QgR0MzRGVudW0g dGV4dHVyZUZvcm1hdCA9IEdyYXBoaWNzQ29udGV4dDNEOjpSR0JBOwogCg== 124473 2012-01-29 15:26:30 -0800 2012-01-30 09:51:19 -0800 Patch bug-77300-20120129152629.patch text/plain 2021 fischman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDg1ZTNmZDFmMjQ1MTcwOGI4YjcxZTQ4YmMzMTIwNjkxMmU5Y2M4YTEuLjJlNWZjOGQxZjVjYjJl ZDcxNWJlMTQyOWJiYzczZDk1OGQxM2E0M2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMDEtMjkgIEFtaSBGaXNjaG1hbiAgPGZpc2NobWFuQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIFBhY2lmeSBjbGFuZyBzaGFyZWRfbGlicmFy eSBidWlsZCBieSBsZWFraW5nIGEgZ2xvYmFsIHN0YXRpYy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3MzAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB0ZXN0cy9UZXh0dXJlTWFuYWdlclRlc3QuY3Bw OgorICAgICAgICAoV1RGKToKKwogMjAxMi0wMS0yNyAgSmVmZiBUaW1hbnVzICA8dHdpekBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBJbmNyZWFzZSB0aGUgc2l6ZSBvZiB0aGUg R2FuZXNoIHRleHR1cmUgY2FjaGUgdG8gcHJldmVudCBwZXJmb3JtYW5jZSBwcm9ibGVtcyBvbiBh ZHZhbmNlZCBDYW52YXMyRCBwYWdlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vV2ViS2l0VW5pdFRlc3RzLmd5cCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0VW5p dFRlc3RzLmd5cAppbmRleCA1MDFkMGVlNWMyMzIyMWM4ODY1OWMwYjNmYzIwYjUzNzRiYTVjMTUz Li41YTk4YTg0NTljNWVjNzg2ODgyMzU0NTc5NzJhZTNiYzlmZWUyZmJlIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdFVuaXRUZXN0cy5neXAKKysrIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9XZWJLaXRVbml0VGVzdHMuZ3lwCkBAIC01MSw2ICs1MSw3IEBACiAgICAg ICAgIHsKICAgICAgICAgICAgICd0YXJnZXRfbmFtZSc6ICd3ZWJraXRfdW5pdF90ZXN0cycsCiAg ICAgICAgICAgICAndHlwZSc6ICdleGVjdXRhYmxlJywKKyAgICAgICAgICAgICd2YXJpYWJsZXMn OiB7ICdlbmFibGVfd2V4aXRfdGltZV9kZXN0cnVjdG9ycyc6IDEsIH0sCiAgICAgICAgICAgICAn bXN2c19ndWlkJzogJzdDRUZFODAwLTg0MDMtNDE4QS1BRDZBLTJENTJDNkZDM0VBRCcsCiAgICAg ICAgICAgICAnZGVwZW5kZW5jaWVzJzogWwogICAgICAgICAgICAgICAgICdXZWJLaXQuZ3lwOndl YmtpdCcsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1RleHR1cmVN YW5hZ2VyVGVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1RleHR1cmVNYW5h Z2VyVGVzdC5jcHAKaW5kZXggN2MwODhkYWJjOGRmZjJkMzMyMzc3ZTM1YzBiYTU2MTAxNzBiYmRm ZC4uMDJkZDRhMGE0ZTdhNTg4ZDVmMGM0Y2JhYjA2MjFjZTg5NzkyOWI0NyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9UZXh0dXJlTWFuYWdlclRlc3QuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvVGV4dHVyZU1hbmFnZXJUZXN0LmNwcApAQCAt MzksNyArMzksNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGRlbGV0ZVRleHR1cmUodW5z aWduZWQsIGNvbnN0IEludFNpemUmLCBHQzNEZW51bSkgeyB9CiB9OwogCi1GYWtlVGV4dHVyZUFs bG9jYXRvciBmYWtlVGV4dHVyZUFsbG9jYXRvcjsKK0RFRklORV9TVEFUSUNfTE9DQUwoRmFrZVRl eHR1cmVBbGxvY2F0b3IsIGZha2VUZXh0dXJlQWxsb2NhdG9yLCAoKSk7CiBjb25zdCBJbnRTaXpl IHRleHR1cmVTaXplKDI1NiwgMjU2KTsKIGNvbnN0IEdDM0RlbnVtIHRleHR1cmVGb3JtYXQgPSBH cmFwaGljc0NvbnRleHQzRDo6UkdCQTsKIAo= 124564 2012-01-30 09:51:22 -0800 2012-01-30 10:41:44 -0800 Patch bug-77300-20120130095121.patch text/plain 2327 fischman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDg1ZTNmZDFmMjQ1MTcwOGI4YjcxZTQ4YmMzMTIwNjkxMmU5Y2M4YTEuLjJlNWZjOGQxZjVjYjJl ZDcxNWJlMTQyOWJiYzczZDk1OGQxM2E0M2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMDEtMjkgIEFtaSBGaXNjaG1hbiAgPGZpc2NobWFuQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIFBhY2lmeSBjbGFuZyBzaGFyZWRfbGlicmFy eSBidWlsZCBieSBsZWFraW5nIGEgZ2xvYmFsIHN0YXRpYy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3MzAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB0ZXN0cy9UZXh0dXJlTWFuYWdlclRlc3QuY3Bw OgorICAgICAgICAoV1RGKToKKwogMjAxMi0wMS0yNyAgSmVmZiBUaW1hbnVzICA8dHdpekBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBJbmNyZWFzZSB0aGUgc2l6ZSBvZiB0aGUg R2FuZXNoIHRleHR1cmUgY2FjaGUgdG8gcHJldmVudCBwZXJmb3JtYW5jZSBwcm9ibGVtcyBvbiBh ZHZhbmNlZCBDYW52YXMyRCBwYWdlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vV2ViS2l0VW5pdFRlc3RzLmd5cCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0VW5p dFRlc3RzLmd5cAppbmRleCA1MDFkMGVlNWMyMzIyMWM4ODY1OWMwYjNmYzIwYjUzNzRiYTVjMTUz Li41YTk4YTg0NTljNWVjNzg2ODgyMzU0NTc5NzJhZTNiYzlmZWUyZmJlIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdFVuaXRUZXN0cy5neXAKKysrIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9XZWJLaXRVbml0VGVzdHMuZ3lwCkBAIC01MSw2ICs1MSw3IEBACiAgICAg ICAgIHsKICAgICAgICAgICAgICd0YXJnZXRfbmFtZSc6ICd3ZWJraXRfdW5pdF90ZXN0cycsCiAg ICAgICAgICAgICAndHlwZSc6ICdleGVjdXRhYmxlJywKKyAgICAgICAgICAgICd2YXJpYWJsZXMn OiB7ICdlbmFibGVfd2V4aXRfdGltZV9kZXN0cnVjdG9ycyc6IDEsIH0sCiAgICAgICAgICAgICAn bXN2c19ndWlkJzogJzdDRUZFODAwLTg0MDMtNDE4QS1BRDZBLTJENTJDNkZDM0VBRCcsCiAgICAg ICAgICAgICAnZGVwZW5kZW5jaWVzJzogWwogICAgICAgICAgICAgICAgICdXZWJLaXQuZ3lwOndl YmtpdCcsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1RleHR1cmVN YW5hZ2VyVGVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1RleHR1cmVNYW5h Z2VyVGVzdC5jcHAKaW5kZXggN2MwODhkYWJjOGRmZjJkMzMyMzc3ZTM1YzBiYTU2MTAxNzBiYmRm ZC4uNTIwZDVjMjZjN2ExNTk2NmE3MDNlMjE0ODBkOGI5YjEzMjUxMDhlMCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9UZXh0dXJlTWFuYWdlclRlc3QuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvVGV4dHVyZU1hbmFnZXJUZXN0LmNwcApAQCAt MzksNyArMzksNiBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGRlbGV0ZVRleHR1cmUodW5z aWduZWQsIGNvbnN0IEludFNpemUmLCBHQzNEZW51bSkgeyB9CiB9OwogCi1GYWtlVGV4dHVyZUFs bG9jYXRvciBmYWtlVGV4dHVyZUFsbG9jYXRvcjsKIGNvbnN0IEludFNpemUgdGV4dHVyZVNpemUo MjU2LCAyNTYpOwogY29uc3QgR0MzRGVudW0gdGV4dHVyZUZvcm1hdCA9IEdyYXBoaWNzQ29udGV4 dDNEOjpSR0JBOwogCkBAIC01NSw2ICs1NCw3IEBAIFBhc3NPd25QdHI8VGV4dHVyZU1hbmFnZXI+ IGNyZWF0ZVRleHR1cmVNYW5hZ2VyKHNpemVfdCBtYXhUZXh0dXJlcywgc2l6ZV90IHByZWZlCiAK IGJvb2wgcmVxdWVzdFRleHR1cmUoVGV4dHVyZU1hbmFnZXIqIG1hbmFnZXIsIFRleHR1cmVUb2tl biB0b2tlbikKIHsKKyAgICBERUZJTkVfU1RBVElDX0xPQ0FMKEZha2VUZXh0dXJlQWxsb2NhdG9y LCBmYWtlVGV4dHVyZUFsbG9jYXRvciwgKCkpOwogICAgIHVuc2lnbmVkIHRleHR1cmVJZDsKICAg ICBib29sIHJlc3VsdCA9IG1hbmFnZXItPnJlcXVlc3RUZXh0dXJlKHRva2VuLCB0ZXh0dXJlU2l6 ZSwgdGV4dHVyZUZvcm1hdCwgdGV4dHVyZUlkKTsKICAgICBpZiAocmVzdWx0KQo= 124570 2012-01-30 10:41:48 -0800 2012-01-31 15:34:45 -0800 Patch for landing bug-77300-20120130104231.patch text/plain 1322 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDNhOTYzZjhkM2Y1NjM2NmIwMzJiMTExOGZkMTljMmRkMjU1ZWQ2M2QuLjM0MTdhMTE2MzhhYTFk MDk0ZDE4ZDQzZmI1NjhmNGI1MzUyMTA4ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTItMDEtMzAgIEFtaSBGaXNjaG1hbiAgPGZpc2NobWFuQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIGVuYWJsZSAtV2V4aXQtdGltZS1kZXN0cnVj dG9ycyBmb3Igd2Via2l0IHVuaXQgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTc3MzAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVG9ueSBDaGFu Zy4KKworICAgICAgICAqIFdlYktpdFVuaXRUZXN0cy5neXA6IEVuYWJsZSBjbGFuZyBjaGVjayBm b3IgZXhpdCB0aW1lIGRlc3RydWN0b3JzLgorCiAyMDEyLTAxLTMwICBUb21teSBXaWRlbmZseWNo dCAgPHRvbW15d0Bnb29nbGUuY29tPgogCiAgICAgICAgIFtjaHJvbWl1bV0gTWVkaWFTdHJlYW0g QVBJOiBGaXggYSBmZXcgbWVtb3J5IGxlYWtzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL1dlYktpdFVuaXRUZXN0cy5neXAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktp dFVuaXRUZXN0cy5neXAKaW5kZXggNTAxZDBlZTVjMjMyMjFjODg2NTljMGIzZmMyMGI1Mzc0YmE1 YzE1My4uNWE5OGE4NDU5YzVlYzc4Njg4MjM1NDU3OTcyYWUzYmM5ZmVlMmZiZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJLaXRVbml0VGVzdHMuZ3lwCisrKyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0VW5pdFRlc3RzLmd5cApAQCAtNTEsNiArNTEsNyBAQAog ICAgICAgICB7CiAgICAgICAgICAgICAndGFyZ2V0X25hbWUnOiAnd2Via2l0X3VuaXRfdGVzdHMn LAogICAgICAgICAgICAgJ3R5cGUnOiAnZXhlY3V0YWJsZScsCisgICAgICAgICAgICAndmFyaWFi bGVzJzogeyAnZW5hYmxlX3dleGl0X3RpbWVfZGVzdHJ1Y3RvcnMnOiAxLCB9LAogICAgICAgICAg ICAgJ21zdnNfZ3VpZCc6ICc3Q0VGRTgwMC04NDAzLTQxOEEtQUQ2QS0yRDUyQzZGQzNFQUQnLAog ICAgICAgICAgICAgJ2RlcGVuZGVuY2llcyc6IFsKICAgICAgICAgICAgICAgICAnV2ViS2l0Lmd5 cDp3ZWJraXQnLAo= 124835 2012-01-31 15:34:48 -0800 2012-01-31 15:55:54 -0800 Patch bug-77300-20120131153447.patch text/plain 2506 fischman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDAyMGFhYjZiNzliNjgyZGM3MTc3ZjNmOWFiZjIwMzYyNzczYzVlOTQuLjRmNTk3M2YwNmNjMzg2 NmEwNzliOTAyN2QzZTczZDRlNzUyMzliNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDEtMzEgIEFtaSBGaXNjaG1hbiAgPGZpc2NobWFuQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIGVuYWJsZSAtV2V4aXQtdGltZS1kZXN0cnVj dG9ycyBmb3Igd2Via2l0IHVuaXQgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTc3MzAwCisgICAgICAgIEZpeCB0aGUgb25seSBleHRhbnQgdmlv bGF0aW9uICh2ZXJpZmllZCBieSBidWlsZGluZyB3ZWJraXRfdW5pdF90ZXN0cyBpbiBzdGF0aWMg YnVpbGQpLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogV2ViS2l0VW5pdFRlc3RzLmd5cDoKKyAgICAgICAgKiB0ZXN0cy9GcmFtZVRlc3RIZWxwZXJz LmNwcDoKKyAgICAgICAgKFdlYktpdDo6RnJhbWVUZXN0SGVscGVyczo6ZGVmYXVsdFdlYkZyYW1l Q2xpZW50KToKKyAgICAgICAgKFdlYktpdDo6RnJhbWVUZXN0SGVscGVyczo6ZGVmYXVsdFdlYlZp ZXdDbGllbnQpOgorCiAyMDEyLTAxLTMwICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90 QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTA2MzI0Lgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJLaXRVbml0VGVzdHMuZ3lwIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJLaXRVbml0VGVzdHMuZ3lwCmluZGV4IDUwMWQwZWU1 YzIzMjIxYzg4NjU5YzBiM2ZjMjBiNTM3NGJhNWMxNTMuLjVhOThhODQ1OWM1ZWM3ODY4ODIzNTQ1 Nzk3MmFlM2JjOWZlZTJmYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vV2Vi S2l0VW5pdFRlc3RzLmd5cAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdFVuaXRU ZXN0cy5neXAKQEAgLTUxLDYgKzUxLDcgQEAKICAgICAgICAgewogICAgICAgICAgICAgJ3Rhcmdl dF9uYW1lJzogJ3dlYmtpdF91bml0X3Rlc3RzJywKICAgICAgICAgICAgICd0eXBlJzogJ2V4ZWN1 dGFibGUnLAorICAgICAgICAgICAgJ3ZhcmlhYmxlcyc6IHsgJ2VuYWJsZV93ZXhpdF90aW1lX2Rl c3RydWN0b3JzJzogMSwgfSwKICAgICAgICAgICAgICdtc3ZzX2d1aWQnOiAnN0NFRkU4MDAtODQw My00MThBLUFENkEtMkQ1MkM2RkMzRUFEJywKICAgICAgICAgICAgICdkZXBlbmRlbmNpZXMnOiBb CiAgICAgICAgICAgICAgICAgJ1dlYktpdC5neXA6d2Via2l0JywKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvRnJhbWVUZXN0SGVscGVycy5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3Rlc3RzL0ZyYW1lVGVzdEhlbHBlcnMuY3BwCmluZGV4IDFhMTE0NTYzMWRl NTJlN2I1MmQxZDJiYzYwMWQyNjhjYTliZTY2OWQuLmJhNjY2NjY5OWJjY2UxZWY0ZGYxMDAwOWU3 ODViMGYwMmI0YTc5ZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMv RnJhbWVUZXN0SGVscGVycy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9G cmFtZVRlc3RIZWxwZXJzLmNwcApAQCAtMzEsNiArMzEsNyBAQAogI2luY2x1ZGUgImNvbmZpZy5o IgogI2luY2x1ZGUgIkZyYW1lVGVzdEhlbHBlcnMuaCIKIAorI2luY2x1ZGUgIlN0ZExpYkV4dHJh cy5oIgogI2luY2x1ZGUgIldlYkZyYW1lLmgiCiAjaW5jbHVkZSAiV2ViRnJhbWVDbGllbnQuaCIK ICNpbmNsdWRlICJXZWJTZXR0aW5ncy5oIgpAQCAtNzEsNyArNzIsNyBAQCBjbGFzcyBUZXN0V2Vi RnJhbWVDbGllbnQgOiBwdWJsaWMgV2ViRnJhbWVDbGllbnQgewogCiBzdGF0aWMgV2ViRnJhbWVD bGllbnQqIGRlZmF1bHRXZWJGcmFtZUNsaWVudCgpCiB7Ci0gICAgc3RhdGljIFRlc3RXZWJGcmFt ZUNsaWVudCBjbGllbnQ7CisgICAgREVGSU5FX1NUQVRJQ19MT0NBTChUZXN0V2ViRnJhbWVDbGll bnQsIGNsaWVudCwgKCkpOwogICAgIHJldHVybiAmY2xpZW50OwogfQogCkBAIC04MCw3ICs4MSw3 IEBAIGNsYXNzIFRlc3RXZWJWaWV3Q2xpZW50IDogcHVibGljIFdlYlZpZXdDbGllbnQgewogCiBz dGF0aWMgV2ViVmlld0NsaWVudCogZGVmYXVsdFdlYlZpZXdDbGllbnQoKQogewotICAgIHN0YXRp YyBUZXN0V2ViVmlld0NsaWVudCBjbGllbnQ7CisgICAgREVGSU5FX1NUQVRJQ19MT0NBTChUZXN0 V2ViVmlld0NsaWVudCwgIGNsaWVudCwgKCkpOwogICAgIHJldHVybiAmY2xpZW50OwogfQogCg==