<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>77298</bug_id>
          
          <creation_ts>2012-01-29 07:58:01 -0800</creation_ts>
          <short_desc>ARIA spinbutton role incorrectly mapped to ProgressIndicatorRole</short_desc>
          <delta_ts>2012-07-11 14:21:10 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Accessibility</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Steve Faulkner">faulkner.steve</reporter>
          <assigned_to name="chris fleizach">cfleizach</assigned_to>
          <cc>bdakin</cc>
    
    <cc>cfleizach</cc>
    
    <cc>dmazzoni</cc>
    
    <cc>faulkner.steve</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>544736</commentid>
    <comment_count>0</comment_count>
    <who name="Steve Faulkner">faulkner.steve</who>
    <bug_when>2012-01-29 07:58:01 -0800</bug_when>
    <thetext>The HTML5 input type=number  element as implemented in webkit includes a spinbutton control which is mapped as 

AXRole:  &quot;AXIncrementor&quot;
 AXSubrole:  &quot;(null)&quot;
 AXRoleDescription:  &quot;stepper&quot;

The ARIA spinbutton role is currently mapped to 
 { &quot;spinbutton&quot;, ProgressIndicatorRole }, in webkit

(source: AccessibilityObject.cpp: 1376)


The WAI -ARIA implementation guide maps spinbutton to (source:http://www.w3.org/TR/wai-aria-implementation/#mapping_role_table)
AXRole:  &quot;AXIncrementor&quot;
 AXSubrole:  &quot;(null)&quot;
 AXRoleDescription:  &quot;stepper&quot;



Recommend fixing implementation so it maps to the correct role.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>664464</commentid>
    <comment_count>1</comment_count>
    <who name="Steve Faulkner">faulkner.steve</who>
    <bug_when>2012-07-08 01:12:01 -0700</bug_when>
    <thetext>I believe changing the current line http://trac.webkit.org/browser/trunk/Source/WebCore/accessibility/AccessibilityObject.cpp#L1402


from { &quot;spinbutton&quot;, ProgressIndicatorRole },

to 

 { &quot;spinbutton&quot;, IncrementorRole },

would resolve the issue

there may be some changes required in other files for other platforms as in Windows the appropriate mapping would  likely be

{ &quot;spinbutton&quot;, SpinButtonRole },</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>664466</commentid>
    <comment_count>2</comment_count>
    <who name="Steve Faulkner">faulkner.steve</who>
    <bug_when>2012-07-08 01:32:01 -0700</bug_when>
    <thetext>Examples of javascript widgets affected by this bug:

in the Ext GWT library the simple form the spin button is identified using ARIA role=spinbutton , it is incorrectly exposed as progress indicator
http://dev.sencha.com/playpen/gxt/aria2/test.html?id=focusmanager

in the Dojo digit library 
http://archive.dojotoolkit.org/nightly/checkout/dijit/tests/form/test_Spinner.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>664911</commentid>
    <comment_count>3</comment_count>
      <attachid>151258</attachid>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2012-07-09 09:31:05 -0700</bug_when>
    <thetext>Created attachment 151258
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>667056</commentid>
    <comment_count>4</comment_count>
      <attachid>151258</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-07-11 14:21:06 -0700</bug_when>
    <thetext>Comment on attachment 151258
patch

Clearing flags on attachment: 151258

Committed r122372: &lt;http://trac.webkit.org/changeset/122372&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>667057</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-07-11 14:21:10 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>151258</attachid>
            <date>2012-07-09 09:31:05 -0700</date>
            <delta_ts>2012-07-11 14:21:06 -0700</delta_ts>
            <desc>patch</desc>
            <filename>patch.txt</filename>
            <type>text/plain</type>
            <size>3831</size>
            <attacher name="chris fleizach">cfleizach</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMjExMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA3LTA5ICBDaHJpcyBG
bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVJJQSBzcGluYnV0dG9u
IHJvbGUgaW5jb3JyZWN0bHkgbWFwcGVkIHRvIFByb2dyZXNzSW5kaWNhdG9yUm9sZQorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzcyOTgKKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkv
QWNjZXNzaWJpbGl0eU9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVBUklBUm9s
ZU1hcCk6CisKIDIwMTItMDctMDkgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21h
aWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjIxMDcuCkluZGV4
OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9i
amVjdC5jcHAJKHJldmlzaW9uIDEyMjExMCkKKysrIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxp
dHkvQWNjZXNzaWJpbGl0eU9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzOTksNyArMTM5
OSw3IEBACiAgICAgICAgIHsgInNlYXJjaCIsIExhbmRtYXJrU2VhcmNoUm9sZSB9LAogICAgICAg
ICB7ICJzZXBhcmF0b3IiLCBTcGxpdHRlclJvbGUgfSwKICAgICAgICAgeyAic2xpZGVyIiwgU2xp
ZGVyUm9sZSB9LAotICAgICAgICB7ICJzcGluYnV0dG9uIiwgUHJvZ3Jlc3NJbmRpY2F0b3JSb2xl
IH0sCisgICAgICAgIHsgInNwaW5idXR0b24iLCBTcGluQnV0dG9uUm9sZSB9LAogICAgICAgICB7
ICJzdGF0dXMiLCBBcHBsaWNhdGlvblN0YXR1c1JvbGUgfSwKICAgICAgICAgeyAidGFiIiwgVGFi
Um9sZSB9LAogICAgICAgICB7ICJ0YWJsaXN0IiwgVGFiTGlzdFJvbGUgfSwKSW5kZXg6IExheW91
dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDEyMjExMCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA
QCAtMSwzICsxLDEzIEBACisyMDEyLTA3LTA5ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBh
cHBsZS5jb20+CisKKyAgICAgICAgQVJJQSBzcGluYnV0dG9uIHJvbGUgaW5jb3JyZWN0bHkgbWFw
cGVkIHRvIFByb2dyZXNzSW5kaWNhdG9yUm9sZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzcyOTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L2FyaWEtc3Bp
bmJ1dHRvbi1leHBlY3RlZC50eHQ6CisgICAgICAgICogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxp
dHkvYXJpYS1zcGluYnV0dG9uLmh0bWw6CisKIDIwMTItMDctMDkgIEFuZHJlaSBPbmVhICA8b25l
YUBhZG9iZS5jb20+CiAKICAgICAgICAgW0NTU1JlZ2lvbnNdIFJlbmFtZSBOYW1lZEZsb3c6Omdl
dFJlZ2lvbnNCeUNvbnRlbnROb2RlIHRvIE5hbWVkRmxvdzo6Z2V0UmVnaW9uc0J5Q29udGVudApJ
bmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS1zcGluYnV0
dG9uLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMv
YWNjZXNzaWJpbGl0eS9hcmlhLXNwaW5idXR0b24tZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAxMjIx
MTApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9hcmlhLXNwaW5i
dXR0b24tZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAotSW4gYWNj
ZXNzaWJpbGl0eSwgdGhlIGZvbGxvd2luZyBzaG91bGQgYmUgYSBwcm9ncmVzcyBpbmRpY2F0b3I6
CitJbiBhY2Nlc3NpYmlsaXR5LCB0aGUgZm9sbG93aW5nIHNob3VsZCBiZSBhbiBpbmNyZW1lbnRv
cjoKIAogWAogCi1UaGlzIHRlc3QgUEFTU0VTIGluIER1bXBSZW5kZXJUcmVlLiBUaGUgcm9sZSBp
cyBBWFJvbGU6IEFYUHJvZ3Jlc3NJbmRpY2F0b3IKK1RoaXMgdGVzdCBQQVNTRVMgaW4gRHVtcFJl
bmRlclRyZWUuIFRoZSByb2xlIGlzIEFYUm9sZTogQVhJbmNyZW1lbnRvcgpJbmRleDogTGF5b3V0
VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS1zcGluYnV0dG9uLmh0bWwKPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS1z
cGluYnV0dG9uLmh0bWwJKHJldmlzaW9uIDEyMjExMCkKKysrIExheW91dFRlc3RzL3BsYXRmb3Jt
L21hYy9hY2Nlc3NpYmlsaXR5L2FyaWEtc3BpbmJ1dHRvbi5odG1sCSh3b3JraW5nIGNvcHkpCkBA
IC0xMywxNSArMTMsMTUgQEAKICAgICAgICAgdmFyIGFyaWFSb2xlID0gYWNjZXNzaWJpbGl0eUNv
bnRyb2xsZXIuZm9jdXNlZEVsZW1lbnQucm9sZTsKICAgICAgICAKICAgICAgICAgdmFyIHJlc3Vs
dCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQiKTsKLSAgICAgICAgaWYgKGFyaWFS
b2xlID09ICJBWFJvbGU6IEFYUHJvZ3Jlc3NJbmRpY2F0b3IiKQorICAgICAgICBpZiAoYXJpYVJv
bGUgPT0gIkFYUm9sZTogQVhJbmNyZW1lbnRvciIpCiAgICAgICAgICAgICByZXN1bHQuaW5uZXJU
ZXh0ID0gIlRoaXMgdGVzdCBQQVNTRVMgaW4gRHVtcFJlbmRlclRyZWUuIFRoZSByb2xlIGlzICIg
KyBhcmlhUm9sZTsKICAgICAgICAgZWxzZQotICAgICAgICAgICAgcmVzdWx0LmlubmVyVGV4dCA9
ICJUaGlzIHRlc3QgRkFJTFMgaW4gRHVtcFJlbmRlclRyZWUuIFRoZSBBUklBIHJvbGUgaXMgIiAr
IGFyaWFSb2xlICsgIiwgYnV0IHNob3VsZCBiZSBBWFByb2dyZXNzSW5kaWNhdG9yIjsKKyAgICAg
ICAgICAgIHJlc3VsdC5pbm5lclRleHQgPSAiVGhpcyB0ZXN0IEZBSUxTIGluIER1bXBSZW5kZXJU
cmVlLiBUaGUgQVJJQSByb2xlIGlzICIgKyBhcmlhUm9sZSArICIsIGJ1dCBzaG91bGQgYmUgQVhJ
bmNyZW1lbnRvciI7CiAgICAgfQogPC9zY3JpcHQ+CiAKIDxkaXY+Ci0gICAgPHA+SW4gYWNjZXNz
aWJpbGl0eSwgdGhlIGZvbGxvd2luZyBzaG91bGQgYmUgYSBwcm9ncmVzcyBpbmRpY2F0b3I6PC9w
PgorICAgIDxwPkluIGFjY2Vzc2liaWxpdHksIHRoZSBmb2xsb3dpbmcgc2hvdWxkIGJlIGFuIGlu
Y3JlbWVudG9yOjwvcD4KICAgICA8cD48c3BhbiB0YWJpbmRleD0iMCIgcm9sZT0ic3BpbmJ1dHRv
biIgaWQ9InNwaW5idXR0b24iIGFyaWEtdmFsdWVub3c9NSBhcmlhLXZhbHVlbWluPTAgYXJpYS12
YWx1ZW1heD0xMD5YPC9zcGFuPjwvcD4KICAgICA8c3BhbiBpZD0icmVzdWx0Ij48L3NwYW4+CiAg
ICAgPHNjcmlwdD4K
</data>

          </attachment>
      

    </bug>

</bugzilla>