77288 2012-01-28 14:14:38 -0800 REGRESSION (r104303): Clicking inline video controls gives the video a focus ring 2012-02-06 16:52:19 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED data:text/html,%3Cvideo%20controls%20src=%22http://movies.apple.com/movies/us/apple/ipoditunes/2007/touch/ads/apple_ipodtouch_touch_r640-9cie.mov%22%3E InRadar, Regression P1 Normal --- 1 mitz jer.noble jer.noble sullivan webkit.review.bot oldest_to_newest 544691 0 mitz 2012-01-28 14:14:38 -0800 To reproduce: Navigate to the URL. When the video loads, click the play button. Result: The video gets a focus ring around it, but it shouldn’t. Notes: This happens with many videos at apple.com. Caused by <http://trac.webkit.org/r104303>, the fix for bug 75650. 544692 1 mitz 2012-01-28 14:15:58 -0800 <rdar://problem/10771242> 548256 2 jer.noble 2012-02-02 16:50:25 -0800 I believe the actual regression for this is <http://trac.webkit.org/changeset/95381>, the fix for bug #67190. In that bug, HTMLMediaElements were explicitly made focusable. The fix for bug #75650 unmasked this behavior. 548257 3 jer.noble 2012-02-02 16:51:38 -0800 It looks like we can make the HTMLMediaElement non-mouse focusable without breaking keyboard focus (ala bug #67190) by overriding Node::isMouseFocusable(). 548968 4 125387 jer.noble 2012-02-03 12:53:15 -0800 Created attachment 125387 Patch 550407 5 125387 webkit.review.bot 2012-02-06 16:34:31 -0800 Comment on attachment 125387 Patch Rejecting attachment 125387 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Core/html/HTMLMediaElement.h Hunk #1 FAILED at 336. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/html/HTMLMediaElement.h.rej patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/media/video-mouse-focus-expected.txt patching file LayoutTests/media/video-mouse-focus.html Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Darin Adler']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11442046 550410 6 jer.noble 2012-02-06 16:37:42 -0800 Doing this one manually... 550425 7 jer.noble 2012-02-06 16:52:19 -0800 Committed r106876: <http://trac.webkit.org/changeset/106876> 125387 2012-02-03 12:53:15 -0800 2012-02-06 16:34:31 -0800 Patch bug-77288-20120203125314.patch text/plain 4786 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmJhZjJkOWMwMmU3OTE4 OGYyMmVlZWRiMDBjMTYwYzAzNDRmMGFlYS4uZDhiOTk3NjY5YjI1YzIyNDUwMDQ3ZWJmNDQ5ZDg3 MmY0ZDJmMGRhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAyLTAzICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxMDQz MDMpOiBDbGlja2luZyBpbmxpbmUgdmlkZW8gY29udHJvbHMgZ2l2ZXMgdGhlIHZpZGVvIGEgZm9j dXMgcmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzcyODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU ZXN0OiBtZWRpYS92aWRlby1tb3VzZS1mb2N1cy5odG1sCisKKyAgICAgICAgRG8gbm90IGFsbG93 IG1lZGlhIGVsZW1lbnRzIHRvIGJlIGZvY3VzZWQgYnkgbW91c2UgY2xpY2sgYnkgb3ZlcnJpZGlu ZyBpc01vdXNlRm9jdXNhYmxlCisgICAgICAgIGFuZCByZXR1cm5pbmcgZmFsc2UuCisKKyAgICAg ICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1l ZGlhRWxlbWVudDo6aXNNb3VzZUZvY3VzYWJsZSk6CisgICAgICAgICogaHRtbC9IVE1MTWVkaWFF bGVtZW50Lmg6CisKIDIwMTItMDItMDMgIEpvY2hlbiBFaXNpbmdlciAgPGpvY2hlbkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmVtb3ZlIHVubmVjY2VzYXJ5IGNhbkV4ZWN1dGVTY3JpcHRzIGNo ZWNrIGZyb20gdjggYmluZGluZ3MsIGFuZCBjb3JyZWN0bHkgaW5kZWljYXRlIHdoZW4gd2UncmUg YWJvdXQgdG8gZXhlY3V0ZSBhIHNjcmlwdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MTWVkaWFFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxl bWVudC5jcHAKaW5kZXggZThiYjc4OGQ2YTFmMGUyYzc0MGEzZjc5YTNiYmY5ZTg3Zjg3ODllMi4u NTcyM2RiNmE4OGE1MDY1ODM0NDY2ODM0OGU1MDllYWM3YzJmZjMzNiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCkBAIC0zMTUsNiArMzE1LDExIEBAIGJvb2wgSFRN TE1lZGlhRWxlbWVudDo6c3VwcG9ydHNGb2N1cygpIGNvbnN0CiAgICAgcmV0dXJuIGNvbnRyb2xz KCkgfHwgIEhUTUxFbGVtZW50OjpzdXBwb3J0c0ZvY3VzKCk7CiB9CiAKK2Jvb2wgSFRNTE1lZGlh RWxlbWVudDo6aXNNb3VzZUZvY3VzYWJsZSgpIGNvbnN0Cit7CisgICAgcmV0dXJuIGZhbHNlOwor fQorCiB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OmF0dHJpYnV0ZUNoYW5nZWQoQXR0cmlidXRlKiBh dHRyLCBib29sIHByZXNlcnZlRGVjbHMpCiB7CiAgICAgSFRNTEVsZW1lbnQ6OmF0dHJpYnV0ZUNo YW5nZWQoYXR0ciwgcHJlc2VydmVEZWNscyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxNZWRpYUVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxl bWVudC5oCmluZGV4IDk4ZmRmNWEwZmVmNjFhODFhM2NlODgyZTdiZDRhZjVkZjFjYjNkOGEuLmU0 YzA0YzBiNTZlZDY0ZjJmN2Q4ODE1YTY3ZDE3NzZmMzFjNmEyMWYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTE1lZGlhRWxlbWVudC5oCkBAIC0zMzYsNiArMzM2LDcgQEAgcHJpdmF0ZToKICAgICB2 b2lkIGNyZWF0ZU1lZGlhUGxheWVyKCk7CiAKICAgICB2aXJ0dWFsIGJvb2wgc3VwcG9ydHNGb2N1 cygpIGNvbnN0OworICAgIHZpcnR1YWwgYm9vbCBpc01vdXNlRm9jdXNhYmxlKCkgY29uc3Q7CiAg ICAgdmlydHVhbCB2b2lkIGF0dHJpYnV0ZUNoYW5nZWQoQXR0cmlidXRlKiwgYm9vbCBwcmVzZXJ2 ZURlY2xzKTsKICAgICB2aXJ0dWFsIGJvb2wgcmVuZGVyZXJJc05lZWRlZChjb25zdCBOb2RlUmVu ZGVyaW5nQ29udGV4dCYpOwogICAgIHZpcnR1YWwgUmVuZGVyT2JqZWN0KiBjcmVhdGVSZW5kZXJl cihSZW5kZXJBcmVuYSosIFJlbmRlclN0eWxlKik7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzYwY2U0NzFiOTAzMjE2NDY2 NmYyOTU2NWI3MzlhNjVkYWY0YjgzZi4uMTFlOTllMmNkNzc2OTk4M2Q0MGEwMzMxOWJlYjVlNDZj NThmZWE5ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAyLTAzICBKZXIgTm9ibGUgIDxq ZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxMDQzMDMpOiBDbGlj a2luZyBpbmxpbmUgdmlkZW8gY29udHJvbHMgZ2l2ZXMgdGhlIHZpZGVvIGEgZm9jdXMgcmluZwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzcyODgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIG1lZGlhL3Zp ZGVvLW1vdXNlLWZvY3VzLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogbWVkaWEvdmlk ZW8tbW91c2UtZm9jdXMuaHRtbDogQWRkZWQuCisKIDIwMTItMDItMDMgIEpvY2hlbiBFaXNpbmdl ciAgPGpvY2hlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVtb3ZlIHVubmVjY2VzYXJ5IGNh bkV4ZWN1dGVTY3JpcHRzIGNoZWNrIGZyb20gdjggYmluZGluZ3MsIGFuZCBjb3JyZWN0bHkgaW5k ZWljYXRlIHdoZW4gd2UncmUgYWJvdXQgdG8gZXhlY3V0ZSBhIHNjcmlwdApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tbW91c2UtZm9jdXMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvbWVkaWEvdmlkZW8tbW91c2UtZm9jdXMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjIz MzExZWJhZjg0YmE3ZmNjZTliYzA0MzM2MjlkNzE3Mzk0OTI4YTEKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1tb3VzZS1mb2N1cy1leHBlY3RlZC50eHQKQEAgLTAs MCArMSw1IEBACitUaGlzIHRlc3RzIHRoYXQgYSBtb3VzZSBjbGljayBldmVudCB3aWxsIG5vdCBj YXVzZSBhIG1lZGlhIGVsZW1lbnQgdG8gZ2FpbiBmb2N1cy4KKworRVhQRUNURUQgKGRvY3VtZW50 LmFjdGl2ZUVsZW1lbnQuaWQgIT0gJ3ZpZGVvJykgT0sKK0VORCBPRiBURVNUCisKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLW1vdXNlLWZvY3VzLmh0bWwgYi9MYXlvdXRUZXN0 cy9tZWRpYS92aWRlby1tb3VzZS1mb2N1cy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmY0ZTNiMWMxZGFkZGQ4 YzJiMjMzODExNDUyODI3ZGE1YzEwOTAzMjMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9tZWRpYS92aWRlby1tb3VzZS1mb2N1cy5odG1sCkBAIC0wLDAgKzEsMzAgQEAKKzwhRE9DVFlQ RSBodG1sPgorPGh0bWw+CisgICAgPGhlYWQ+CisgICAgICAgIDxzY3JpcHQgc3JjPSJ2aWRlby10 ZXN0LmpzIj48L3NjcmlwdD4KKyAgICAgICAgPHNjcmlwdD4KKyAgICAgICAgICAgIHZhciBzdGFy dFRlc3QgPSBmdW5jdGlvbigpIHsKKyAgICAgICAgICAgICAgICBpZiAoIXdpbmRvdy5ldmVudFNl bmRlcikgeworICAgICAgICAgICAgICAgICAgICBsb2dSZXN1bHQoZmFsc2UsICJUaGlzIHRlc3Qg cmVxdWlyZXMgd2luZG93LmV2ZW50U2VuZGVyLiIpOworICAgICAgICAgICAgICAgICAgICByZXR1 cm47CisgICAgICAgICAgICAgICAgfQorCisgICAgICAgICAgICAgICAgZmluZE1lZGlhRWxlbWVu dCgpOworICAgICAgICAgICAgICAgIHZhciByZWN0ID0gdmlkZW8uZ2V0Qm91bmRpbmdDbGllbnRS ZWN0KCk7CisgICAgICAgICAgICAgICAgdmFyIHggPSByZWN0LmxlZnQgKyByZWN0LndpZHRoIC8g MjsKKyAgICAgICAgICAgICAgICB2YXIgeSA9IHJlY3QudG9wICsgcmVjdC5oZWlnaHQgLyAyOwor CisgICAgICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oeCwgeSk7CisgICAgICAg ICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7CisgICAgICAgICAgICAgICAgZXZlbnRT ZW5kZXIubW91c2VVcCgpOworCisgICAgICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCJkb2N1bWVu dC5hY3RpdmVFbGVtZW50LmlkIiwgInZpZGVvIiwgIiE9Iik7CisgICAgICAgICAgICAgICAgZW5k VGVzdCgpOworICAgICAgICAgICAgfTsKKyAgICAgICAgPC9zY3JpcHQ+CisgICAgPC9oZWFkPgor ICAgIDxib2R5IG9ubG9hZD0ic3RhcnRUZXN0KCk7Ij4KKyAgICAgICAgPHA+VGhpcyB0ZXN0cyB0 aGF0IGEgbW91c2UgY2xpY2sgZXZlbnQgd2lsbCBub3QgY2F1c2UgYSBtZWRpYSBlbGVtZW50IHRv IGdhaW4gZm9jdXMuPC9wPgorICAgICAgICA8dmlkZW8gaWQ9InZpZGVvIiBjb250cm9scz48L3Zp ZGVvPgorICAgIDwvYm9keT4KKzwvaHRtbD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg==