77260 2012-01-27 16:09:55 -0800 DRT pasteboard object should return the correct pasteboard name 2012-01-27 17:23:29 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac Unspecified RESOLVED FIXED P2 Normal --- 77261 1 enrica enrica ap oldest_to_newest 544491 0 enrica 2012-01-27 16:09:55 -0800 The current implementation returns nil regardless of the name used to create the pasteboard object. 544502 1 124396 enrica 2012-01-27 16:32:35 -0800 Created attachment 124396 Pastch 544519 2 124396 mitz 2012-01-27 16:54:39 -0800 Comment on attachment 124396 Pastch View in context: https://bugs.webkit.org/attachment.cgi?id=124396&action=review r=me assuming you fix the memory management issue. > Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.m:45 > +-(id)initWithName:(NSString*)name; Needs a space before the *. A newline before this line wouldn’t hurt either. > Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.m:91 > +- (id)initWithName:(NSString*)name Needs a space before the *. > Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.m:96 > + pasteboardName = name; You should -copy name here and -release pasteboardName in -dealloc. 544521 3 enrica 2012-01-27 17:00:05 -0800 thanks for the review! I'll fix the memory management issue. 544527 4 enrica 2012-01-27 17:13:08 -0800 http://trac.webkit.org/changeset/106171 544531 5 enrica 2012-01-27 17:23:29 -0800 Dan pointed out I should have used copy instead of initWithString. Landed a follow-up fix. http://trac.webkit.org/changeset/106172 124396 2012-01-27 16:32:35 -0800 2012-01-27 16:54:39 -0800 Pastch drtpasteboard.txt text/plain 2341 enrica SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwNjE2NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDEyLTAxLTI3ICBFbnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+ CisKKyAgICAgICAgRFJUIHBhc3RlYm9hcmQgb2JqZWN0IHNob3VsZCByZXR1cm4gdGhlIGNvcnJl Y3QgcGFzdGVib2FyZCBuYW1lLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzcyNjAKKyAgICAgICAgCisgICAgICAgIEN1cnJlbnRseSB0aGUgbmFtZSBw cm9wZXJ0eSBhbHdheXMgcmV0dXJucyBuaWwuCisgICAgICAgIEFkZGluZyBhIG1lbWViZXIgdmFy aWFibGUgdG8gc3RvcmUgdGhlIHBhc3RlYm9hcmQgbmFtZSBhbmQgcmV0dXJuIGl0cworICAgICAg ICB2YWx1ZSBmcm9tIHRoZSBuYW1lIG1ldGhvZCBpbnN0ZWFkIG9mIHJldHVybmluZyBuaWwgYWx3 YXlzLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog RHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlUGFzdGVib2FyZC5tOgorICAgICAgICAo K1tEdW1wUmVuZGVyVHJlZVBhc3RlYm9hcmQgX3Bhc3RlYm9hcmRXaXRoTmFtZTpdKToKKyAgICAg ICAgKC1bTG9jYWxQYXN0ZWJvYXJkIGluaXRXaXRoTmFtZTpdKToKKyAgICAgICAgKC1bTG9jYWxQ YXN0ZWJvYXJkIG5hbWVdKToKKwogMjAxMi0wMS0yNyAgTWFydGluIFJvYmluc29uICA8bXJvYmlu c29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gW1dLMl0gSW1wbGVtZW50IHRoZSBwb2xp Y3kgY2xpZW50CkluZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWVQ YXN0ZWJvYXJkLm0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBS ZW5kZXJUcmVlUGFzdGVib2FyZC5tCShyZXZpc2lvbiAxMDU5MDgpCisrKyBUb29scy9EdW1wUmVu ZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWVQYXN0ZWJvYXJkLm0JKHdvcmtpbmcgY29weSkKQEAg LTQwLDcgKzQwLDkgQEAgQGludGVyZmFjZSBMb2NhbFBhc3RlYm9hcmQgOiBOU1Bhc3RlYm9hcgog ICAgIE5TTXV0YWJsZVNldCAqdHlwZXNTZXQ7CiAgICAgTlNNdXRhYmxlRGljdGlvbmFyeSAqZGF0 YUJ5VHlwZTsKICAgICBOU0ludGVnZXIgY2hhbmdlQ291bnQ7CisgICAgTlNTdHJpbmcgKnBhc3Rl Ym9hcmROYW1lOwogfQorLShpZClpbml0V2l0aE5hbWU6KE5TU3RyaW5nKiluYW1lOwogQGVuZAog CiBzdGF0aWMgTlNNdXRhYmxlRGljdGlvbmFyeSAqbG9jYWxQYXN0ZWJvYXJkczsKQEAgLTU4LDcg KzYwLDcgQEAgKyAoTlNQYXN0ZWJvYXJkICopX3Bhc3RlYm9hcmRXaXRoTmFtZTooTgogICAgIExv Y2FsUGFzdGVib2FyZCAqcGFzdGVib2FyZCA9IFtsb2NhbFBhc3RlYm9hcmRzIG9iamVjdEZvcktl eTpuYW1lXTsKICAgICBpZiAocGFzdGVib2FyZCkKICAgICAgICAgcmV0dXJuIHBhc3RlYm9hcmQ7 Ci0gICAgcGFzdGVib2FyZCA9IFtbTG9jYWxQYXN0ZWJvYXJkIGFsbG9jXSBpbml0XTsKKyAgICBw YXN0ZWJvYXJkID0gW1tMb2NhbFBhc3RlYm9hcmQgYWxsb2NdIGluaXRXaXRoTmFtZTpuYW1lXTsK ICAgICBbbG9jYWxQYXN0ZWJvYXJkcyBzZXRPYmplY3Q6cGFzdGVib2FyZCBmb3JLZXk6bmFtZV07 CiAgICAgW3Bhc3RlYm9hcmQgcmVsZWFzZV07CiAgICAgcmV0dXJuIHBhc3RlYm9hcmQ7CkBAIC04 NiwxMSArODgsMTIgQEAgKyAoaWQpYWxsb2MKICAgICByZXR1cm4gTlNBbGxvY2F0ZU9iamVjdChz ZWxmLCAwLCAwKTsKIH0KIAotLSAoaWQpaW5pdAorLSAoaWQpaW5pdFdpdGhOYW1lOihOU1N0cmlu ZyopbmFtZQogewogICAgIHR5cGVzQXJyYXkgPSBbW05TTXV0YWJsZUFycmF5IGFsbG9jXSBpbml0 XTsKICAgICB0eXBlc1NldCA9IFtbTlNNdXRhYmxlU2V0IGFsbG9jXSBpbml0XTsKICAgICBkYXRh QnlUeXBlID0gW1tOU011dGFibGVEaWN0aW9uYXJ5IGFsbG9jXSBpbml0XTsKKyAgICBwYXN0ZWJv YXJkTmFtZSA9IG5hbWU7CiAgICAgcmV0dXJuIHNlbGY7CiB9CiAKQEAgLTEwNCw3ICsxMDcsNyBA QCAtICh2b2lkKWRlYWxsb2MKIAogLSAoTlNTdHJpbmcgKiluYW1lCiB7Ci0gICAgcmV0dXJuIG5p bDsKKyAgICByZXR1cm4gcGFzdGVib2FyZE5hbWU7CiB9CiAKIC0gKHZvaWQpcmVsZWFzZUdsb2Jh bGx5Cg==