77254 2012-01-27 15:44:50 -0800 Prepare WebCore.gyp for ffmpeg source transition. 2012-01-30 12:30:43 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dalecurtis tony abarth dpranke scherkus tony webkit.review.bot oldest_to_newest 544458 0 dalecurtis 2012-01-27 15:44:50 -0800 Prepare WebCore.gyp for ffmpeg source transition. 544461 1 124386 dalecurtis 2012-01-27 15:47:27 -0800 Created attachment 124386 Patch 544467 2 dalecurtis 2012-01-27 15:51:13 -0800 scherkus: Who is a good reviewer for this? Chromium try bots are in progress. Is there anything else to check? 544547 3 dalecurtis 2012-01-27 17:47:53 -0800 abarth: I noticed you've changed the WebCore.gyp file the most in recent history, can you please take a look at this? Chrome Linux/Mac/Win Trybots all passed compile. 544632 4 abarth 2012-01-28 00:20:50 -0800 Tony or dpranke is probably your best reviewer. 544822 5 124386 tony 2012-01-29 18:27:03 -0800 Comment on attachment 124386 Patch I would drop the trailing slash since we don't normally append it on include dirs. 544823 6 124482 tony 2012-01-29 18:29:32 -0800 Created attachment 124482 Patch for landing 544842 7 124482 webkit.review.bot 2012-01-29 19:49:32 -0800 Comment on attachment 124482 Patch for landing Clearing flags on attachment: 124482 Committed r106209: <http://trac.webkit.org/changeset/106209> 544843 8 webkit.review.bot 2012-01-29 19:49:37 -0800 All reviewed patches have been landed. Closing bug. 545308 9 dalecurtis 2012-01-30 12:30:43 -0800 Thanks for the review and nit fix Tony! 124386 2012-01-27 15:47:27 -0800 2012-01-29 18:29:26 -0800 Patch bug-77254-20120127154725.patch text/plain 1640 dalecurtis U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTYyMzRlMTM2M2E1MTg0 MzQzOWQ1YTE4NTZmMDg1MmM2MmUzNWY1My4uNjgzOTUzOGYwMmI5ZDc5NDExNzY1ZGM2NWMxYTQ3 MzU2NzQ4MjU5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAxLTI3ICBEYWxl IEN1cnRpcyAgPGRhbGVjdXJ0aXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFByZXBhcmUgV2Vi Q29yZS5neXAgZm9yIGZmbXBlZyBzb3VyY2UgdHJhbnNpdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3MjU0CisKKyAgICAgICAgV2UncmUgbWln cmF0aW5nIG91ciBmZm1wZWcgcmVwbyBmcm9tIGEgc2V0IG9mIHBhdGNoZXMgbGl2aW5nIG9uIHRv cCBvZgorICAgICAgICBhIHRhcmJhbGwgdG8gYW4gYWN0dWFsIGdpdCBmb3JrIG9mIHVwc3RyZWFt LiAgVGhlIHBhdGhzIGhhdmUgY2hhbmdlZAorICAgICAgICBzbGlnaHRseS4KKworICAgICAgICBJ biBvcmRlciB0byBub3QgYnJlYWsgdGhlIGN1cnJlbnQgYnVpbGQsIHdlJ2xsIGtlZXAgYm90aCBw YXRocyBhcm91bmQKKyAgICAgICAgdW50aWwgdGhlIHRyYW5zaXRpb24gaXMgY29tcGxldGUuICBB ZnRlcndhcmQgdGhlICdwYXRjaGVkLWZmbXBlZycgcGF0aAorICAgICAgICB3aWxsIGJlIHJlbW92 ZWQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLiBHWVAgY2hhbmdlLCBpZiBpdCBkb2Vzbid0IHdvcmssIG5vdGhpbmcgd2lsbCBj b21waWxlLgorCisgICAgICAgICogV2ViQ29yZS5neXAvV2ViQ29yZS5neXA6CisKIDIwMTItMDEt MjcgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJU aWxlTGF5ZXJzIHNob3VsZCBob25vciB0aGUgYWNjZWxlcmF0ZXNEcmF3aW5nIGZsYWcKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwIGIvU291cmNlL1dl YkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKaW5kZXggNjg4NGI0MWFmMWQxOWM5YzQ0NTdl ZDAxN2M0YmE5MTFmMTgyNDhjNy4uZDgzODEyYmQ0ZDg1ZDRhMzkyYzRlMWMzMjY3OGMwN2VhMjVl NWFiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAK KysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKQEAgLTEzNzgsNiAr MTM3OCw3IEBACiAgICAgICAgICAgJ2RpcmVjdF9kZXBlbmRlbnRfc2V0dGluZ3MnOiB7CiAgICAg ICAgICAgICAnaW5jbHVkZV9kaXJzJzogWwogICAgICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNf ZGlyKS90aGlyZF9wYXJ0eS9mZm1wZWcvcGF0Y2hlZC1mZm1wZWcnLAorICAgICAgICAgICAgICAn PChjaHJvbWl1bV9zcmNfZGlyKS90aGlyZF9wYXJ0eS9mZm1wZWcvJywKICAgICAgICAgICAgIF0s CiAgICAgICAgICAgfSwKICAgICAgICAgICAnZGVwZW5kZW5jaWVzJzogWwo= 124482 2012-01-29 18:29:32 -0800 2012-01-29 19:49:32 -0800 Patch for landing bug-77254-20120129183015.patch text/plain 1641 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWQ0MjYxN2UzZGNkYWJj YWRkNGUwM2NjZjI0ZDVmYTU2ZmNjYThjOS4uYTEyZjA5MzE4YzE2MTQwNjAyODViNWVhMDljNmY3 NjVhM2FhNDFiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAxLTI5ICBEYWxl IEN1cnRpcyAgPGRhbGVjdXJ0aXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFByZXBhcmUgV2Vi Q29yZS5neXAgZm9yIGZmbXBlZyBzb3VyY2UgdHJhbnNpdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3MjU0CisKKyAgICAgICAgV2UncmUgbWln cmF0aW5nIG91ciBmZm1wZWcgcmVwbyBmcm9tIGEgc2V0IG9mIHBhdGNoZXMgbGl2aW5nIG9uIHRv cCBvZgorICAgICAgICBhIHRhcmJhbGwgdG8gYW4gYWN0dWFsIGdpdCBmb3JrIG9mIHVwc3RyZWFt LiAgVGhlIHBhdGhzIGhhdmUgY2hhbmdlZAorICAgICAgICBzbGlnaHRseS4KKworICAgICAgICBJ biBvcmRlciB0byBub3QgYnJlYWsgdGhlIGN1cnJlbnQgYnVpbGQsIHdlJ2xsIGtlZXAgYm90aCBw YXRocyBhcm91bmQKKyAgICAgICAgdW50aWwgdGhlIHRyYW5zaXRpb24gaXMgY29tcGxldGUuICBB ZnRlcndhcmQgdGhlICdwYXRjaGVkLWZmbXBlZycgcGF0aAorICAgICAgICB3aWxsIGJlIHJlbW92 ZWQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVG9ueSBDaGFuZy4KKworICAgICAgICBObyBuZXcg dGVzdHMuIEdZUCBjaGFuZ2UsIGlmIGl0IGRvZXNuJ3Qgd29yaywgbm90aGluZyB3aWxsIGNvbXBp bGUuCisKKyAgICAgICAgKiBXZWJDb3JlLmd5cC9XZWJDb3JlLmd5cDoKKwogMjAxMi0wMS0yOSAg Tm9lbCBHb3Jkb24gIDxub2VsLmdvcmRvbkBnbWFpbC5jb20+CiAKICAgICAgICAgW2Nocm9taXVt XSBVc2UgZGVjb2Rpbmcgc3dpenpsZSBvbmx5IG9uIGxpYmpwZWctdHVyYm8gMS4xLjkwKwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAgYi9Tb3VyY2Uv V2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAppbmRleCA2ODg0YjQxYWYxZDE5YzljNDQ1 N2VkMDE3YzRiYTkxMWYxODI0OGM3Li4wMzU3MjA3NjE3YjZjYWI1YzI5MWQ3OTM0ZjQxODNmNzY1 ZjJlOGE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5 cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cApAQCAtMTM3OCw2 ICsxMzc4LDcgQEAKICAgICAgICAgICAnZGlyZWN0X2RlcGVuZGVudF9zZXR0aW5ncyc6IHsKICAg ICAgICAgICAgICdpbmNsdWRlX2RpcnMnOiBbCiAgICAgICAgICAgICAgICc8KGNocm9taXVtX3Ny Y19kaXIpL3RoaXJkX3BhcnR5L2ZmbXBlZy9wYXRjaGVkLWZmbXBlZycsCisgICAgICAgICAgICAg ICc8KGNocm9taXVtX3NyY19kaXIpL3RoaXJkX3BhcnR5L2ZmbXBlZycsCiAgICAgICAgICAgICBd LAogICAgICAgICAgIH0sCiAgICAgICAgICAgJ2RlcGVuZGVuY2llcyc6IFsK