77236 2012-01-27 12:46:38 -0800 [chromium] Don't ever skip drawing the non-composited content layer 2012-01-27 15:24:12 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne cc-bugs enne jamesr vangelis webkit.review.bot oldest_to_newest 544272 0 enne 2012-01-27 12:46:38 -0800 [chromium] Don't ever skip drawing the non-composited content layer 544276 1 124355 enne 2012-01-27 12:52:39 -0800 Created attachment 124355 Patch 544286 2 enne 2012-01-27 12:55:52 -0800 I considered the option of always reserving the root layer tiles first, but I think this would cause bad behavior in the case of a large layer that covers the entire root layer, where all that texture memory would get reserved but none of it is actually in use. So, instead, I felt like maybe just always checkerboarding the root layer might be a better solution. 544306 3 124355 jamesr 2012-01-27 13:10:35 -0800 Comment on attachment 124355 Patch R=me. At least with this we won't blue out 544429 4 124355 webkit.review.bot 2012-01-27 15:24:08 -0800 Comment on attachment 124355 Patch Clearing flags on attachment: 124355 Committed r106160: <http://trac.webkit.org/changeset/106160> 544430 5 webkit.review.bot 2012-01-27 15:24:12 -0800 All reviewed patches have been landed. Closing bug. 124355 2012-01-27 12:52:39 -0800 2012-01-27 15:24:08 -0800 Patch bug-77236-20120127125237.patch text/plain 5657 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmI3MmNjZDU3ZDkzNzg4 ZWNkZmJlYzJmZDFjZWFhNzVhODMxMWY0MS4uYWJmOWEzYTE3NDI3ZjcwYjlmNjllYzEwNTQyODll MGQ3YTc3MTJkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTAxLTI3ICBBZHJp ZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CisKKyAgICAgICAgW2Nocm9taXVtXSBEb24n dCBldmVyIHNraXAgZHJhd2luZyB0aGUgbm9uLWNvbXBvc2l0ZWQgY29udGVudCBsYXllcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzcyMzYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5jZSB0aGUgcm9v dCBsYXllciBoYXMgaXRzIHRleHR1cmVzIHBvdGVudGlhbGx5IHJlc2VydmVkIGxhc3QgaW4gYQor ICAgICAgICBmcm9udC10by1iYWNrIGl0ZXJhdGlvbiwgZG9uJ3QgZXZlciBza2lwIGRyYXdpbmcg aXQgaWYgd2UgY2FuJ3QKKyAgICAgICAgcmVzZXJ2ZSBpdHMgdGV4dHVyZXMuIEluc3RlYWQsIGNo ZWNrZXJib2FyZCBhbmQgZHJhdyBiYWNrZ3JvdW5kIGNvbG9yCisgICAgICAgIHF1YWRzIGluc3Rl YWQgdG8gZmlsbCB0aGUgdmlld3BvcnQuIFRoaXMgYmVoYXZpb3IgaXMgdGllZCB0byB0aGUKKyAg ICAgICAgYmFja2dyb3VuZEZpbGxzVmlld3BvcnQgc2V0dGluZy4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL1RpbGVkTGF5ZXJDaHJvbWl1bS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpUaWxlZExheWVyQ2hyb21pdW06OnByZXBhcmVUb1VwZGF0ZVRpbGVzKToKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVGlsaW5nRGF0YS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpDQ0xheWVyVGlsaW5nRGF0YTo6cmVzZXQpOgorICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVGlsZWRMYXllckltcGwuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6Q0NUaWxlZExheWVySW1wbDo6YXBwZW5kUXVhZHMpOgorCiAyMDEyLTAx LTI2ICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IFNjcmlwdHMgcGFuZWwgZWRpdG9yIGNvbnRhaW5lciBzaG91bGQgYmUgYmFz ZWQgb24gVUlTb3VyY2VDb2RlIG9iamVjdHMsIG5vdCBTb3VyY2VGcmFtZXMuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vQ2hhbmdlTG9nCmluZGV4IGRhOTIwZDVkMGI4YmMxZDUyNDBjZmE1ODFmYWIzN2ZhYjVjN2Q0 YmIuLjMyYjViN2ZmYzdkOTJkMTg0NGQ3YWRlMmI2YTk3YWNlMDdmZDBmNDggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDEtMjcgIEFkcmllbm5lIFdh bGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIERvbid0IGV2ZXIg c2tpcCBkcmF3aW5nIHRoZSBub24tY29tcG9zaXRlZCBjb250ZW50IGxheWVyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzIzNgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgYSB0aW55IGZpeC4g SWYgdGhlIG5vbi1jb21wb3NpdGVkIGNvbnRlbnQgbGF5ZXIgbmV2ZXIgZ2V0cworICAgICAgICBw YWludGVkLCB0aGVuIHRoZSBiYWNrZ3JvdW5kIGNvbG9yIG5ldmVyIGdldHMgc2V0IGFuZCBpdCBp cyBqdXN0CisgICAgICAgIG9wYXF1ZSBibGFjay4KKworICAgICAgICAqIHNyYy9XZWJWaWV3SW1w bC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpzZXRJc0FjY2VsZXJhdGVkQ29t cG9zaXRpbmdBY3RpdmUpOgorCiAyMDEyLTAxLTI1ICBHcmVnIEJpbGxvY2sgIDxnYmlsbG9ja0Bn b29nbGUuY29tPgogCiAgICAgICAgIEFkZCBJbnRlbnRSZXF1ZXN0IGluY2x1ZGUgZm9yIEZyYW1l TG9hZGVyQ2xpZW50SW1wbC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL1RpbGVkTGF5ZXJDaHJvbWl1bS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UaWxlZExheWVyQ2hyb21pdW0uY3BwCmluZGV4IDYz ODVkNjg5MDgxNjBhMzVjYmQ3OTRhNzAzOWJlMWUzZDBmYjU3MjYuLjBkNTJjNjE4ZjFkMTUzNjM5 MzA5NjhmMzM1NDI5ODMwMzE3ZTEyNTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL1RpbGVkTGF5ZXJDaHJvbWl1bS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVGlsZWRMYXllckNocm9taXVtLmNw cApAQCAtMzk1LDcgKzM5NSwxMCBAQCB2b2lkIFRpbGVkTGF5ZXJDaHJvbWl1bTo6cHJlcGFyZVRv VXBkYXRlVGlsZXMoYm9vbCBpZGxlLCBpbnQgbGVmdCwgaW50IHRvcCwgaW50CiAgICAgICAgICAg ICBpZiAoIXRpbGUtPm1hbmFnZWRUZXh0dXJlKCktPnJlc2VydmUobV90aWxlci0+dGlsZVNpemUo KSwgbV90ZXh0dXJlRm9ybWF0KSkgewogICAgICAgICAgICAgICAgIG1fc2tpcHNJZGxlUGFpbnQg PSB0cnVlOwogICAgICAgICAgICAgICAgIGlmICghaWRsZSkgewotICAgICAgICAgICAgICAgICAg ICBtX3NraXBzRHJhdyA9IHRydWU7CisgICAgICAgICAgICAgICAgICAgIC8vIElmIHRoZSBiYWNr Z3JvdW5kIGNvdmVycyB0aGUgdmlld3BvcnQsIGFsd2F5cyBkcmF3IHRoaXMKKyAgICAgICAgICAg ICAgICAgICAgLy8gbGF5ZXIgc28gdGhhdCBjaGVja2VyYm9hcmRlZCB0aWxlcyB3aWxsIHN0aWxs IGRyYXcuCisgICAgICAgICAgICAgICAgICAgIGlmICghYmFja2dyb3VuZENvdmVyc1ZpZXdwb3J0 KCkpCisgICAgICAgICAgICAgICAgICAgICAgICBtX3NraXBzRHJhdyA9IHRydWU7CiAgICAgICAg ICAgICAgICAgICAgIGNsZWFudXBSZXNvdXJjZXMoKTsKICAgICAgICAgICAgICAgICB9CiAgICAg ICAgICAgICAgICAgcmV0dXJuOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRpbGluZ0RhdGEuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRpbGluZ0RhdGEuY3BwCmlu ZGV4IDhiODYyMmI3OGFlZmFjOTczOTIxYTNkNTFjNGUyMDg0OGJjMmY3NmYuLjkyNjM3ZmM4M2Fm OTBjNGIyOTQ1OGViNDQyMzE5ZDc5YjY5MDNiNmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUaWxpbmdEYXRhLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVGls aW5nRGF0YS5jcHAKQEAgLTk2LDcgKzk2LDYgQEAgQ0NMYXllclRpbGluZ0RhdGE6OlRpbGUqIEND TGF5ZXJUaWxpbmdEYXRhOjp0aWxlQXQoaW50IGksIGludCBqKSBjb25zdAogdm9pZCBDQ0xheWVy VGlsaW5nRGF0YTo6cmVzZXQoKQogewogICAgIG1fdGlsZXMuY2xlYXIoKTsKLSAgICBtX3RpbGlu Z0RhdGEuc2V0VG90YWxTaXplKDAsIDApOwogfQogCiB2b2lkIENDTGF5ZXJUaWxpbmdEYXRhOjps YXllclJlY3RUb1RpbGVJbmRpY2VzKGNvbnN0IEludFJlY3QmIGxheWVyUmVjdCwgaW50JiBsZWZ0 LCBpbnQmIHRvcCwgaW50JiByaWdodCwgaW50JiBib3R0b20pIGNvbnN0CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1RpbGVkTGF5ZXJJ bXBsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0ND VGlsZWRMYXllckltcGwuY3BwCmluZGV4IDM0NGQ3NDI0NWY4ZWMxZjVmZGI2YzJjYjIxZGNkYjkx Y2FiNDkxODIuLmYxMTE3NzQ0OWY0YzAwNmUyZTIyODUwMTYzMmZiNjgwMzk4MDA3ODUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVGls ZWRMYXllckltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL2NjL0NDVGlsZWRMYXllckltcGwuY3BwCkBAIC0xMjcsNyArMTI3LDcgQEAgdm9pZCBD Q1RpbGVkTGF5ZXJJbXBsOjphcHBlbmRRdWFkcyhDQ1F1YWRMaXN0JiBxdWFkTGlzdCwgY29uc3Qg Q0NTaGFyZWRRdWFkU3RhdGUKIAogICAgIGFwcGVuZEd1dHRlclF1YWRzKHF1YWRMaXN0LCBzaGFy ZWRRdWFkU3RhdGUpOwogCi0gICAgaWYgKCFtX3RpbGVyIHx8IG1fdGlsZXItPmlzRW1wdHkoKSB8 fCBsYXllclJlY3QuaXNFbXB0eSgpKQorICAgIGlmICghbV90aWxlciB8fCAhbV90aWxlci0+bnVt VGlsZXMoKSB8fCBsYXllclJlY3QuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm47CiAKICAgICBp bnQgbGVmdCwgdG9wLCByaWdodCwgYm90dG9tOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViVmlld0ltcGwuY3BwCmluZGV4IDY2YThhOWQ5YzBhNjI3YzdjYmQxMWZlNDdhY2I5MzEyOThm N2U2YjAuLjYyYTYyYTY3YTMzYjY5ZTNkNjAzYzczNWFhZDUyOTJhMzdkODM0NDAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTMwMjAsNiArMzAyMCwx MCBAQCB2b2lkIFdlYlZpZXdJbXBsOjpzZXRJc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdBY3RpdmUo Ym9vbCBhY3RpdmUpCiAKICAgICAgICAgbV9ub25Db21wb3NpdGVkQ29udGVudEhvc3QgPSBOb25D b21wb3NpdGVkQ29udGVudEhvc3Q6OmNyZWF0ZShXZWJWaWV3SW1wbENvbnRlbnRQYWludGVyOjpj cmVhdGUodGhpcykpOwogICAgICAgICBtX25vbkNvbXBvc2l0ZWRDb250ZW50SG9zdC0+c2V0U2hv d0RlYnVnQm9yZGVycyhwYWdlKCktPnNldHRpbmdzKCktPnNob3dEZWJ1Z0JvcmRlcnMoKSk7CisK KyAgICAgICAgaWYgKHBhZ2UoKSAmJiBwYWdlKCktPm1haW5GcmFtZSgpLT52aWV3KCkpCisgICAg ICAgICAgICBtX25vbkNvbXBvc2l0ZWRDb250ZW50SG9zdC0+c2V0QmFja2dyb3VuZENvbG9yKHBh Z2UoKS0+bWFpbkZyYW1lKCktPnZpZXcoKS0+ZG9jdW1lbnRCYWNrZ3JvdW5kQ29sb3IoKSk7CisK ICAgICAgICAgbV9sYXllclRyZWVIb3N0ID0gQ0NMYXllclRyZWVIb3N0OjpjcmVhdGUodGhpcywg Y2NTZXR0aW5ncyk7CiAgICAgICAgIGlmIChtX2xheWVyVHJlZUhvc3QpIHsKICAgICAgICAgICAg IG1fbGF5ZXJUcmVlSG9zdC0+c2V0SGF2ZVdoZWVsRXZlbnRIYW5kbGVycyhtX2hhdmVXaGVlbEV2 ZW50SGFuZGxlcnMpOwo=