77186 2012-01-26 22:15:32 -0800 [Chromium] REGRESSION(r87067): WebFrame::setFindEndstateFocusAndSelection() doesn't set the selection for <input> and <textarea> 2012-01-30 01:37:39 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Other All RESOLVED FIXED P1 Normal --- 1 tkent tkent dglazkov dominicc hayato morrita oldest_to_newest 543834 0 tkent 2012-01-26 22:15:32 -0800 http://code.google.com/p/chromium/issues/detail?id=109379 543845 1 124265 tkent 2012-01-26 22:31:52 -0800 Created attachment 124265 Patch 544847 2 124265 morrita 2012-01-29 20:04:31 -0800 Comment on attachment 124265 Patch Looks OK. But having if (host->hasTagName(HTMLNames::inputTag) || host->hasTagName(HTMLNames::textareaTag)) looks cryptic a bit. Hopefully we can give some intention revealing name for this kind of check. 544850 3 tkent 2012-01-29 20:13:41 -0800 (In reply to comment #2) > Looks OK. But having if (host->hasTagName(HTMLNames::inputTag) || host->hasTagName(HTMLNames::textareaTag)) looks cryptic a bit. Hopefully we can give some intention revealing name for this kind of check. How about changing it to "if (host->isFocusable())" ? Does it make sense for non-builtin shadow DOM components? 544872 4 hayato 2012-01-29 21:29:28 -0800 (In reply to comment #3) > (In reply to comment #2) > > Looks OK. But having if (host->hasTagName(HTMLNames::inputTag) || host->hasTagName(HTMLNames::textareaTag)) looks cryptic a bit. Hopefully we can give some intention revealing name for this kind of check. > > How about changing it to "if (host->isFocusable())" ? Does it make sense for non-builtin shadow DOM components? I don't think it make sense for non-buitin shadow DOM components. I cannot see a clear reason to return host instead of an internal focusable element in case of non-builtin shadow DOM components. 544876 5 tkent 2012-01-29 21:36:19 -0800 ok, I'm landing the patch as is for now. 544898 6 124265 webkit.review.bot 2012-01-29 23:23:15 -0800 Comment on attachment 124265 Patch Clearing flags on attachment: 124265 Committed r106216: <http://trac.webkit.org/changeset/106216> 124265 2012-01-26 22:31:52 -0800 2012-01-29 23:23:15 -0800 Patch bug-77186-20120127153150.patch text/plain 6355 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGE5MWZkNzVlMjYyOTJlYzM5NTVmMGI4MGUzZmViNzRhM2ZkODMyZjMuLjI0Y2NlMjQ2N2FlY2Ex YzNlMGUyN2NjMmUwODdhNTBjMThiM2I1OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjcgQEAKKzIwMTItMDEtMjYgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gUkVHUkVTU0lPTihyODcwNjcpOiBXZWJGcmFtZTo6 c2V0RmluZEVuZHN0YXRlRm9jdXNBbmRTZWxlY3Rpb24oKQorICAgICAgICBkb2Vzbid0IHNldCB0 aGUgc2VsZWN0aW9uIGZvciA8aW5wdXQ+IGFuZCA8dGV4dGFyZWE+CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzE4NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gdGhlIGZpbmQtaW4tcGFnZSBib3gg aXMgY2xvc2VkLCBXZWJGcmFtZTo6c3RvcEZpbmRpbmcoZmFsc2UpIGlzCisgICAgICAgIGNhbGxl ZC4gSXQgY2FsbHMgc2V0RmluZEVuZHN0YXRlRm9jdXNBbmRTZWxlY3Rpb24oKS4gQmVmb3JlIHI4 NzA2NywKKyAgICAgICAgbV9hY3RpdmVNYXRjaCB3YXMgc3RvcmVkIGFzIHRoZSBub3JtYWwgc2Vs ZWN0aW9uIGluIDxpbnB1dD4gb3IKKyAgICAgICAgPHRleHRhcmVhPiBieSBhY2NpZGVudC4gcjg3 MDY3IHN0b3BwZWQgdGhpcyBhY2NpZGVudGFsIGJlaGF2aW9yLgorCisgICAgICAgIEhvd2V2ZXIg dGhlIGJlaGF2aW9yIG9mIHByZS1yODcwNjcgaXMgdXNlZnVsIGFuZCB3ZSBzaG91bGQgc3VwcG9y dCBpdAorICAgICAgICBmb3IgY29udGVudEVkaXRhYmxlIGVsZW1lbnRzIHRvby4KKworICAgICAg ICAqIHNyYy9XZWJGcmFtZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUltcGw6 OnNldEZpbmRFbmRzdGF0ZUZvY3VzQW5kU2VsZWN0aW9uKToKKyAgICAgICAgLSBBZGQgc3BlY2lh bCBoYW5kaW5nIGZvciA8aW5wdXQ+IGFuZCA8dGV4dGFyZWE+IHRvIGZpbmQgYSBmb2N1c2FibGUg cGFyZW50LgorICAgICAgICAtIFNldHMgdGhlIGFjdGl2ZSBtYXRjaCBhcyB0aGUgc2VsZWN0aW9u IGV2ZW4gaWYgYSBmb2N1c2FibGUgcGFyZW50IGlzIGZvdW5kLgorICAgICAgICAqIHRlc3RzL1dl YkZyYW1lVGVzdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OlRFU1RfRik6IEFkZCB0ZXN0cyBmb3Ig ZmluZCgpIGFuZCBzdG9wRmluZGluZygpLgorICAgICAgICAqIHRlc3RzL2RhdGEvZmluZC5odG1s OiBBZGRlZC4KKwogMjAxMi0wMS0yNiAgVy4gSmFtZXMgTWFjTGVhbiAgPHdqbWFjbGVhbkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBBbGxvdyBtb2RpZmljYXRpb24gb2Ygc2l6 ZSBvZiBwYXJ0aWFsbHkgb2NjbHVkZWQgcXVhZHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViRnJhbWVJbXBsLmNwcAppbmRleCA5ZDBlMGMzNDMzMTgxYTY1ODk5ZTE0NGU2YTY1Yjk2 OGRmNjY3ODU0Li45MTYzZTJlN2RlYzM1YzRlNDFiYjhkNGIwYjRiZGI2NDZlMWU3MTgyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKQEAgLTIxNjQsMTEg KzIxNjQsMTggQEAgdm9pZCBXZWJGcmFtZUltcGw6OnNldEZpbmRFbmRzdGF0ZUZvY3VzQW5kU2Vs ZWN0aW9uKCkKICAgICAgICAgLy8gVHJ5IHRvIGZpbmQgdGhlIGZpcnN0IGZvY3VzYWJsZSBub2Rl IHVwIHRoZSBjaGFpbiwgd2hpY2ggd2lsbCwgZm9yCiAgICAgICAgIC8vIGV4YW1wbGUsIGZvY3Vz IGxpbmtzIGlmIHdlIGhhdmUgZm91bmQgdGV4dCB3aXRoaW4gdGhlIGxpbmsuCiAgICAgICAgIE5v ZGUqIG5vZGUgPSBtX2FjdGl2ZU1hdGNoLT5maXJzdE5vZGUoKTsKKyAgICAgICAgaWYgKG5vZGUg JiYgbm9kZS0+aXNJblNoYWRvd1RyZWUoKSkgeworICAgICAgICAgICAgTm9kZSogaG9zdCA9IG5v ZGUtPnNoYWRvd0FuY2VzdG9yTm9kZSgpOworICAgICAgICAgICAgaWYgKGhvc3QtPmhhc1RhZ05h bWUoSFRNTE5hbWVzOjppbnB1dFRhZykgfHwgaG9zdC0+aGFzVGFnTmFtZShIVE1MTmFtZXM6OnRl eHRhcmVhVGFnKSkKKyAgICAgICAgICAgICAgICBub2RlID0gaG9zdDsKKyAgICAgICAgfQogICAg ICAgICB3aGlsZSAobm9kZSAmJiAhbm9kZS0+aXNGb2N1c2FibGUoKSAmJiBub2RlICE9IGZyYW1l KCktPmRvY3VtZW50KCkpCiAgICAgICAgICAgICBub2RlID0gbm9kZS0+cGFyZW50Tm9kZSgpOwog CiAgICAgICAgIGlmIChub2RlICYmIG5vZGUgIT0gZnJhbWUoKS0+ZG9jdW1lbnQoKSkgewotICAg ICAgICAgICAgLy8gRm91bmQgYSBmb2N1c2FibGUgcGFyZW50IG5vZGUuIFNldCBmb2N1cyB0byBp dC4KKyAgICAgICAgICAgIC8vIEZvdW5kIGEgZm9jdXNhYmxlIHBhcmVudCBub2RlLiBTZXQgdGhl IGFjdGl2ZSBtYXRjaCBhcyB0aGUKKyAgICAgICAgICAgIC8vIHNlbGVjdGlvbiBhbmQgZm9jdXMg dG8gdGhlIGZvY3VzYWJsZSBub2RlLgorICAgICAgICAgICAgZnJhbWUoKS0+c2VsZWN0aW9uKCkt PnNldFNlbGVjdGlvbihtX2FjdGl2ZU1hdGNoLmdldCgpKTsKICAgICAgICAgICAgIGZyYW1lKCkt PmRvY3VtZW50KCktPnNldEZvY3VzZWROb2RlKG5vZGUpOwogICAgICAgICAgICAgcmV0dXJuOwog ICAgICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYkZy YW1lVGVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYkZyYW1lVGVzdC5j cHAKaW5kZXggMmIyZWE3NjAxNWM0NmJmNzkzYmZjZmExMjIyZGEzOThmMTM3ZjYxNi4uYjU5MDAx ODYwZGEyYWI5YmJmMGEyZDgyYjI4MjZkYzgwYmNkYWYyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS90ZXN0cy9XZWJGcmFtZVRlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vdGVzdHMvV2ViRnJhbWVUZXN0LmNwcApAQCAtMzMsOSArMzMsMTEgQEAKICNpbmNs dWRlICJGcmFtZVRlc3RIZWxwZXJzLmgiCiAjaW5jbHVkZSAiUmVzb3VyY2VFcnJvci5oIgogI2lu Y2x1ZGUgIldlYkRvY3VtZW50LmgiCisjaW5jbHVkZSAiV2ViRmluZE9wdGlvbnMuaCIKICNpbmNs dWRlICJXZWJGb3JtRWxlbWVudC5oIgogI2luY2x1ZGUgIldlYkZyYW1lLmgiCiAjaW5jbHVkZSAi V2ViRnJhbWVDbGllbnQuaCIKKyNpbmNsdWRlICJXZWJSYW5nZS5oIgogI2luY2x1ZGUgIldlYlNj cmlwdFNvdXJjZS5oIgogI2luY2x1ZGUgIldlYlNlYXJjaGFibGVGb3JtRGF0YS5oIgogI2luY2x1 ZGUgIldlYlNlY3VyaXR5UG9saWN5LmgiCkBAIC0zNzksNCArMzgxLDU0IEBAIFRFU1RfRihXZWJG cmFtZVRlc3QsIENvbnRleHROb3RpZmljYXRpb25zSXNvbGF0ZWRXb3JsZHMpCiAgICAgRVhQRUNU X0VRKDEsIG1hdGNoQ291bnQpOwogfQogCitURVNUX0YoV2ViRnJhbWVUZXN0LCBGaW5kSW5QYWdl KQoreworICAgIHJlZ2lzdGVyTW9ja2VkSHR0cFVSTExvYWQoImZpbmQuaHRtbCIpOworICAgIFdl YlZpZXcqIHdlYlZpZXcgPSBGcmFtZVRlc3RIZWxwZXJzOjpjcmVhdGVXZWJWaWV3QW5kTG9hZCht X2Jhc2VVUkwgKyAiZmluZC5odG1sIik7CisgICAgV2ViRnJhbWUqIGZyYW1lID0gd2ViVmlldy0+ bWFpbkZyYW1lKCk7CisgICAgY29uc3QgaW50IGZpbmRJZGVudGlmaWVyID0gMTIzNDU7CisgICAg V2ViRmluZE9wdGlvbnMgb3B0aW9uczsKKworICAgIC8vIEZpbmQgaW4gYSA8ZGl2PiBlbGVtZW50 LgorICAgIEVYUEVDVF9UUlVFKGZyYW1lLT5maW5kKGZpbmRJZGVudGlmaWVyLCBXZWJTdHJpbmc6 OmZyb21VVEY4KCJiYXIxIiksIG9wdGlvbnMsIGZhbHNlLCAwKSk7CisgICAgZnJhbWUtPnN0b3BG aW5kaW5nKGZhbHNlKTsKKyAgICBXZWJSYW5nZSByYW5nZSA9IGZyYW1lLT5zZWxlY3Rpb25SYW5n ZSgpOworICAgIEVYUEVDVF9FUSg1LCByYW5nZS5zdGFydE9mZnNldCgpKTsKKyAgICBFWFBFQ1Rf RVEoOSwgcmFuZ2UuZW5kT2Zmc2V0KCkpOworICAgIEVYUEVDVF9UUlVFKGZyYW1lLT5kb2N1bWVu dCgpLmZvY3VzZWROb2RlKCkuaXNOdWxsKCkpOworCisgICAgLy8gRmluZCBpbiBhbiA8aW5wdXQ+ IHZhbHVlLgorICAgIEVYUEVDVF9UUlVFKGZyYW1lLT5maW5kKGZpbmRJZGVudGlmaWVyLCBXZWJT dHJpbmc6OmZyb21VVEY4KCJiYXIyIiksIG9wdGlvbnMsIGZhbHNlLCAwKSk7CisgICAgLy8gQ29u ZmlybSBzdG9wRmluZGluZyhmYWxzZSkgc2V0cyB0aGUgc2VsZWN0aW9uIG9uIHRoZSBmb3VuZCB0 ZXh0LgorICAgIGZyYW1lLT5zdG9wRmluZGluZyhmYWxzZSk7CisgICAgcmFuZ2UgPSBmcmFtZS0+ c2VsZWN0aW9uUmFuZ2UoKTsKKyAgICBBU1NFUlRfRkFMU0UocmFuZ2UuaXNOdWxsKCkpOworICAg IEVYUEVDVF9FUSg1LCByYW5nZS5zdGFydE9mZnNldCgpKTsKKyAgICBFWFBFQ1RfRVEoOSwgcmFu Z2UuZW5kT2Zmc2V0KCkpOworICAgIEVYUEVDVF9FUShXZWJTdHJpbmc6OmZyb21VVEY4KCJJTlBV VCIpLCBmcmFtZS0+ZG9jdW1lbnQoKS5mb2N1c2VkTm9kZSgpLm5vZGVOYW1lKCkpOworCisgICAg Ly8gRmluZCBpbiBhIDx0ZXh0YXJlYT4gY29udGVudC4KKyAgICBFWFBFQ1RfVFJVRShmcmFtZS0+ ZmluZChmaW5kSWRlbnRpZmllciwgV2ViU3RyaW5nOjpmcm9tVVRGOCgiYmFyMyIpLCBvcHRpb25z LCBmYWxzZSwgMCkpOworICAgIC8vIENvbmZpcm0gc3RvcEZpbmRpbmcoZmFsc2UpIHNldHMgdGhl IHNlbGVjdGlvbiBvbiB0aGUgZm91bmQgdGV4dC4KKyAgICBmcmFtZS0+c3RvcEZpbmRpbmcoZmFs c2UpOworICAgIHJhbmdlID0gZnJhbWUtPnNlbGVjdGlvblJhbmdlKCk7CisgICAgQVNTRVJUX0ZB TFNFKHJhbmdlLmlzTnVsbCgpKTsKKyAgICBFWFBFQ1RfRVEoNSwgcmFuZ2Uuc3RhcnRPZmZzZXQo KSk7CisgICAgRVhQRUNUX0VRKDksIHJhbmdlLmVuZE9mZnNldCgpKTsKKyAgICBFWFBFQ1RfRVEo V2ViU3RyaW5nOjpmcm9tVVRGOCgiVEVYVEFSRUEiKSwgZnJhbWUtPmRvY3VtZW50KCkuZm9jdXNl ZE5vZGUoKS5ub2RlTmFtZSgpKTsKKworICAgIC8vIEZpbmQgaW4gYSBjb250ZW50RWRpdGFibGUg ZWxlbWVudC4KKyAgICBFWFBFQ1RfVFJVRShmcmFtZS0+ZmluZChmaW5kSWRlbnRpZmllciwgV2Vi U3RyaW5nOjpmcm9tVVRGOCgiYmFyNCIpLCBvcHRpb25zLCBmYWxzZSwgMCkpOworICAgIC8vIENv bmZpcm0gc3RvcEZpbmRpbmcoZmFsc2UpIHNldHMgdGhlIHNlbGVjdGlvbiBvbiB0aGUgZm91bmQg dGV4dC4KKyAgICBmcmFtZS0+c3RvcEZpbmRpbmcoZmFsc2UpOworICAgIHJhbmdlID0gZnJhbWUt PnNlbGVjdGlvblJhbmdlKCk7CisgICAgQVNTRVJUX0ZBTFNFKHJhbmdlLmlzTnVsbCgpKTsKKyAg ICBFWFBFQ1RfRVEoMCwgcmFuZ2Uuc3RhcnRPZmZzZXQoKSk7CisgICAgRVhQRUNUX0VRKDQsIHJh bmdlLmVuZE9mZnNldCgpKTsKKyAgICAvLyAiYmFyNCIgaXMgc3Vycm91bmRlZCBieSA8c3Bhbj4s IGJ1dCB0aGUgZm9jdXNhYmxlIG5vZGUgc2hvdWxkIGJlIHRoZSBwYXJlbnQgPGRpdj4uCisgICAg RVhQRUNUX0VRKFdlYlN0cmluZzo6ZnJvbVVURjgoIkRJViIpLCBmcmFtZS0+ZG9jdW1lbnQoKS5m b2N1c2VkTm9kZSgpLm5vZGVOYW1lKCkpOworCisgICAgd2ViVmlldy0+Y2xvc2UoKTsKK30KKwog fSAvLyBuYW1lc3BhY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMv ZGF0YS9maW5kLmh0bWwgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL2RhdGEvZmluZC5o dG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAuLjk1MmM4MjNmYjdiZGMxMjhmODQxODQ0NWZmNTk1YmRlOTdlNTQyMTUK LS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL2RhdGEvZmlu ZC5odG1sCkBAIC0wLDAgKzEsNiBAQAorPGJvZHk+Cis8ZGl2PmZvbzEgYmFyMSBiYXoxPC9kaXY+ Cis8aW5wdXQgdmFsdWU9ImZvbzIgYmFyMiBiYXoyIj4KKzx0ZXh0YXJlYT5mb28zIGJhcjMgYmF6 MzwvdGV4dGFyZWE+Cis8ZGl2IGNvbnRlbnRFZGl0YWJsZT0idHJ1ZSI+Zm9vNCA8c3Bhbj5iYXI0 PC9zcGFuPiBiYXo0PC9kaXY+Cis8L2JvZHk+Cg==