77185 2012-01-26 22:08:13 -0800 ImageBuffer::draw should deep copy if drawing to an accelerated context 2018-12-06 13:57:55 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=192471 P2 Normal --- 1 mdelaney7 mdelaney7 mdelaney7 simon.fraser oldest_to_newest 543831 0 mdelaney7 2012-01-26 22:08:13 -0800 Currently, ImageBuffer::draw shallow copies itself when it's unaccelerated by wrapping its data provider bits in a CGImage. However, the CG API requires that those bits don't change before it gets a chance to draw with them which is something ImageBuffer very much doesn't guarantee since it's basically intended for the exact opposite purpose. Thus, especially in the case of accelerated canvas there can be image tearing so we need to always do a deep copy if the destination context is accelerated. Unfortunately, due to the nature of this issue it's hard to make any non-flaky test, however the code fix is simple and safe as it was our old path before the shallow copy optimization was introduced. 543838 1 124261 mdelaney7 2012-01-26 22:24:16 -0800 Created attachment 124261 Patch 543853 2 mdelaney7 2012-01-26 23:23:28 -0800 Committed r106095: <http://trac.webkit.org/changeset/106095> 124261 2012-01-26 22:24:16 -0800 2012-01-26 22:31:21 -0800 Patch bug-77185-20120126222414.patch text/plain 3377 mdelaney7 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNjA4OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAxLTI2ICBNYXR0aGV3 IERlbGFuZXkgIDxtZGVsYW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgSW1hZ2VCdWZmZXI6OmRy YXcgc2hvdWxkIGRlZXAgY29weSBpZiBkcmF3aW5nIHRvIGFuIGFjY2VsZXJhdGVkIGNvbnRleHQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3MTg1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzIHNpbmNlIGFueSB0ZXN0IGZvciB0aGlzIGlzc3VlIHdvdWxkIGJlIGZsYWt5IGF0IGJlc3Qu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUJ1ZmZlckNHLmNwcDogRGVl cCBjb3B5IHdoZW4gZHJhd2luZyBvdXJzZWxmIGludG8KKyAgICAgICAgICAgIGFuIGFjY2VsZXJh dGVkIGNvbnRleHQgZm9yIGJvdGggZHJhdyBhbmQgZHJhd1BhdHRlcm4uCisgICAgICAgIChXZWJD b3JlOjpJbWFnZUJ1ZmZlcjo6ZHJhdyk6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6 ZHJhd1BhdHRlcm4pOgorCiAyMDEyLTAxLTI2ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcu Ym90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTA1NDg2 LgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VCdWZmZXJD Ry5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cv SW1hZ2VCdWZmZXJDRy5jcHAJKHJldmlzaW9uIDEwNTg0OSkKKysrIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlQnVmZmVyQ0cuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0y NDEsNyArMjQxLDcgQEAgdm9pZCBJbWFnZUJ1ZmZlcjo6ZHJhdyhHcmFwaGljc0NvbnRleHQqIAog ICAgIENvbG9yU3BhY2UgY29sb3JTcGFjZSA9IChkZXN0Q29udGV4dCA9PSBtX2NvbnRleHQpID8g Q29sb3JTcGFjZURldmljZVJHQiA6IHN0eWxlQ29sb3JTcGFjZTsKIAogICAgIFJldGFpblB0cjxD R0ltYWdlUmVmPiBpbWFnZTsKLSAgICBpZiAoZGVzdENvbnRleHQgPT0gbV9jb250ZXh0KQorICAg IGlmIChkZXN0Q29udGV4dCA9PSBtX2NvbnRleHQgfHwgZGVzdENvbnRleHQtPmlzQWNjZWxlcmF0 ZWRDb250ZXh0KCkpCiAgICAgICAgIGltYWdlLmFkb3B0Q0YoY29weU5hdGl2ZUltYWdlKENvcHlC YWNraW5nU3RvcmUpKTsgLy8gRHJhd2luZyBpbnRvIG91ciBvd24gYnVmZmVyLCBuZWVkIHRvIGRl ZXAgY29weS4KICAgICBlbHNlCiAgICAgICAgIGltYWdlLmFkb3B0Q0YoY29weU5hdGl2ZUltYWdl KERvbnRDb3B5QmFja2luZ1N0b3JlKSk7CkBAIC0yNDksMTkgKzI0OSwxOSBAQCB2b2lkIEltYWdl QnVmZmVyOjpkcmF3KEdyYXBoaWNzQ29udGV4dCogCiAgICAgZGVzdENvbnRleHQtPmRyYXdOYXRp dmVJbWFnZShpbWFnZS5nZXQoKSwgbV9zaXplLCBjb2xvclNwYWNlLCBkZXN0UmVjdCwgc3JjUmVj dCwgb3ApOwogfQogCi12b2lkIEltYWdlQnVmZmVyOjpkcmF3UGF0dGVybihHcmFwaGljc0NvbnRl eHQqIGNvbnRleHQsIGNvbnN0IEZsb2F0UmVjdCYgc3JjUmVjdCwgY29uc3QgQWZmaW5lVHJhbnNm b3JtJiBwYXR0ZXJuVHJhbnNmb3JtLCBjb25zdCBGbG9hdFBvaW50JiBwaGFzZSwgQ29sb3JTcGFj ZSBzdHlsZUNvbG9yU3BhY2UsIENvbXBvc2l0ZU9wZXJhdG9yIG9wLCBjb25zdCBGbG9hdFJlY3Qm IGRlc3RSZWN0KQordm9pZCBJbWFnZUJ1ZmZlcjo6ZHJhd1BhdHRlcm4oR3JhcGhpY3NDb250ZXh0 KiBkZXN0Q29udGV4dCwgY29uc3QgRmxvYXRSZWN0JiBzcmNSZWN0LCBjb25zdCBBZmZpbmVUcmFu c2Zvcm0mIHBhdHRlcm5UcmFuc2Zvcm0sIGNvbnN0IEZsb2F0UG9pbnQmIHBoYXNlLCBDb2xvclNw YWNlIHN0eWxlQ29sb3JTcGFjZSwgQ29tcG9zaXRlT3BlcmF0b3Igb3AsIGNvbnN0IEZsb2F0UmVj dCYgZGVzdFJlY3QpCiB7CiAgICAgaWYgKCFtX2NvbnRleHQtPmlzQWNjZWxlcmF0ZWRDb250ZXh0 KCkpIHsKLSAgICAgICAgaWYgKGNvbnRleHQgPT0gbV9jb250ZXh0KSB7CisgICAgICAgIGlmIChk ZXN0Q29udGV4dCA9PSBtX2NvbnRleHQgfHwgZGVzdENvbnRleHQtPmlzQWNjZWxlcmF0ZWRDb250 ZXh0KCkpIHsKICAgICAgICAgICAgIFJlZlB0cjxJbWFnZT4gY29weSA9IGNvcHlJbWFnZShDb3B5 QmFja2luZ1N0b3JlKTsgLy8gRHJhd2luZyBpbnRvIG91ciBvd24gYnVmZmVyLCBuZWVkIHRvIGRl ZXAgY29weS4KLSAgICAgICAgICAgIGNvcHktPmRyYXdQYXR0ZXJuKGNvbnRleHQsIHNyY1JlY3Qs IHBhdHRlcm5UcmFuc2Zvcm0sIHBoYXNlLCBzdHlsZUNvbG9yU3BhY2UsIG9wLCBkZXN0UmVjdCk7 CisgICAgICAgICAgICBjb3B5LT5kcmF3UGF0dGVybihkZXN0Q29udGV4dCwgc3JjUmVjdCwgcGF0 dGVyblRyYW5zZm9ybSwgcGhhc2UsIHN0eWxlQ29sb3JTcGFjZSwgb3AsIGRlc3RSZWN0KTsKICAg ICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgIFJlZlB0cjxJbWFnZT4gaW1hZ2VGb3JSZW5kZXJp bmcgPSBjb3B5SW1hZ2UoRG9udENvcHlCYWNraW5nU3RvcmUpOwotICAgICAgICAgICAgaW1hZ2VG b3JSZW5kZXJpbmctPmRyYXdQYXR0ZXJuKGNvbnRleHQsIHNyY1JlY3QsIHBhdHRlcm5UcmFuc2Zv cm0sIHBoYXNlLCBzdHlsZUNvbG9yU3BhY2UsIG9wLCBkZXN0UmVjdCk7CisgICAgICAgICAgICBp bWFnZUZvclJlbmRlcmluZy0+ZHJhd1BhdHRlcm4oZGVzdENvbnRleHQsIHNyY1JlY3QsIHBhdHRl cm5UcmFuc2Zvcm0sIHBoYXNlLCBzdHlsZUNvbG9yU3BhY2UsIG9wLCBkZXN0UmVjdCk7CiAgICAg ICAgIH0KICAgICB9IGVsc2UgewogICAgICAgICBSZWZQdHI8SW1hZ2U+IGNvcHkgPSBjb3B5SW1h Z2UoQ29weUJhY2tpbmdTdG9yZSk7Ci0gICAgICAgIGNvcHktPmRyYXdQYXR0ZXJuKGNvbnRleHQs IHNyY1JlY3QsIHBhdHRlcm5UcmFuc2Zvcm0sIHBoYXNlLCBzdHlsZUNvbG9yU3BhY2UsIG9wLCBk ZXN0UmVjdCk7CisgICAgICAgIGNvcHktPmRyYXdQYXR0ZXJuKGRlc3RDb250ZXh0LCBzcmNSZWN0 LCBwYXR0ZXJuVHJhbnNmb3JtLCBwaGFzZSwgc3R5bGVDb2xvclNwYWNlLCBvcCwgZGVzdFJlY3Qp OwogICAgIH0KIH0KIAo=