77181 2012-01-26 20:47:27 -0800 [chromium] CCLayerTreeHostImpl minor code cleanup 2012-01-27 15:14:17 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 trchen webkit-unassigned aelias cc-bugs jamesr nduca trchen webkit.review.bot oldest_to_newest 543787 0 trchen 2012-01-26 20:47:27 -0800 [chromium] CCLayerTreeHostImpl minor code cleanup 543792 1 124250 trchen 2012-01-26 20:50:31 -0800 Created attachment 124250 Patch 543812 2 124250 jamesr 2012-01-26 21:14:16 -0800 Comment on attachment 124250 Patch R=me, thanks! 544421 3 124250 webkit.review.bot 2012-01-27 15:14:13 -0800 Comment on attachment 124250 Patch Clearing flags on attachment: 124250 Committed r106158: <http://trac.webkit.org/changeset/106158> 544422 4 webkit.review.bot 2012-01-27 15:14:17 -0800 All reviewed patches have been landed. Closing bug. 124250 2012-01-26 20:50:31 -0800 2012-01-27 15:14:13 -0800 Patch bug-77181-20120126205030.patch text/plain 5440 trchen U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MDU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDNiMzcyMWM1OGYwNjAz MDU2NGM3OTNlOTkyMzk0MGJlZjA3ZTJhYi4uNGIxODIyMjdjMjQxYmM4NTdlNWQ5NzcxMzE5OGM4 MmY0OGQ4MmFhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTAxLTI2ICBUaWVu LVJlbiBDaGVuICA8dHJjaGVuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEND TGF5ZXJUcmVlSG9zdEltcGwgbWlub3IgY29kZSBjbGVhbnVwCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzE4MQorCisgICAgICAgIEZpeCBhIHR5cG8g aW4gY29tbWVudHMgYW5kIGdyb3VwIGZ1bmN0aW9ucyBwcm9wZXJseS4KKyAgICAgICAgUmVwbGFj ZSBkdXBsaWNhdGVkIGNvbnRlbnQgc2l6ZSBjb2RlIHdpdGggZnVuY3Rpb24uCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBj aGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNDTGF5ZXJU cmVlSG9zdEltcGw6OnN0YXJ0UGFnZVNjYWxlQW5pbWF0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6 OkNDTGF5ZXJUcmVlSG9zdEltcGw6OmNvbnRlbnRTaXplKToKKyAgICAgICAgKFdlYkNvcmUpOgor ICAgICAgICAoV2ViQ29yZTo6Q0NMYXllclRyZWVIb3N0SW1wbDo6dXBkYXRlTWF4U2Nyb2xsUG9z aXRpb24pOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJU cmVlSG9zdEltcGwuaDoKKyAgICAgICAgKENDTGF5ZXJUcmVlSG9zdEltcGwpOgorCiAyMDEyLTAx LTI1ICBDcmlzIE5lY2thciAgPGNkbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWRkIGEgc2No ZW1lIHJlZ2lzdHJ5IGZvciBDT1JTIHJlcXVlc3RzLiBBbGxvdyBzaW1wbGUgQ09SUyByZXF1ZXN0 cyB0byBiZSBtYWRlIHRvIHJlZ2lzdGVyZWQgc2NoZW1lcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdEltcGwu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXll clRyZWVIb3N0SW1wbC5jcHAKaW5kZXggNmMyYzc0MjZmYzBiOTUwMDFkZWVlOGE3MDk0ZWM5Y2Q4 ZjUwYzk1Zi4uYzlkZWQ5OGIyMDExM2IyYjFlODUzODY2NzhhY2IzM2JhMWZmMjAwMyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXll clRyZWVIb3N0SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0SW1wbC5jcHAKQEAgLTEyMiw3ICsxMjIsNyBAQCB2 b2lkIENDTGF5ZXJUcmVlSG9zdEltcGw6OnN0YXJ0UGFnZVNjYWxlQW5pbWF0aW9uKGNvbnN0IElu dFNpemUmIHRhcmdldFBvc2l0aW9uLAogICAgIEludFNpemUgc2Nyb2xsVG90YWwgPSB0b1NpemUo bV9zY3JvbGxMYXllckltcGwtPnNjcm9sbFBvc2l0aW9uKCkgKyBtX3Njcm9sbExheWVySW1wbC0+ c2Nyb2xsRGVsdGEoKSk7CiAgICAgc2Nyb2xsVG90YWwuc2NhbGUobV9wYWdlU2NhbGVEZWx0YSk7 CiAgICAgZmxvYXQgc2NhbGVUb3RhbCA9IG1fcGFnZVNjYWxlICogbV9wYWdlU2NhbGVEZWx0YTsK LSAgICBJbnRTaXplIHNjYWxlZENvbnRlbnRTaXplID0gbV9zY3JvbGxMYXllckltcGwtPmNoaWxk cmVuKClbMF0tPmNvbnRlbnRCb3VuZHMoKTsKKyAgICBJbnRTaXplIHNjYWxlZENvbnRlbnRTaXpl ID0gY29udGVudFNpemUoKTsKICAgICBzY2FsZWRDb250ZW50U2l6ZS5zY2FsZShtX3BhZ2VTY2Fs ZURlbHRhKTsKIAogICAgIG1fcGFnZVNjYWxlQW5pbWF0aW9uID0gQ0NQYWdlU2NhbGVBbmltYXRp b246OmNyZWF0ZShzY3JvbGxUb3RhbCwgc2NhbGVUb3RhbCwgbV92aWV3cG9ydFNpemUsIHNjYWxl ZENvbnRlbnRTaXplLCBzdGFydFRpbWVNcyk7CkBAIC0yNDQsNiArMjQ0LDE1IEBAIHZvaWQgQ0NM YXllclRyZWVIb3N0SW1wbDo6b3B0aW1pemVSZW5kZXJQYXNzZXMoQ0NSZW5kZXJQYXNzTGlzdCYg cGFzc2VzKQogICAgICAgICBwYXNzZXNbaV0tPm9wdGltaXplUXVhZHMoKTsKIH0KIAorSW50U2l6 ZSBDQ0xheWVyVHJlZUhvc3RJbXBsOjpjb250ZW50U2l6ZSgpIGNvbnN0Cit7CisgICAgLy8gVE9E TyhhZWxpYXMpOiBIYXJkY29kaW5nIHRoZSBmaXJzdCBjaGlsZCBoZXJlIGlzIHdlaXJkLiBUaGlu ayBvZgorICAgIC8vIGEgY2xlYW5lciB3YXkgdG8gZ2V0IHRoZSBjb250ZW50Qm91bmRzIG9uIHRo ZSBJbXBsIHNpZGUuCisgICAgaWYgKCFtX3Njcm9sbExheWVySW1wbCB8fCBtX3Njcm9sbExheWVy SW1wbC0+Y2hpbGRyZW4oKS5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybiBJbnRTaXplKCk7Cisg ICAgcmV0dXJuIG1fc2Nyb2xsTGF5ZXJJbXBsLT5jaGlsZHJlbigpWzBdLT5jb250ZW50Qm91bmRz KCk7Cit9CisKIHZvaWQgQ0NMYXllclRyZWVIb3N0SW1wbDo6ZHJhd0xheWVycygpCiB7CiAgICAg VFJBQ0VfRVZFTlQoIkNDTGF5ZXJUcmVlSG9zdEltcGw6OmRyYXdMYXllcnMiLCB0aGlzLCAwKTsK QEAgLTQ0MCw5ICs0NDksNyBAQCB2b2lkIENDTGF5ZXJUcmVlSG9zdEltcGw6OnVwZGF0ZU1heFNj cm9sbFBvc2l0aW9uKCkKICAgICBGbG9hdFNpemUgdmlld0JvdW5kcyA9IG1fdmlld3BvcnRTaXpl OwogICAgIHZpZXdCb3VuZHMuc2NhbGUoMSAvIG1fcGFnZVNjYWxlRGVsdGEpOwogCi0gICAgLy8g VE9ETyhhZWxpYXMpOiBIYXJkY29kaW5nIHRoZSBmaXJzdCBjaGlsZCBoZXJlIGlzIHdlaXJkLiBU aGluayBvZgotICAgIC8vIGEgY2xlYW5lciB3YXkgdG8gZ2V0IHRoZSBjb250ZW50Qm91bmRzIG9u IHRoZSBJbXBsIHNpZGUuCi0gICAgSW50U2l6ZSBtYXhTY3JvbGwgPSBtX3Njcm9sbExheWVySW1w bC0+Y2hpbGRyZW4oKVswXS0+Y29udGVudEJvdW5kcygpIC0gZXhwYW5kZWRJbnRTaXplKHZpZXdC b3VuZHMpOworICAgIEludFNpemUgbWF4U2Nyb2xsID0gY29udGVudFNpemUoKSAtIGV4cGFuZGVk SW50U2l6ZSh2aWV3Qm91bmRzKTsKICAgICAvLyBUaGUgdmlld3BvcnQgbWF5IGJlIGxhcmdlciB0 aGFuIHRoZSBjb250ZW50cyBpbiBzb21lIGNhc2VzLCBzdWNoIGFzCiAgICAgLy8gaGF2aW5nIGEg dmVydGljYWwgc2Nyb2xsYmFyIGJ1dCBubyBob3Jpem9udGFsIG92ZXJmbG93LgogICAgIG1heFNj cm9sbC5jbGFtcE5lZ2F0aXZlVG9aZXJvKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmggYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJ bXBsLmgKaW5kZXggZGViYTZjODZiOGJjMmNmYWFkNDQ2NDlkMjIzOTBmZGVjNmYxYWJlMi4uYTcx YWRhZTY3NTMyZjMyNDk2YTU0Mjg0YWE1N2Y3MGIzNDA0Y2QwMSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0SW1w bC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0ND TGF5ZXJUcmVlSG9zdEltcGwuaApAQCAtNjEsNyArNjEsNyBAQCBwdWJsaWM6CiAgICAgc3RhdGlj IFBhc3NPd25QdHI8Q0NMYXllclRyZWVIb3N0SW1wbD4gY3JlYXRlKGNvbnN0IENDU2V0dGluZ3Mm LCBDQ0xheWVyVHJlZUhvc3RJbXBsQ2xpZW50Kik7CiAgICAgdmlydHVhbCB+Q0NMYXllclRyZWVI b3N0SW1wbCgpOwogCi0gICAgLy8gQ0NJbnB1dEhhbmRsZXJUYXJnZXQgaW1wbGVtZW50YXRpb24K KyAgICAvLyBDQ0lucHV0SGFuZGxlckNsaWVudCBpbXBsZW1lbnRhdGlvbgogICAgIHZpcnR1YWwg dm9pZCBzZXROZWVkc1JlZHJhdygpOwogICAgIHZpcnR1YWwgQ0NJbnB1dEhhbmRsZXJDbGllbnQ6 OlNjcm9sbFN0YXR1cyBzY3JvbGxCZWdpbihjb25zdCBJbnRQb2ludCYpOwogICAgIHZpcnR1YWwg dm9pZCBzY3JvbGxCeShjb25zdCBJbnRTaXplJik7CkBAIC03MCw2ICs3MCw3IEBAIHB1YmxpYzoK ICAgICB2aXJ0dWFsIHZvaWQgcGluY2hHZXN0dXJlQmVnaW4oKTsKICAgICB2aXJ0dWFsIHZvaWQg cGluY2hHZXN0dXJlVXBkYXRlKGZsb2F0LCBjb25zdCBJbnRQb2ludCYpOwogICAgIHZpcnR1YWwg dm9pZCBwaW5jaEdlc3R1cmVFbmQoKTsKKyAgICB2aXJ0dWFsIHZvaWQgc3RhcnRQYWdlU2NhbGVB bmltYXRpb24oY29uc3QgSW50U2l6ZSYgdGFyZ2V0UG9zaXRpb24sIGJvb2wgYW5jaG9yUG9pbnQs IGZsb2F0IHBhZ2VTY2FsZSwgZG91YmxlIHN0YXJ0VGltZU1zLCBkb3VibGUgZHVyYXRpb25Ncyk7 CiAKICAgICAvLyBWaXJ0dWFsIGZvciB0ZXN0aW5nCiAgICAgdmlydHVhbCB2b2lkIGJlZ2luQ29t bWl0KCk7CkBAIC0xMTIsOCArMTEzLDYgQEAgcHVibGljOgogICAgIHZvaWQgc2V0UGFnZVNjYWxl RmFjdG9yQW5kTGltaXRzKGZsb2F0IHBhZ2VTY2FsZSwgZmxvYXQgbWluUGFnZVNjYWxlLCBmbG9h dCBtYXhQYWdlU2NhbGUpOwogICAgIGZsb2F0IHBhZ2VTY2FsZSgpIGNvbnN0IHsgcmV0dXJuIG1f cGFnZVNjYWxlOyB9CiAKLSAgICB2b2lkIHN0YXJ0UGFnZVNjYWxlQW5pbWF0aW9uKGNvbnN0IElu dFNpemUmIHRhcmdldFBvc2l0aW9uLCBib29sIGFuY2hvclBvaW50LCBmbG9hdCBwYWdlU2NhbGUs IGRvdWJsZSBzdGFydFRpbWVNcywgZG91YmxlIGR1cmF0aW9uTXMpOwotCiAgICAgY29uc3QgQ0NT ZXR0aW5ncyYgc2V0dGluZ3MoKSBjb25zdCB7IHJldHVybiBtX3NldHRpbmdzOyB9CiAKICAgICBQ YXNzT3duUHRyPENDU2Nyb2xsQW5kU2NhbGVTZXQ+IHByb2Nlc3NTY3JvbGxEZWx0YXMoKTsKQEAg LTEzNCw2ICsxMzMsNyBAQCBwcml2YXRlOgogICAgIHZvaWQgdHJhY2tEYW1hZ2VGb3JBbGxTdXJm YWNlcyhDQ0xheWVySW1wbCogcm9vdERyYXdMYXllciwgY29uc3QgQ0NMYXllckxpc3QmIHJlbmRl clN1cmZhY2VMYXllckxpc3QpOwogICAgIHZvaWQgY2FsY3VsYXRlUmVuZGVyUGFzc2VzKENDUmVu ZGVyUGFzc0xpc3QmKTsKICAgICB2b2lkIG9wdGltaXplUmVuZGVyUGFzc2VzKENDUmVuZGVyUGFz c0xpc3QmKTsKKyAgICBJbnRTaXplIGNvbnRlbnRTaXplKCkgY29uc3Q7CiAKICAgICBPd25QdHI8 TGF5ZXJSZW5kZXJlckNocm9taXVtPiBtX2xheWVyUmVuZGVyZXI7CiAgICAgUmVmUHRyPENDTGF5 ZXJJbXBsPiBtX3Jvb3RMYXllckltcGw7Cg==