7718 2006-03-11 04:19:15 -0800 run-webkit-tests fast/dom/HTMLObjectElement/ hangs 2006-03-13 12:07:32 -0800 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 RESOLVED FIXED HasReduction P1 Normal --- 1 ap webkit-unassigned mitz oldest_to_newest 35886 0 ap 2006-03-11 04:19:15 -0800 run-webkit-tests fast/dom/HTMLObjectElement/ This runs two tests, each of those runs fine on its own. Here, object-as-frame.html hangs while waiting for notifyDone(), because an exception happens earlier: ReferenceError: Can't find variable: shouldBe This seems to indicate that onLoad is called before external scripts are loaded. 36074 1 darin 2006-03-12 22:02:11 -0800 Maybe this is the reason some layout tests intermittently fail on the server. Those also seem to indicate that onload is firing before scripts run, although they are internal scripts, not external. 36104 2 mitz 2006-03-13 08:18:51 -0800 It's all about the trailing slash. This hangs: run-webkit-tests fast/dom/HTMLObjectElement//object-as-frame.html but this doesn't: run-webkit-tests fast/dom/HTMLObjectElement/object-as-frame.html 36108 3 7048 ap 2006-03-13 09:17:03 -0800 Created attachment 7048 proposed fix Mitz has explained it to me that sequences of slashes don't collapse in URLs (unlike they do in POSIX paths), so just patching run-webkit-tests. 36110 4 ap 2006-03-13 09:43:53 -0800 DumpRenderTree uses CFURLCreateWithFileSystemPath() for file paths, and it sounds like this function should canonicalize the paths; <rdar://4475631>. 36114 5 7048 ddkilzer 2006-03-13 10:33:05 -0800 Comment on attachment 7048 proposed fix >- print OUT "$testPath\n"; >+ print OUT File::Spec->canonpath("$testPath\n"); I don't think the "\n" should be included in the method call since it's not part of the path! Something more like this: >+ print OUT File::Spec->canonpath($testPath), "\n"; 36115 6 7049 ap 2006-03-13 10:50:30 -0800 Created attachment 7049 proposed fix I don't think it changes the behavior in any way, but if it reads better, why not :) 36116 7 7049 darin 2006-03-13 11:29:20 -0800 Comment on attachment 7049 proposed fix r=me 7048 2006-03-13 09:17:03 -0800 2006-03-13 10:50:30 -0800 proposed fix 7718r1_patch.txt text/plain 690 ap SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMJKHJldmlzaW9uIDEzMjYyKQor KysgV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCSh3b3JraW5nIGNvcHkpCkBA IC0zMDksMTEgKzMwOSwxMSBAQCBmb3IgbXkgJHRlc3QgKEB0ZXN0cykgewogICAgICAgICAgICAg JHRlc3RQYXRoID1+IHN8L2N5Z2RyaXZlL2N8Yzp8OwogICAgICAgICAgICAgJHRlc3RQYXRoID1+ IHN8L3xcXHxnOwogICAgICAgICB9IAotICAgICAgICBwcmludCBPVVQgIiR0ZXN0UGF0aFxuIjsK KyAgICAgICAgcHJpbnQgT1VUIEZpbGU6OlNwZWMtPmNhbm9ucGF0aCgiJHRlc3RQYXRoXG4iKTsK ICAgICB9IGVsc2UgewogICAgICAgICBvcGVuSFRUUERJZk5lZWRlZCgpOwogICAgICAgICAKLSAg ICAgICAgbXkgJHBhdGggPSAkdGVzdDsKKyAgICAgICAgbXkgJHBhdGggPSBGaWxlOjpTcGVjLT5j YW5vbnBhdGgoJHRlc3QpOwogICAgICAgICAkcGF0aCA9fiBzL15odHRwXC90ZXN0c1wvLy87CiAg ICAgICAgIHByaW50IE9VVCAiaHR0cDovLzEyNy4wLjAuMTokaHR0cGRQb3J0LyRwYXRoXG4iOwog ICAgIH0K 7049 2006-03-13 10:50:30 -0800 2006-03-13 11:29:20 -0800 proposed fix 7718r2_patch.txt text/plain 695 ap SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMJKHJldmlzaW9uIDEzMjYyKQor KysgV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCSh3b3JraW5nIGNvcHkpCkBA IC0zMDksMTEgKzMwOSwxMSBAQCBmb3IgbXkgJHRlc3QgKEB0ZXN0cykgewogICAgICAgICAgICAg JHRlc3RQYXRoID1+IHN8L2N5Z2RyaXZlL2N8Yzp8OwogICAgICAgICAgICAgJHRlc3RQYXRoID1+ IHN8L3xcXHxnOwogICAgICAgICB9IAotICAgICAgICBwcmludCBPVVQgIiR0ZXN0UGF0aFxuIjsK KyAgICAgICAgcHJpbnQgT1VUIEZpbGU6OlNwZWMtPmNhbm9ucGF0aCgiJHRlc3RQYXRoIikgLiAi XG4iOwogICAgIH0gZWxzZSB7CiAgICAgICAgIG9wZW5IVFRQRElmTmVlZGVkKCk7CiAgICAgICAg IAotICAgICAgICBteSAkcGF0aCA9ICR0ZXN0OworICAgICAgICBteSAkcGF0aCA9IEZpbGU6OlNw ZWMtPmNhbm9ucGF0aCgkdGVzdCk7CiAgICAgICAgICRwYXRoID1+IHMvXmh0dHBcL3Rlc3RzXC8v LzsKICAgICAgICAgcHJpbnQgT1VUICJodHRwOi8vMTI3LjAuMC4xOiRodHRwZFBvcnQvJHBhdGhc biI7CiAgICAgfQo=