77177 2012-01-26 19:53:47 -0800 Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered 2012-01-26 20:11:24 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned oldest_to_newest 543760 0 fpizlo 2012-01-26 19:53:47 -0800 Probably should not be relying on $_ not being clobbered in such a large loop body in the first place. 543762 1 124242 fpizlo 2012-01-26 19:55:09 -0800 Created attachment 124242 the patch 543764 2 124244 fpizlo 2012-01-26 19:56:54 -0800 Created attachment 124244 the patch Forgot about one implicit use of $_. 543772 3 124244 jhoneycutt 2012-01-26 20:06:52 -0800 Comment on attachment 124244 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=124244&action=review > Tools/ChangeLog:3 > + Tools/Scripts/change-log-editor is broken due to $_ getting clobbered change-log-editor -> commit-log-editor > Tools/Scripts/commit-log-editor:136 > while (<LOG>) { > + my $curLine = $_; You could do while (my $curLine = <LOG>) { > Tools/Scripts/commit-log-editor:145 > + if (!isGit() || $curLine =~ /^#/) { # Could remove this EOL comment while you're here. 543774 4 fpizlo 2012-01-26 20:11:24 -0800 Landed in http://trac.webkit.org/changeset/106082 124242 2012-01-26 19:55:09 -0800 2012-01-26 19:56:54 -0800 the patch changeedit_patch_1.diff text/plain 2229 fpizlo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwNjA4MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDEyLTAxLTI2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisK KyAgICAgICAgVG9vbHMvU2NyaXB0cy9jaGFuZ2UtbG9nLWVkaXRvciBpcyBicm9rZW4gZHVlIHRv ICRfIGdldHRpbmcgY2xvYmJlcmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD03NzE3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy9jb21taXQtbG9nLWVkaXRvcjoKKwogMjAxMi0wMS0yNiAg T2phbiBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIERlY3JlYXNlIHNsZWVw IHRpbWUgd2hlbiBraWxsaW5nIHNlcnZlcl9wcm9jZXNzIG9uIE1hYy4KSW5kZXg6IFRvb2xzL1Nj cmlwdHMvY29tbWl0LWxvZy1lZGl0b3IKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9jb21t aXQtbG9nLWVkaXRvcgkocmV2aXNpb24gMTA2MDgxKQorKysgVG9vbHMvU2NyaXB0cy9jb21taXQt bG9nLWVkaXRvcgkod29ya2luZyBjb3B5KQpAQCAtMTMzLDIzICsxMzMsMjQgQEAgbXkgJGxvZ0Nv bnRlbnRzID0gIiI7CiBteSAkZXhpc3RpbmdMb2cgPSAwOwogb3BlbiBMT0csICRsb2cgb3IgZGll ICJDb3VsZCBub3Qgb3BlbiB0aGUgbG9nIGZpbGUuIjsKIHdoaWxlICg8TE9HPikgeworICAgIG15 ICRjdXJMaW5lID0gJF87CiAgICAgaWYgKGlzR2l0KCkpIHsKLSAgICAgICAgaWYgKC9eIyBDaGFu Z2VzIHRvIGJlIGNvbW1pdHRlZDokLykgeworICAgICAgICBpZiAoJGN1ckxpbmUgPX4gL14jIENo YW5nZXMgdG8gYmUgY29tbWl0dGVkOiQvKSB7CiAgICAgICAgICAgICAkaW5DaGFuZ2VzVG9CZUNv bW1pdHRlZCA9IDE7Ci0gICAgICAgIH0gZWxzaWYgKCRpbkNoYW5nZXNUb0JlQ29tbWl0dGVkICYm IC9eIyBcUy8pIHsKKyAgICAgICAgfSBlbHNpZiAoJGluQ2hhbmdlc1RvQmVDb21taXR0ZWQgJiYg JGN1ckxpbmUgPX4gL14jIFxTLykgewogICAgICAgICAgICAgJGluQ2hhbmdlc1RvQmVDb21taXR0 ZWQgPSAwOwogICAgICAgICB9CiAgICAgfQogCi0gICAgaWYgKCFpc0dpdCgpIHx8IC9eIy8pIHsg IwotICAgICAgICAkbG9nQ29udGVudHMgLj0gJF87CisgICAgaWYgKCFpc0dpdCgpIHx8ICRjdXJM aW5lID1+IC9eIy8pIHsgIworICAgICAgICAkbG9nQ29udGVudHMgLj0gJGN1ckxpbmU7CiAgICAg fSBlbHNlIHsKICAgICAgICAgIyAkXyBjb250YWlucyB0aGUgY3VycmVudCBnaXQgbG9nIG1lc3Nh Z2UKICAgICAgICAgIyAod2l0aG91dCB0aGUgbG9nIGNvbW1lbnQgaW5mbykuIFdlIGRvbid0IG5l ZWQgaXQuCiAgICAgfQotICAgICRleGlzdGluZ0xvZyA9IGlzR2l0KCkgJiYgISgvXiMvIHx8IC9e XHMqJC8pIHVubGVzcyAkZXhpc3RpbmdMb2c7CisgICAgJGV4aXN0aW5nTG9nID0gaXNHaXQoKSAm JiAhKCRjdXJMaW5lID1+IC9eIy8gfHwgL15ccyokLykgdW5sZXNzICRleGlzdGluZ0xvZzsKICAg ICBteSAkY2hhbmdlTG9nRmlsZU5hbWUgPSBjaGFuZ2VMb2dGaWxlTmFtZSgpOwotICAgIHB1c2gg QGNoYW5nZUxvZ3MsIG1ha2VGaWxlUGF0aFJlbGF0aXZlKCQxKSBpZiAkaW5DaGFuZ2VzVG9CZUNv bW1pdHRlZCAmJiAoL14oPzpNfEEpLi4uLiguKiRjaGFuZ2VMb2dGaWxlTmFtZSlccj9cbj8kLyB8 fCAvXiNcdCg/Om1vZGlmaWVkfG5ldyBmaWxlKTogICAoLiokY2hhbmdlTG9nRmlsZU5hbWUpJC8p ICYmICEvLSRjaGFuZ2VMb2dGaWxlTmFtZSQvOworICAgIHB1c2ggQGNoYW5nZUxvZ3MsIG1ha2VG aWxlUGF0aFJlbGF0aXZlKCQxKSBpZiAkaW5DaGFuZ2VzVG9CZUNvbW1pdHRlZCAmJiAoJGN1ckxp bmUgPX4gL14oPzpNfEEpLi4uLiguKiRjaGFuZ2VMb2dGaWxlTmFtZSlccj9cbj8kLyB8fCAkY3Vy TGluZSA9fiAvXiNcdCg/Om1vZGlmaWVkfG5ldyBmaWxlKTogICAoLiokY2hhbmdlTG9nRmlsZU5h bWUpJC8pICYmICRjdXJMaW5lICF+IC8tJGNoYW5nZUxvZ0ZpbGVOYW1lJC87CiB9CiBjbG9zZSBM T0c7CiAK 124244 2012-01-26 19:56:54 -0800 2012-01-26 20:06:52 -0800 the patch changeedit_patch_2.diff text/plain 2241 fpizlo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwNjA4MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDEyLTAxLTI2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisK KyAgICAgICAgVG9vbHMvU2NyaXB0cy9jaGFuZ2UtbG9nLWVkaXRvciBpcyBicm9rZW4gZHVlIHRv ICRfIGdldHRpbmcgY2xvYmJlcmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD03NzE3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy9jb21taXQtbG9nLWVkaXRvcjoKKwogMjAxMi0wMS0yNiAg T2phbiBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIERlY3JlYXNlIHNsZWVw IHRpbWUgd2hlbiBraWxsaW5nIHNlcnZlcl9wcm9jZXNzIG9uIE1hYy4KSW5kZXg6IFRvb2xzL1Nj cmlwdHMvY29tbWl0LWxvZy1lZGl0b3IKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9jb21t aXQtbG9nLWVkaXRvcgkocmV2aXNpb24gMTA2MDgxKQorKysgVG9vbHMvU2NyaXB0cy9jb21taXQt bG9nLWVkaXRvcgkod29ya2luZyBjb3B5KQpAQCAtMTMzLDIzICsxMzMsMjQgQEAgbXkgJGxvZ0Nv bnRlbnRzID0gIiI7CiBteSAkZXhpc3RpbmdMb2cgPSAwOwogb3BlbiBMT0csICRsb2cgb3IgZGll ICJDb3VsZCBub3Qgb3BlbiB0aGUgbG9nIGZpbGUuIjsKIHdoaWxlICg8TE9HPikgeworICAgIG15 ICRjdXJMaW5lID0gJF87CiAgICAgaWYgKGlzR2l0KCkpIHsKLSAgICAgICAgaWYgKC9eIyBDaGFu Z2VzIHRvIGJlIGNvbW1pdHRlZDokLykgeworICAgICAgICBpZiAoJGN1ckxpbmUgPX4gL14jIENo YW5nZXMgdG8gYmUgY29tbWl0dGVkOiQvKSB7CiAgICAgICAgICAgICAkaW5DaGFuZ2VzVG9CZUNv bW1pdHRlZCA9IDE7Ci0gICAgICAgIH0gZWxzaWYgKCRpbkNoYW5nZXNUb0JlQ29tbWl0dGVkICYm IC9eIyBcUy8pIHsKKyAgICAgICAgfSBlbHNpZiAoJGluQ2hhbmdlc1RvQmVDb21taXR0ZWQgJiYg JGN1ckxpbmUgPX4gL14jIFxTLykgewogICAgICAgICAgICAgJGluQ2hhbmdlc1RvQmVDb21taXR0 ZWQgPSAwOwogICAgICAgICB9CiAgICAgfQogCi0gICAgaWYgKCFpc0dpdCgpIHx8IC9eIy8pIHsg IwotICAgICAgICAkbG9nQ29udGVudHMgLj0gJF87CisgICAgaWYgKCFpc0dpdCgpIHx8ICRjdXJM aW5lID1+IC9eIy8pIHsgIworICAgICAgICAkbG9nQ29udGVudHMgLj0gJGN1ckxpbmU7CiAgICAg fSBlbHNlIHsKICAgICAgICAgIyAkXyBjb250YWlucyB0aGUgY3VycmVudCBnaXQgbG9nIG1lc3Nh Z2UKICAgICAgICAgIyAod2l0aG91dCB0aGUgbG9nIGNvbW1lbnQgaW5mbykuIFdlIGRvbid0IG5l ZWQgaXQuCiAgICAgfQotICAgICRleGlzdGluZ0xvZyA9IGlzR2l0KCkgJiYgISgvXiMvIHx8IC9e XHMqJC8pIHVubGVzcyAkZXhpc3RpbmdMb2c7CisgICAgJGV4aXN0aW5nTG9nID0gaXNHaXQoKSAm JiAhKCRjdXJMaW5lID1+IC9eIy8gfHwgJGN1ckxpbmUgPX4gL15ccyokLykgdW5sZXNzICRleGlz dGluZ0xvZzsKICAgICBteSAkY2hhbmdlTG9nRmlsZU5hbWUgPSBjaGFuZ2VMb2dGaWxlTmFtZSgp OwotICAgIHB1c2ggQGNoYW5nZUxvZ3MsIG1ha2VGaWxlUGF0aFJlbGF0aXZlKCQxKSBpZiAkaW5D aGFuZ2VzVG9CZUNvbW1pdHRlZCAmJiAoL14oPzpNfEEpLi4uLiguKiRjaGFuZ2VMb2dGaWxlTmFt ZSlccj9cbj8kLyB8fCAvXiNcdCg/Om1vZGlmaWVkfG5ldyBmaWxlKTogICAoLiokY2hhbmdlTG9n RmlsZU5hbWUpJC8pICYmICEvLSRjaGFuZ2VMb2dGaWxlTmFtZSQvOworICAgIHB1c2ggQGNoYW5n ZUxvZ3MsIG1ha2VGaWxlUGF0aFJlbGF0aXZlKCQxKSBpZiAkaW5DaGFuZ2VzVG9CZUNvbW1pdHRl ZCAmJiAoJGN1ckxpbmUgPX4gL14oPzpNfEEpLi4uLiguKiRjaGFuZ2VMb2dGaWxlTmFtZSlccj9c bj8kLyB8fCAkY3VyTGluZSA9fiAvXiNcdCg/Om1vZGlmaWVkfG5ldyBmaWxlKTogICAoLiokY2hh bmdlTG9nRmlsZU5hbWUpJC8pICYmICRjdXJMaW5lICF+IC8tJGNoYW5nZUxvZ0ZpbGVOYW1lJC87 CiB9CiBjbG9zZSBMT0c7CiAK