77160 2012-01-26 16:24:57 -0800 SchemeRegistry scheme registration is racey 2013-03-16 22:54:30 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified REOPENED P2 Normal --- 1 cdn cdn abarth ap oldest_to_newest 543637 0 cdn 2012-01-26 16:24:57 -0800 Scheme registration within SchemeRegistry should only be able to occur from the main thread as pointed out by ap@ on https://bugs.webkit.org/show_bug.cgi?id=77041. Currently this is not enforced and in some cases this may cause a race. We should fix this and add asserts (as AP suggested) to all of the scheme registries. 543649 1 124213 cdn 2012-01-26 16:44:27 -0800 Created attachment 124213 Patch 543651 2 124213 abarth 2012-01-26 16:46:30 -0800 Comment on attachment 124213 Patch WebKit usually prefers links to bugs rather than parenthetical comments. (We're lazy that way.) 543659 3 cdn 2012-01-26 16:54:43 -0800 Committed r106064: <http://trac.webkit.org/changeset/106064> 543664 4 cdn 2012-01-26 16:57:42 -0800 This patch was just to remove the assert and add a fixme 856678 5 124213 ap 2013-03-16 22:54:30 -0700 Comment on attachment 124213 Patch Clearing r+ flag from a landed patch, so that this doesn't show up in commit queue. 124213 2012-01-26 16:44:27 -0800 2013-03-16 22:54:29 -0700 Patch bug-77160-20120126164426.patch text/plain 1433 cdn SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNjA2MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAxLTI2ICBDcmlzIE5l Y2thciAgPGNkbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVGhlIHJlZ2lzdHJhdGlvbiBvZiBz Y2hlbWVzIGlzIGN1cnJlbnRseSByYWNleSBhcyB0aGV5IGFyZSBub3QgcmVnaXN0ZXJlZCBmcm9t IHRoZSBtYWluIHRocmVhZC4gCisgICAgICAgIEdldHRpbmcgcmlkIG9mIHRoZSBhc3NlcnQgdGhh dCBlbnN1cmVzIHRoYXQgd2UgYXJlIHJlZ2lzdGVyaW5nIGZyb20gdGhlIG1haW4gdGhyZWFkIHVu dGlsIHdlIGNhbiBmaXggdGhpcy4KKworICAgICAgICBUaGFuayB5b3UgYXBAd2Via2l0IGZvciBo ZWxwaW5nIHVzIGlkZW50aWZ5IHRoaXMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTc3MTYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9TY2hlbWVSZWdpc3RyeS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpDT1JTRW5hYmxlZFNjaGVtZXMpOgorCiAyMDEyLTAxLTI2ICBBbmRlcnMgQ2Fy bHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgV2UgZG9uJ3QgbmVlZCB0byBh bHdheXMgcmVwYWludCBvdmVybGF5IHNjcm9sbGJhcnMgaWYgdGhleSdyZSBpbiBsYXllcnMKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NjaGVtZVJlZ2lzdHJ5LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY2hlbWVSZWdpc3RyeS5jcHAJKHJldmlzaW9u IDEwNjA1NykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NjaGVtZVJlZ2lzdHJ5LmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTU1LDcgKzE1NSw3IEBAIHN0YXRpYyBVUkxTY2hlbWVzTWFwJiBz Y2hlbWVzQWxsb3dpbmdEYXQKIAogc3RhdGljIFVSTFNjaGVtZXNNYXAmIENPUlNFbmFibGVkU2No ZW1lcygpCiB7Ci0gICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKKyAgICAvLyBGSVhNRSAoNzcx NjApOiBTY2hlbWUgcmVnaXN0cmF0aW9uIHNob3VsZCBvbmx5IGJlIGFsbG93ZWQgZnJvbSB0aGUg bWFpbiB0aHJlYWQuIAogICAgIERFRklORV9TVEFUSUNfTE9DQUwoVVJMU2NoZW1lc01hcCwgQ09S U0VuYWJsZWRTY2hlbWVzLCAoKSk7CiAKICAgICBpZiAoQ09SU0VuYWJsZWRTY2hlbWVzLmlzRW1w dHkoKSkgewo=