77145 2012-01-26 14:53:27 -0800 [JSC] Some JS_EXPORTDATA may not be necessary. 2012-01-28 05:33:43 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77275 72854 1 morrita morrita darin kevino webkit.review.bot oldest_to_newest 543511 0 morrita 2012-01-26 14:53:27 -0800 This is derived from Bug 72854. Some JSC classes have s_info static class variables which are marked as JS_EXPORTDATA. But these may not be necessary. In this bug, we are going to investigate if we can remove them. 544202 1 124339 morrita 2012-01-27 11:17:33 -0800 Created attachment 124339 Patch 544204 2 morrita 2012-01-27 11:20:46 -0800 SInce I'm visiting a remote office I cannot check this on Windows for now. But I feel that we can see the obvious consequence on the bot... This patch is so small and it would be easy to rollout if the bot fails. 544207 3 morrita 2012-01-27 11:23:07 -0800 Hi Darin and Kevin, Could you rubberstamp this small symbol adjustment stuff? 544379 4 124339 webkit.review.bot 2012-01-27 14:41:08 -0800 Comment on attachment 124339 Patch Clearing flags on attachment: 124339 Committed r106151: <http://trac.webkit.org/changeset/106151> 544381 5 webkit.review.bot 2012-01-27 14:41:12 -0800 All reviewed patches have been landed. Closing bug. 544410 6 morrita 2012-01-27 15:05:57 -0800 Hmm Apple win bots are so red today that I cannot confirm that this patch works well... Please feel free to revert this if this has any possible problem/is suspicious in any level. 124339 2012-01-27 11:17:33 -0800 2012-01-27 14:41:08 -0800 Patch bug-77145-20120128041732.patch text/plain 3560 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 YmVkMzQzODAzMTZjMjFlOTc3ZjEzODhkMzQ4NDIzMTgyMTg3NWM0Li5mYzQ2MzM0MDI1MWYyMTVl N2ZmMTllMmQ1YzM0Nzg0M2M3YjM3NzM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxMi0wMS0yNyAgTU9SSVRBIEhhamltZSAgPG1vcnJpdGFAZ29vZ2xlLmNv bT4KKworICAgICAgICBbSlNDXSBTb21lIEpTX0VYUE9SVERBVEEgbWF5IG5vdCBiZSBuZWNlc3Nh cnkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzE0 NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92 ZWQgSlNfRVhQT1JUREFUQSBhdHRyaWJ1dGVzIHdob3NlIGF0dHJpYnV0aW5nIHN5bWJvbHMgYXJl CisgICAgICAgIG5vdCBleHBvcnRlZCBvbiBNYWMgcG9ydC4KKyAgICAgICAgCisgICAgICAgICog cnVudGltZS9FeGNlcHRpb25IZWxwZXJzLmg6CisgICAgICAgIChJbnRlcnJ1cHRlZEV4ZWN1dGlv bkVycm9yKToKKyAgICAgICAgKiBydW50aW1lL0pTQm91bmRGdW5jdGlvbi5oOgorICAgICAgICAo SlNCb3VuZEZ1bmN0aW9uKToKKyAgICAgICAgKiBydW50aW1lL1JlZ0V4cC5oOgorICAgICAgICAo UmVnRXhwKToKKyAgICAgICAgKiBydW50aW1lL1JlZ0V4cE1hdGNoZXNBcnJheS5oOgorICAgICAg ICAoUmVnRXhwTWF0Y2hlc0FycmF5KToKKwogMjAxMi0wMS0yNyAgWmVubyBBbGJpc3NlciAgPHpl bm9Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRdW01hY10gQnVpbGQgZmFpbHMgYWZ0ZXIgYWRk aW5nIElDVSBzdXBwb3J0IChyMTA1OTk3KS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0V4Y2VwdGlvbkhlbHBlcnMuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0V4Y2VwdGlvbkhlbHBlcnMuaAppbmRleCAzODgyMzViMGRiZWE4ZDVlNjdhMTJmMWM4 YTBlNzM3MDFlZGI3Mjg4Li43YmZmZDI5NGIzNTY4NzRmYWMxNGJkOTQ0Y2M0YzkyYmIyYzdiNzI4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FeGNlcHRpb25IZWxw ZXJzLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhjZXB0aW9uSGVscGVy cy5oCkBAIC03OSw3ICs3OSw3IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIFN0cnVjdHVyZTo6 Y3JlYXRlKGdsb2JhbERhdGEsIGdsb2JhbE9iamVjdCwgcHJvdG90eXBlLCBUeXBlSW5mbyhPYmpl Y3RUeXBlLCBTdHJ1Y3R1cmVGbGFncyksICZzX2luZm8pOwogICAgIH0KIAotICAgIHN0YXRpYyBK U19FWFBPUlREQVRBIGNvbnN0IENsYXNzSW5mbyBzX2luZm87CisgICAgc3RhdGljIGNvbnN0IENs YXNzSW5mbyBzX2luZm87CiB9OwogCiBjbGFzcyBUZXJtaW5hdGVkRXhlY3V0aW9uRXJyb3IgOiBw dWJsaWMgSlNOb25GaW5hbE9iamVjdCB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9KU0JvdW5kRnVuY3Rpb24uaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0pTQm91bmRGdW5jdGlvbi5oCmluZGV4IGM2MGQ3ZGIwMTllMTFmYTdkNGNhOGQwOWY1MWNl Y2NhMDg4OTA4MGUuLmU1NGQ0NTg4M2RmZGU0YzI5ODA5YTdjYWM3YWYyNTk2ODFjOGVkOTAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQm91bmRGdW5jdGlvbi5o CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQm91bmRGdW5jdGlvbi5oCkBA IC01MSw3ICs1MSw3IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIFN0cnVjdHVyZTo6Y3JlYXRl KGdsb2JhbERhdGEsIGdsb2JhbE9iamVjdCwgcHJvdG90eXBlLCBUeXBlSW5mbyhKU0Z1bmN0aW9u VHlwZSwgU3RydWN0dXJlRmxhZ3MpLCAmc19pbmZvKTsgCiAgICAgfQogCi0gICAgc3RhdGljIEpT X0VYUE9SVERBVEEgY29uc3QgQ2xhc3NJbmZvIHNfaW5mbzsKKyAgICBzdGF0aWMgY29uc3QgQ2xh c3NJbmZvIHNfaW5mbzsKIAogcHJvdGVjdGVkOgogICAgIGNvbnN0IHN0YXRpYyB1bnNpZ25lZCBT dHJ1Y3R1cmVGbGFncyA9IE92ZXJyaWRlc0hhc0luc3RhbmNlIHwgT3ZlcnJpZGVzVmlzaXRDaGls ZHJlbiB8IEJhc2U6OlN0cnVjdHVyZUZsYWdzOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvUmVnRXhwLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9S ZWdFeHAuaAppbmRleCAzMTFiYjc1MzJmOGZhNmEyNTBlODFhM2JmZGEyNDBiYTc0M2M1YWI2Li5k MDIwMWNiZmI5NDI4YmFiYmE5YTE1YzExOTcyYjQyNGNjNmRhMjY4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHAuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9SZWdFeHAuaApAQCAtNzIsNyArNzIsNyBAQCBuYW1lc3BhY2UgSlNDIHsK ICAgICAgICAgICAgIHJldHVybiBTdHJ1Y3R1cmU6OmNyZWF0ZShnbG9iYWxEYXRhLCBnbG9iYWxP YmplY3QsIHByb3RvdHlwZSwgVHlwZUluZm8oTGVhZlR5cGUsIDApLCAmc19pbmZvKTsKICAgICAg ICAgfQogICAgICAgICAKLSAgICAgICAgc3RhdGljIEpTX0VYUE9SVERBVEEgY29uc3QgQ2xhc3NJ bmZvIHNfaW5mbzsKKyAgICAgICAgc3RhdGljIGNvbnN0IENsYXNzSW5mbyBzX2luZm87CiAKICAg ICAgICAgUmVnRXhwS2V5IGtleSgpIHsgcmV0dXJuIFJlZ0V4cEtleShtX2ZsYWdzLCBtX3BhdHRl cm5TdHJpbmcpOyB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L1JlZ0V4cE1hdGNoZXNBcnJheS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVn RXhwTWF0Y2hlc0FycmF5LmgKaW5kZXggYWNkMjMxN2I4MGY0ZGRlODA1YWY1ZTYzNGYxZDIxZGVj MGJlNzMyOS4uYzM0OTIwZDhkZDY0MWI5YmE5MGQ0NWEzODNlN2E4MDBjMTIwMzEzYSAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwTWF0Y2hlc0FycmF5LmgK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwTWF0Y2hlc0FycmF5LmgK QEAgLTM5LDcgKzM5LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIH0KICAgICAgICAgc3Rh dGljIHZvaWQgZGVzdHJveShKU0NlbGwqKTsKIAotICAgICAgICBzdGF0aWMgSlNfRVhQT1JUREFU QSBjb25zdCBDbGFzc0luZm8gc19pbmZvOworICAgICAgICBzdGF0aWMgY29uc3QgQ2xhc3NJbmZv IHNfaW5mbzsKIAogICAgICAgICBzdGF0aWMgU3RydWN0dXJlKiBjcmVhdGVTdHJ1Y3R1cmUoSlNH bG9iYWxEYXRhJiBnbG9iYWxEYXRhLCBKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBKU1Zh bHVlIHByb3RvdHlwZSkKICAgICAgICAgewo=