77137 2012-01-26 13:48:42 -0800 [chromium] Remove dead and unnecessary code related to LayerChromium::cleanupResources 2012-01-26 15:14:03 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alokp alokp cc-bugs jamesr nduca vangelis webkit.review.bot oldest_to_newest 543445 0 alokp 2012-01-26 13:48:42 -0800 LayerChromium::cleanupResourcesRecursive() seems dead. 543449 1 124174 alokp 2012-01-26 13:53:04 -0800 Created attachment 124174 proposed patch 543451 2 124174 alokp 2012-01-26 13:54:19 -0800 Comment on attachment 124174 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=124174&action=review > Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp:-181 > - if (layerTreeHost()) This is unnecessary. LayerChromium::setLayerTreeHost() already does this. 543455 3 124174 jamesr 2012-01-26 13:56:49 -0800 Comment on attachment 124174 proposed patch R=me, this has been dead a while. Thanks for removing it. 543537 4 124174 webkit.review.bot 2012-01-26 15:13:59 -0800 Comment on attachment 124174 proposed patch Clearing flags on attachment: 124174 Committed r106052: <http://trac.webkit.org/changeset/106052> 543538 5 webkit.review.bot 2012-01-26 15:14:03 -0800 All reviewed patches have been landed. Closing bug. 124174 2012-01-26 13:53:04 -0800 2012-01-26 15:13:59 -0800 proposed patch 77137.patch text/plain 2810 alokp SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNjAzOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAxLTI2ICBBbG9rIFBy aXlhZGFyc2hpICA8YWxva3BAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gUmVt b3ZlIGRlYWQgYW5kIHVubmVjZXNzYXJ5IGNvZGUgcmVsYXRlZCB0byBMYXllckNocm9taXVtOjpj bGVhbnVwUmVzb3VyY2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03NzEzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0IG5lZWRlZC4gT25seSByZW1vdmluZyBkZWFkIGNvZGUuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllckNocm9taXVtLmNwcDoKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllckNocm9taXVtLmg6CisgICAg ICAgIChXZWJDb3JlOjpMYXllckNocm9taXVtOjpsYXllclRyZWVIb3N0KToKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UaWxlZExheWVyQ2hyb21pdW0uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6VGlsZWRMYXllckNocm9taXVtOjpzZXRMYXllclRyZWVIb3N0KToKKwogMjAx Mi0wMS0yNiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAg IEdldCByaWQgb2YgU2Nyb2xsRWxhc3RpY2l0eUNvbnRyb2xsZXI6OmVuZFNjcm9sbEdlc3R1cmUo KQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJD aHJvbWl1bS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5jcHAJKHJldmlzaW9uIDEwNTYzMikKKysrIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyQ2hyb21pdW0uY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC05NCwxOSArOTQsNiBAQCB2b2lkIExheWVyQ2hyb21pdW06OmNsZWFu dXBSZXNvdXJjZXMoKQogewogfQogCi12b2lkIExheWVyQ2hyb21pdW06OmNsZWFudXBSZXNvdXJj ZXNSZWN1cnNpdmUoKQotewotICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgY2hpbGRyZW4oKS5z aXplKCk7ICsraSkKLSAgICAgICAgY2hpbGRyZW4oKVtpXS0+Y2xlYW51cFJlc291cmNlc1JlY3Vy c2l2ZSgpOwotCi0gICAgaWYgKG1hc2tMYXllcigpKQotICAgICAgICBtYXNrTGF5ZXIoKS0+Y2xl YW51cFJlc291cmNlc1JlY3Vyc2l2ZSgpOwotICAgIGlmIChyZXBsaWNhTGF5ZXIoKSkKLSAgICAg ICAgcmVwbGljYUxheWVyKCktPmNsZWFudXBSZXNvdXJjZXNSZWN1cnNpdmUoKTsKLQotICAgIGNs ZWFudXBSZXNvdXJjZXMoKTsKLX0KLQogdm9pZCBMYXllckNocm9taXVtOjpzZXRJc05vbkNvbXBv c2l0ZWRDb250ZW50KGJvb2wgaXNOb25Db21wb3NpdGVkQ29udGVudCkKIHsKICAgICBtX2lzTm9u Q29tcG9zaXRlZENvbnRlbnQgPSBpc05vbkNvbXBvc2l0ZWRDb250ZW50OwpJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVy Q2hyb21pdW0uaAkocmV2aXNpb24gMTA1NjMyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xOTYs NyArMTk2LDYgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBjb250ZW50Q2hhbmdlZCgpIHsg fQogCiAgICAgQ0NMYXllclRyZWVIb3N0KiBsYXllclRyZWVIb3N0KCkgY29uc3QgeyByZXR1cm4g bV9sYXllclRyZWVIb3N0LmdldCgpOyB9Ci0gICAgdm9pZCBjbGVhbnVwUmVzb3VyY2VzUmVjdXJz aXZlKCk7CiAKIHByb3RlY3RlZDoKICAgICBMYXllckNocm9taXVtKCk7CkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UaWxlZExheWVyQ2hyb21pdW0uY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L1RpbGVkTGF5ZXJDaHJvbWl1bS5jcHAJKHJldmlzaW9uIDEwNTYzMikKKysrIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1RpbGVkTGF5ZXJDaHJvbWl1bS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTE3OCw5ICsxNzgsNiBAQCB2b2lkIFRpbGVkTGF5ZXJDaHJvbWl1bTo6 c2V0TGF5ZXJUcmVlSG9zCiAgICAgaWYgKGhvc3QgPT0gbGF5ZXJUcmVlSG9zdCgpKQogICAgICAg ICByZXR1cm47CiAKLSAgICBpZiAobGF5ZXJUcmVlSG9zdCgpKQotICAgICAgICBjbGVhbnVwUmVz b3VyY2VzKCk7Ci0KICAgICBMYXllckNocm9taXVtOjpzZXRMYXllclRyZWVIb3N0KGhvc3QpOwog CiAgICAgaWYgKCFob3N0KQo=