<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>77128</bug_id>
          
          <creation_ts>2012-01-26 12:08:48 -0800</creation_ts>
          <short_desc>Fix include path in gyp file for V8InternalSettings.h</short_desc>
          <delta_ts>2012-01-26 14:27:03 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Scott Graham">scottmg</reporter>
          <assigned_to name="Scott Graham">scottmg</assigned_to>
          <cc>morrita</cc>
    
    <cc>tkent</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>543359</commentid>
    <comment_count>0</comment_count>
    <who name="Scott Graham">scottmg</who>
    <bug_when>2012-01-26 12:08:48 -0800</bug_when>
    <thetext>See https://bugs.webkit.org/show_bug.cgi?id=76424. The correct path appears to be V8InternalSettings.h. Having the wrong path causes unnecessary rebuilds on Windows under VS2010.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>543460</commentid>
    <comment_count>1</comment_count>
      <attachid>124177</attachid>
    <who name="Scott Graham">scottmg</who>
    <bug_when>2012-01-26 14:04:27 -0800</bug_when>
    <thetext>Created attachment 124177
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>543463</commentid>
    <comment_count>2</comment_count>
      <attachid>124177</attachid>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2012-01-26 14:09:34 -0800</bug_when>
    <thetext>Comment on attachment 124177
Patch

ok</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>543489</commentid>
    <comment_count>3</comment_count>
      <attachid>124177</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-01-26 14:26:59 -0800</bug_when>
    <thetext>Comment on attachment 124177
Patch

Clearing flags on attachment: 124177

Committed r106045: &lt;http://trac.webkit.org/changeset/106045&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>543490</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-01-26 14:27:03 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>124177</attachid>
            <date>2012-01-26 14:04:27 -0800</date>
            <delta_ts>2012-01-26 14:26:59 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-77128-20120126140426.patch</filename>
            <type>text/plain</type>
            <size>1384</size>
            <attacher name="Scott Graham">scottmg</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjI1N2ViN2Q0YzU1Yjkz
MDE3ZjkyOWViMTcxNDNjOTY4OGY0YWFlZi4uMzk0ZWZlNmJiNjQzYjU3MzU5Y2I4MzVjNTliZjYz
MWE4ODU1YTE2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTAxLTI2ICBTY290
dCBHcmFoYW0gIDxzY290dG1nQGNob21pdW0ub3JnPgorCisgICAgICAgIEZpeCBpbmNsdWRlIHBh
dGggaW4gZ3lwIGZpbGUgZm9yIFY4SW50ZXJuYWxTZXR0aW5ncy5oCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzEyOAorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZS5neXAvV2ViQ29yZS5neXA6
CisKIDIwMTItMDEtMjYgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAog
ICAgICAgICBObyBuZWVkIHRvIHNldCBtX2hhdmVTY3JvbGxlZFNpbmNlUGFnZUxvYWQgaW4gYmVn
aW5TY3JvbGxHZXN0dXJlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9X
ZWJDb3JlLmd5cCBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCmluZGV4
IDA4MjVjYTE4ZjVhYWIwZTdjMTZkMGRiYWYwZjhkMTA4OTkxOGE4YmUuLjY4ODRiNDFhZjFkMTlj
OWM0NDU3ZWQwMTdjNGJhOTExZjE4MjQ4YzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dl
YkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dl
YkNvcmUuZ3lwCkBAIC0yMDM3LDcgKzIwMzcsNyBAQAogICAgICAgICAnPChTSEFSRURfSU5URVJN
RURJQVRFX0RJUikvd2ViY29yZS9iaW5kaW5ncy9WOEludGVybmFscy5jcHAnLAogICAgICAgICAn
PChTSEFSRURfSU5URVJNRURJQVRFX0RJUikvd2Via2l0L2JpbmRpbmdzL1Y4SW50ZXJuYWxzLmgn
LAogICAgICAgICAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJUikvd2ViY29yZS9iaW5kaW5ncy9W
OEludGVybmFsU2V0dGluZ3MuY3BwJywKLSAgICAgICAgJzwoU0hBUkVEX0lOVEVSTUVESUFURV9E
SVIpL3dlYmtpdC9iaW5kaW5ncy9WOEludGVybmFsc1NldHRpbmdzLmgnLAorICAgICAgICAnPChT
SEFSRURfSU5URVJNRURJQVRFX0RJUikvd2Via2l0L2JpbmRpbmdzL1Y4SW50ZXJuYWxTZXR0aW5n
cy5oJywKICAgICAgIF0sCiAgICAgICAnc291cmNlcy8nOiBbCiAgICAgICAgIFsnZXhjbHVkZScs
ICd0ZXN0aW5nL2pzJ10sCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>