77117 2012-01-26 10:33:50 -0800 ASSERT(!m_overlay) reached in TapHighlightController.cpp:73 2012-01-26 10:47:12 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abecsi abecsi hausmann kenneth webkit.review.bot oldest_to_newest 543248 0 abecsi 2012-01-26 10:33:50 -0800 The PageOverlay does only get uninstalled after the fade-out animation finishes, so do not assert on !m_overlay after the uninstallPageOverlay(m_overlay, /* fadeout */ true) call. 543250 1 124140 abecsi 2012-01-26 10:35:15 -0800 Created attachment 124140 proposed patch 543252 2 webkit.review.bot 2012-01-26 10:36:47 -0800 Attachment 124140 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style. 543257 3 124142 abecsi 2012-01-26 10:40:15 -0800 Created attachment 124142 proposed patch with bug number 543268 4 124142 abecsi 2012-01-26 10:47:05 -0800 Comment on attachment 124142 proposed patch with bug number Clearing flags on attachment: 124142 Committed r106012: <http://trac.webkit.org/changeset/106012> 543269 5 abecsi 2012-01-26 10:47:12 -0800 All reviewed patches have been landed. Closing bug. 124140 2012-01-26 10:35:15 -0800 2012-01-26 10:40:15 -0800 proposed patch fadeout.diff text/plain 1339 abecsi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlZWFkMmNiLi5jZjRiMjkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMDEtMjYgIEFuZHJhcyBCZWNzaSAgPGFuZHJhcy5iZWNzaUBub2tpYS5jb20+CisK KyAgICAgICAgQVNTRVJUKCFtX292ZXJsYXkpIHJlYWNoZWQgaW4gVGFwSGlnaGxpZ2h0Q29udHJv bGxlci5jcHA6NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGUgUGFnZU92ZXJsYXkgZG9lcyBvbmx5IGdldCB1bmluc3RhbGxlZCBhZnRlciB0aGUg ZmFkZS1vdXQgYW5pbWF0aW9uIGZpbmlzaGVzLAorICAgICAgICBzbyBkbyBub3QgYXNzZXJ0IG9u ICFtX292ZXJsYXkgYWZ0ZXIgdGhlIHVuaW5zdGFsbFBhZ2VPdmVybGF5IGNhbGwuCisKKyAgICAg ICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvVGFwSGlnaGxpZ2h0Q29udHJvbGxlci5jcHA6CisgICAg ICAgIChXZWJLaXQ6OlRhcEhpZ2hsaWdodENvbnRyb2xsZXI6OmhpZGVIaWdobGlnaHQpOgorCiAy MDEyLTAxLTI2ICBDYWlvIE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gIDxjYWlvLm9saXZlaXJh QG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgSW1wbGVtZW50IG92ZXJyaWRlUHJlZmVyZW5jZSBm b3IgYm9vbGVhbiBwcmVmZXJlbmNlcyBpbiBXZWJLaXRUZXN0UnVubmVyCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvVGFwSGlnaGxpZ2h0Q29udHJvbGxlci5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvVGFwSGlnaGxpZ2h0Q29udHJv bGxlci5jcHAKaW5kZXggNTQwODEwNy4uMWMzNmE0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1RhcEhpZ2hsaWdodENvbnRyb2xsZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9UYXBIaWdobGlnaHRDb250cm9sbGVyLmNw cApAQCAtNzAsNyArNzAsNiBAQCB2b2lkIFRhcEhpZ2hsaWdodENvbnRyb2xsZXI6OmhpZGVIaWdo bGlnaHQoKQogewogICAgIGlmIChtX292ZXJsYXkpCiAgICAgICAgIG1fd2ViUGFnZS0+dW5pbnN0 YWxsUGFnZU92ZXJsYXkobV9vdmVybGF5LCAvKiBmYWRlb3V0ICovIHRydWUpOwotICAgIEFTU0VS VCghbV9vdmVybGF5KTsKIH0KIAogdm9pZCBUYXBIaWdobGlnaHRDb250cm9sbGVyOjpwYWdlT3Zl cmxheURlc3Ryb3llZChQYWdlT3ZlcmxheSopCg== 124142 2012-01-26 10:40:15 -0800 2012-01-26 10:47:05 -0800 proposed patch with bug number fadeout.diff text/plain 1388 abecsi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmMjJhZmUwLi40MDI4MzU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDEtMjYgIEFuZHJhcyBCZWNzaSAgPGFuZHJhcy5iZWNzaUBub2tpYS5jb20+CisK KyAgICAgICAgQVNTRVJUKCFtX292ZXJsYXkpIHJlYWNoZWQgaW4gVGFwSGlnaGxpZ2h0Q29udHJv bGxlci5jcHA6NzMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTc3MTE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhlIFBhZ2VPdmVybGF5IGRvZXMgb25seSBnZXQgdW5pbnN0YWxsZWQgYWZ0ZXIgdGhlIGZh ZGUtb3V0IGFuaW1hdGlvbiBmaW5pc2hlcywKKyAgICAgICAgc28gZG8gbm90IGFzc2VydCBvbiAh bV9vdmVybGF5IGFmdGVyIHRoZSB1bmluc3RhbGxQYWdlT3ZlcmxheSBjYWxsLgorCisgICAgICAg ICogV2ViUHJvY2Vzcy9XZWJQYWdlL1RhcEhpZ2hsaWdodENvbnRyb2xsZXIuY3BwOgorICAgICAg ICAoV2ViS2l0OjpUYXBIaWdobGlnaHRDb250cm9sbGVyOjpoaWRlSGlnaGxpZ2h0KToKKwogMjAx Mi0wMS0yNiAgQ2FpbyBNYXJjZWxvIGRlIE9saXZlaXJhIEZpbGhvICA8Y2Fpby5vbGl2ZWlyYUBv cGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFdlYlByZWZlcmVuY2VzU3RvcmU6IHVzZSBERUZJTkVf U1RBVElDX0xPQ0FMIGZvciBvdmVycmlkZXMgSGFzaE1hcApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1RhcEhpZ2hsaWdodENvbnRyb2xsZXIuY3BwIGIvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1RhcEhpZ2hsaWdodENvbnRyb2xsZXIuY3Bw CmluZGV4IDU0MDgxMDcuLjFjMzZhNGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9UYXBIaWdobGlnaHRDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvVGFwSGlnaGxpZ2h0Q29udHJvbGxlci5jcHAKQEAgLTcw LDcgKzcwLDYgQEAgdm9pZCBUYXBIaWdobGlnaHRDb250cm9sbGVyOjpoaWRlSGlnaGxpZ2h0KCkK IHsKICAgICBpZiAobV9vdmVybGF5KQogICAgICAgICBtX3dlYlBhZ2UtPnVuaW5zdGFsbFBhZ2VP dmVybGF5KG1fb3ZlcmxheSwgLyogZmFkZW91dCAqLyB0cnVlKTsKLSAgICBBU1NFUlQoIW1fb3Zl cmxheSk7CiB9CiAKIHZvaWQgVGFwSGlnaGxpZ2h0Q29udHJvbGxlcjo6cGFnZU92ZXJsYXlEZXN0 cm95ZWQoUGFnZU92ZXJsYXkqKQo=