77112 2012-01-26 10:03:37 -0800 If the QTDIR environment variable is set, the build system fails to compile WinCairo 2012-02-13 12:55:15 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 david.delaune ossy aroben bfulgham dbates ossy oldest_to_newest 543226 0 david.delaune 2012-01-26 10:03:37 -0800 Hi, When the environment variable QTDIR is defined the build system fails to compile the WinCairo branch. The problem is in the perl module: WebKit\Tools\Scripts\webkitdirs.pm The sub determineIsQt() function contains the line: $isQt = defined($ENV{'QTDIR'}); It could easily be fixed by adding a check for isWinCairo() Best Wishes, -David Delaune 544999 1 124522 ossy 2012-01-30 04:08:58 -0800 Created attachment 124522 Patch 545171 2 124522 dbates 2012-01-30 09:43:10 -0800 Comment on attachment 124522 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124522&action=review > Tools/Scripts/webkitdirs.pm:882 > # The presence of QTDIR only means Qt if --gtk or --wx or --efl or --blackberry or --chromium are not on the command-line This comment should be updated to mention that we ignore the QTDIR environment variable when --wincairo is specified on the command line. On another note, this exclusion list of ports is long. Maybe we should consider only building for Qt when the --qt command line option is explicitly specified. That is, don't check for a set QTDIR environment variable. 546155 3 ossy 2012-01-31 09:19:21 -0800 (In reply to comment #2) > (From update of attachment 124522 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=124522&action=review > > > Tools/Scripts/webkitdirs.pm:882 > > # The presence of QTDIR only means Qt if --gtk or --wx or --efl or --blackberry or --chromium are not on the command-line > > This comment should be updated to mention that we ignore the QTDIR environment variable when --wincairo is specified on the command line. Good point, fixed. > On another note, this exclusion list of ports is long. Maybe we should consider only building for Qt when the --qt command line option is explicitly specified. That is, don't check for a set QTDIR environment variable. I agree with you more or less ... But in my opinion requiring from developer to use explicit --qt for build-webkit, run-javascriptcore-tests, run-webkit-tests isn't a good idea. What do you think if we add an evironment for example DEFAULT_WEBKIT_PLATFORM, and developers can define a default platform on they work, but can be overriden with command line options: --gtk, --efl, ... I think it can be useful for all WebKit developer. 546157 4 ossy 2012-01-31 09:20:36 -0800 I think with this change we can expect that the developer set DEFAULT_WEBKIT_PLATFORM or add platform explicitly. 546158 5 124522 ossy 2012-01-31 09:21:18 -0800 Comment on attachment 124522 Patch Landed in http://trac.webkit.org/changeset/106363 with fixed comment. 547110 6 dbates 2012-02-01 09:04:24 -0800 (In reply to comment #3) > (In reply to comment #2) > [...] > What do you think if we add an evironment for example DEFAULT_WEBKIT_PLATFORM, and developers can define a default platform on they work, but can be overriden with command line options: --gtk, --efl, ... > I don't have a strong opinion on this at this time. Maybe other people have an opinion on this. 124522 2012-01-30 04:08:58 -0800 2012-01-31 09:21:18 -0800 Patch bug-77112-20120130040856.patch text/plain 1382 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MjI5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2M5YzNkZjU3ZGFjMGNmYjIzMTY4MGY1MDhiOTJkMjE1 ZTk4NzMxMC4uYTNkMjFhODFmMzhhZjBmNzhjODJlZWVjMjQ0OGIxMDgxNGU4M2MwMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1 IEBACiAyMDEyLTAxLTMwICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAK KyAgICAgICAgSWYgdGhlIFFURElSIGVudmlyb25tZW50IHZhcmlhYmxlIGlzIHNldCwgdGhlIGJ1 aWxkIHN5c3RlbSBmYWlscyB0byBjb21waWxlIFdpbkNhaXJvCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzExMgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAg ICAgICAoZGV0ZXJtaW5lSXNRdCk6CisKKzIwMTItMDEtMzAgIENzYWJhIE9zenRyb2dvbsOhYyAg PG9zc3lAd2Via2l0Lm9yZz4KKwogICAgICAgICBVbnJldmlld2VkIHJvbGxpbmcgb3V0IHIxMDYy MjIuCiAKICAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVy cy9zaW5nbGVfdGVzdF9ydW5uZXIucHk6CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggZThmZTNkMmI1OWE3 MGE4YmM2MjRhMTdkMjc4NmI3MGE3YjUzZDUyMi4uM2RiNTQ2Y2IzODdhYmJmMzE3ZDQ2YWU3OTli MTY0ZjAyZWY5MGQ3NyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtODgwLDExICs4ODAsMTEgQEAgc3Vi IGRldGVybWluZUlzUXQoKQogICAgIH0KIAogICAgICMgVGhlIHByZXNlbmNlIG9mIFFURElSIG9u bHkgbWVhbnMgUXQgaWYgLS1ndGsgb3IgLS13eCBvciAtLWVmbCBvciAtLWJsYWNrYmVycnkgb3Ig LS1jaHJvbWl1bSBhcmUgbm90IG9uIHRoZSBjb21tYW5kLWxpbmUKLSAgICBpZiAoaXNHdGsoKSB8 fCBpc1d4KCkgfHwgaXNFZmwoKSB8fCBpc0JsYWNrQmVycnkoKSB8fCBpc0Nocm9taXVtKCkpIHsK KyAgICBpZiAoaXNHdGsoKSB8fCBpc1d4KCkgfHwgaXNFZmwoKSB8fCBpc0JsYWNrQmVycnkoKSB8 fCBpc0Nocm9taXVtKCkgfHwgaXNXaW5DYWlybygpKSB7CiAgICAgICAgICRpc1F0ID0gMDsKICAg ICAgICAgcmV0dXJuOwogICAgIH0KLSAgICAKKwogICAgICRpc1F0ID0gZGVmaW5lZCgkRU5WeydR VERJUid9KTsKIH0KIAo=