77104 2012-01-26 08:26:18 -0800 Fix build when VERBOSE_SPECULATION_FAILURE is enabled in DFG 2012-01-26 14:55:45 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pvarga pvarga barraclough fpizlo jberlin oliver webkit.review.bot oldest_to_newest 543162 0 pvarga 2012-01-26 08:26:18 -0800 The following failure occurs during compilation when VERBOSE_SPECULATION_FAILURE macro is enabled: ../../../../Source/JavaScriptCore/dfg/DFGOperations.cpp: In function 'void JSC::DFG::debugOperationPrintSpeculationFailure(JSC::ExecState*, void*)': ../../../../Source/JavaScriptCore/dfg/DFGOperations.cpp:1014: error: 'exec' was not declared in this scope 543163 1 124120 pvarga 2012-01-26 08:29:00 -0800 Created attachment 124120 proposed patch Add missing exec to the parameter list. 543170 2 jberlin 2012-01-26 08:45:58 -0800 Build fixes like this can be checked in without review. 543471 3 124120 fpizlo 2012-01-26 14:13:58 -0800 Comment on attachment 124120 proposed patch R=me. As Jessie said, you're welcome to commit changes like this without review! 543516 4 124120 webkit.review.bot 2012-01-26 14:55:41 -0800 Comment on attachment 124120 proposed patch Clearing flags on attachment: 124120 Committed r106049: <http://trac.webkit.org/changeset/106049> 543517 5 webkit.review.bot 2012-01-26 14:55:45 -0800 All reviewed patches have been landed. Closing bug. 124120 2012-01-26 08:29:00 -0800 2012-01-26 14:55:41 -0800 proposed patch 0001-VSF-fix.patch text/plain 1626 pvarga RnJvbSBmYTU5M2QxMGI4ZTM3Y2YxYzlkZGJhN2IwOWU1OGM3NWE2MTZjY2RmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBWYXJnYSA8cHZhcmdhQGluZi51LXN6ZWdlZC5odT4K RGF0ZTogVGh1LCAyNiBKYW4gMjAxMiAxNzoyNzozOCArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIFZT RiBmaXgKCi0tLQogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICB8 ICAgMTAgKysrKysrKysrKwogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25z LmNwcCB8ICAgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMSBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2NTg0YjM4Li42ZWQxNmVhIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wMS0yNiAgUGV0 ZXIgVmFyZ2EgIDxwdmFyZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBGaXggYnVpbGQgd2hlbiBW RVJCT1NFX1NQRUNVTEFUSU9OX0ZBSUxVUkUgaXMgZW5hYmxlZCBpbiBERkcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3MTA0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkZmcvREZHT3BlcmF0aW9ucy5j cHA6CisgICAgICAgICgpOgorCiAyMDEyLTAxLTI2ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5 QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XVtXaW5dIE9uZSBtb3JlIHNwZWN1bGF0aXZlIGJ1 aWxkZml4IGFmdGVyIHIxMDU5NzAuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR09wZXJhdGlvbnMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVy YXRpb25zLmNwcAppbmRleCBhMmUwMmNlLi4zZDRjZTk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5jcHAKQEAgLTEwMDksNyArMTAwOSw3IEBAIHNpemVfdCBE RkdfT1BFUkFUSU9OIGRmZ0NvbnZlcnRKU1ZhbHVlVG9Cb29sZWFuKEV4ZWNTdGF0ZSogZXhlYywg RW5jb2RlZEpTVmFsdWUKIH0KIAogI2lmIERGR19FTkFCTEUoVkVSQk9TRV9TUEVDVUxBVElPTl9G QUlMVVJFKQotdm9pZCBERkdfT1BFUkFUSU9OIGRlYnVnT3BlcmF0aW9uUHJpbnRTcGVjdWxhdGlv bkZhaWx1cmUoRXhlY1N0YXRlKiwgdm9pZCogZGVidWdJbmZvUmF3KQordm9pZCBERkdfT1BFUkFU SU9OIGRlYnVnT3BlcmF0aW9uUHJpbnRTcGVjdWxhdGlvbkZhaWx1cmUoRXhlY1N0YXRlKiBleGVj LCB2b2lkKiBkZWJ1Z0luZm9SYXcpCiB7CiAgICAgSlNHbG9iYWxEYXRhKiBnbG9iYWxEYXRhID0g JmV4ZWMtPmdsb2JhbERhdGEoKTsKICAgICBOYXRpdmVDYWxsRnJhbWVUcmFjZXIgdHJhY2VyKGds b2JhbERhdGEsIGV4ZWMpOwotLSAKMS43LjguNAoK